wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-30 18:57:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3032 from JacobBarthelmeh/PKCS12

Browse Source 
fix error checking when parsing a PKCS12 DER into an internal structure
This commit is contained in:
toddouska
2020-06-12 09:57:40 -07:00
committed by GitHub
parent 255cc016b3 3a430522da
commit f30eb0197b
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
wolfcrypt/src/pkcs12.c
View File

@ -190,6 +190,7 @@ void wc_PKCS12_free(WC_PKCS12* pkcs12)
} }
/* return 0 on success */
static int GetSafeContent(WC_PKCS12* pkcs12, const byte* input, static int GetSafeContent(WC_PKCS12* pkcs12, const byte* input,
word32* idx, int maxIdx) word32* idx, int maxIdx)
{ {
@ -228,7 +229,7 @@ static int GetSafeContent(WC_PKCS12* pkcs12, const byte* input,
} }
if ((ret = GetLength(input, &localIdx, &size, maxIdx)) <= 0) { if ((ret = GetLength(input, &localIdx, &size, maxIdx)) <= 0) {
freeSafe(safe, pkcs12->heap); freeSafe(safe, pkcs12->heap);
return ret; return ASN_PARSE_E;
} }
switch (oid) { switch (oid) {
@ -251,7 +252,7 @@ static int GetSafeContent(WC_PKCS12* pkcs12, const byte* input,
} }
if ((ret = GetLength(input, &localIdx, &size, maxIdx)) <= 0) { if ((ret = GetLength(input, &localIdx, &size, maxIdx)) <= 0) {
freeSafe(safe, pkcs12->heap); freeSafe(safe, pkcs12->heap);
return ret; return ASN_PARSE_E;
} }
break; break;
@ -350,7 +351,8 @@ static int GetSafeContent(WC_PKCS12* pkcs12, const byte* input,
} }
/* optional mac data */ /* parse optional mac data
* return 0 on success */
static int GetSignData(WC_PKCS12* pkcs12, const byte* mem, word32* idx, static int GetSignData(WC_PKCS12* pkcs12, const byte* mem, word32* idx,
word32 totalSz) word32 totalSz)
{ {
@ -366,7 +368,7 @@ static int GetSignData(WC_PKCS12* pkcs12, const byte* mem, word32* idx,
*/ */
if ((ret = GetSequence(mem, &curIdx, &size, totalSz)) <= 0) { if ((ret = GetSequence(mem, &curIdx, &size, totalSz)) <= 0) {
WOLFSSL_MSG("Failed to get PKCS12 sequence"); WOLFSSL_MSG("Failed to get PKCS12 sequence");
return ret; return ASN_PARSE_E;
} }
#ifdef WOLFSSL_DEBUG_PKCS12 #ifdef WOLFSSL_DEBUG_PKCS12
@ -405,7 +407,7 @@ static int GetSignData(WC_PKCS12* pkcs12, const byte* mem, word32* idx,
if ((ret = GetLength(mem, &curIdx, &size, totalSz)) <= 0) { if ((ret = GetLength(mem, &curIdx, &size, totalSz)) <= 0) {
XFREE(mac, pkcs12->heap, DYNAMIC_TYPE_PKCS); XFREE(mac, pkcs12->heap, DYNAMIC_TYPE_PKCS);
return ret; return ASN_PARSE_E;
} }
mac->digestSz = size; mac->digestSz = size;
mac->digest = (byte*)XMALLOC(mac->digestSz, pkcs12->heap, mac->digest = (byte*)XMALLOC(mac->digestSz, pkcs12->heap,
@ -637,7 +639,7 @@ int wc_d2i_PKCS12(const byte* der, word32 derSz, WC_PKCS12* pkcs12)
totalSz = derSz; totalSz = derSz;
if ((ret = GetSequence(der, &idx, &size, totalSz)) <= 0) { if ((ret = GetSequence(der, &idx, &size, totalSz)) <= 0) {
WOLFSSL_MSG("Failed to get PKCS12 sequence"); WOLFSSL_MSG("Failed to get PKCS12 sequence");
return ret; return ASN_PARSE_E;
} }
/* get version */ /* get version */