Tobias Frauenschläger 0dd6aa3704 Prevent ECC tmp key leak and UB in wc_ecc_mulmod_ex ...

ecc_key_tmp_final was guarded by `if (err == MP_OKAY)`, leaking
key->t1/t2 (and x/y/z under ALT_ECC_SIZE) whenever an allocation or
mulmod step after ecc_key_tmp_init failed.

Simply removing the guard is unsafe here: unlike wc_ecc_mulmod_ex2
(whose arg checks `return` directly), this function XMALLOC'd `key`
before the arg checks and used `goto exit`, so a bad-arg call would
hand uninitialized memory to ecc_key_tmp_final and XFREE garbage
pointers.

Defer the XMALLOC until after the arg/range checks so `key` is NULL
on the early-error paths, then call ecc_key_tmp_final unconditionally
to plug the leak on the late-error paths.

2026-04-29 09:19:58 +02:00

..

benchmark

wolfcrypt/benchmark/benchmark.c: add missing WOLFSSL_USE_SAVE_VECTOR_REGISTERS handling in bench_stats_ops_finish().

2026-04-27 11:36:48 -05:00

src

Prevent ECC tmp key leak and UB in wc_ecc_mulmod_ex

2026-04-29 09:19:58 +02:00

test

wolfcrypt/test/test.c:

2026-04-27 11:36:34 -05:00