Daniele Lacamera d868aa2299 sha: reorder update arg guards to make the empty-update decision coverable ...

wc_ShaUpdate, wc_Sha3Update, wc_Shake128_Update and wc_Shake256_Update
guarded inputs as:
    if (obj == NULL || (data == NULL && len > 0)) return BAD_FUNC_ARG;
    if (data == NULL && len == 0) return 0;
The first guard rejected (data==NULL, len>0) before the second decision,
so that decision's len==0 condition could only ever be observed true --
its MC/DC independence pair was structurally unreachable.

Reorder to the same idiom sha256.c/sha512.c already use:
    if (obj == NULL) return BAD_FUNC_ARG;
    if (data == NULL && len == 0) return 0;   /* (NULL,len>0) now reaches: len==0 false */
    if (data == NULL) return BAD_FUNC_ARG;
Behavior is identical for every input; the existing DIGEST_UPDATE_TEST
cases wc_*Update(&dgst, NULL, 1) and (&dgst, NULL, 0) now exercise both
sides of the decision. Closes the four guard-ordering MC/DC residuals in
the sha campaign module (sha.c and sha3.c).

2026-07-13 11:19:23 +02:00

..

benchmark

Clamp benchmark numBlocks to at least 1 so large block sizes still run.

2026-07-11 22:29:35 -06:00

src

sha: reorder update arg guards to make the empty-update decision coverable

2026-07-13 11:19:23 +02:00

test

Fixes from regression testing

2026-07-13 10:49:43 +10:00