mirror of
https://github.com/wolfSSL/wolfssl.git
synced 2026-08-15 16:01:33 +02:00
The scripts that wait for a server to publish its ready file declare counter at file scope and never reset it, so the retry budget is shared by every server start in the script instead of applying to each one. Once the early cases have used it up, every later create_port() falls straight through to "NO ready file ending test", kills a server that was starting normally, and the client then fails with "port number cannot be 0". Retry loops do not help, since the budget is already spent when they run. The failure needs only a build whose server start-up is slow enough to consume a few tenths of a second each time. It showed up in the FIPS dev-no-POST kernel-settings-all-pqc-asm job, where the server pays for the CASTs, the PQC algorithms and the vector-register fallback fuzzer: psk.test gave up after exactly 20 waits and tls13.test after exactly 51, both the full script budget rather than a per-case one. Reset counter where the wait begins, which is what the ocsp-stapling scripts already do. Reproduced with a wrapper that delays the server by one second: psk.test then fails on its third case before the change and passes after it.
175 lines
4.4 KiB
Bash
Executable File
175 lines
4.4 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# timeout(1) is GNU coreutils and absent on macOS; where it's missing, run the
|
|
# command unbounded (the flaky hang this guards against is Linux-only CI).
|
|
if ! command -v timeout >/dev/null 2>&1; then
|
|
timeout() { while [ "${1:-}" = "-s" ] || [ "${1:-}" = "-k" ]; do shift 2; done; shift; "$@"; }
|
|
fi
|
|
|
|
|
|
#resume.test
|
|
|
|
# if we can, isolate the network namespace to eliminate port collisions.
|
|
if [[ -n "$NETWORK_UNSHARE_HELPER" ]]; then
|
|
if [[ -z "$NETWORK_UNSHARE_HELPER_CALLED" ]]; then
|
|
export NETWORK_UNSHARE_HELPER_CALLED=yes
|
|
exec "$NETWORK_UNSHARE_HELPER" "$0" "$@" || exit $?
|
|
fi
|
|
elif [ "${AM_BWRAPPED-}" != "yes" ]; then
|
|
bwrap_path="$(command -v bwrap)"
|
|
if [ -n "$bwrap_path" ]; then
|
|
export AM_BWRAPPED=yes
|
|
exec "$bwrap_path" --unshare-net --dev-bind / / "$0" "$@"
|
|
fi
|
|
unset AM_BWRAPPED
|
|
fi
|
|
|
|
# need a unique resume port since may run the same time as testsuite
|
|
# use server port zero hack to get one
|
|
resume_string="reused"
|
|
resume_sup_string="Resume session"
|
|
ems_string="Extended\ Master\ Secret"
|
|
resume_port=0
|
|
no_pid=-1
|
|
server_pid=$no_pid
|
|
counter=0
|
|
# let's use absolute path to a local dir (make distcheck may be in sub dir)
|
|
# also let's add some randomness by adding pid in case multiple 'make check's
|
|
# per source tree
|
|
ready_file=`pwd`/wolfssl_resume_ready$$
|
|
|
|
echo "ready file $ready_file"
|
|
|
|
remove_ready_file() {
|
|
if test -e "$ready_file"; then
|
|
echo -e "removing existing ready file"
|
|
rm "$ready_file"
|
|
fi
|
|
}
|
|
|
|
|
|
do_cleanup() {
|
|
echo "in cleanup"
|
|
|
|
if [ $server_pid != $no_pid ] && kill -0 $server_pid 2>&-
|
|
then
|
|
# sleep to give sanitizers time to dump backtraces.
|
|
sleep 1
|
|
echo "killing server"
|
|
kill -9 $server_pid
|
|
fi
|
|
remove_ready_file
|
|
}
|
|
|
|
do_trap() {
|
|
echo "got trap"
|
|
do_cleanup
|
|
exit 1
|
|
}
|
|
|
|
do_test() {
|
|
echo -e "\nStarting example server for resume test...\n"
|
|
|
|
#make sure we support session resumption (!NO_SESSION_CACHE)
|
|
# Check the client for the extended master secret disable option. If
|
|
# present we need to run the test twice.
|
|
options_check=`./examples/client/client '-?'`
|
|
case "$options_check" in
|
|
*$resume_sup_string*)
|
|
echo -e "\nResume test supported";;
|
|
*)
|
|
echo -e "\nResume test not supported with build"
|
|
return;;
|
|
esac
|
|
|
|
remove_ready_file
|
|
echo "./examples/server/server -r -R \"$ready_file\" -p $resume_port"
|
|
timeout -s KILL 2m ./examples/server/server -r -R "$ready_file" -p $resume_port &
|
|
server_pid=$!
|
|
|
|
counter=0
|
|
while [ ! -s "$ready_file" -a "$counter" -lt 20 ]; do
|
|
echo -e "waiting for ready file..."
|
|
sleep 0.1
|
|
counter=$((counter+ 1))
|
|
done
|
|
|
|
if test -e "$ready_file"; then
|
|
echo -e "found ready file, starting client..."
|
|
else
|
|
echo -e "NO ready file ending test..."
|
|
do_cleanup
|
|
exit 1
|
|
fi
|
|
|
|
# sleep for an additional 0.1 to mitigate race on write/read of $ready_file:
|
|
sleep 0.1
|
|
|
|
# get created port 0 ephemeral port
|
|
resume_port=`cat "$ready_file"`
|
|
|
|
echo "./examples/client/client $1 -r -p $resume_port"
|
|
capture_out=$(./examples/client/client $1 -r -p $resume_port 2>&1)
|
|
client_result=$?
|
|
|
|
if [ $client_result != 0 ]
|
|
then
|
|
echo -e "client failed!\ncapture_out=$capture_out\nclient_result=$client_result"
|
|
do_cleanup
|
|
exit 1
|
|
fi
|
|
|
|
wait $server_pid
|
|
server_result=$?
|
|
remove_ready_file
|
|
|
|
if [ $server_result != 0 ]
|
|
then
|
|
echo -e "client failed!"
|
|
exit 1
|
|
fi
|
|
|
|
case "$capture_out" in
|
|
*$resume_string*)
|
|
echo "resumed session" ;;
|
|
*)
|
|
echo "did NOT resume session as expected"
|
|
exit 1
|
|
;;
|
|
esac
|
|
}
|
|
|
|
trap do_trap INT TERM
|
|
|
|
./examples/client/client '-?' 2>&1 | grep -- 'Client not compiled in!'
|
|
if [ $? -ne 0 ]; then
|
|
./examples/server/server '-?' 2>&1 | grep -- 'Server not compiled in!'
|
|
if [ $? -ne 0 ]; then
|
|
RUN_TEST="Y"
|
|
fi
|
|
fi
|
|
|
|
./examples/client/client '-?' 2>&1 | grep -- 'Resume session'
|
|
if [ $? -ne 0 ]; then
|
|
RUN_TEST="Y"
|
|
fi
|
|
|
|
if [ "$RUN_TEST" = "Y" ]; then
|
|
do_test
|
|
|
|
# Check the client for the extended master secret disable option. If
|
|
# present we need to run the test twice.
|
|
options_check=`./examples/client/client -?`
|
|
case "$options_check" in
|
|
*$ems_string*)
|
|
echo -e "\nRepeating resume test without extended master secret..."
|
|
do_test -n ;;
|
|
*)
|
|
;;
|
|
esac
|
|
fi
|
|
|
|
echo -e "\nSuccess!\n"
|
|
|
|
exit 0
|