mirror of
https://github.com/wolfSSL/wolfssl.git
synced 2026-08-15 07:51:22 +02:00
Tobias Frauenschläger
5d2188f958
WOLFSSL_CERT_SIGN_CB is set only by --enable-certsigncb, and that flag appears nowhere under .github/. wc_SignCert_cb() is therefore compiled by no CI job, and neither is test_wc_SignCert_cb(), the only test covering it. The buffer bounds check the preceding commits add to that function, and the test assertions that go with it, would have merged without anything building them. Added as its own entry in the os-check Linux config list, in sorted position. "minutes" is seeded at 8.3 from the sibling --enable-all entries rather than omitted: the omission defaults it to 1.0, which sorts an eight minute build last in a list scheduled longest-first and deals it into whichever shard is already fullest. It also suppresses the stale estimate annotation that would otherwise prompt the refresh. Replace it with the real number from the Minutes column of the first run. Verified by running the entry through the workflow's own driver, .github/scripts/parallel-make-check.py, with the CFLAGS the workflow applies at make time (-pedantic -Wdeclaration-after-statement -Wnull-dereference -Wno-overlength-strings -DTEST_LIBWOLFSSL_SOURCES_INCLUSION_SEQUENCE) and --private-dir=certs. The out-of-tree build produces no compiler warnings and make check reports 17 passed, 6 skipped, 0 failed. Both test_wc_SignCert_buffer_bounds and test_wc_SignCert_cb run rather than skip.