boostorg/container
1
0
Fork 1
mirror of https://github.com/boostorg/container.git synced 2025-07-30 20:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

Avoid comparing iterators that could have been invalidated after erase()

Browse Source
This commit is contained in:
Ion Gaztañaga
2024-11-24 22:31:38 +01:00
parent a0848ceaf1
commit 3e70ecfa80
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
include/boost/container/detail/flat_tree.hpp
View File

@ -952,9 +952,10 @@ class flat_tree
typename container_type::iterator const e = boost::movelib::inplace_set_unique_difference
(it, seq.end(), seq.begin(), it, val_cmp);
//it might be invalidated by erasing [e, seq.end) if e == it, so check it before
const bool remaining = e != it;
seq.erase(e, seq.cend());
//it might be invalidated by erasing [e, seq.end) if e == it
if (it != e)
if (remaining)
{
//Step 4: merge both ranges
(flat_tree_container_inplace_merge)(seq, it, this->priv_value_comp(), contiguous_tag);