Run most of the unordered container tests (not the exception tests) on warning

level 4 on Visual C++.


[SVN r38648]

test/container/Jamfile.v2

@@ -9,6 +9,7 @@ project unordered-test/container
     : requirements
         <toolset>intel-linux:"<cxxflags>-strict_ansi -cxxlib-icc"
         <toolset>gcc:<cxxflags>-Wsign-promo
+        <toolset>msvc:<cxxflags>/W4
     ;
 
 test-suite container-tests

test/container/compile_tests.hpp

@@ -3,7 +3,17 @@
 // Distributed under the Boost Software License, Version 1.0. (See accompanying
 // file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
 
+#if defined(BOOST_MSVC)
+#pragma warning(push)
+#pragma warning(disable:4100) // unreferenced formal parameter
+#endif
+
 #include <boost/concept_check.hpp>
+
+#if defined(BOOST_MSVC)
+#pragma warning(pop)
+#endif
+
 #include <boost/mpl/assert.hpp>
 #include <boost/mpl/bool.hpp>
 #include <boost/type_traits/is_same.hpp>

test/helpers/allocator.hpp

@@ -10,6 +10,11 @@
 #include <cstdlib>
 #include <boost/limits.hpp>
 
+#if defined(BOOST_MSVC)
+#pragma warning(push)
+#pragma warning(disable:4100) // unreferenced formal parameter
+#endif
+
 namespace test
 {
     template <class T>
@@ -26,8 +31,8 @@ namespace test
         template <class U> struct rebind { typedef malloc_allocator<U> other; };
 
         malloc_allocator() {}
-        template <class Y> malloc_allocator(malloc_allocator<Y> const& x) {}
-        malloc_allocator(malloc_allocator const& x) {}
+        template <class Y> malloc_allocator(malloc_allocator<Y> const&) {}
+        malloc_allocator(malloc_allocator const&) {}
 
         pointer address(reference r) { return &r; }
         const_pointer address(const_reference r) { return &r; }
@@ -37,7 +42,7 @@ namespace test
         }
 
         pointer allocate(size_type n, const_pointer u) { return allocate(n); }
-        void deallocate(pointer p, size_type n) { free(p); }
+        void deallocate(pointer p, size_type) { free(p); }
         void construct(pointer p, T const& t) { new(p) T(t); }
         void destroy(pointer p) { p->~T(); }
 
@@ -59,4 +64,9 @@ namespace test
     };
 }
 
+#if defined(BOOST_MSVC)
+#pragma warning(pop)
+#pragma warning(disable:4100) // unreferenced formal parameter
+#endif
+
 #endif

test/helpers/generators.hpp

@@ -59,7 +59,7 @@ namespace test
     inline signed char generate(signed char const*)
     {
         using namespace std;
-        return rand();
+        return static_cast<signed char>(rand());
     }
 
     inline std::string generate(std::string const*)

test/helpers/invariants.hpp

@@ -15,6 +15,11 @@
 #include "./helpers.hpp"
 #include "./allocator.hpp"
 
+#if defined(BOOST_MSVC)
+#pragma warning(push)
+#pragma warning(disable:4127) // conditional expression is constant
+#endif
+
 namespace test
 {
     template <class X>
@@ -92,5 +97,9 @@ namespace test
     }
 }
 
+#if defined(BOOST_MSVC)
+#pragma warning(pop)
+#endif
+
 #endif
 

test/objects/minimal.hpp

@@ -8,6 +8,11 @@
 
 #include <cstddef>
 
+#if defined(BOOST_MSVC)
+#pragma warning(push)
+#pragma warning(disable:4100) // unreferenced formal parameter
+#endif
+
 namespace test
 {
 namespace minimal
@@ -226,4 +231,8 @@ namespace minimal
 }
 }
 
+#if defined(BOOST_MSVC)
+#pragma warning(pop)
+#endif
+
 #endif

test/unordered/Jamfile.v2

@@ -9,6 +9,7 @@ project unordered-test/unordered
     : requirements
         <toolset>intel-linux:"<cxxflags>-strict_ansi -cxxlib-icc"
         <toolset>gcc:<cxxflags>-Wsign-promo
+        <toolset>msvc:<cxxflags>/W4
     ;
 
 test-suite unordered-tests

test/unordered/compile_tests.cpp

@@ -6,7 +6,17 @@
 #include <boost/unordered_set.hpp>
 #include <boost/unordered_map.hpp>
 
+#if defined(BOOST_MSVC)
+#pragma warning(push)
+#pragma warning(disable:4100) // unreferenced formal parameter
+#endif
+
 #include <boost/concept_check.hpp>
+
+#if defined(BOOST_MSVC)
+#pragma warning(pop)
+#endif
+
 #include <boost/mpl/assert.hpp>
 #include <boost/iterator/iterator_traits.hpp>
 #include "../helpers/check_return_type.hpp"

test/unordered/load_factor_tests.cpp

@@ -9,6 +9,11 @@
 #include <boost/limits.hpp>
 #include "../helpers/random_values.hpp"
 
+#if defined(BOOST_MSVC)
+#pragma warning(push)
+#pragma warning(disable:4127) // conditional expression is constant
+#endif
+
 template <class X>
 void load_factor_tests(X* = 0)
 {
@@ -70,3 +75,8 @@ int main()
 
     return boost::report_errors();
 }
+
+#if defined(BOOST_MSVC)
+#pragma warning(pop)
+#pragma warning(disable:4127) // conditional expression is constant
+#endif

test/unordered/unnecessary_copy_tests.cpp

@@ -11,7 +11,7 @@ struct count_copies
 {
     static int count;
     count_copies() { ++count; }
-    count_copies(count_copies const& x) { ++count; }
+    count_copies(count_copies const&) { ++count; }
 private:
     count_copies& operator=(count_copies const&);
 };
@@ -20,7 +20,7 @@ private:
 namespace boost {
 #endif
 
-std::size_t hash_value(count_copies const& x) {
+std::size_t hash_value(count_copies const&) {
     return 0;
 }
 
@@ -28,7 +28,7 @@ std::size_t hash_value(count_copies const& x) {
 }
 #endif
 
-bool operator==(count_copies const& x, count_copies const& y) {
+bool operator==(count_copies const&, count_copies const&) {
     return true;
 }