dolphin-emu/dolphin
1
0
Fork 1
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-09-09 09:40:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13854 from dreamsyntax/fix-regression-callers-broken

Browse Source 
PPCSymbolDB: Fix callers not updating
This commit is contained in:
Tilka
2025-08-10 19:13:29 +01:00
committed by GitHub
parent 4140c6f383 d946656b87
commit ba656e641e
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Source/Core/Core/PowerPC/PPCSymbolDB.cpp
View File

@@ -236,13 +236,17 @@ std::string PPCSymbolDB::GetDescription(u32 addr) const
void PPCSymbolDB::FillInCallers()
{
std::lock_guard lock(m_mutex);
FillInCallers(&m_functions);
}
for (auto& p : m_functions)
void PPCSymbolDB::FillInCallers(XFuncMap* functions)
{
for (auto& p : *functions)
{
p.second.callers.clear();
}
for (auto& entry : m_functions)
for (auto& entry : *functions)
{
Common::Symbol& f = entry.second;
for (const Common::SCall& call : f.calls)
@@ -250,8 +254,8 @@ void PPCSymbolDB::FillInCallers()
const Common::SCall new_call(entry.first, call.call_address);
const u32 function_address = call.function;
auto func_iter = m_functions.find(function_address);
if (func_iter != m_functions.end())
auto func_iter = functions->find(function_address);
if (func_iter != functions->end())
{
Common::Symbol& called_function = func_iter->second;
called_function.callers.push_back(new_call);
@@ -622,7 +626,7 @@ bool PPCSymbolDB::LoadMap(const Core::CPUThreadGuard& guard, std::string filenam
Index(&new_functions);
DetermineNoteLayers(&new_notes);
FillInCallers();
FillInCallers(&new_functions);
std::lock_guard lock(m_mutex);
std::swap(m_functions, new_functions);

1
Source/Core/Core/PowerPC/PPCSymbolDB.h
View File

@@ -57,4 +57,5 @@ private:
static void AddKnownNote(u32 start_addr, u32 size, const std::string& name, XNoteMap* notes);
static void DetermineNoteLayers(XNoteMap* notes);
static void FillInCallers(XFuncMap* functions);
};