espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-07-29 18:27:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'bugfix/http_client_test_memcorupt_v4.2' into 'release/v4.2'

Browse Source 
ci/test: Fix esp_http_client test not to use pointer after free (v4.2)

See merge request espressif/esp-idf!13701
This commit is contained in:
Mahavir Jain
2021-06-24 05:52:27 +00:00
parent c6e0decf0a 3810be0df5
commit 131ab4b92b
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
components/esp_http_client/test/test_http_client.c
View File

@ -124,7 +124,10 @@ TEST_CASE("Username and password will not reset if new absolute URL doesnot spec
TEST_ASSERT_EQUAL_STRING(USERNAME, value);
esp_http_client_set_url(client, "http://" HOST "/get");
esp_http_client_set_username(client, value);
esp_http_client_set_password(client, value);
// esp_http_client_set_username sets new username and thus invalidates the original one
// which we still reference in the local variable `value` (better forget it)
value = NULL;
esp_http_client_set_password(client, (char *)USERNAME); // Need to cast the string literal (argument is not a const char*)
//checks if username is set or not
r = esp_http_client_get_username(client, &value);
TEST_ASSERT_EQUAL(ESP_OK, r);