espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-07-29 18:27:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'bugfix/ut_ext_win_open_file_v4.0' into 'release/v4.0'

Browse Source 
Tools: Close temporary file before invoking external tools accessing it

See merge request espressif/esp-idf!9832
This commit is contained in:
Ivan Grokhotkov
2020-11-09 17:16:25 +08:00
parent c535031c2f 6bec17308c
commit 31e0866561
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tools/unit-test-app/idf_ext.py
View File

@ -71,7 +71,7 @@ def action_extensions(base_actions, project_path=os.getcwd()):
new_cache_values["TEST_COMPONENTS"] = config.get("TEST_COMPONENTS", "''")
new_cache_values["TESTS_ALL"] = int(new_cache_values["TEST_COMPONENTS"] == "''")
with tempfile.NamedTemporaryFile() as sdkconfig_temp:
with tempfile.NamedTemporaryFile(delete=False) as sdkconfig_temp:
# Use values from the combined defaults and the values from
# config folder to build config
sdkconfig_default = os.path.join(project_path, "sdkconfig.defaults")
@ -84,13 +84,18 @@ def action_extensions(base_actions, project_path=os.getcwd()):
sdkconfig_temp.write(b"\n")
sdkconfig_temp.write(sdkconfig_config_file.read())
sdkconfig_temp.flush()
new_cache_values["SDKCONFIG_DEFAULTS"] = sdkconfig_temp.name
try:
args.define_cache_entry.extend(["%s=%s" % (k, v) for k, v in new_cache_values.items()])
reconfigure = base_actions["actions"]["reconfigure"]["callback"]
reconfigure(None, ctx, args)
finally:
try:
os.unlink(sdkconfig_temp.name)
except OSError:
pass
# This target builds the configuration. It does not currently track dependencies,
# but is good enough for CI builds if used together with clean-all-configs.