espressif/esp-protocols
1
0
Fork 1
mirror of https://github.com/espressif/esp-protocols.git synced 2025-07-30 02:37:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14 from b1ackviking/fix-missing-virtual-dtors

Browse Source 
fix: add virtual destructors to ModuleIf and CommandableIf
This commit is contained in:
david-cermak
2022-02-23 11:01:48 +01:00
committed by GitHub
parent 5d27b2681a 325a1933c4
commit 50b083a58c
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
components/esp_modem/examples/modem_console/main/httpget_handle.c
View File

@ -46,6 +46,7 @@ static esp_err_t http_event_handler(esp_http_client_event_t *evt)
case HTTP_EVENT_DISCONNECTED: case HTTP_EVENT_DISCONNECTED:
ESP_LOGI(TAG, "HTTP_EVENT_DISCONNECTED"); ESP_LOGI(TAG, "HTTP_EVENT_DISCONNECTED");
break; break;
default: break;
} }
return ESP_OK; return ESP_OK;
} }
@ -105,4 +106,4 @@ void modem_console_register_http(void)
.argtable = &http_args .argtable = &http_args
}; };
ESP_ERROR_CHECK(esp_console_cmd_register(&http_cmd)); ESP_ERROR_CHECK(esp_console_cmd_register(&http_cmd));
} }

12
components/esp_modem/include/cxx_include/esp_modem_types.hpp
View File

@ -67,6 +67,12 @@ struct PdpContext {
*/ */
class CommandableIf { class CommandableIf {
public: public:
CommandableIf() = default;
CommandableIf(const CommandableIf&) = delete;
CommandableIf& operator=(const CommandableIf&) = delete;
CommandableIf(CommandableIf&&) = delete;
CommandableIf& operator=(CommandableIf&&) = delete;
virtual ~CommandableIf() = default;
/** /**
* @brief Sends custom AT command * @brief Sends custom AT command
* @param command Command to be sent * @param command Command to be sent
@ -83,6 +89,12 @@ public:
*/ */
class ModuleIf { class ModuleIf {
public: public:
ModuleIf() = default;
ModuleIf(const ModuleIf&) = delete;
ModuleIf& operator=(const ModuleIf&) = delete;
ModuleIf(ModuleIf&&) = delete;
ModuleIf& operator=(ModuleIf&&) = delete;
virtual ~ModuleIf() = default;
/** /**
* @brief Sets the data mode up (provides the necessary configuration to connect to the cellular network) * @brief Sets the data mode up (provides the necessary configuration to connect to the cellular network)
* @return true on success * @return true on success