feedc0de/GSL
1
0
Fork 0
forked from microsoft/GSL
Code Pull Requests Activity

We should be using standard algorithms where possible.

Browse Source 
Use of algorithms in the STL should be promoted where possible.
Also fixed up some whitespace issues.
This commit is contained in:
Kern Handa
2015-09-25 17:11:17 -07:00
parent b40d3466c6
commit c4f9b87d96
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/array_view.h
+3 -8
View File
@@ -28,6 +28,7 @@
#include <utility>
#include <array>
#include <iterator>
#include <algorithm>
#include "fail_fast.h"
#ifndef _MSC_VER
@@ -142,12 +143,7 @@ namespace details
}
_CONSTEXPR bool operator==(const ConcreteType& rhs) const _NOEXCEPT
{
for (unsigned int i = 0; i < rank; ++i)
{
if (elems[i] != rhs.elems[i])
return false;
}
return true;
return std::equal(elems, elems + rank, rhs.elems);
}
_CONSTEXPR bool operator!=(const ConcreteType& rhs) const _NOEXCEPT
{
@@ -160,8 +156,7 @@ namespace details
_CONSTEXPR ConcreteType operator-() const
{
ConcreteType ret = to_concrete();
for (unsigned int i = 0; i < rank; ++i)
ret.elems[i] = -ret.elems[i];
std::transform(ret, ret + rank, ret, std::negate<ValueType>{});
return ret;
}
_CONSTEXPR ConcreteType operator+(const ConcreteType& rhs) const