feedc0de/bobbycar-controller-firmware
1
0
Fork 0
Code Issues 8 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Added flos hall #10

Closed
CommanderRedYT wants to merge 1 commits from sehr_gschissenes_hall into master
pull from: sehr_gschissenes_hall
merge into: feedc0de:master
Conversation 4 Commits 1 Files Changed 3 +103 -138
CommanderRedYT commented 2021-08-05 23:30:07 +02:00 (Migrated from github.com)
Copy Link
No description provided.
0xFEEDC0DE64 (Migrated from github.com) reviewed 2021-08-05 23:30:07 +02:00
peterpoetzi commented 2021-09-23 20:10:12 +02:00 (Migrated from github.com)
Copy Link

I Propose that instead of naming HALL Sensor pinouts, GSCHISSENES_HALL and SEHR_GSCHISSENES_HALL, name them:

HALL_ABC
HALL_ACB
HALL_BAC
HALL_BCA
HALL_CAB
HALL_CBA

and therefore reject this pull request

I Propose that instead of naming HALL Sensor pinouts, `GSCHISSENES_HALL `and `SEHR_GSCHISSENES_HALL`, name them: ``` HALL_ABC HALL_ACB HALL_BAC HALL_BCA HALL_CAB HALL_CBA ``` and therefore reject this pull request
👍 1
CommanderRedYT commented 2021-10-01 11:28:17 +02:00 (Migrated from github.com)
Copy Link

Can implement when coding #88

Can implement when coding #88
mickdermack commented 2022-04-28 22:20:25 +02:00 (Migrated from github.com)
Copy Link

I think all of the proposed changes contained in this PR are present in latest master in some form, therefore we can close this.

I think all of the proposed changes contained in this PR are present in latest master in some form, therefore we can close this.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
0xFEEDC0DE64
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
needs-testing
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
feedc0de
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: feedc0de/bobbycar-controller-firmware#10
No description provided.
Delete Branch "sehr_gschissenes_hall"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?