WIP: Implement angleDelta accumulation #7

2020-05-26T16:55:52+02:00

0xFEEDC0DE64 commented

(Migrated from github.com)

No description provided.

mickdermack (Migrated from github.com) reviewed 2020-05-26 19:18:36 +02:00

main.cpp

mickdermack (Migrated from github.com) commented

Consider converting this to a guard style if:

    if (UART_DMA_CHANNEL->CNDTR == 0)
        return;

Consider converting this to a guard style if: ```suggestion if (UART_DMA_CHANNEL->CNDTR == 0) return; ```

mickdermack (Migrated from github.com) reviewed 2020-05-26 19:22:32 +02:00

main.cpp

mickdermack (Migrated from github.com) commented

Is there a reason why this exact value was chosen (and the define removed)? Consider adding a comment here.

This pull request has changes conflicting with the target branch.

View command line instructions

From your project repository, check out a new branch and test the changes.

git fetch -u origin angleDelta:angleDelta

git checkout angleDelta

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: feedc0de/bobbycar-controller-firmware#7