[Feature] Skip MenuItem #8

New Issue

2022-03-22T09:54:39+01:00

CommanderRedYT commented

2022-03-22 09:54:39 +01:00

(Migrated from github.com)

A MenuItem that acts like an empty one but skips (so just for design)

0xFEEDC0DE64 commented

2022-03-22 10:50:53 +01:00

(Migrated from github.com)

Add virtual bool visible() const { return true; } to MenuItem or introduce a new VisibleInterface
in menu rendering code, call continue; whenever a menuitem is not visible, which should result in correct delta rendering with my existing Label widgets.

1. Add `virtual bool visible() const { return true; }` to MenuItem or introduce a new VisibleInterface 2. in menu rendering code, call `continue;` whenever a menuitem is not visible, which should result in correct delta rendering with my existing Label widgets.

CommanderRedYT commented

2022-03-22 11:35:39 +01:00

(Migrated from github.com)

What if its already been drawn? Will it clear the space? Or is it constant and not changeable? Also for the scroll behavior, should there be a option to skip the element as if it was not there or should it be selectable like the current empty-text menu items.

Will open a pull request, also, with a new Class so one can just type

espgui::constructMenuItem<espgui::Empty item>();

(Name tbd)

What if its already been drawn? Will it clear the space? Or is it constant and not changeable? Also for the scroll behavior, should there be a option to skip the element as if it was not there or should it be selectable like the current empty-text menu items. Will open a pull request, also, with a new Class so one can just type ```cpp espgui::constructMenuItem<espgui::Empty item>(); ``` (Name tbd)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: feedc0de/esp-gui-lib#8