feedc0de/mp-units
1
0
Fork 0
forked from mpusz/mp-units
Code Pull Requests Activity
1,630 Commits 8 Branches 17 Tags
48b6280486e8fec21e2becb69f9aef87cad4f1d2
Commit Graph
1630 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Chip Hogg 48b6280486 Merge branch 'master' into chiphogg/prime-wheel 2022-03-19 16:01:32 +00:00
Chip Hogg 166dd1e944 Work around numbers with very large first factors 
We introduce the `known_first_factor` variable template.
 2022-03-19 15:56:12 +00:00
Chip Hogg a99e5f9032 Switch tests to use top-level, anonymous namespace 2022-03-19 15:54:29 +00:00
Chip Hogg 28c4fe3c08 Run clang-format-15 on changed files 2022-03-19 14:29:11 +00:00
Chip Hogg 1e8460d401 Revert "Try upping the basis size further" 
This reverts commit 87073856a7.
It didn't fix the problem, and it caused some new ones.  We need a
different approach.
 2022-03-19 13:21:47 +00:00
Mateusz Pusz e09de55291 docs: CONTRIBUTING updated 2022-03-18 14:39:22 +01:00
Mateusz Pusz f56e3bc0da Merge pull request #339 from mpusz/clang-format 
style: all files refromatted with clang-format
 2022-03-18 12:35:34 +01:00
Mateusz Pusz b58b696e92 style: clang-format formatting improved with additional parenthesis 2022-03-18 09:10:27 +01:00
Mateusz PuszandJohel Ernesto Guerrero Peña 6d82ddebbc Update test/unit_test/static/quantity_kind_test.cpp 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
 2022-03-18 08:21:15 +01:00
Mateusz PuszandJohel Ernesto Guerrero Peña 6531d188d1 Update src/core/include/units/quantity.h 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
 2022-03-18 08:20:43 +01:00
Mateusz PuszandJohel Ernesto Guerrero Peña f4fbac86b4 Update src/core/include/units/quantity.h 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
 2022-03-18 08:20:36 +01:00
Mateusz PuszandJohel Ernesto Guerrero Peña 03290d74a2 Update src/core/include/units/quantity.h 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
 2022-03-18 08:20:27 +01:00
Mateusz PuszandJohel Ernesto Guerrero Peña 6e59e7a927 Update src/core/include/units/quantity.h 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
 2022-03-18 08:20:08 +01:00
Mateusz PuszandJohel Ernesto Guerrero Peña c6f35b0231 Update src/core/include/units/quantity_cast.h 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
 2022-03-18 08:19:40 +01:00
Mateusz Pusz 144f6951c0 style: all files refromatted with clang-format 2022-03-17 23:59:48 +01:00
Mateusz Pusz a2f28feb04 Merge pull request #338 from hofbi/contributing-md-typos 
docs: fix typos in contributing.md
 2022-03-17 18:12:53 +01:00
Markus Hofbauer c3ff6a22d2 docs: fix typos in contributing.md 2022-03-17 15:35:07 +01:00
Mateusz Pusz cc90985958 fix: Clang-12 compilation fixed 2022-03-15 13:14:15 +01:00
Mateusz Pusz 7730e76fb7 build: test_package/conanfile.py cleanup 2022-03-14 19:27:25 +01:00
Mateusz Pusz 211a11b7c9 build: conanfile.py cleanup 2022-03-14 19:26:43 +01:00
Mateusz Pusz 627b2fb6d0 build: MSVC version handling fixed 2022-03-14 19:25:59 +01:00
Chip Hogg 87073856a7 Try upping the basis size further 
We are well into a regime of diminishing returns, but we'd better start
by seeing if the easy thing works.  Besides, setting this to 7 trips the
step limit in _generating_ the algorithm!
 2022-03-12 18:56:26 +00:00
Chip Hogg a719a8b912 Try upping the basis size 2022-03-11 03:57:21 +00:00
Chip Hogg 70640a1017 Remove constexpr-incompatible assert() 2022-03-11 03:56:57 +00:00
Chip Hogg 59d9cd1407 static_cast for first factor 2022-03-11 03:50:08 +00:00
Chip Hogg bfa8db6139 Use std::accumulate 2022-03-11 03:48:57 +00:00
Chip Hogg 73a56115a1 Fix wheel factorization algorithm 2022-03-11 03:42:19 +00:00
Chip Hogg 6c73947fe0 Satisfy complaint 
This line shouldn't _actually_ ever be reachable, but I can't fault the
compiler for not figuring that out.
 2022-03-10 23:50:33 +00:00
Chip Hogg c8a44adee2 Add missing header for std::integral 2022-03-10 23:41:47 +00:00
Chip Hogg 24b284fcbb Add tests to support claims in comment 2022-03-10 23:41:36 +00:00
Chip Hogg 04b80f0827 Use wheel factorization for prime numbers 
Certain existing units in the library require very large prime
numbers---so large, in fact, that our naive trial division hits the
_iteration limit_ for `constexpr` loops.  We don't want to force users
to provide a compiler option override, so we'd better find another way.

The solution is to use the "wheel factorization" algorithm:
https://en.wikipedia.org/wiki/Wheel_factorization

This lets us skip most composite numbers in our trial division.  The
implementation presented here is configurable in terms of the size of
the "basis" of primes we use.  Bigger bases let us skip more primes, but
at the cost of storing more numbers.  Fortunately, it turns out that N=3
was good enough for our purposes.
 2022-03-10 23:29:02 +00:00
Mateusz Pusz 2198c8a403 Merge pull request #334 from JohelEGP/ratio_maths_unused_header 
refactor(bits): remove unused header
 2022-03-10 21:43:04 +01:00
Mateusz Pusz 1b9d680275 Merge pull request #335 from JohelEGP/non_static_constexpr_globals 
refactor: drop `static` from `constexpr` globals
 2022-03-10 21:23:00 +01:00
Johel Ernesto Guerrero Peña 72046b0fe7 refactor: drop static from constexpr globals 2022-03-10 14:33:32 -04:00
Mateusz Pusz 6193854f31 Merge pull request #333 from chiphogg/chiphogg/intmax 
Use intmax for base of integral powers
 2022-03-10 19:29:23 +01:00
Mateusz Pusz a5fff2f210 Merge branch 'master' of github.com:mpusz/units 2022-03-10 19:05:41 +01:00
Mateusz Pusz 6171b8ab69 docs: Outdated TODO comments removed 2022-03-10 19:05:36 +01:00
Mateusz Pusz 74e6cf8def Merge pull request #336 from JohelEGP/unused_header_quantity_cast 
refactor: remove unused header
 2022-03-10 19:01:50 +01:00
Mateusz Pusz ce8fbcaf6c build: conanfile.py updated 2022-03-10 18:55:40 +01:00
Johel Ernesto Guerrero Peña eee4f7d49c refactor: remove unused header 2022-03-09 20:23:21 -04:00
Johel Ernesto Guerrero Peña b52da14e36 refactor(bits): remove unused header 2022-03-08 20:38:07 -04:00
Chip Hogg 7cda52af55 Merge branch 'master' into chiphogg/intmax 2022-03-01 02:30:13 +00:00
Mateusz Pusz 5668257fe1 build: Conan geerated target renamed to wg21_linear_algebra 2022-02-28 19:23:34 +01:00
Mateusz Pusz 87ab85625b The latest Conan generates Catch2 CMake target 2022-02-28 18:27:03 +01:00
Mateusz Pusz 0a6d11cf27 Depracated build_requires(..., force_host_context=True) replaced with test_requires(...) 2022-02-28 18:25:20 +01:00
Chip Hogg 632f2785a9 Clarify section header 2022-02-24 01:48:02 +00:00
Chip Hogg 240bdd659c Use intmax for base of integral powers 
I used `int` before, because it was simple, and I thought _surely_ it
would be enough.  I mean, who's going to make a unit whose magnitude has
a prime factor bigger than 32 bits?

This brings us to the "Dalton", a unit whose ratio-magnitude numerator
is 16605390666050.  The prime factorization of 16605390666050 is
(2 * 5 * 5 * 53 * 6266185157), and this last number is bigger than 2^31
by a factor of 3 or so.

Fortunately, we should have done this from the beginning anyway, because
otherwise there would be numbers we could represent in `ratio` which we
couldn't represent in `Magnitude`, and this should never be the case.
 2022-02-24 01:17:27 +00:00
Mateusz Pusz 3651e199bf Merge pull request #331 from JohelEGP/llvm15 
refactor: update hacks for LLVM 15
 2022-02-08 10:40:31 +01:00
Mateusz Pusz 1a5341141a Merge pull request #329 from chiphogg/mag-value-t 
Add value and categorization helpers for Magnitude
 2022-02-08 10:39:31 +01:00
Johel Ernesto Guerrero Peña 3f145a25db refactor: update hacks for LLVM 15 2022-02-07 21:07:22 -04:00