feedc0de/mp-units
1
0
Fork 0
forked from mpusz/mp-units
Code Pull Requests Activity
1,649 Commits 8 Branches 17 Tags
63f3dd2be6bef9824c0a2c563c80bdbf3b2000ca
Commit Graph
1649 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Mateusz Pusz 63f3dd2be6 Merge pull request #344 from JohelEGP/quotient_remainder_theorem 
test(static): simplify quotient_remainder_theorem test cases
 2022-03-22 10:04:49 +01:00
Mateusz Pusz 9e22c7b0c7 chore: Gitpod configuration fixed 2022-03-21 19:43:45 +00:00
Johel Ernesto Guerrero Peña feb1a0b860 test(static): simplify quotient_remainder_theorem test cases 2022-03-21 14:29:50 -04:00
Mateusz Pusz 57dc186162 chore: clang-12 and clang-format-15 added to gitpod 2022-03-21 19:00:58 +01:00
Mateusz Pusz 6218a709ae refactor: first_factor_maybe() replaced with get_first_of() 2022-03-21 18:13:47 +01:00
Mateusz Pusz b822a149b9 Merge pull request #343 from JohelEGP/cmake_systems 
build(cmake): fix export name of mp-units-system
 2022-03-21 11:50:01 +01:00
Mateusz Pusz ca283b94f6 refactor: find_first_factor() refactored 2022-03-21 11:16:50 +01:00
Mateusz Pusz 3729a9fe93 Merge pull request #337 from chiphogg/chiphogg/prime-wheel 
Use wheel factorization for prime numbers
 2022-03-21 10:37:05 +01:00
Johel Ernesto Guerrero Peña 94d143ef7e build(cmake): fix export name of mp-units-system 2022-03-20 09:17:25 -04:00
Chip Hogg b589ba8d86 Omit redundant computation 
This stems from an earlier mistake where I was using primes in the first
wheel, rather than coprimes-to-the-basis.  1 is not prime, so we used to
need to handle it separately (in an implementation which was, to be
clear, wrong).  It _is_ coprime, so now we get it for free!
 2022-03-19 22:10:01 +00:00
Mateusz Pusz e1f7266b51 refactor: <algorithm.h> header added 
Should be replaced with `<algorithm>` when C++20 modules will be used. Right now this header is too expensive to compile.
 2022-03-19 20:07:55 +01:00
Chip Hogg 6872117bae Replace reduce with bespoke implementation 
If _this_ isn't `constexpr` compatible, I'm going to propose removing
support for the MacOS clang build.
 2022-03-19 17:35:20 +00:00
Chip Hogg f495ad9e75 Replace accumulate with reduce 
Perhaps this will also satisfy Apple's Clang 13?  Since `reduce` is
newer, it may be more likely to be `constexpr` compatible.
 2022-03-19 17:27:38 +00:00
Mateusz Pusz 117c380ba8 Merge pull request #341 from hofbi/init-pre-commit 
Init pre commit
 2022-03-19 18:16:51 +01:00
Chip Hogg 438feb3001 Remove offending unit test 
Apparently, the constexpr depth which clang and MSVC can handle is too
shallow for me to write a unit test that works on all supported
compilers.
 2022-03-19 17:05:55 +00:00
Chip Hogg 0f80c10104 Try "gentler" test case 
I verified that we hit GCC 10's constexpr limit with
`wheel_factorizer<1>`, but pass with `wheel_factorizer<4>`.  I hope this
number is enough smaller than the square root of the previous value that
the other compilers will be able to handle it.  If not: we'll go lower.
 2022-03-19 16:58:43 +00:00
Chip Hogg c339383873 Convert names to standard_case 2022-03-19 16:07:39 +00:00
Chip Hogg 48b6280486 Merge branch 'master' into chiphogg/prime-wheel 2022-03-19 16:01:32 +00:00
Chip Hogg 166dd1e944 Work around numbers with very large first factors 
We introduce the `known_first_factor` variable template.
 2022-03-19 15:56:12 +00:00
Chip Hogg a99e5f9032 Switch tests to use top-level, anonymous namespace 2022-03-19 15:54:29 +00:00
Chip Hogg 28c4fe3c08 Run clang-format-15 on changed files 2022-03-19 14:29:11 +00:00
Chip Hogg 1e8460d401 Revert "Try upping the basis size further" 
This reverts commit 87073856a7.
It didn't fix the problem, and it caused some new ones.  We need a
different approach.
 2022-03-19 13:21:47 +00:00
Markus Hofbauer 4c127797da check: run pre-commit on all files 2022-03-18 16:12:21 +01:00
Markus Hofbauer 7b8d97646c check: initial setup for pre-commit 2022-03-18 16:12:21 +01:00
Mateusz Pusz e09de55291 docs: CONTRIBUTING updated 2022-03-18 14:39:22 +01:00
Mateusz Pusz f56e3bc0da Merge pull request #339 from mpusz/clang-format 
style: all files refromatted with clang-format
 2022-03-18 12:35:34 +01:00
Mateusz Pusz b58b696e92 style: clang-format formatting improved with additional parenthesis 2022-03-18 09:10:27 +01:00
Mateusz PuszandJohel Ernesto Guerrero Peña 6d82ddebbc Update test/unit_test/static/quantity_kind_test.cpp 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
 2022-03-18 08:21:15 +01:00
Mateusz PuszandJohel Ernesto Guerrero Peña 6531d188d1 Update src/core/include/units/quantity.h 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
 2022-03-18 08:20:43 +01:00
Mateusz PuszandJohel Ernesto Guerrero Peña f4fbac86b4 Update src/core/include/units/quantity.h 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
 2022-03-18 08:20:36 +01:00
Mateusz PuszandJohel Ernesto Guerrero Peña 03290d74a2 Update src/core/include/units/quantity.h 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
 2022-03-18 08:20:27 +01:00
Mateusz PuszandJohel Ernesto Guerrero Peña 6e59e7a927 Update src/core/include/units/quantity.h 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
 2022-03-18 08:20:08 +01:00
Mateusz PuszandJohel Ernesto Guerrero Peña c6f35b0231 Update src/core/include/units/quantity_cast.h 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
 2022-03-18 08:19:40 +01:00
Mateusz Pusz 144f6951c0 style: all files refromatted with clang-format 2022-03-17 23:59:48 +01:00
Mateusz Pusz a2f28feb04 Merge pull request #338 from hofbi/contributing-md-typos 
docs: fix typos in contributing.md
 2022-03-17 18:12:53 +01:00
Markus Hofbauer c3ff6a22d2 docs: fix typos in contributing.md 2022-03-17 15:35:07 +01:00
Mateusz Pusz cc90985958 fix: Clang-12 compilation fixed 2022-03-15 13:14:15 +01:00
Mateusz Pusz 7730e76fb7 build: test_package/conanfile.py cleanup 2022-03-14 19:27:25 +01:00
Mateusz Pusz 211a11b7c9 build: conanfile.py cleanup 2022-03-14 19:26:43 +01:00
Mateusz Pusz 627b2fb6d0 build: MSVC version handling fixed 2022-03-14 19:25:59 +01:00
Chip Hogg 87073856a7 Try upping the basis size further 
We are well into a regime of diminishing returns, but we'd better start
by seeing if the easy thing works.  Besides, setting this to 7 trips the
step limit in _generating_ the algorithm!
 2022-03-12 18:56:26 +00:00
Chip Hogg a719a8b912 Try upping the basis size 2022-03-11 03:57:21 +00:00
Chip Hogg 70640a1017 Remove constexpr-incompatible assert() 2022-03-11 03:56:57 +00:00
Chip Hogg 59d9cd1407 static_cast for first factor 2022-03-11 03:50:08 +00:00
Chip Hogg bfa8db6139 Use std::accumulate 2022-03-11 03:48:57 +00:00
Chip Hogg 73a56115a1 Fix wheel factorization algorithm 2022-03-11 03:42:19 +00:00
Chip Hogg 6c73947fe0 Satisfy complaint 
This line shouldn't _actually_ ever be reachable, but I can't fault the
compiler for not figuring that out.
 2022-03-10 23:50:33 +00:00
Chip Hogg c8a44adee2 Add missing header for std::integral 2022-03-10 23:41:47 +00:00
Chip Hogg 24b284fcbb Add tests to support claims in comment 2022-03-10 23:41:36 +00:00
Chip Hogg 04b80f0827 Use wheel factorization for prime numbers 
Certain existing units in the library require very large prime
numbers---so large, in fact, that our naive trial division hits the
_iteration limit_ for `constexpr` loops.  We don't want to force users
to provide a compiler option override, so we'd better find another way.

The solution is to use the "wheel factorization" algorithm:
https://en.wikipedia.org/wiki/Wheel_factorization

This lets us skip most composite numbers in our trial division.  The
implementation presented here is configurable in terms of the size of
the "basis" of primes we use.  Bigger bases let us skip more primes, but
at the cost of storing more numbers.  Fortunately, it turns out that N=3
was good enough for our purposes.
 2022-03-10 23:29:02 +00:00