feedc0de/my-rook-config
1
0 Fork 0
forked from rook/rook
Code Pull Requests Activity

test: fix unit test code to remove extra comma

Browse Source 
this commit fix regression comming from another pr
which was merged and since github was down ci were
not running.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit f98dd9f9f0)
This commit is contained in:
subhamkrai committed 2026-02-10 13:51:47 +05:30
1 parent 6c3759322f
commit 334bc5a1fb
2 files changed
+6 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

pkg/operator/ceph/nfs/controller_test.go
+3 -3
View File
@@ -207,7 +207,7 @@ func TestCephNFSController(t *testing.T) {
newReconcile := func(clusterCtx *clusterd.Context, cl client.WithWatch) *ReconcileCephNFS {
// Create a ReconcileCephNFS object with the scheme and fake client.
return &ReconcileCephNFS{client: cl, scheme: testScheme, context: clusterCtx, opManagerContext: ctx, recorder: events.NewFakeRecorder(50),}
return &ReconcileCephNFS{client: cl, scheme: testScheme, context: clusterCtx, opManagerContext: ctx, recorder: events.NewFakeRecorder(50)}
}
// Mock request to simulate Reconcile() being called on an event for a
@@ -626,7 +626,7 @@ func TestNFSKeyRotation(t *testing.T) {
}
cl := fake.NewClientBuilder().WithScheme(s).WithRuntimeObjects(object...).Build()
r := &ReconcileCephNFS{client: cl, scheme: s, context: c, opManagerContext: ctx, recorder: events.NewFakeRecorder(50),}
r := &ReconcileCephNFS{client: cl, scheme: s, context: c, opManagerContext: ctx, recorder: events.NewFakeRecorder(50)}
req := reconcile.Request{
NamespacedName: types.NamespacedName{
@@ -666,7 +666,7 @@ func TestNFSKeyRotation(t *testing.T) {
})
t.Run("subsequent reconcile - retain cephx status", func(t *testing.T) {
r := &ReconcileCephNFS{client: cl, scheme: s, context: c, opManagerContext: ctx, recorder: events.NewFakeRecorder(50),}
r := &ReconcileCephNFS{client: cl, scheme: s, context: c, opManagerContext: ctx, recorder: events.NewFakeRecorder(50)}
updateDeploymentAndWait, _ = testopk8s.UpdateDeploymentAndWaitStub()
_, err := r.Reconcile(ctx, req)
assert.NoError(t, err)
pkg/operator/ceph/nvmeof/controller_test.go
+3 -3
View File
@@ -166,7 +166,7 @@ func TestCephNVMeOFGatewayController(t *testing.T) {
}
newReconcile := func(clusterCtx *clusterd.Context, cl client.WithWatch) *ReconcileCephNVMeOFGateway {
return &ReconcileCephNVMeOFGateway{client: cl, scheme: testScheme, context: clusterCtx, opManagerContext: ctx, recorder: events.NewFakeRecorder(50),}
return &ReconcileCephNVMeOFGateway{client: cl, scheme: testScheme, context: clusterCtx, opManagerContext: ctx, recorder: events.NewFakeRecorder(50)}
}
req := reconcile.Request{
@@ -514,7 +514,7 @@ func TestNVMeOFKeyRotation(t *testing.T) {
}
cl := fake.NewClientBuilder().WithScheme(s).WithRuntimeObjects(object...).Build()
r := &ReconcileCephNVMeOFGateway{client: cl, scheme: s, context: c, opManagerContext: ctx, recorder: events.NewFakeRecorder(50),}
r := &ReconcileCephNVMeOFGateway{client: cl, scheme: s, context: c, opManagerContext: ctx, recorder: events.NewFakeRecorder(50)}
req := reconcile.Request{
NamespacedName: types.NamespacedName{
@@ -551,7 +551,7 @@ func TestNVMeOFKeyRotation(t *testing.T) {
})
t.Run("subsequent reconcile - retain cephx status", func(t *testing.T) {
r := &ReconcileCephNVMeOFGateway{client: cl, scheme: s, context: c, opManagerContext: ctx, recorder: events.NewFakeRecorder(50),}
r := &ReconcileCephNVMeOFGateway{client: cl, scheme: s, context: c, opManagerContext: ctx, recorder: events.NewFakeRecorder(50)}
_, err := r.Reconcile(ctx, req)
assert.NoError(t, err)
nvmeofResult := cephv1.CephNVMeOFGateway{}