csi: remove attacher sidecar from CephFS rook deployment
CephFS CSI driver dont have/advertise controller publish/unpublish capabilities, thus dont need attacher sidecar for its operations. The presence of external-attacher adds on overhead and issues wrt attachment in various scenarios. One of them would be the lack of performance on syncing volumeattachment from api server..etc. More or less we don't have controller publish and unpublish capabilities, so we should not make use of this sidecar and cause unnecessary addon here thus other issues. similar changes have been added to CSI https://github.com/ceph/ceph-csi/pull/3149 Signed-off-by: yati1998 <ypadia@redhat.com>
This commit is contained in:
1 parent
ec0c9a7963
commit
4bfd88dc4d
10 files changed
+5
-58
No files matched your search
@@ -100,8 +100,8 @@ If you did not modify the `cluster.yaml` above, it is expected that one OSD will
|
||||
```console
|
||||
$ kubectl -n rook-ceph get pod
|
||||
NAME READY STATUS RESTARTS AGE
|
||||
csi-cephfsplugin-provisioner-d77bb49c6-n5tgs 5/5 Running 0 140s
|
||||
csi-cephfsplugin-provisioner-d77bb49c6-v9rvn 5/5 Running 0 140s
|
||||
csi-cephfsplugin-provisioner-d77bb49c6-n5tgs 4/4 Running 0 140s
|
||||
csi-cephfsplugin-provisioner-d77bb49c6-v9rvn 4/4 Running 0 140s
|
||||
csi-cephfsplugin-rthrp 3/3 Running 0 140s
|
||||
csi-rbdplugin-hbsm7 3/3 Running 0 140s
|
||||
csi-rbdplugin-provisioner-5b5cd64fd-nvk6c 6/6 Running 0 140s
|
||||
|
||||
@@ -292,7 +292,7 @@ Restarting the `csi-xxxxplugin-xxx` pod on the node may help.
|
||||
|
||||
## Volume Attachment
|
||||
|
||||
Each provisioner pod also has a sidecar container called `csi-attacher`.
|
||||
Each RBD provisioner pod also has a sidecar container called `csi-attacher`.
|
||||
|
||||
### csi-attacher
|
||||
|
||||
|
||||
@@ -8,3 +8,4 @@
|
||||
|
||||
- The toolbox pod now uses the Ceph image directly instead of the Rook image
|
||||
- Add support for AWS Server Side Encryption with (AWS-SSE:S3)[https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingServerSideEncryption.html] for RGW.
|
||||
- Remove Attacher sidecar from CephFS Rook deployment.
|
||||
@@ -454,12 +454,6 @@ rules:
|
||||
- apiGroups: [""]
|
||||
resources: ["events"]
|
||||
verbs: ["list", "watch", "create", "update", "patch"]
|
||||
- apiGroups: ["storage.k8s.io"]
|
||||
resources: ["volumeattachments"]
|
||||
verbs: ["get", "list", "watch", "patch"]
|
||||
- apiGroups: ["storage.k8s.io"]
|
||||
resources: ["volumeattachments/status"]
|
||||
verbs: ["patch"]
|
||||
- apiGroups: [""]
|
||||
resources: ["persistentvolumeclaims/status"]
|
||||
verbs: ["patch"]
|
||||
|
||||
@@ -227,14 +227,6 @@ csi:
|
||||
limits:
|
||||
memory: 256Mi
|
||||
cpu: 200m
|
||||
- name : csi-attacher
|
||||
resource:
|
||||
requests:
|
||||
memory: 128Mi
|
||||
cpu: 100m
|
||||
limits:
|
||||
memory: 256Mi
|
||||
cpu: 200m
|
||||
- name : csi-snapshotter
|
||||
resource:
|
||||
requests:
|
||||
|
||||
@@ -42,12 +42,6 @@ rules:
|
||||
- apiGroups: [""]
|
||||
resources: ["events"]
|
||||
verbs: ["list", "watch", "create", "update", "patch"]
|
||||
- apiGroups: ["storage.k8s.io"]
|
||||
resources: ["volumeattachments"]
|
||||
verbs: ["get", "list", "watch", "patch"]
|
||||
- apiGroups: ["storage.k8s.io"]
|
||||
resources: ["volumeattachments/status"]
|
||||
verbs: ["patch"]
|
||||
- apiGroups: [""]
|
||||
resources: ["persistentvolumeclaims/status"]
|
||||
verbs: ["patch"]
|
||||
|
||||
@@ -393,14 +393,6 @@ data:
|
||||
# limits:
|
||||
# memory: 256Mi
|
||||
# cpu: 200m
|
||||
# - name : csi-attacher
|
||||
# resource:
|
||||
# requests:
|
||||
# memory: 128Mi
|
||||
# cpu: 100m
|
||||
# limits:
|
||||
# memory: 256Mi
|
||||
# cpu: 200m
|
||||
# - name : csi-snapshotter
|
||||
# resource:
|
||||
# requests:
|
||||
|
||||
@@ -316,14 +316,6 @@ data:
|
||||
# limits:
|
||||
# memory: 256Mi
|
||||
# cpu: 200m
|
||||
# - name : csi-attacher
|
||||
# resource:
|
||||
# requests:
|
||||
# memory: 128Mi
|
||||
# cpu: 100m
|
||||
# limits:
|
||||
# memory: 256Mi
|
||||
# cpu: 200m
|
||||
# - name : csi-snapshotter
|
||||
# resource:
|
||||
# requests:
|
||||
|
||||
@@ -610,7 +610,7 @@ func (r *ReconcileCSI) startDrivers(ver *version.Info, ownerInfo *k8sutil.OwnerI
|
||||
}
|
||||
}
|
||||
if EnableCephFS {
|
||||
err = csiDriverobj.createCSIDriverInfo(r.opManagerContext, r.context.Clientset, CephFSDriverName, k8sutil.GetValue(r.opConfig.Parameters, "CSI_CEPHFS_FSGROUPPOLICY", string(k8scsi.ReadWriteOnceWithFSTypeFSGroupPolicy)), true)
|
||||
err = csiDriverobj.createCSIDriverInfo(r.opManagerContext, r.context.Clientset, CephFSDriverName, k8sutil.GetValue(r.opConfig.Parameters, "CSI_CEPHFS_FSGROUPPOLICY", string(k8scsi.ReadWriteOnceWithFSTypeFSGroupPolicy)), false)
|
||||
if err != nil {
|
||||
return errors.Wrapf(err, "failed to create CSI driver object for %q", CephFSDriverName)
|
||||
}
|
||||
|
||||
@@ -22,24 +22,6 @@ spec:
|
||||
priorityClassName: {{ .ProvisionerPriorityClassName }}
|
||||
{{ end }}
|
||||
containers:
|
||||
- name: csi-attacher
|
||||
image: {{ .AttacherImage }}
|
||||
args:
|
||||
- "--v={{ .SidecarLogLevel }}"
|
||||
- "--csi-address=$(ADDRESS)"
|
||||
- "--leader-election=true"
|
||||
- "--timeout={{ .GRPCTimeout }}"
|
||||
- "--leader-election-namespace={{ .Namespace }}"
|
||||
- "--leader-election-lease-duration=137s"
|
||||
- "--leader-election-renew-deadline=107s"
|
||||
- "--leader-election-retry-period=26s"
|
||||
env:
|
||||
- name: ADDRESS
|
||||
value: /csi/csi-provisioner.sock
|
||||
imagePullPolicy: "IfNotPresent"
|
||||
volumeMounts:
|
||||
- name: socket-dir
|
||||
mountPath: /csi
|
||||
{{ if .EnableCephFSSnapshotter }}
|
||||
- name: csi-snapshotter
|
||||
image: {{ .SnapshotterImage }}
|
||||
|
||||
Reference in new issue
Block a user