Merge pull request #14629 from BlaineEXE/fix-multus-validation-test-default-service-account

multus: fix default service account handling

cmd/rook/userfacing/multus/validation/validation.go

@@ -134,6 +134,8 @@ func init() {
 			"The default value is set to the worst-case value for a Rook Ceph cluster with 3 portable OSDs, 3 portable monitors, "+
 			"and where all optional child resources have been created with 1 daemon such that they all might run on a single node in a failure scenario. "+
 			"If you aren't sure what to choose for this value, add 1 for each additional OSD beyond 3.")
+	runCmd.Flags().StringVar(&validationConfig.ServiceAccountName, "service-account", defaultConfig.ServiceAccountName,
+		"The name of the service account that will be used for test resources.")
 	runCmd.Flags().BoolVar(&flagHostCheckOnly, "host-check-only", defaultConfig.HostCheckOnly,
 		"Only check that hosts can connect to the server via the public network. Do not start clients. "+
 			"This mode is recommended when a Rook cluster is already running and consuming the public network specified.")

tests/scripts/multus/test-110-cli.sh

@@ -6,6 +6,10 @@ OUTFILE="cli-test.log"
 
 kubectl create namespace "$NAMESPACE"
 
+# create the expected serviceaccount in the namespace
+# in Minikube/KinD, the tool needs no special permissions, so just the SA is fine
+kubectl create serviceaccount rook-ceph-system --namespace "$NAMESPACE"
+
 ./rook --log-level DEBUG multus validation run \
   --namespace "$NAMESPACE" \
   --public-network default/public-net \

tests/scripts/multus/test-210-stretch-overlap.sh

@@ -7,6 +7,10 @@ OUTFILE="overlap-test.log"
 
 kubectl create namespace "$NAMESPACE"
 
+# create the expected serviceaccount in the namespace
+# in Minikube/KinD, the tool needs no special permissions, so just the SA is fine
+kubectl create serviceaccount rook-ceph-system --namespace "$NAMESPACE"
+
 sed \
   -e "s|namespace:.*|namespace: $NAMESPACE|" \
   -e 's|publicNetwork:.*|publicNetwork: "default/public-net"|' \

tests/scripts/multus/test-220-stretch-pub-and-cluster.sh

@@ -7,6 +7,10 @@ OUTFILE="stretch-pub-and-cluster-test.log"
 
 kubectl create namespace "$NAMESPACE"
 
+# create the expected serviceaccount in the namespace
+# in Minikube/KinD, the tool needs no special permissions, so just the SA is fine
+kubectl create serviceaccount rook-ceph-system --namespace "$NAMESPACE"
+
 sed \
   -e "s|namespace:.*|namespace: $NAMESPACE|" \
   -e 's|publicNetwork:.*|publicNetwork: "default/public-net"|' \

tests/scripts/multus/test-230-stretch-pub-only.sh

@@ -7,6 +7,10 @@ OUTFILE="stretch-pub-test.log"
 
 kubectl create namespace "$NAMESPACE"
 
+# create the expected serviceaccount in the namespace
+# in Minikube/KinD, the tool needs no special permissions, so just the SA is fine
+kubectl create serviceaccount rook-ceph-system --namespace "$NAMESPACE"
+
 # all daemons get public network, so all should get started
 
 sed \

tests/scripts/multus/test-240-stretch-cluster-only.sh

@@ -7,6 +7,10 @@ OUTFILE="stretch-cluster-test.log"
 
 kubectl create namespace "$NAMESPACE"
 
+# create the expected serviceaccount in the namespace
+# in Minikube/KinD, the tool needs no special permissions, so just the SA is fine
+kubectl create serviceaccount rook-ceph-system --namespace "$NAMESPACE"
+
 sed \
   -e "s|namespace:.*|namespace: $NAMESPACE|" \
   -e 's|publicNetwork:.*|publicNetwork: ""|' \