csi: enable CSI Metadata Injection by Default

This PR sets CSI_ENABLE_METADATA to true by default in the
Rook configuration, ensuring that the --setmetadata=true
flag is added to CSI nodeplugin pods

Signed-off-by: Oded Viner <oviner@redhat.com>

pkg/operator/ceph/csi/csi.go

@@ -172,9 +172,9 @@ func (r *ReconcileCSI) setParams() error {
 		CSIParam.EnableCSIEncryption = true
 	}
 
-	CSIParam.CSIEnableMetadata = false
-	if strings.EqualFold(k8sutil.GetOperatorSetting("CSI_ENABLE_METADATA", "false"), "true") {
-		CSIParam.CSIEnableMetadata = true
+	CSIParam.CSIEnableMetadata = true
+	if strings.EqualFold(k8sutil.GetOperatorSetting("CSI_ENABLE_METADATA", "true"), "false") {
+		CSIParam.CSIEnableMetadata = false
 	}
 
 	if strings.EqualFold(k8sutil.GetOperatorSetting("CSI_CEPHFS_PLUGIN_UPDATE_STRATEGY", rollingUpdate), onDelete) {

pkg/operator/ceph/csi/operator_config_test.go

@@ -87,5 +87,5 @@ func TestReconcileCSI_createOrUpdateOperatorConfig(t *testing.T) {
 
 	err = cl.Get(context.TODO(), types.NamespacedName{Name: opConfigCRName, Namespace: r.opConfig.OperatorNamespace}, opConfig)
 	assert.NoError(t, err)
-	assert.Equal(t, *opConfig.Spec.DriverSpecDefaults.EnableMetadata, false)
+	assert.Equal(t, *opConfig.Spec.DriverSpecDefaults.EnableMetadata, true)
 }