Afte pylint was updated to version 3.2.0
a set of new errors appeared. This makes
ci passing by either fixing the problem
or ignoring it in the check
Signed-off-by: NymanRobin <robin.nyman@est.tech>
(cherry picked from commit dcec080468)
LVM-based OSDs on PVCs are legacy and are not well tested.
Therefore, we add status to the cephcluster CR that at least
gives a clue that the OSDs should be replaced.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 3628e83892)
v2 port can be avalaible without v1,
so fixing the current check
Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit 800d2f11f5)
this commit allow user to use requiredDuringSchedulingIgnoredDuringExecution map
Signed-off-by: Hyeonki Hong <hhk7734@gmail.com>
(cherry picked from commit 2e0c015d42)
With the release of Reef v18.2.2 we update the default
recommended version of Ceph to fix the prometheus issues
seen with v18.2.1
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 026d745f8a)
currently the script requires to have both v2 and v1 port
to enable v2 port, but that is not the necessary condition,
so removing the chek, and enabling it only v2 is present to
successfully configure with v2 only
part-of: https://github.com/rook/rook/issues/13827
Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit 117bc76f20)
Reduce CRD size by removing some descriptions for things that
(a) are long, (b) are repeated, and (c) are commong kubernetes types.
Remove the `Status` field from VolumeClaimTemplates (a.k.a. PVCs) in
types.go to remove all unnecessary status-related fields.
Use `yq` to go through generated `crds.yaml` to strip out descriptions
for well-known k8s types that are long and repeated where we can't
remove them from types.go. This is mostly placement descriptions and
volumeSource descriptions.
The overall `crds.yaml` file is reduced to less than 60% of its original
size.
Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
Co-authored-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit bd7477ec61)
# Conflicts:
# deploy/charts/rook-ceph/templates/resources.yaml
# deploy/examples/crds.yaml
since networkFence is a cluster-based resource so that we don't need
the namespace and ownerReferences as it cause garbage-collector errors.
Also, now we create the networkFence with clusteUID label so when doing
cleanup we match the cephCluster uid and networkFence label clusterUID.
Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 5bff860380)
Fixes: #13692
Since the introduction of the "host" network provider, the legacy
"hostNetwork" setting is intended to be used only in combination with
the default network provider (""), but the code did not enforce this.
This change adds the required validation checks to throw errors
in invalid constellations.
These checks are added both in the operator's input validation code
and as kubernetes x-validation admission policies in the Cepcluster CRD.
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 25aa15e6c1)
Updating the cephcsi image to 3.10.2
which is the latest released one.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit c22597a32c)
When CPU requests and limits are assigned to a pod,
the pod will be guaranteed the requests, up to the limits.
Even if there are spare CPU cycles, the pod cannot use
them. Thus, pods can be unnecessarily denied compute
when they need to burst if the limits are set.
Therefore, it is not recommended to set CPU limits
since the CPU requests are already guaranteeing that
no pod will be starved at least for its requests.
Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 27265ff279)
For now we are using the operator namespace name
as the prefix for the csi driver, This PR provides
an option for the users if someone wants to have
their own prefix for the csi driver, if someone tries
to change the prefix for existing csi driver rook
operator will fail to reconcile the csi driver.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit c35a8532aa)
The operator needs to burst significantly when reconciling,
then will quiet down and nearly not consume any cpu.
Therefore, we allow the operator to burst to more than
a full cpu instead of limiting it to a half cpu.
Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit ca28887403)
We set `ceph_secret=${ROOK_CEPH_SECRET}` just a couple lines above,
and this duplicate is probably just an oversight.
This duplicate key is not present in the similar scripts in
examples/toolbox.yaml
examples/toolbox-operator-image.yaml
Signed-off-by: Erik Berg <erikberg@usit.uio.no>
(cherry picked from commit 2a225ac718)
Removing whitespace for consistency and wrong indentation level.
There's one actual "oopsie-fix" in here for CSI_ENABLE_READ_AFFINITY
Signed-off-by: Erik Berg <erikberg@usit.uio.no>
(cherry picked from commit 9a2d8505e7)
The pg_autoscaler mgr module is no longer possible to disable.
Ceph requires the module to always be enabled. Now the
autoscaling configuration is done with a per-pool setting.
Now the rook module is shown as an example to enable.
Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit f0c30e2edb)
This commit adds the flexibility to configure
leader election flags as per the user
requirement and also keeps the existing values
as the default one.
resolve: #13475
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 9b418d24a1)
updating csi provisioner to 3.6.3 to
as we have a bug in 3.6.2
resolves: #13475
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 85b86efee1)
The mds max daemons had been set arbitrarily to 10.
Allow more mds daemons for clusters that have a
scenario for large numbers of mds to manage the
filesystem metadata.
Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 98816ad79f)
we have changed the --cluster-name flag to --k8s-cluster-name
but to support automation while upgrade we should support
the legacy flag
Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit 8e4ec01cbb)
Long CRD descriptions were pushing the size of the CRDs manifest
over 1MB, which causes issues when creating the CRDs. To shorten
the manifest, the descriptions are now limited to 100 chars.
This still gives some ability for dev tools to show a brief
description if needed. The generated CRD docs still contain
the full descriptions for reference.
Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 3c1b0692e4)
Use Quay as the source for the nginx-unprivileged image used for the
Multus validation tool because Quay does not rate limit image pulls,
which are a common complaint for users of the tool.
Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit cd253d0218)
Since v18.2.1 is the default recommendation for the ceph version,
update all the docs and examples to that version.
Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 56a3370d83)
Travis Nielsen
NymanRobin
parth-gr
Hyeonki Hong
Redouane Kachach
mergify[bot]
Alexander Trost
Madhu Rajanna
Tim Olow
subhamkrai
Michael Adam
parth-gr
Erik Berg
Praveen M
Blaine Gardner
Riya Singhal