Commit Graph
8166 Commits
Author SHA1 Message Date
Travis Nielsen 08c3099b8c Merge pull request #9074 from travisn/helm-settings-configmap
helm: Apply operator settings in configmap instead of deployment
2022-01-20 15:37:55 -07:00
Travis Nielsen 741f211a13 helm: apply operator settings in configmap instead of deployment
Some operator settings can be applied dynamically in a configmap
instead of requiring the operator to restart. While these settings
may be infrequently updated, applying these settings in the configmap
can avoid an unnecessary operator restart. This will also make the
operator deployment more consistent with the non-helm install.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-01-20 14:41:28 -07:00
Travis Nielsen 048190d010 Merge pull request #9613 from leseb/fix-9602
core: reconcile operator configuration with env var
2022-01-20 09:53:11 -07:00
Blaine Gardner 54a7e1e477 Merge pull request #9444 from cloudandheat/feature/swift-and-keystone
rgw: Design document for the Keystone and Swift integration
2022-01-20 09:20:58 -07:00
Sébastien Han 1208bc1410 core: reconcile operator configuration with env var
Previously, we were ignoring configuration changes coming from the
operator's pod env variables. We were assuming most users were using the
operator configmap "rook-ceph-operator-config" but most Helm users
don't. Now we will reconcile if a cephcluster is found during a CREATE
event (can be an operator restart or a cephcluster creation) AND no
"rook-ceph-operator-config" is found which means the operator's pod env
var are used.
Also, unit tests have been added (long due) for the predicate!

Closes: #9602, #9487, #9579
Signed-off-by: Sébastien Han <seb@redhat.com>
2022-01-20 16:13:11 +01:00
Blaine Gardner d0d83edc5f Merge pull request #9502 from cybozu-go/core-support-priority-class-for-crashcollector
core: support priority class for crashcollector
2022-01-19 10:38:29 -07:00
Travis Nielsen ece65ff144 Merge pull request #9586 from Madhu-1/helm-csi-vrc
csi: add support to create volumesnapshotclass
2022-01-19 09:59:57 -07:00
Madhu Rajanna 85dc212704 csi: add support to create volumesnapshotclass
add support for helm charts to create default
volumesnapshotclass for cephfs and rbd

fixes: #9566

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-01-19 21:51:28 +05:30
Travis Nielsen 49c7ff0612 Merge pull request #9547 from subhamkrai/annotation-on-resources
mon: add annotation to mon secret and cm
2022-01-19 07:51:05 -07:00
Sébastien Han fc1bbd7195 Merge pull request #9605 from yati1998/port
csi: restrict csiaddons to use only 1 port
2022-01-19 15:43:34 +01:00
Satoru Takeuchi 5465481e0b core: support priority class for crashcollector
Support priorityClass to crashcollectors as mons, mgrs, and osds.

https://rook.io/docs/rook/v1.8/ceph-cluster-crd.html#priority-class-names-configuration-settings

The main use case is applying the high priority to crashcollectors to preempt normal pods
under heavy load. Without this feature, we might lose crash information.

Closes: https://github.com/rook/rook/issues/9500

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2022-01-19 13:54:03 +00:00
yati1998 c559bbdf6b csi: restrict csiaddons to use only 1 port
This commit restrict csiaddons to open only 1 port
as per the requirement which is required for security.

Fixes: #9604

Signed-off-by: yati1998 <ypadia@redhat.com>
2022-01-19 12:07:46 +05:30
subhamkrai 02d43e82e0 mon: add annotation to mon secret and cm
add annotations to secrets and configmaps to use
different tools to sync secrets and configmap.
Currently, these annotation is applied only on
the `rook-ceph-mon-endpoints` configmap and
the secrets `rook-ceph-mon` and `rook-ceph-admin-keyring`.

Closes: https://github.com/rook/rook/issues/8999
Signed-off-by: subhamkrai <srai@redhat.com>
2022-01-19 10:15:17 +05:30
Sébastien Han c6ca35eea1 Merge pull request #9534 from yati1998/csi-addon
csi: implement csi-addons sidecar
2022-01-18 17:55:07 +01:00
Sébastien Han 46ef24b5c9 Merge pull request #9571 from parth-gr/external-cluster-osd-blocklist
csi: Add osd blocklist capabilities to the external cephcluster
2022-01-18 17:42:14 +01:00
yati1998 2b92dc812c csi: implement csi-addons sidecar
This commit implements the csi-addons sidecar.

Signed-off-by: yati1998 <ypadia@redhat.com>
2022-01-18 21:52:01 +05:30
Travis Nielsen bf5e329d8e Merge pull request #9596 from thotz/update-keda-latest-keda-vers
docs: update scaledobject.yaml for applicable with keda v2.5
2022-01-18 08:02:40 -07:00
Sébastien Han 7bfa320528 Merge pull request #9594 from leseb/fix-locale
build: set LC_ALL on the make target
2022-01-18 15:15:17 +01:00
Jiffin Tony Thottan e90c36f255 docs: update scaledobject.yaml for applicable with keda v2.5
Even though mention about keda 2.x version, the scaledObject.yaml or
rgw-keda.yaml referring to older keda CRs

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2022-01-18 18:57:28 +05:30
parth-gr 7e851f15c6 csi: add osd blocklist capabilities to the external cephcluster
The CSI users created by the external script(both for rbd and cephfs)
need the blocklist capability so the CSI pods can execute the
`osd blocklist` commands for metro DR
update the mon caps of csi users with `profile simple-rados-client-with-blocklist`
so they have privileges to run osd blocklist cmds

Closes: https://issues.redhat.com/browse/RHSTOR-2451

Signed-off-by: parth-gr <paarora@redhat.com>
2022-01-18 18:01:01 +05:30
Sébastien Han b2050b0f00 Merge pull request #9581 from humblec/release-3.5
Update ceph csi release 3.5 image and sidecars
2022-01-18 12:16:53 +01:00
Sébastien Han 8512b6a0e1 build: set LC_ALL on the make target
Simply applying `LC_ALL=C` will work for the current shell only. For all
the shells and sub-shell to use it, we must set it globally.
Making it the first thing in the Make entrypoint now so the CRD and RBAC
sorting works on all the platforms.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-01-18 12:01:04 +01:00
Humble Chirammal b7584f3007 csi: update sidecar to the latest releases
Below sidecars are updated to the latest releases with this commit.

csi-provisioner      : 3.1.0
csi-attacher         : 3.4.0
node-driver-registrar: 2.4.0

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2022-01-17 23:32:48 +05:30
Humble Chirammal e8d9884f05 csi: update ceph csi images to release 3.5.0
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2022-01-17 23:32:45 +05:30
Travis Nielsen e2711754bf Merge pull request #9582 from subhamkrai/update-ssd-bluestore-value
osd: correct bluestore compression min blob size for ssd
2022-01-17 09:32:30 -07:00
Sébastien Han ae6195b0a9 Merge pull request #9585 from leseb/skip-encryption
ci: skip encryption test if env is not set
2022-01-17 16:22:36 +01:00
Sébastien Han f014724288 ci: skip encryption test if env is not set
If the secret is not present in the run then let's skip it.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-01-17 15:50:40 +01:00
subhamkrai d87be97a50 osd: correct bluestore compression min blob size for ssd
Update bluestore compression min blob size for ssd to 8192.
It was typo which was added long time back.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-01-17 15:13:15 +05:30
Travis Nielsen f3246228d8 Merge pull request #9467 from travisn/update-mgr-service
mgr: Update services when active mgr changes
2022-01-13 12:21:03 -07:00
Sébastien Han cf5f68f378 Merge pull request #9545 from rook/kms-hpcs
osd: add ibm key protect kms
2022-01-13 18:11:15 +01:00
Blaine Gardner 1dde99bef7 Merge pull request #9570 from BlaineEXE/make-crd-rbac-ordering-deterministic-in-linux
build: make crd/rbac generation order deterministic
2022-01-13 10:05:08 -07:00
Blaine Gardner 6f4a23694d build: make crd/rbac generation order deterministic
Linux doesn't guarantee file ordering, so when dealing with files in
order, we can use 'sort' to make sure the order is deterministic. For
yq's usage of files, we need to keep file names in an intermediate
variable, and this should be an array to support file paths with spaces.
'readarray' is not available on MacOS's built-in bash, so a longer
'while read' loop is needed for the array creation.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-01-13 09:24:07 -07:00
Blaine Gardner 3b415ea15a Merge pull request #9482 from yuvalif/ceph-cloudevent-topic
rgw: add HTTP CloudEvent endpoints to CephBucketNotification CR
2022-01-13 08:40:07 -07:00
Sébastien Han a7acf490b6 osd: add ibm key protect kms
The cluster-wide encryption feature now has a new supported key
management system: IBM Key protect. More information about the backend
can be found in Rook documentation under the

Today's implementation stores OSD encryption keys has "Standard" keys.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-01-13 16:02:10 +01:00
Travis Nielsen 11127f54ca mgr: update services when active mgr changes
When the active mgr changes, there may be user-created services
that also need to have their selector updated to point to the
new active mgr. Now the operator will update any service in the
rook operator namespace that has the label app=rook-ceph-mgr
to point to the active mgr.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-01-13 07:25:24 -07:00
Sebastian Riese 38d37011c2 rgw: swift design document: add the endpoint to the swift user secret
This makes the secret a self-contained description how to access the
Swift API.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2022-01-13 11:10:11 +01:00
Yuval Lifshitz c99e2a37fd rgw: add HTTP CloudEvent endpoints to CephBucketNotification CR
this add a configuration parameter that allows an RGW, from
Ceph Quincy (v17) and on, to send bucket notifications to an HTTP CloudEvents
endpoint.
Header format:
https://github.com/cloudevents/spec/blob/main/cloudevents/adapters/aws-s3.md

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2022-01-13 12:08:40 +02:00
Travis Nielsen 9840273d8e Merge pull request #9546 from travisn/helm-upgrade-test
tests: Helm upgrade integration test
2022-01-12 13:24:41 -07:00
Travis Nielsen 8fb758fee9 test: implement helm upgrade integration test
The helm tests were previously only for new installs, and did
not have an upgrade path. Now the upgrade path is tested
to give confidence in the helm upgrades.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-01-12 07:19:42 -07:00
Travis Nielsen 52c938b7f9 test: remove obsolete check for test suites to run
The test suites were triggered by Jenkins potentially
using different versions of K8s and environment variables.
There is no longer a need for these environment vars to
determine which test suites should be run. The test
suites to run can just be triggered directly.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-01-11 11:10:50 -07:00
Travis Nielsen d1f3e3b9ad test: upgrade from v1.7.10
The upgrade test is best if run from the latest v1.7 patch release.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-01-11 11:10:48 -07:00
Sébastien Han fdbb741962 Merge pull request #9549 from rook/dependabot/go_modules/github.com/hashicorp/vault-1.8.5
build(deps): bump github.com/hashicorp/vault from 1.8.2 to 1.8.5
2022-01-11 16:14:12 +01:00
Travis Nielsen 714046b55f Merge pull request #9554 from henryzhangsta/cluster-monitoring-helm
helm: use operatorNamespace if exists for monitoring RBAC
2022-01-11 08:07:11 -07:00
Travis Nielsen dbcd2f8a30 Merge pull request #9560 from leseb/fix-2039240
osd: use cluster name when fetching the cephcluster
2022-01-11 07:48:25 -07:00
Sébastien Han 0a54db935b osd: use cluster name when fetching the cephcluster
Previously we were using the namespace, it's a mistake, even though most
clusters use the same name as the namespace.
Let's be precise and use the cluster name when looking for it.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-01-11 15:05:59 +01:00
Henry Zhang 3d89834ee4 helm: use operatorNamespace if exists for monitoring RBAC
right now the RoleBinding for monitoring is created with the cluster namespace as the subject
this causes the operator to loop on reconcile due to it not having permissions to create monitors
in the other cluster

moving the subject to the operator namespace fixes this

Signed-off-by: Henry Zhang <me@henry.dev>
2022-01-10 20:53:18 -05:00
dependabot[bot] 42cdf84bad build(deps): bump github.com/hashicorp/vault from 1.8.2 to 1.8.5
Bumps [github.com/hashicorp/vault](https://github.com/hashicorp/vault) from 1.8.2 to 1.8.5.
- [Release notes](https://github.com/hashicorp/vault/releases)
- [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md)
- [Commits](https://github.com/hashicorp/vault/compare/v1.8.2...v1.8.5)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/vault
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-10 15:14:08 +00:00
Sébastien Han 511c250336 Merge pull request #9411 from parth-gr/external-cluster-permission-security
security: update auth permissions for external cluster
2022-01-10 16:12:42 +01:00
Sebastian Riese 880ee65866 rgw: swift design document: make the annotations markers numerical
This is for consistency with the other design documents.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2022-01-10 13:08:37 +01:00
Sebastian Riese c01788bec0 rgw: swift design document: change subuser secret name
The colon character is not allowed in secret names, therfore the secret
with the subuser credentials must use another character to join the
user and the subuser name.

This in turn makes the mapping non-injective (which has security
implications).

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2022-01-10 13:06:07 +01:00