Commit Graph
8016 Commits
Author SHA1 Message Date
Sébastien Han 0ffb22faa3 Merge pull request #9396 from y1r/add-context-k8sutil-service
core: add context parameter to k8sutil service
2021-12-13 10:03:37 +01:00
Sébastien Han b10e3419b0 Merge pull request #9397 from y1r/add-context-k8sutil-rs-and-secret
core: add context to k8sutil replicaset and secret
2021-12-13 10:02:21 +01:00
Yuichiro Ueno b6ce262e7f core: add context to k8sutil replicaset and secret
This commit adds context parameter to k8sutil replicaset and secret
functions. By this, we can handle cancellation during API call of
replicaset and secret resource.

Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
2021-12-11 11:42:31 +09:00
Yuichiro Ueno 03e976b52c core: add context parameter to k8sutil service
This commit adds context parameter to k8sutil service functions. By
this, we can handle cancellation during API call of service resource.

Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
2021-12-11 11:40:28 +09:00
Travis Nielsen 3309e9a3ee Merge pull request #9380 from leseb/fix-9375
osd: cleanup cluster using the root UID
2021-12-10 10:26:10 -07:00
Sébastien Han 1f7536ffab osd: cleanup cluster using the root UID
We need to use the root UID to run the cleanup job since ceph-volume
does not support running as non-root in all the versions. We have this
ceph tracker to allow this https://tracker.ceph.com/issues/53511 but
it's not in all ceph's versions. Implementing a version check is tricky
since at this stage the cluster is being deleted and it's hard to catch
it.

Closes: https://github.com/rook/rook/issues/9375
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-12-10 10:14:15 +01:00
Travis Nielsen 9299e32f5b Merge pull request #9377 from travisn/reset-release-notes
docs: Reset the pending release notes for 1.9
2021-12-09 14:29:44 -07:00
Travis Nielsen 6d89747b21 docs: reset the pending release notes for 1.9
With the v1.8 release pending, we can reset the pending
release notes for v1.9.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-12-09 12:48:11 -07:00
Blaine Gardner f36f08039f Merge pull request #9372 from BlaineEXE/upgrade-doc-admission-controller
docs: add instructions to upgrade admission controller
2021-12-09 12:41:32 -07:00
Blaine GardnerandSébastien Han 6c09de619f docs: add instructions to upgrade admission controller
In 1.8, the admission controller has merged with the operator and the
operator needs an emptyDir and a volume mount to store the webhook
certificates.

Co-authored-by: Blaine Gardner <blaine.gardner@redhat.com>
Co-authored-by: Sébastien Han <seb@redhat.com>

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-12-09 12:39:19 -07:00
Blaine Gardner 2467daa406 Merge pull request #9169 from thotz/addtestcasesbucketnotification
test: add more test cases for bucket notfication
2021-12-09 08:54:21 -07:00
Sébastien Han f32ee1e182 Merge pull request #9357 from Omar007/patch-2
helm: rook-ceph chart: Set up webhook cert volume
2021-12-09 14:40:26 +01:00
Sébastien Han ac06d035e6 Merge pull request #8776 from parth-gr/snapshot-mirror-status
ceph: removing fs_name arg from daemon status cmd
2021-12-09 13:53:03 +01:00
parth-gr f7082c9efa mds: removing fs_name arg from daemon status cmd
If cephVersion>= 16.2.7, we run
ceph fs snapshot mirror daemon status
otherwise we run
ceph fs snapshot mirror daemon status <fs_name>

Updating the cmd so both the ceph version can run successfully

Closes: https://github.com/rook/rook/issues/8458
Signed-off-by: parth-gr <paarora@redhat.com>
2021-12-09 17:40:28 +05:30
Omar Pakker 5841077549 helm: rook-ceph chart: Set up webhook cert volume
The 1.8 (beta) relies on a volume when using the admission controller,
which is missing from the Helm chart.
This change sets up the volume so the operators starts properly
when set up to run the admission controller.

Closes: https://github.com/rook/rook/issues/9349
Signed-off-by: Omar Pakker <Omar007@users.noreply.github.com>
2021-12-09 08:46:19 +00:00
Blaine Gardner d40e6d78e7 Merge pull request #9362 from BlaineEXE/nfs-make-namespace-optional
nfs: make rados.namespace optional
2021-12-08 17:00:05 -07:00
Blaine Gardner 0bbab6dfc9 nfs: make rados.namespace optional
Fix the CephNFS spec.rados API specifiation to be clear that spec.rados
is optional for all Ceph v16 versions, including that
spec.rados.namespace is optional.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-12-08 16:27:51 -07:00
Blaine Gardner 6ad2026a0e Merge pull request #9356 from BlaineEXE/nfs-remove-poolconfig
nfs: remove poolConfig
2021-12-08 15:35:06 -07:00
Blaine Gardner aaecc93315 nfs: remove poolConfig
Remove the poolConfig in CephNFS to prevent different CephNFS CRs from
contending to change the replication spec of the default NFS pool.

Resolves #9355

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-12-08 13:56:28 -07:00
Blaine Gardner a99f8985b0 Merge pull request #9150 from yuvalif/ceph-notifications-refactor
ceph: bucket notifications refactoring work
2021-12-08 11:30:15 -07:00
Sébastien Han 6a10adc4fb Merge pull request #9347 from leseb/fix-9314
core: always return nil clusterInfo on failure
2021-12-08 18:08:10 +01:00
Sébastien Han 2bba4f18b8 Merge pull request #9343 from leseb/bump-to-16.2.7
core: bump to ceph 16.2.7
2021-12-08 18:03:41 +01:00
Blaine Gardner d20692aa6a Merge pull request #9281 from BlaineEXE/nfs-docs
docs: update NFS docs
2021-12-08 10:00:46 -07:00
Travis Nielsen 9aea032f0d Merge pull request #9214 from travisn/update-failure-domain
pool: Update the desired failure domain when changed
2021-12-08 09:59:22 -07:00
Sébastien Han e5ce6abac0 core: continue and create an initial cluster info or fail
Let's catch the correct error when no cluster info exists yet. If we
have another error, we fail the orchestration and try again. This could
help up catching small API hiccups for example.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-12-08 17:31:44 +01:00
Sébastien Han 4f1a2d47a4 core: fix error message
Let's have a more accurate and correct error message that reflects what
the failing function tried to do.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-12-08 17:30:49 +01:00
Sébastien Han fdd243d3de core: always return nil on error
We should always return a nil pointer of clusterInfo if
CreateOrLoadClusterInfo() returns an error.

Closes: https://github.com/rook/rook/issues/9314
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-12-08 17:30:07 +01:00
Sébastien Han 0a918814ea core: bump to ceph 16.2.7
ceph 16.2.7 is out so let's use it in our manifests.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-12-08 17:24:56 +01:00
Blaine Gardner e98959cce0 docs: update NFS docs
NFS docs need to be updated to reflect changes between Octopus and
Pacific, how users are affected, how NFS is configured differently
between the Ceph versions, and how to upgrade from one Ceph version to
the other.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-12-08 09:14:53 -07:00
Travis Nielsen 8e55dd9d41 pool: update the desired failure domain when changed
The failure domain is baked into the crush rule that is
created for a pool. To allow for an updated failure domain
on the pool, create a new crush rule specific for that
failure domain and update the pool with the new rule.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-12-08 08:10:53 -07:00
Sébastien Han 122ff34d11 Merge pull request #9342 from travisn/upgrade-toolbox-spec
test: Upgrade test to update the toolbox spec
2021-12-08 09:13:03 +01:00
Travis Nielsen 1e9d4cc31f test: upgrade test to update the toolbox spec
The toolbox spec changed from 1.7 to 1.8 due to the removal
of tini from the image. The upgrade test was failing on
k8s 1.18 due to this issue.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-12-07 17:00:22 -07:00
Travis Nielsen 3d69e10ac4 Merge pull request #8452 from subhamkrai/ec-file-layout
mds: create EC pool as secondary pool
2021-12-07 15:47:01 -07:00
Travis Nielsen b79950f726 Merge pull request #9337 from travisn/helm-upgrade-doc
docs: Clarify helm chart version upgrades
2021-12-07 15:07:31 -07:00
Blaine Gardner 7045fd3b69 Merge pull request #9316 from BlaineEXE/generate-common-from-helm
build: generate common.yaml from helm charts
2021-12-07 15:06:28 -07:00
Travis Nielsen 1002c6fd2e docs: clarify helm chart version upgrades
Since the cluster helm chart was created in v1.7, the new helm
chart specifies the ceph image, so we clarify the upgrade
doc with the latest info.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-12-07 14:09:45 -07:00
Blaine Gardner bcc7d3e541 build: generate common.yaml from helm charts
Generate deploy/examples/common.yaml from Helm charts. There were still
a few differences between common.yaml and the Helm charts. Where there
were differences we assume common.yaml was the most up-to-date.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-12-07 13:54:27 -07:00
Travis Nielsen c953032d09 Merge pull request #8678 from parth-gr/Recommended-labels
core: create rook resources with k8s recommended labels
2021-12-07 11:53:33 -07:00
Blaine Gardner d9806a8ec9 Merge pull request #9317 from BlaineEXE/upgrade-docs
docs: revise upgrade doc for Rook v1.8
2021-12-07 09:30:20 -07:00
Yuval Lifshitz f2b065a3ae rgw: refactor bucket notification code
this should make sure code reuse between the OBC label controller and
the CephBucketNotification controller.
done as part of the cleanup work from:
https://github.com/rook/rook/pull/8426

this also include adding unit tests for:
- topic controller
- notification controller
- obc label controller

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2021-12-07 18:24:46 +02:00
Travis Nielsen 399eb17e84 Merge pull request #9332 from parth-gr/rbac-sort
build: updated locale for rbac generation
2021-12-07 09:24:02 -07:00
Blaine Gardner 922ecbf53a docs: revise upgrade doc for Rook v1.8
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-12-07 09:15:56 -07:00
Sébastien Han 90c063240a Merge pull request #9327 from leseb/check-helm
build: check for the existence of helm
2021-12-07 16:25:02 +01:00
parth-grandBlaine Gardner blaine.gardner@redhat.com 3647dec90f build: updated locale for rbac generation
Currently there was an issue related to sorting
files in Rbac generation in different platforms
Updated the locale to LC_ALL=C so rbac generation
can done correctly

Closes: https://github.com/rook/rook/issues/9331
Co-authored-by: Blaine Gardner blaine.gardner@redhat.com
Signed-off-by: parth-gr <paarora@redhat.com>
2021-12-07 20:32:27 +05:30
parth-gr 0a86d26b2e core: create rook resources with k8s recommended labels
Adding Recommended Labels on the resources created by rook
    and using Recommended Labels in the helm chart,
    for better visuals and management of k8s object

Closes: https://github.com/rook/rook/issues/8400
Signed-off-by: parth-gr <paarora@redhat.com>
2021-12-07 18:16:44 +05:30
Sébastien Han 1f33859048 Merge pull request #9312 from travisn/truncate-job-name
Truncate job name of the osd prepare job further to avoid pod generation failure on K8s 1.22
2021-12-07 10:06:27 +01:00
Sébastien Han 21e9243780 Merge pull request #9315 from yuvalif/ceph-mark-notifications-experimental
rgw: add note that bucket notifications are experimental
2021-12-07 10:03:39 +01:00
Sébastien Han e0fd2a7cb3 build: check for the existence of helm
Let's fail nicely if the helm command is not available.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-12-07 09:52:31 +01:00
Yuval Lifshitz cd0cc8fa1c rgw: add note that bucket notifications are epxerimental
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2021-12-07 10:41:46 +02:00
subhamkrai 5bb29f1a21 mds: create EC pool as secondary pool
When creating EC fs, create replicated pool as primary
pool and ec pool as secondary pool, creating ec pool
as primary is not encouraged and it will lead to failure.

Also, changing the pool name in storageclass-ec file.

Closes: https://github.com/rook/rook/issues/8210
Signed-off-by: subhamkrai <srai@redhat.com>
2021-12-07 07:44:54 +05:30