Commit Graph
8872 Commits
Author SHA1 Message Date
Madhu Rajanna 187bea6701 csi: disable liveness sidecar by default
A Liveness sidecar container that is deployed
with the CSI pods will be helpful to check
csi driver is properly responding or not.
and there is no liveness or readiness
kubernetes probe added for this one.
Providing an option to enable this
sidecar deployment and disabling it by default.

fixes #8783

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-07-28 14:01:26 +05:30
Travis Nielsen 4cf2af6d1a Merge pull request #10636 from travisn/obsolete-osbase
build: Remove obsolete OSBASE image var
2022-07-27 14:09:09 -06:00
Travis Nielsen 3b6cc45113 Merge pull request #10626 from anthonyeleven/anthonyeleven/prom-localrules-tweaks
Improve descriptions in localrules.yaml
2022-07-27 11:40:23 -06:00
Travis Nielsen c2991de238 Merge pull request #10580 from gauravsitlani/cephfs-mirroring-test
docs: CephFS mirroring updates around Peer Tokens
2022-07-27 10:25:24 -06:00
Gaurav Sitlani 27f2098ad9 docs: cephfs mirroring updates around peer tokens
This commit updates the CephFS mirroring documentation
around Peer tokens to get the token created correctly.

Signed-off-by: Gaurav Sitlani <gauravsitlani@riseup.net>
2022-07-27 21:52:21 +05:30
Anthony D'Atri dc53497d37 docs: improve descriptions in localrules.yaml
Parallel upstream changes via https://github.com/ceph/ceph/pull/47284

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2022-07-26 16:32:29 -07:00
Travis Nielsen 4d8cbaac83 build: remove obsolete image base var
The OSBASE and OSBASEIMAGE are obsolete from an older version
of rook where Ceph was not the base image. Now that Ceph provides
the base image, there is no need for these vars in the makefile.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-07-26 11:57:49 -06:00
Travis Nielsen 6eda2654a6 Merge pull request #10581 from chienfuchen32/patch-2
docs: update Example Configurations document
2022-07-25 13:12:03 -06:00
Travis Nielsen 41fcdcc28d Merge pull request #10583 from sathieu/helm_prometheusrule_labels_annotations
helm: add labels and annotations to PrometheusRule
2022-07-25 13:08:23 -06:00
Travis Nielsen cec872dbff Merge pull request #10630 from subhamkrai/use-ceph-17.2.1
ci: use ceph v17.2.1 instead of latest v17
2022-07-25 09:54:52 -06:00
subhamkrai 4501cc25c6 ci: use ceph v17.2.1 instead of latest v17
there could be something breaking with latest ceph.
So, let's stick to v17.2.1.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-07-25 20:14:52 +05:30
Mathieu Parent 44b43557f9 helm: add labels and annotations to PrometheusRule
Signed-off-by: Mathieu Parent <mathieu.parent@insee.fr>
2022-07-21 10:26:31 +02:00
Travis Nielsen e8b28c080f Merge pull request #10610 from anthonyeleven/anthonyeleven/update-pg-advice
docs: clarify PG count actions and update pgcalc URL
2022-07-19 09:08:24 -06:00
chienfuchen32 5ddca98460 docs: update Example Configurations Docs
Some link fixing in Example Configurations
Ref: https://rook.io/docs/rook/v1.9/Storage-Configuration/Block-Storage-RBD/rbd-mirroring/
     https://rook.io/docs/rook/v1.9/Getting-Started/example-configurations/#block-devices

Signed-off-by: chienfuchen32 <chienfuchen32@gmail.com>
2022-07-19 12:43:38 +08:00
Anthony D'Atri 6b2b0f468c docs: clarify PG count actions and update pgcalc URL
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2022-07-18 20:11:06 -07:00
Travis Nielsen 89fadabcc1 Merge pull request #10575 from shalevpenker97/EnableRBDStats-mgr-fix
Fix EnableRBDStats mgr
2022-07-18 12:57:54 -06:00
Travis Nielsen e3256c07fe Merge pull request #10523 from leseb/fix-stuck-reconciler
core: fix stuck reconciler (more checkpoints for cancelled context)
2022-07-18 08:58:07 -06:00
Travis Nielsen de448d31f9 Merge pull request #10607 from Juneezee/test/t.Setenv
test: use `T.Setenv` to set env vars in tests
2022-07-15 16:02:04 -06:00
Travis Nielsen 3a164e3129 Merge pull request #10602 from travisn/doc-telemetry
docs: Add telemetry section to quickstart guide
2022-07-15 10:16:54 -06:00
Travis Nielsen 9ea37be45f docs: add telemetry section to quickstart guide
To start collecting telemetry on upstream clusters,
we add a new section to the quickstart guide that
requests users to enable the telemetry.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-07-15 10:12:15 -06:00
Eng Zer Jun 8a25b1d903 test: use T.Setenv to set env vars in tests
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-07-15 23:07:19 +08:00
Travis Nielsen fc541764f1 Merge pull request #10484 from jsoref/spelling
core: fix spelling
2022-07-15 08:31:41 -06:00
Travis Nielsen 37a4d9e959 Merge pull request #10491 from zhucan/feat-10451
object: network mode can be set separately for cephcluster and rgw
2022-07-14 11:21:26 -06:00
Travis Nielsen 2c1041a3ec Merge pull request #10511 from parth-gr/auto-assign
ci: add ci bot for auto assign issue
2022-07-14 10:52:50 -06:00
Travis Nielsen 3c3803c936 Merge pull request #10590 from 4k1l/examples_fix_secretname
examples: fix secrets naming import-external-cluster.sh script
2022-07-14 10:44:37 -06:00
Ali, Akil 25265bc9c2 external: fix secrets naming
The secrets are being created with "rook-" prefix, but used without it.
Signed-off-by: Ali, Akil <ali-akil@gmx.de>
2022-07-14 16:55:45 +02:00
parth-gr 2ba7237c98 ci: add ci bot for auto assign issue
Now users can auto-assign issues by commenting
/assign on the issue topic

Closes: https://github.com/rook/rook/issues/10492
Signed-off-by: parth-gr <paarora@redhat.com>
2022-07-14 11:22:28 +05:30
Satoru Takeuchi ac2f375cb3 Merge pull request #10494 from microyahoo/issue_10486
osd: metadata device supports udev path
2022-07-14 14:31:55 +09:00
Liang Zheng 7609dad72f osd: metadata device supports udev path
This commit adds udev path for metadata device

Closes: https://github.com/rook/rook/issues/10486

Signed-off-by: Liang Zheng <zhengliang0901@gmail.com>
2022-07-14 10:26:33 +08:00
Travis Nielsen f3b7c36426 Merge pull request #10589 from travisn/whereabouts-version
ci: Pin the whereabouts version to v0.5.3
2022-07-13 12:02:47 -06:00
Travis Nielsen 53955790f3 ci: pin the whereabouts version to v0.5.3
The whereabouts manifests in the master branch
have moved around, so until the new approach
is investigated we pin to the latest release
version v0.5.3

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-07-13 10:37:15 -06:00
Travis Nielsen e1f52afc2e Merge pull request #10570 from subhamkrai/update-default-leader-election
csi: default values of leader election not enough
2022-07-13 08:04:50 -06:00
Travis Nielsen 35bcf5c1db Merge pull request #10577 from travisn/mgr-services
mgr: Skip updating service if there is no selector
2022-07-13 07:44:11 -06:00
subhamkrai 5e92a30a77 csi: default values of leader election not enough
csi pods uses leader election and they were using
default values but seems like default values of leader
election are not working for some specific clusters.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-07-13 09:50:39 +05:30
Travis Nielsen b8dac76d18 mgr: skip updating service if there is no selector
When the mgr services are updated by the operator to set the
active mgr properly, skip services that do not currently
have a selector set.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-07-12 16:30:20 -06:00
Sébastien Han a6036074db core: more checkpoint for context cancelled
Some context canceled were missed and not reported correctly. We had
multiple reconcilers running in //. Since they all run in goroutine then
will continue to run until they timeout (if timeout is available,
    otherwise would run forever until the op is restarted).

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-07-12 12:07:59 +02:00
Sébastien Han 247d725aac core: let IsInitialized return errors
Let's return an error instead of a bool so we can better parse it and
decide what to do with it.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-07-12 12:07:57 +02:00
Satoru Takeuchi d82eb8adbe Merge pull request #7967 from cybozu-go/ceph-support-some-dm-devices-in-host-based-cluster
osd: support OSD on logical volume in host-based cluster
2022-07-12 07:24:32 +09:00
Satoru Takeuchi 7e571f6114 osd: support OSD on logical volume in host-based cluster
Rook supports raw mode OSD in host-based cluster. So we can also
support OSD on logical volume in this kind of cluster.

Logical volumes aren't picked by filters (i.e. `useAllDevices: true`
and `device{Path,}Filter` to avoid unwanted LV consumption on upgrade.

Closes: https://github.com/rook/rook/issues/2047

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2022-07-11 21:08:50 +00:00
shalev.p 49996522bf pool: configureRBDStats remove postfix dot in mgr config path
The ceph rbd_stats does not take affect with dot postfix.

Closes: https://github.com/rook/rook/issues/10574
Signed-off-by: shalev.p <shalev.p@taboola.com>
2022-07-11 18:21:42 +03:00
Blaine Gardner 97114eaa07 Merge pull request #10572 from BlaineEXE/remove-old-rbac-yaml
build: remove obsolete rbac.yaml file
2022-07-08 12:23:11 -06:00
Blaine Gardner 7cbda4d814 Merge pull request #10563 from parth-gr/rbac-wildcard
core: remove all wildcard permissions in rbac definations
2022-07-08 11:36:54 -06:00
Blaine Gardner 566585640b build: remove obsolete rbac.yaml file
build/rbac/rbac.yaml should have been removed when we started generating
common.yaml, but it was missed.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-07-08 09:59:05 -06:00
parth-gr 50daeb29e5 core: remove all wildcard permissions in rbac definations
Reduce the RBAC scope to the minimum necessary
permissions for rook to operator

Signed-off-by: parth-gr <paarora@redhat.com>
2022-07-08 20:50:59 +05:30
Travis Nielsen 5b6d9cc172 Merge pull request #10569 from subhamkrai/helm-webhook-port
helm: add missing port for webhook in helm
2022-07-08 08:34:38 -06:00
subhamkrai 94f0c0dc25 helm: add missing port for webhook in helm
adding port which was missing from helm rook-ceph chart
which is used by webhook due to which it was failing with
```
failed to run operator: gave up to run the operator manager: failed to
run the controller-runtime manager: listen tcp :9443: bind: address
already in use
```

Signed-off-by: subhamkrai <srai@redhat.com>
2022-07-08 17:39:46 +05:30
Josh Soref 6e7b8767f3 core: fix spelling
* another
* are
* availability
* available
* bootstrap
* boundaries
* ceph
* certificate
* class
* codifies
* consuming
* corrupted
* createor
* csi
* deployments
* exceeded
* execute
* filesystem
* healthiness
* heuristics
* immediately
* insecure
* installed
* isolated
* maintained
* maximum
* minute
* monitor
* new
* nginx
* nonexistent
* not
* occurs
* omitempty
* operator
* orchestration
* persistentvolumes
* placement
* preexisting
* prometheus
* protecting
* provisioner
* purposes
* reconcile
* regex
* related
* requests
* returns
* rubbish
* running
* schedulable
* schedule
* serviceaccount
* simulating
* snapshots
* statement
* static
* tenants
* the
* unavailable
* volumeattachment
* waiting
* with
* wrapper
* zonegroup

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-07-07 18:10:47 -04:00
Travis Nielsen a730d6d801 Merge pull request #10544 from travisn/remove-octopus
core: Remove support for ceph Octopus in Rook v1.10
2022-07-07 15:35:16 -06:00
Travis Nielsen dad97f3425 core: remove support for ceph octopus
With octopus coming to end of life, we remove support from
Rook for deploying Ceph Octopus and assume a min version of
Pacific v16. Any checks for octopus or earlier are removed
from the reconciles since they are obsolete.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-07-07 15:03:26 -06:00
Travis Nielsen 86b14d4467 Merge pull request #10558 from koor-tech/helm_label
helm: use recommended value for helm managed-by label
2022-07-07 11:57:00 -06:00