Commit Graph
8061 Commits
Author SHA1 Message Date
Sebastian Riese 1e2cf1665f rgw: swift design document: add s3 credentials generation via keystone
This was missing to complete the integration with keystone.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2022-01-07 15:10:18 +01:00
Sebastian Riese 96fb61dd26 rgw: swift design document: set the target version
As proposed in the review the natural target version for this feature is
1.9 which is to be released around March 2022.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2022-01-06 15:43:42 +01:00
Sebastian Riese ad693d555a rgw: swift design document: improve spelling and wording
Miscellaneous wording and fix spelling fixes.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2022-01-06 15:41:05 +01:00
Sebastian Riese b14222c813 rgw: swift design document: remove the Open Questions
The open questions have been resolved in the discussion and the chosen
solution has been added to the main text. So the Open Questions section
is obsolete now.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2022-01-06 15:38:45 +01:00
Sebastian Riese f9b2e39eca rgw: swift design document: sharpen the goals/non-goals
The goals/non-goals were mixed up to a degree. This
cleanly separates them to their respective sections.

In the course of that the term "Keystone API" was replaced by the more
correct "OpenStack Identity API" and the documentation of the API was
linked.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2022-01-06 15:35:38 +01:00
Sebastian Riese ed01435f0e rgw: swift design document: remove unnecessary metadata
As noted in the review this metadata is not required in design
documents.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2022-01-06 15:33:29 +01:00
Sebastian Riese 283d31e0db rgw: swift design document: configure swift in a new section
Instead of mixing configuration for different protocols in the gateway
section, depending on the type option, introduce a new section protocols for
API specific configuration.

This allows configuring s3 and swift in one RGW and at the same time
simplifies validation of the CRD and allows for a clean separation of
concerns.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2022-01-03 13:46:38 +01:00
Sebastian Riese 90a37ddd22 rgw: swift design document: clarify specification
* add annotations to the examples of new CR fields

* add links to external documentation

* clarify language issues raised in review

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2022-01-03 13:46:33 +01:00
Sebastian Riese b9a32d0ba0 rgw: swift design document: clarify the section on the openrc secret
The prior formulation which openrc variables take effect was
ambiguous/contradictory.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2021-12-17 16:34:40 +01:00
Sebastian Riese bd7fe77c2f rgw: swift design document: subuser management
Access to the Swift API is granted via subusers. The configuration
of the subusers is added to the cephobjectstoreuser CR.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2021-12-17 16:32:03 +01:00
Sebastian Riese 127c40626a rgw: swift design document: document which CAs are used for accessing keystone
The integration of Keystone includes HTTPS API calls to Keystone. We
document why the CA bundle used to verify those connections,
can't be explicitly configured and how it can be indirectly configured.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2021-12-17 16:29:09 +01:00
Sebastian Riese dc08052c3b rgw: swift-design document: make OBC interaction out-of-scope
It is not clear at this moment whether anyone has a use case for this.
As a workaround you can explicitly generate a user and subuser that
can access the bucket created via OBC.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2021-12-17 16:28:58 +01:00
Sebastian Riese 47c71ce7dd rgw: draft a design document for the Keystone and Swift integration
Ceph RGW supports integrating with OpenStack clouds by providing
the Swift object store API and using Keystone for authentication.
The design document describes how the required configuration shall
be mapped to the Object Store CRD.

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
2021-12-16 10:55:35 +01:00
Travis Nielsen 07f101e157 Merge pull request #9363 from travisn/configure-built-in-pool
pool: Allow configuration of built-in pools with non-k8s names
2021-12-15 16:03:54 -07:00
Travis Nielsen 60cc67fed4 test: only create replicated pools in ci
Creating an EC pool is causing the CI to hang when the EC
pool is initialized since there aren't enough OSDs to
satisfy the EC parameters.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-12-15 15:32:03 -07:00
Travis Nielsen 7ee9cc9d56 pool: allow configuration of built-in pools with non-k8s names
The built-in pools device_health_metrics and .nfs created by ceph
need to be configured for replicas, failure domain, etc.
To support this, we allow the pool to be created as a CR.
Since K8s does not support underscores in the resource names
the operator must translate this special pool name into
the name expected by ceph.

This also sets the basis for allowing filesystem data
pools to specify the desired pool name instead of requiring
a generated name.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-12-15 15:32:02 -07:00
Travis Nielsen 7a6a62f43b Merge pull request #9386 from leseb/mgr-active-side-car-permissions
mgr: run the watch side car config on /etc/ceph
2021-12-15 12:20:28 -07:00
Blaine Gardner 016ae962c7 Merge pull request #9388 from BlaineEXE/helm-add-monitoring-option
helm: add optional monitoring RBAC to operator chart
2021-12-14 15:35:49 -07:00
Blaine GardnerandMathieu Parent e3be7a30ba helm: add optional monitoring RBAC to operator chart
An older version of the Helm chart always installed RBAC permissions for
enabling monitoring. In an effort to reduce the privileges Rook uses by
default, they were removed. We need to still include the monitoring RBAC
optionally since the change could break some users.

Co-authored-by: Mathieu Parent <mathieu.parent@insee.fr>
Co-authored-by: Blaine Gardner <blaine.gardner@redhat.com>

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-12-14 15:32:54 -07:00
Blaine Gardner 24a77d4fa1 Merge pull request #9296 from degorenko/cephfs-datapools
file: allow to create CephFS dataPools with predefined names
2021-12-14 11:04:49 -07:00
Travis Nielsen 8c4a239e4c Merge pull request #9423 from parth-gr/direct-mount-toolbox
build: updating tini init command in direct mount toolbox
2021-12-14 10:53:59 -07:00
parth-gr bc355c695e build: update the securityContext of direct mount container
update securityContext to runAsUser: 0
so container can run as a root user

Signed-off-by: parth-gr <paarora@redhat.com>
2021-12-14 19:37:27 +05:30
parth-gr bd3e558c24 build: updating tini init command in direct mount toolbox
the tini have been removed but was still present at direct mount
used the bin/bash shell in place of tini

Closes: https://github.com/rook/rook/issues/9382
Signed-off-by: parth-gr <paarora@redhat.com>
2021-12-14 18:40:25 +05:30
Denis Egorenko 3ff681e81d file: allow to create CephFS data pools with predefined names
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
2021-12-14 12:52:19 +04:00
Sébastien Han ca7d7dd14f Merge pull request #9276 from subhamkrai/external-rbd-ec
pool: add rbd ec pool support in external cluster
2021-12-14 09:51:02 +01:00
Sébastien Han 8a9c4e5706 Merge pull request #9415 from travisn/k8s-1.23-test
build: Add K8s 1.23 to the CI tests
2021-12-14 09:29:19 +01:00
Sébastien Han af30b0a5b8 Merge pull request #9417 from BlaineEXE/fix-health-checker-when-force-deleted
pool: file: object: clean up health checkers for force deletion
2021-12-14 09:16:04 +01:00
subhamkrai fc88e4ff8e pool: update the failure domain of pool-ec file to host
Updating the failure domain of pool-ec file from
osd to host.

Signed-off-by: subhamkrai <srai@redhat.com>
2021-12-14 12:13:27 +05:30
subhamkrai 22865815cf pool: add rbd ec pool support in external cluster
Adding cli agrument `--rbd-metadata-ec-pool-name` to read
rbd ec pool name to support ec pool in external cluster
and also updating the json blob.

Signed-off-by: subhamkrai <srai@redhat.com>
2021-12-14 12:13:22 +05:30
Travis Nielsen ec7039e7f8 build: add k8s 1.23 to the ci tests
With the release of k8s 1.23 we update the CI to run PRs
against K8s 1.16 and K8s 1.23, the oldest and latest
releases that are supported. The master branch will
run against the latest v1.16, 1.18, 1.21, and 1.23.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-12-13 23:33:49 -07:00
Blaine Gardner 0c76be8c38 pool: file: object: clean up health checkers for force deletion
When CephBlockPool, CephFilesystem, or CephObjectStore resources are
deleted after removing their finalizer, the code path to stop monitoring
was not stopping monitoring since a non-present resource does not have a
name and namespace attached. When the object is deleted, ensure the
internal representation used to stop monitoring has a name and namespace
to fix the issue.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-12-13 16:07:01 -07:00
Sébastien Han 839d7e19df Merge pull request #9410 from CO-lhagman/restricted-cephfs-caps
security: use correct osd tags for restricted caps with external cluster script
2021-12-13 15:44:14 +01:00
Lennart Hagemann 7507790375 security: use correct osd tags for restricted caps
The create-external-cluster-resources.py with
--create-external-cluster-resources set to true
sets a wrong osd application tag. It should use
the fs name and not the fs pools.

Closes: https://github.com/rook/rook/issues/9227
Signed-off-by: Lennart Hagemann <lennart.hagemann@continum.net>
2021-12-13 15:03:02 +01:00
Sébastien Han 892c9a211c mgr: add missing context to the active-watch sidecar
The context was not initialized and thus the configmap fetch will fail
with a nil pointer.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-12-13 14:13:30 +01:00
Sébastien Han 5c1e459a6a mgr: run active-watch as root and privileged
For now, we must run the container with UID 0 and privileged for
multiple reasons:

* the rook binary writes ceph config to /var/lib/rook which is owned by
  root
* it's difficult to use /etc/ceph since it will conflict with the
  rook-ceph-override configmap AND is also owned by root since it's a
  mounted configmap.
* using /etc/ceph might be possible but has other issues with rook's
  exec package since the ceph config is built from /var/lib/rook

Closes: https://github.com/rook/rook/issues/9385
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-12-13 14:02:33 +01:00
Sébastien Han 200fb569f4 Merge pull request #9395 from y1r/add-context-k8sutil-kvstore
core: add context parameter to k8sutil kvstore
2021-12-13 11:44:58 +01:00
Sébastien Han 97b41eacdc Merge pull request #9391 from y1r/add-context-k8sutil-pvc
core: add context parameter to k8sutil pvc
2021-12-13 10:07:11 +01:00
Sébastien Han 9d345cafdf Merge pull request #9392 from y1r/add-context-k8sutil-prometheus
core: add context parameter to k8sutil prometheus
2021-12-13 10:06:09 +01:00
Sébastien Han ba8c6e061f Merge pull request #9394 from y1r/add-context-k8sutil-configmap
core: add context parameter to k8sutil configMap
2021-12-13 10:05:31 +01:00
Sébastien Han 870114fc91 Merge pull request #9393 from y1r/add-context-k8sutil-endpoint
core: add context parameter to k8sutil endpoint
2021-12-13 10:04:19 +01:00
Sébastien Han 0ffb22faa3 Merge pull request #9396 from y1r/add-context-k8sutil-service
core: add context parameter to k8sutil service
2021-12-13 10:03:37 +01:00
Sébastien Han b10e3419b0 Merge pull request #9397 from y1r/add-context-k8sutil-rs-and-secret
core: add context to k8sutil replicaset and secret
2021-12-13 10:02:21 +01:00
Yuichiro Ueno b6ce262e7f core: add context to k8sutil replicaset and secret
This commit adds context parameter to k8sutil replicaset and secret
functions. By this, we can handle cancellation during API call of
replicaset and secret resource.

Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
2021-12-11 11:42:31 +09:00
Yuichiro Ueno 03e976b52c core: add context parameter to k8sutil service
This commit adds context parameter to k8sutil service functions. By
this, we can handle cancellation during API call of service resource.

Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
2021-12-11 11:40:28 +09:00
Yuichiro Ueno 5352cf58a7 core: add context parameter to k8sutil pvc
This commit adds context parameter to k8sutil pvc functions. By this, we
can handle cancellation during API call of pvc resource.

Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
2021-12-11 11:32:46 +09:00
Yuichiro Ueno c6c8dca0a7 core: add context parameter to k8sutil prometheus
This commit adds context parameter to k8sutil prometheus functions. By
this, we can handle cancellation during API call of prometheus resource.

Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
2021-12-11 11:29:24 +09:00
Yuichiro Ueno d1d252c5c2 core: add context parameter to k8sutil endpoint
This commit adds context parameter to k8sutil endpoint functions. By
this, we can handle cancellation during API call of endpoint resource.

Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
2021-12-11 11:26:21 +09:00
Yuichiro Ueno 25f784194d core: add context parameter to k8sutil configMap
This commit adds context parameter to k8sutil configMap functions. By
this, we can handle cancellation during API call of configMap resource.

Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
2021-12-11 11:21:55 +09:00
Yuichiro Ueno 0d8c581aa9 core: add context parameter to k8sutil kvstore
This commit adds context parameter to k8sutil kvstore functions. By
this, we can handle cancellation during API call of kvstore resource.

Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
2021-12-11 11:17:12 +09:00
Travis Nielsen 3309e9a3ee Merge pull request #9380 from leseb/fix-9375
osd: cleanup cluster using the root UID
2021-12-10 10:26:10 -07:00