Commit Graph
8330 Commits
Author SHA1 Message Date
subhamkrai 2115daa317 core: refactor webhook config and related script
This commit refactor webhook config by adding/removing
spaces. Also, moved the Issue and Certificate creation
from bash script to webhook config yaml.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-03-14 10:16:01 +05:30
subhamkrai 536a73af64 core: remove caBundle value from webhook
now, we don't require caBundle values to verify in
webhook config.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-03-09 09:11:02 +05:30
Travis Nielsen 7ef5a0462f Merge pull request #9854 from Zempashi/helm-cephobjectstore-parameters
helm: fix rook-ceph-cluster helm chart for cephobjectstore storageclass without/empty parameters
2022-03-08 17:04:52 -07:00
Julien Girardin e8024cde8d helm: fix storageClass parameters handling
Test existence of parameters to avoid printing artifacts that
break yaml
Signed-off-by: Julien Girardin <jugirardin@free.fr>
2022-03-08 23:01:57 +01:00
Travis Nielsen 235781e28a Merge pull request #9841 from travisn/multiple-filesystem-legacy
helm: Remove obsolete setting for enabling multiple filesystems
2022-03-07 16:12:37 -07:00
Travis Nielsen f6f75c8038 Merge pull request #9842 from BlaineEXE/disable-raw-mode-for-some-disk-specific-configs
osd: disable raw mode for specific disk configs
2022-03-07 10:39:25 -07:00
Blaine Gardner 27ea49b9cd osd: disable raw mode for specific disk configs
If a specific disk is configured to have more than one OSD per device,
or if it has a metadata device specified, exclude it from raw mode on an
individual basis.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-03-07 08:35:14 -07:00
Travis Nielsen 2beee12f29 Merge pull request #9838 from mtt0/master
helm: add cephFileSystems storageClass.pool
2022-03-07 08:09:28 -07:00
Sébastien Han 1a78fbac67 Merge pull request #9732 from subhamkrai/split-code-and-unit-test
core: split external script unit test and main code in diff file
2022-03-07 15:09:28 +01:00
mtt0 fd4cdc589f helm: add cephFileSystems storageClass.pool
CephFileSystem StorageClass created by helm chart should use the specified pool
in values.yaml rather than hardcode 'data0'

Closes: #9826
Signed-off-by: mtt0 <retmain@foxmail.com>
2022-03-07 10:49:13 +08:00
Travis Nielsen 8383d9ab87 helm: remove obsolete setting for enabling multiple filesystems
The multiple filesystem support was added in Pacific and no
need for a setting that allows the support. The setting was
already removed other places from rook in a previous change
https://github.com/rook/rook/pull/8350.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-03-04 10:30:50 -07:00
Travis Nielsen 507a2e3364 Merge pull request #9834 from travisn/pdb-debug-logs
core: Disruption controller log ceph errors in debug level
2022-03-03 18:07:04 -07:00
Travis Nielsen bc6381169e core: disruption controller log ceph errors in debug level
The controller for disruption budgets is verbose at cluster creation
when the cluster is not yet created, which generates a lot of noise
in the log that makes the cluster look unhealthy. This is an expected
condition, so we can change this logging to debug level.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-03-03 14:36:27 -07:00
Travis Nielsen 79a316eaa7 Merge pull request #9829 from spdfnet/patch-1
Documentation/ceph-teardown.md: fix typo
2022-03-03 10:38:50 -07:00
Brian_P 577f96efb1 docs: teardown typo
Fix typo in teardown documentation
demsetup -> dmsetup

Signed-off-by: spdfnet <32593931+spdfnet@users.noreply.github.com>
2022-03-03 15:52:07 +00:00
Travis Nielsen 000ad22508 Merge pull request #9821 from matthiasr/mr/document-9806
operator: Document that the `rook-ceph-operator-config` ConfigMap is …
2022-03-03 07:43:05 -07:00
Matthias Rampke 57d0fada7b operator: document that the rook-ceph-operator-config ConfigMap is needed
We discovered the hard way that configuration through the environment
does not work if this ConfigMap is not present altogether. Document this
as a common issue.

Closes #9806.

Signed-off-by: Matthias Rampke <matthias@rampke.de>
2022-03-03 08:43:27 +00:00
Travis Nielsen fd9cb1f3fd Merge pull request #9823 from travisn/pr-template-text
docs: Update the pr template checklist
2022-03-02 16:10:21 -07:00
Travis Nielsen 459869859c Merge pull request #9808 from travisn/two-mgrs
mgr: Set the default count of mgr daemons to 2
2022-03-02 14:49:46 -07:00
Travis Nielsen bc9914e99d mgr: set the default count of mgr daemons to 2
To ensure the mgr is not the single point of failure, the mgr
daemon count is now set to 2 by default in the cluster examples.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-03-02 13:35:05 -07:00
Travis Nielsen 9003f1b2fc docs: update the pr template checklist
The PR checklist has a couple links that were outdated
and some other items that are generally not necessary to
consider in every PR. Now the checklist is more concise
and links are updated.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-03-02 12:00:07 -07:00
Travis Nielsen d716d203eb Merge pull request #9816 from sungjunyoung/master
docs: correct ceph toolbox path
2022-03-01 08:59:09 -07:00
Travis Nielsen 08aed0213c Merge pull request #9567 from Madhu-1/fix-9220
csi: add custom ceph.conf for csi pods
2022-03-01 08:19:02 -07:00
Junyoung, Sung 8c19e5b260 docs: correct ceph toolbox path
Signed-off-by: Junyoung, Sung <wnsdud1861@gmail.com>
2022-03-02 00:15:18 +09:00
Madhu Rajanna 2076a3c788 csi: add custom ceph.conf for csi pods
Currently, the admin/user can configure the ceph.conf
for daemon pods using https://rook.io/docs/rook/v1.7/
ceph-advanced-configuration.html#custom-cephconf-settings.
This the above custom ceph.conf is only for ceph pods.
the support to provide constom ceph.conf for cephcsi
is added in cephcsi PR 2476

This PR adds the support to create/update
ceph.conf for csi pods.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-03-01 12:42:59 +05:30
Travis Nielsen 2e91a819b4 Merge pull request #9814 from travisn/latest-ceph-base
build: Update ceph base image to v16.2.7-20220216
2022-02-28 14:26:39 -07:00
Travis Nielsen a98678585a build: update ceph base image to v16.2.7-20220216
The latest ceph image should be used for the base of
the rook image to pick up the latest security releases.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-02-28 11:21:49 -07:00
Travis Nielsen c8e68511ce Merge pull request #9804 from travisn/cleanup-metadata-pvcs
osd: Purge job will remove all pvcs for the osd
2022-02-28 11:08:38 -07:00
Satoru Takeuchi c2d5bab1c0 Merge pull request #9807 from travisn/osd-purge-cmd
osd: Remove osd with purge instead of destroy
2022-02-28 08:13:23 +09:00
Travis Nielsen 879bde4416 osd: remove osd with purge instead of destroy
The osd destroy command leaves the osd id in use instead
of fully purging the osd id. If the osd id is not also
removed, it gives the impression that there is still
something that needs to be cleaned up from the old osd.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-02-25 12:02:20 -07:00
Travis Nielsen ba165ec121 Merge pull request #9729 from humblec/final-fsgroup
csi: default to ReadWriteOnceWithFSType for cephfs
2022-02-25 07:44:46 -07:00
Travis Nielsen b3ca0f1b87 osd: purge job will remove all pvcs for the osd
The purge job is intended to clean up all the resources
related to an OSD that is to be removed. An OSD with
a metadata, wal, and data PVC was only cleaning up the
data PVC. Now the metadata and wal PVCs will also be
cleaned up.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-02-24 12:05:15 -07:00
Travis Nielsen 9836190bc6 Merge pull request #9799 from travisn/fail-down-fs
file: Allow filesystem removal even with failures
2022-02-24 10:15:48 -07:00
subhamkrai 3e6aa9e556 core: split external script unit test and main code in diff file
split the external script main code and unit test in different file.

Closes: https://github.com/rook/rook/issues/9588
Signed-off-by: subhamkrai <srai@redhat.com>
2022-02-24 18:23:21 +05:30
Travis Nielsen 1f8f71b396 file: allow filesystem removal even with failures
If the filesystem is in a bad state such as never being
created successfully in the first place, the filesystem
removal will continuously fail and prevent the CR from
being removed. Thus, we treat the filesystem removal
as a best effort and log the issue instead of failing
the uninstall reconcile.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-02-23 16:01:58 -07:00
Travis Nielsen bbac0911c9 Merge pull request #9790 from travisn/operator-pri-class
helm: Allow setting priority class on operator and toolbox
2022-02-23 14:34:54 -07:00
Travis Nielsen 1d1de69f3e helm: allow setting priority class on operator and toolbox
The operator and toolbox pods were not configurable for
their priority class in the helm chart. Now the settings
are exposed in the values.yaml.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-02-23 14:02:19 -07:00
Travis Nielsen a778d6737e Merge pull request #9794 from aruniiird/making-alert-timeout-and-alertdoc-timeout-same
monitoring: making alert firing timeout and the doc timeout same
2022-02-23 09:38:13 -07:00
Blaine Gardner 6596244f4e Merge pull request #9781 from BlaineEXE/fuller-ci-logging
test: collect fuller logs for CI tests
2022-02-23 08:58:38 -07:00
Arun Kumar Mohan 054d009af6 monitoring: making alert firing timeout and the doc timeout same
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2022-02-23 21:15:09 +05:30
Travis Nielsen 3d18e780fb Merge pull request #9550 from parth-gr/mds-probes
mds: Override mds startup/liveness probes from CephFilesystem CR
2022-02-23 07:46:43 -07:00
Sébastien Han 7a3bdce0b4 Merge pull request #9791 from parth-gr/vault_doc
docs: Correct VAULT_BACKEND_PATH
2022-02-23 14:05:53 +01:00
parth-gr 413662d475 core: change livenessProbe file name to probes
Added unit test for probes changes and
did re-naming of liveness probes file
as it will contain multiple types of probes

Signed-off-by: parth-gr <paarora@redhat.com>
2022-02-23 17:20:07 +05:30
parth-grandShahak Nagiel cbc9bbff32 docs: correct vault backend path
Based on my testing with the guide above,
the original value in the sample code here:
`VAULT_BACKEND_PATH: rook/ver1`
...did not work and resulted in
a Vault path error when Rook attempted
to provision the OSD filesystem.
When I simplified it to:
`VAULT_BACKEND_PATH: rook`
... then it worked.

I also took the opportunity to add
a comment/clarification about the `VAULT_ADDR` URL.

Co-authored-by: Shahak Nagiel <snagiel@yahoo.com>
Signed-off-by: parth-gr <paarora@redhat.com>
2022-02-23 11:51:29 +05:30
Blaine Gardner 7a7d278ab4 test: fix helm suite conflicting artifact
Two test jobs were collecting artifacts to the same artifact name, which
can cause race conditions and failures to upload artifacts.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-02-22 13:14:39 -07:00
Blaine Gardner 9a5d43761d test: collect fuller logs for CI tests
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-02-22 13:14:39 -07:00
Travis Nielsen b717f4d06f Merge pull request #9773 from thotz/fix-links-in-doc-ceph-multisite
docs: fix broken links in ceph-object-multisite.md
2022-02-22 10:46:43 -07:00
Jiffin Tony Thottan 1f13938bdc docs: fix broken links in ceph-object-multisite.md
The docs have links pointing /design directory in the codebase which
hidden in https://rook.io so change them to rook github repo links.

Fixes: #9768
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
2022-02-22 22:43:59 +05:30
parth-gr 2cf89b11df rgw: use ceph config probes for rgw
use the common method ConfigureStartupProbe and
ConfigureLivenes probe for rgw probes configuration

Signed-off-by: parth-gr <paarora@redhat.com>
2022-02-22 20:36:40 +05:30
parth-gr 1679af4a02 mds: override mds startup liveness probes from CephFilesystem CR
Rook code allows overriding the probes for mds from the CephCluster,
but this should really come from the CephFilesystem CR.

Closes: https://github.com/rook/rook/issues/9519

Signed-off-by: parth-gr <paarora@redhat.com>
2022-02-22 20:36:40 +05:30