Commit Graph
4823 Commits
Author SHA1 Message Date
Travis Nielsen 25fd0df893 Merge pull request #5420 from travisn/osd-node-name
OSD on PVC node assignment should be the node selector rather than nodeName
2020-05-07 12:25:04 -06:00
Travis Nielsen f1b084daa9 Merge pull request #5386 from travisn/multipath-support
Multipath support for OSD on PVC
2020-05-07 11:45:16 -06:00
Travis Nielsen 65377cbe63 ceph: osd on pvc node assignment is node selector
An OSD on a PVC when portable=false is assigned to a node
with a node selector. The same node assignment is expected
for the lifetime of the cluster. On subsequent reconciles,
the operator was looking up the node assignment from the
nodeName on the pod spec, which is not set if the pod is down.
The operator needs to retrieve the assignment from the
deployment spec node selector.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-07 10:51:46 -06:00
Sébastien Han 2e5d6c749e Merge pull request #5362 from thotz/ssl_regression_rgw
objectstore: Add ceph group to FsGroup
2020-05-07 17:18:49 +02:00
Jiffin Tony Thottan 68fc50686a objectstore: Add ceph group as FsGroup
ceph gid (167) provided as supplymentary group, so that all the mounts can
be accessed by the same. This is required for ssl certificate consumed by
the rgw server from ceph octopus onwards.

Closes: https://github.com/rook/rook/issues/5265
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2020-05-07 18:37:36 +05:30
Sébastien Han 228041902b Merge pull request #5406 from cybozu-go/ceph-cleanup-osd-on-pvc
ceph: judge whether an OSD is on PVC or not by function
2020-05-07 09:13:39 +02:00
Travis Nielsen 1e50ca374b Merge pull request #5414 from travisn/force-osd-delete-if-not-out
Delete terminating osd pods even if not out
2020-05-06 17:53:45 -06:00
Travis Nielsen 5f57b6fd3a ceph: skip ceph-volume inventory for PVs
For multipath devices, ceph-volume inventory is failing
to detect that the device is available, complaining about
insufficient space. Instead of relying on c-v inventory
to determine if the device is available, just call
c-v raw list to determine if there is already an osd
configured on the pv. Otherwise, just attempt to configure
the OSD.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-06 17:12:25 -06:00
Travis Nielsen 32730123ea ceph: add support for multipath devices
Add mpath to the list of supported device types,
although it will only work for OSDs on PVCs.
OSDs on a raw device without PVCs have not
yet been tested.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-06 17:12:25 -06:00
Travis Nielsen 3f356d6a8c Merge pull request #5413 from travisn/operator-base-14.2.9
Set v14.2.9 as base image for the operator
2020-05-06 16:25:59 -06:00
Travis Nielsen 3c6bae56b7 ceph: delete terminating osd pods even if not out
When an OSD pod is stuck in terminating state, there is no need
to check if the OSD is marked as out before force deleting.
As long as the osd is down we will force delete the pod.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-06 15:43:04 -06:00
Travis Nielsen dda2e6e0ae Merge pull request #5412 from travisn/allow-unsupported-csi-version
Allow csi driver version to be undetected if unsupported flag is set
2020-05-06 15:27:54 -06:00
Travis Nielsen b5c9d4a02f ceph: set v14.2.9 as base image for the operator
The v14.2.9 release and updated base image have security fixes
that the operator needs to pick up.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-06 12:51:37 -06:00
Travis Nielsen b375e81c37 ceph: allow csi driver version to be undetected
If ROOK_CSI_ALLOW_UNSUPPORTED_VERSION=false and the csi canary image
is set to quay.io/cephcsi/cephcsi:canary, the csi driver fails
to load as expected since it is not supported. But if the
flag is set to true, it is expected to allow the canary image
which isn't versioned. The supported version check was requiring
that the version be detected in the image.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-06 12:36:10 -06:00
Satoru Takeuchi 417ea131bc ceph: judge whether an OSD is on PVC or not by function
There are many duplicated code to judge whether an OSD is on PVC
or not. Instead, let's introduce a function for this purpose.
It can also be applied to the logic of judging whether an OSD
on PVC has metadata device or not.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2020-05-07 00:49:17 +09:00
Travis Nielsen f82a07d441 Merge pull request #5394 from Madhu-1/csi-prio
CSI: Set PriorityClassName for CSI pods
2020-05-06 07:08:54 -06:00
Madhu Rajanna ec3ab55d94 CSI: Set PriorityClassName for CSI provisioner pods
provide an option to set PriorityclassName on the
CSI provisioner pods to avoid pod eviction, as the CSI provisioner
pods a critical in system for storage. the default value
for the CSI provisioner pods is set to system-cluster-critical.

provisioner pods are less priority than plugin pods.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-05-06 15:45:06 +05:30
Madhu Rajanna cc6ec58891 CSI: Set PriorityClassName for CSI plugin pods
provide an option to set Priorityclassname on the
CSI plugin pods to avoid pod eviction, as the CSI plugin pods are
critical in system for storage. the default value
for the CSI plugin pods is set to system-node-critical.
more info can be found at
https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-05-06 15:45:01 +05:30
Sébastien Han 7589573e0b Merge pull request #5405 from travisn/operator-setting-logging
Log the operator settings and their source
2020-05-06 11:27:04 +02:00
Sébastien Han cecbfcfba6 Merge pull request #5372 from leseb/obc-independent-mode
ceph: add support for OBC on external cluster
2020-05-06 10:30:15 +02:00
Sébastien Han 511f16ca70 Merge pull request #5401 from cybozu-go/cleanup-the-integration-test-and-remove-the-description-of-a-removed-feature
Cleanup the integration test and remove the description of a removed feature
2020-05-06 10:15:22 +02:00
Sébastien Han e342f7ea30 Merge pull request #5407 from chenxuc/patch-1
doc: correct the wordings
2020-05-06 09:30:23 +02:00
Chen, Xu Chun (Simon) a39d9a969e doc: correct wordings
correct wordings so that they pass grammar checkings and better understood by non-English native readers. Thanks!

Signed-off-by: XU CHUN CHEN <chenxuc@cn.ibm.com>
2020-05-06 11:21:21 +08:00
Travis Nielsen cd806c83ee ceph: log the operator settings and their source
The operator settings can come either from the configmap, an
env var, or a default value. Knowing where the setting is loaded
from is an important detail to see in the log.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-05 13:10:01 -06:00
Travis Nielsen 2d6fefbd5f Merge pull request #5395 from Madhu-1/csi-2.1.1
CSI: Update CSI version to v2.1.1
2020-05-05 11:25:49 -06:00
Sébastien Han bfb0501c14 Merge pull request #5403 from cybozu-go/ceph-fix-a-dead-link
ceph: fix dead links
2020-05-05 18:32:01 +02:00
Satoru Takeuchi aa7145e1ca ceph: fix dead links
Fix dead links in ceph document.

Closes: https://github.com/rook/rook/issues/5396

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2020-05-06 01:24:29 +09:00
Sébastien Han 775ed9532a Merge pull request #5398 from leseb/lvm-release
ceph: do not fail on deactivate
2020-05-05 18:09:24 +02:00
Satoru Takeuchi 22c5743656 cleanup: remove the descriptions of directory-based OSD
Directory-based OSD is not supported in v1.3.0 anymore. Let's remove
the descriptions of this feature. As an exception, it should still
be in the manifests of v1.2.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2020-05-06 00:44:31 +09:00
Satoru Takeuchi 5fc69b9e49 tests: add a note to the possibility of downgrading some deb packages
We should write down that kubeadm.sh may downgrade some deb packages.
Although it's clear that this script installs some K8s related packages,
downgrading packages are not so.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2020-05-05 23:17:43 +09:00
Satoru Takeuchi c0c0dc4ed9 tests: return bool if the functions are prefixed by "Is"
There are several functions that are prefixed by "Is" and return
just error. It's straightfoward to return bool to make the meaning
of these functions clearer.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2020-05-05 22:55:01 +09:00
Sébastien Han 65aae84bdd ceph: do not fail on deactivate
If we fail to release an LVM device, we should not fail the deployment.
We just print the error and let the backend handle the rest. Some
CSI backend will force detach the device anyway.
This prevents the deployment to get stuck in terminating.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-05-05 12:03:43 +02:00
Madhu Rajanna 73c74d8a42 CSI: Update CSI version to v2.1.1
cephcsi v2.1.1 is released with fix for xfs formatting
issue. This PR updates the cephcsi image version to
v2.1.1

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-05-05 13:08:23 +05:30
Sébastien Han 350abe8603 Merge pull request #5336 from mykaul/master
Images: allow building images using Podman.
2020-05-05 09:15:25 +02:00
Sébastien Han b86bb9c528 ceph: add support for OBC on external cluster
We can now consume an external s3 endpoint which is not managed by Rook.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-05-04 18:14:26 +02:00
Sébastien Han c2079483a4 Merge pull request #5354 from HaichaoLii/mem
tests: Fix ProbeDevices function unit test failure
2020-05-04 15:58:56 +02:00
Sébastien Han 4017aa8de5 Merge pull request #5390 from leseb/rm-old-cr-rbd
ceph: remove leftover rbd mirror in cluster.yaml
2020-05-04 14:07:05 +02:00
Sébastien Han 656240831c ceph: remove leftover rbd mirror in cluster.yaml
Since the rbd mirror has been extracted to its own CR, it does not exist
in cluster.yaml anymore.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-05-04 13:55:58 +02:00
Travis Nielsen 8cdc3c103b Merge pull request #5376 from travisn/restart-osd-if-stuck
Restart portable osd pod if stuck
2020-05-01 08:39:03 -06:00
Travis Nielsen c713fd30f9 ceph: restart portable osd pod if stuck
If the OSD pod is portable and is on a failed node, the node
will be stuck indefinitely in the terminating state. The pod
can be force deleted in this scenario in order to allow the
underlying volume to be detached and then mounted on another
node.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-04-30 09:52:54 -06:00
Sébastien Han 1ea73ce123 Merge pull request #5364 from Madhu-1/err-cleaup
cleanup: use err.Wrap when the formatting is not required
2020-04-30 15:57:27 +02:00
Dmitry Yusupov 6e5a6c4542 Merge pull request #5370 from dyusupov/master
edgefs: raw disk empty check regression fix
2020-04-29 14:10:16 -07:00
Dmitry Yusupov e88704120b edgefs: raw disk empty check regression fix
Signed-off-by: Dmitry Yusupov <dmitry.yusupov@nexenta.com>
2020-04-29 11:48:09 -07:00
Dmitry Yusupov 9b6c1ede66 Merge pull request #5360 from dyusupov/master
edgefs: provide a way to configure ADS
2020-04-29 09:27:56 -07:00
Travis Nielsen f8e884d2ce Merge pull request #5287 from Madhu-1/resource-limit-csi
CSI: Add resource request and limit for CSI pods
2020-04-29 08:09:19 -06:00
Madhu Rajanna 81688398f2 cleanup: use err.Wrap when the formatting is not required
Replaced err.Wrapf with err.Wrap when the formatting
is not required.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-04-29 17:42:59 +05:30
Sébastien Han f90b14f9dc Merge pull request #5349 from jbw976/new-email-lists
docs: update rook mailing lists to new lists.cncf.io addresses
2020-04-29 08:54:11 +02:00
Madhu Rajanna 4065217913 CSI: use warning if the formatting is not required
If the formatting is not required use warning
instead of warningf

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-04-29 10:26:56 +05:30
Madhu Rajanna 4495d1fffd CSI: Add helm documentation for CSI resource
Updated helm documentation for CSI resources
which will be applied for CSI sidecar and plugin
containers.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-04-29 10:26:56 +05:30
Madhu Rajanna a3823c9467 CSI: Add helm template changes for CSI resource
Added template changes in helm chart for the
CSI resource. All resources limits will not
be applied default.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-04-29 10:26:56 +05:30