Commit Graph
12659 Commits
Author SHA1 Message Date
Blaine Gardner 2fd9c9a88c core: finalize CephCluster CephX status handling
Cleanup up overall usage of CephX statuses in CephCluster.

Convert all CephX statuses to non-pointer types. There is no specific
need for pointer types, and keeping these as non-pointers means there is
not a risk of nil pointer exceptions in all the various Rook controllers
for upgraded clusters.

Move initialization of CephCluster CephX status items to
`preMonStartupActions()`. This helps resolve 2 issues:

1. 'Uninitialized' state was being set for external CephClusters where
   CephX statuses are not relevant.
2. 'Uninitialized' state was being set for upgraded clusters whose key
   status cannot be determined.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2025-08-18 14:53:08 -06:00
Travis Nielsen 7e92d2fb03 Merge pull request #16311 from travisn/csi-op-scc
security: Configure sccs for the ceph-csi operator
2025-08-18 08:22:08 -06:00
Travis Nielsen c23754fc11 Merge pull request #16329 from degorenko/fix-pool-remove
pool: fix cephblockpool remove when related pool is already removed
2025-08-15 13:45:34 -06:00
Denis Egorenko c9e0f89a8b pool: fix cephblockpool remove when related pool is already removed from cluster
When removeing CephBlockPool check first that related ceph pool is exist in cluster,
since it may be manually removed by mistake.

Related-Issue: #16328
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
2025-08-15 22:59:34 +04:00
Travis Nielsen 36a47ac01a Merge pull request #16176 from sp98/mon-key-rotation
mon: rotate cephx key
2025-08-15 11:06:31 -06:00
Blaine Gardner 95c5cb0d94 Merge pull request #16070 from Madhu-1/client-name-override
core: option to override the ceph user name in cephClient CR
2025-08-15 10:54:11 -06:00
Madhu Rajanna a71cc27b72 core: implement client name override
There is a field in the CR spec to override
the name and the feature was not implement,
This commits adds the support to override the
cephclient name if ever required.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-08-15 09:50:32 -06:00
Madhu Rajanna 36c84aa43c core: skip Name validation
the CR cannot be created without a Name,
Removing the check as it never gets executed.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-08-15 09:42:16 -06:00
Travis Nielsen 892d43c3e8 Merge pull request #16306 from rook/dependabot/go_modules/github-dependencies-84ee9e4cad
build(deps): bump the github-dependencies group across 1 directory with 8 updates
2025-08-14 14:14:41 -06:00
Travis Nielsen d6b91b9409 Merge pull request #16275 from anshuman-agarwala/secret-removal
operator: Removed legacy secret deletion code in rbd
2025-08-14 14:06:34 -06:00
dependabot[bot] 6a75d578e7 build(deps): bump the github-dependencies group across 1 directory with 8 updates
Bumps the github-dependencies group with 7 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) | `1.55.7` | `1.55.8` |
| [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.30.0` | `1.31.0` |
| [github.com/aws/aws-sdk-go-v2/service/sns](https://github.com/aws/aws-sdk-go-v2) | `1.35.0` | `1.37.0` |
| [github.com/ceph/go-ceph](https://github.com/ceph/go-ceph) | `0.34.0` | `0.35.0` |
| [github.com/csi-addons/kubernetes-csi-addons](https://github.com/csi-addons/kubernetes-csi-addons) | `0.12.0` | `0.13.0` |
| [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator) | `0.84.0` | `0.84.1` |
| [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator) | `0.84.0` | `0.84.1` |

Updates `github.com/aws/aws-sdk-go` from 1.55.7 to 1.55.8
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG_PENDING.md)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.55.7...v1.55.8)

Updates `github.com/aws/aws-sdk-go-v2/config` from 1.30.0 to 1.31.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/v1.30.0...v1.31.0)

Updates `github.com/aws/aws-sdk-go-v2/credentials` from 1.18.0 to 1.18.4
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/config/v1.18.4/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/v1.18.0...config/v1.18.4)

Updates `github.com/aws/aws-sdk-go-v2/service/sns` from 1.35.0 to 1.37.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/v1.35.0...v1.37.0)

Updates `github.com/ceph/go-ceph` from 0.34.0 to 0.35.0
- [Release notes](https://github.com/ceph/go-ceph/releases)
- [Changelog](https://github.com/ceph/go-ceph/blob/master/docs/release-process.md)
- [Commits](https://github.com/ceph/go-ceph/compare/v0.34.0...v0.35.0)

Updates `github.com/csi-addons/kubernetes-csi-addons` from 0.12.0 to 0.13.0
- [Release notes](https://github.com/csi-addons/kubernetes-csi-addons/releases)
- [Changelog](https://github.com/csi-addons/kubernetes-csi-addons/blob/main/PendingReleaseNotes.md)
- [Commits](https://github.com/csi-addons/kubernetes-csi-addons/compare/v0.12.0...v0.13.0)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.84.0 to 0.84.1
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.84.0...v0.84.1)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.84.0 to 0.84.1
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.84.0...v0.84.1)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-version: 1.55.8
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-version: 1.31.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/credentials
  dependency-version: 1.18.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/sns
  dependency-version: 1.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/ceph/go-ceph
  dependency-version: 0.35.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/csi-addons/kubernetes-csi-addons
  dependency-version: 0.13.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring
  dependency-version: 0.84.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client
  dependency-version: 0.84.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-14 13:27:45 -06:00
Travis Nielsen cb6da09a44 security: configure sccs for the csi operator
The CSI operator requires the SecurityContextConstraints to
be configured for the service accounts that have a different
name from the previous CSI driver, both via the manifest install
and the helm install.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2025-08-14 13:20:37 -06:00
Travis Nielsen db8ca2f64f Merge pull request #16043 from subhamkrai/csi-op-helm-support
helm: add helm support for new ceph-csi-operator
2025-08-14 10:00:49 -06:00
Travis Nielsen 0e7dd95078 Merge pull request #16312 from jacksgt/jack-fix-syntax-in-docs
docs: minor syntax fixes for CephCluster CRD documentation
2025-08-14 08:24:04 -06:00
Santosh Pillai 5df485cbb3 Merge pull request #16293 from degorenko/fix-cleanup-job
operator: mount udev to cleanup job and disable udev sync
2025-08-14 18:39:24 +05:30
Jack Henschel d8651f33ea docs: minor syntax fixes for CephCluster CRD documentation
Signed-off-by: Jack Henschel <jhensche@redhat.com>
2025-08-14 11:37:09 +02:00
subhamkrai ee6f2e654a helm: add helm support for new csi-operator
This commit test csi-operator helm chart as a dependencies with rook-ceph operator helm chart.
With these changes csi-operator will be installed as a part of rook-ceph operator helm chart.

Signed-off-by: subhamkrai <srai@redhat.com>
2025-08-14 13:18:13 +05:30
Santosh Pillai fe42fe102f mon: rotate keys
rotate mon daemon keys and update the cephx status for mons in the
cephcluster resource.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2025-08-14 11:16:39 +05:30
Travis Nielsen 4799fb8ac2 Merge pull request #16309 from OdedViner/remove-panic-handler
csi: remove inline panic handler from CreateDefaultClientProfile
2025-08-13 10:28:03 -06:00
Oded Viner 7f0be04773 csi: remove inline panic handler from CreateDefaultClientProfile
remove inline defer that catches and logs panics since it is already handled by pr#16150

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-08-13 19:01:32 +03:00
Travis Nielsen 47d01f8812 Merge pull request #16304 from Madhu-1/update-csi-op-0.4.0
csi: update the csi-operator API
2025-08-13 09:07:12 -06:00
Travis Nielsen 1deec3a396 Merge pull request #16290 from parth-gr/fix-mirror-status
rbdmirror: fix status check for rbd rn mirroring
2025-08-13 08:15:39 -06:00
Travis Nielsen 4afd43093d Merge pull request #16296 from OdedViner/skip_lint_aws_sdk_v1
core: skip staticcheck sa1019 for aws-sdk-go v1 deprecation
2025-08-13 07:41:28 -06:00
Oded Viner 209b084161 core: skip staticcheck sa1019 for aws-sdk-go v1 deprecation
update .golangci.yaml to exclude staticcheck sa1019 warnings for
aws-sdk-go v1 until migration to v2 is completed

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-08-13 11:38:43 +03:00
parth-gr 11b3d7e16e rbdmirror: fix status check for rbd rn mirroring
if the blockpool mirroring is disabled and status check
is not removed, currently rn cr still watches for the status

Add a check if the pool or rados mirroring is disabled then dont
watch for status

Signed-off-by: parth-gr <partharora1010@gmail.com>
2025-08-13 13:33:05 +05:30
Madhu Rajanna 3d024ce3c7 csi: update the csi-operator API
updating the csi operator API version
to latest version.

Adding the cephFS and RBD controllerPublish
secret that are required for the fencing
operation that is supported by ceph-csi
with csi-operator.

Updated the storageclass to include the
secrets incase if user wants to override
the defaults in the clientProfile for
new PVC's.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-08-13 09:30:50 +02:00
Denis Egorenko 09622a8b8d operator: mount udev to cleanup job and disable udev sync
Mount /run/udev inside cluster cleanup jobs and disable udev sync
with DM_DISABLE_UDEV.

Related-Issue: rook#16292
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
2025-08-12 22:46:27 +04:00
Travis Nielsen ce92d9cb33 Merge pull request #16295 from subhamkrai/update-csi-op-deployment
csi: update csi-operator yaml to version v0.4.0
2025-08-12 11:33:13 -06:00
Travis Nielsen 3ea967df70 Merge pull request #16294 from nixpanic/csi-addons/v0.13.0
csi: update Kubernetes CSI-Addons sidecar to version 0.13.0
2025-08-12 11:26:27 -06:00
Travis Nielsen 9f67ee1e20 Merge pull request #16289 from Madhu-1/fix-rbd-user
external: user userID and userKey for rbd
2025-08-12 11:25:15 -06:00
subhamkrai 850ef60a31 csi: update csi-operator yaml to version v0.4.0
this yaml contains all the rbac, crds and csi-operator
deployment all-in-one.

Signed-off-by: subhamkrai <srai@redhat.com>
2025-08-12 22:30:46 +05:30
subham rai c94f490997 Merge pull request #16288 from Madhu-1/fix-16175
csi: update cephfs user and key in secret
2025-08-12 21:34:35 +05:30
Niels de Vos 17d53ed16b csi: update Kubernetes CSI-Addons sidecar to version 0.13.0
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2025-08-12 17:56:37 +02:00
subham rai 70f465745b Merge pull request #16272 from Madhu-1/fix-filepath
core: use filepath.Join instead of path.Json and add unit testing for cleanup functions
2025-08-12 14:59:40 +05:30
Madhu Rajanna db44ef3645 external: user userID and userKey for rbd
csi never used adminID and adminKey for the
rbd secrets, This currently looks to be a
bug where we are creating the secret with userID
and userKey but updating it with adminID and
adminKey, This commits update the script to
use userID and userKey for RBD secrets.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-08-12 09:55:35 +02:00
Madhu Rajanna cb89f351ed csi: update cephfs user and key in secret
cephCSI already deprecated the adminID and
adminKey keys in the secrets and to be backward
compatible it still supports the adminID and
adminKey but it logs the warning, updating the
secrets created by Rook to use userID and userKey
instead of adminID and adminKey.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-08-12 09:53:55 +02:00
Travis Nielsen 6fc530b77f Merge pull request #16284 from rook/dependabot/github_actions/github/codeql-action-3.29.8
build(deps): bump github/codeql-action from 3.29.7 to 3.29.8
2025-08-11 10:59:56 -07:00
Travis Nielsen b01fbc4f5d Merge pull request #16283 from rook/dependabot/github_actions/actions/checkout-5.0.0
build(deps): bump actions/checkout from 4.2.2 to 5.0.0
2025-08-11 10:59:00 -07:00
Travis Nielsen 02f1735754 Merge pull request #16282 from rook/dependabot/github_actions/aws-actions/configure-aws-credentials-4.3.1
build(deps): bump aws-actions/configure-aws-credentials from 4.2.1 to 4.3.1
2025-08-11 10:58:10 -07:00
dependabot[bot] c5c0bfdfb7 build(deps): bump github/codeql-action from 3.29.7 to 3.29.8
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.7 to 3.29.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/51f77329afa6477de8c49fc9c7046c15b9a4e79d...76621b61decf072c1cee8dd1ce2d2a82d33c17ed)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.8
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-11 17:51:39 +00:00
dependabot[bot] b3b61a05a4 build(deps): bump actions/checkout from 4.2.2 to 5.0.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 5.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/11bd71901bbe5b1630ceea73d27597364c9af683...08c6903cd8c0fde910a37f88322edcfb5dd907a8)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-11 17:19:30 +00:00
dependabot[bot] bcb7e750df build(deps): bump aws-actions/configure-aws-credentials
Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 4.2.1 to 4.3.1.
- [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases)
- [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md)
- [Commits](https://github.com/aws-actions/configure-aws-credentials/compare/b47578312673ae6fa5b5096b330d9fbac3d116df...7474bc4690e29a8392af63c5b98e7449536d5c3a)

---
updated-dependencies:
- dependency-name: aws-actions/configure-aws-credentials
  dependency-version: 4.3.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-11 17:06:09 +00:00
Blaine Gardner 59ca78229d Merge pull request #16075 from sp98/mirror-key-rotation
rbd mirror peer key rotation
2025-08-11 10:54:20 -06:00
Santosh Pillai ee0b137d75 core: rotate rbd mirror peer key
rotate the client.rbd-mirror-peer key based on the cephxconfig.
Also update the cephxStatus in the cephcluster as well as the
mirrored cephblockpool.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2025-08-11 21:53:14 +05:30
subham rai 6d943f52b5 Merge pull request #16277 from Madhu-1/fix-csi-op
csi: use cluster namespace for cephConn
2025-08-11 12:41:14 +05:30
Madhu Rajanna 1ff3f07ac5 csi: use cluster namespace for cephConn
CephConnection CR is created with the
kubernetes namespace name as its the
unique name in the entire cluster.
This PR removes unwanted input
parameters and adjust the namespace
name for the cephConnection CR.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-08-11 07:38:27 +02:00
Anshuman 79b24564ef operator: removed legacy secret deletion code in rbd
Signed-off-by: Anshuman <anshuman@ibm.com>
2025-08-08 21:56:06 +05:30
Blaine Gardner 517f519c23 Merge pull request #16227 from sp98/mirror-daemon-key-rotation
core: rotate mirror daemon keys
2025-08-08 09:45:48 -06:00
Travis Nielsen f0a1df3ca0 Merge pull request #16269 from travisn/cephconnection-name
csi: Create cephconnection CR with name of the cluster namespace
2025-08-08 09:07:17 -06:00
Madhu Rajanna 878603ba25 core: add unit testing for cleanup
Adding unit testing for cleanup
functions.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-08-08 12:55:23 +02:00