Commit Graph
10092 Commits
Author SHA1 Message Date
travisn 31cc2c554e tests: toolbox uses same ceph image as the test
The test is currently only using the ceph version that is
included with toolbox.yaml, which may be different
from the version of the ceph cluster being tested.
Now the version will be replaced to match the desired
ceph test version.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 600068ea21)
2023-07-31 21:07:10 +00:00
travisn dd79c1f78d ci: allow commit prefixes for doc and tests
Allow for doc(s) and test(s) commit prefixes to be either
singular or plural. This is always a confusing point when
adding the commit prefix, so let's just allow both.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 3d7924dc22)
2023-07-31 21:07:09 +00:00
Travis Nielsen fdbf4a4ccd Merge pull request #12628 from rook/mergify/bp/release-1.12/pr-12534
external: added an optional flag for enabling v2 mon port (backport #12534)
2023-07-31 15:07:07 -06:00
Travis Nielsen d10988da2a Merge pull request #12629 from rook/mergify/bp/release-1.12/pr-12537
external: set RequireMsgr2 if v2 port is configured (backport #12537)
2023-07-31 15:06:55 -06:00
parth-gr d237dff985 external: set RequireMsgr2 if v2 port is configured
Currently if we use the msgr2 port,
cs-cluster-config-json looks like
"monitors":["192.59.109.11:3300","192.59.109.13:6789","192.59.109.12:6789"]

The first monitor is passed by python script and rest are
Discovered by rook operator, so if the first mon is using the v2 port
lets update the other mons also by setting up the RequireMsgr2 flag

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 2c4897f88c)
2023-07-31 19:21:43 +00:00
Nikhil-Ladha e2c92d16ce external: added an optional flag for enabling v2 mon port
Added a new flag `--v2-port-enable` to enable the v2 mon port.

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
(cherry picked from commit 5daddbe379)
2023-07-31 19:20:56 +00:00
Blaine Gardner d1dccf5b19 Merge pull request #12620 from rook/mergify/bp/release-1.12/pr-12611
multus: revise kube config/client loading (backport #12611)
2023-07-28 12:10:25 -06:00
Blaine Gardner 15f3146cab multus: revise kube config/client loading
The previous client loader routine assumed KUBECONFIG would be set in
CLI environments. Instead, now take this approach:

1. If KUBECONFIG is set, that is the de-facto override that informs the
   tool it is being run in a CLI environment.
2. Otherwise, try creating a client from the default kube config file.
3. If that fails, assume the tool is running in a Kubernetes Pod.

This will continue supporting dev/test environments so that building the
rook container is not necessary for development. It also allows support
for highly opinionated environments (like deployed by OpenShift CSVs)
where it's not possible to install the Rook operator without also
deploying a CephCluster.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit cc9514ad6c)
2023-07-28 17:26:24 +00:00
Blaine Gardner 15f69f7347 Merge pull request #12619 from rook/mergify/bp/release-1.12/pr-12617
nfs: fix null pointer deref in generateSssdSidecarResources() (backport #12617)
2023-07-28 09:47:28 -06:00
Sachin Prabhu 22b4e5d7ea nfs: fix null pointer deref in generateSssdSidecarResources()
0a151e913 results in a bug which causes null pointer dereference when
Kerberos is not setup. This causes a failure in Unit test
TestReconcileCephNFS_addSecurityConfigsToPod

Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
(cherry picked from commit 6cf4627ccd)
2023-07-28 13:57:55 +00:00
Travis Nielsen fe35e61aed Merge pull request #12554 from rook/mergify/bp/release-1.12/pr-12508
external: create ceph cluster namespace (backport #12508)
2023-07-27 12:47:29 -06:00
Travis Nielsen 3660846467 Merge pull request #12586 from rook/mergify/bp/release-1.12/pr-12572
build(deps): bump wagoid/commitlint-github-action from 5.4.1 to 5.4.3 (backport #12572)
2023-07-27 12:47:03 -06:00
Travis Nielsen b3c3cfe389 Merge pull request #12587 from rook/mergify/bp/release-1.12/pr-12562
object: update ceph cosi driver image to v0.1.1 (backport #12562)
2023-07-27 12:46:48 -06:00
Blaine Gardner d81e8e6a12 Merge pull request #12590 from rook/mergify/bp/release-1.12/pr-12560
object: do not add objectstore endpoint to zone when sync is disabled (backport #12560)
2023-07-27 11:54:27 -06:00
Blaine Gardner 4bc21d2267 Merge pull request #12606 from rook/mergify/bp/release-1.12/pr-12517
nfs: mount krb5.conf and krb5.keytab in the sssd container (backport #12517)
2023-07-27 09:06:32 -06:00
Sachin Prabhu b63ac550d2 nfs: mount krb5.conf and krb5.keytab in the sssd container
This will enable us to use GSSAPI in sssd for authentication when
connecting to the remote LDAP server.

Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
(cherry picked from commit 0a151e913d)
2023-07-26 22:53:11 +00:00
Blaine Gardner d81d21367b Merge pull request #12588 from rook/mergify/bp/release-1.12/pr-12575
core: force delete rook-ceph-exporter pod (backport #12575)
2023-07-26 16:45:22 -06:00
Blaine Gardner 7d75997d93 Merge pull request #12604 from rook/mergify/bp/release-1.12/pr-12563
rbd: node fencing, skip pv when pv is not backed by csi (backport #12563)
2023-07-26 16:44:56 -06:00
Alexander Trost a6bab103c3 Merge pull request #12601 from rook/mergify/bp/release-1.12/pr-12564 2023-07-26 22:31:51 +02:00
subhamkrai 98f51c2514 core: node fencing, skip pv when pv is not backed by csi
when node fencing is triggered and a negative case where
one deployment pod consuming pv not provisioned by csi
and another deployment pod with rbd rwo are on the same
node and node fencing is triggered.

In this case rook operator panics since it is trigger to get
field `pv.Spec.CSI.Driver` which will be nil.

Also, skip static pv as there is no `imageName` in the spec
rbd status command will fail.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 72386eb1d0)
2023-07-26 16:45:01 +00:00
Blaine Gardner 910eca098d Merge pull request #12589 from rook/mergify/bp/release-1.12/pr-12466
osd: configure backend store (backport #12466)
2023-07-26 10:04:42 -06:00
Blaine Gardner 690338aa1e Merge pull request #12602 from rook/mergify/bp/release-1.12/pr-12578
test: fix upgrade suite for 1.27.x version (backport #12578)
2023-07-26 09:49:05 -06:00
subhamkrai 2c5672ab65 test: fix upgrade suite for 1.27.x version
the upgrade suite for version 1.27.x is failing
due
```
debug 2023-07-24T19:11:20.264+0000 7f3395a82c80 -1 error: monitor data filesystem reached concerning levels of available storage space (available: 5% 4.4 GiB)
you may adjust 'mon data avail crit' to a lower value to make this go away (default: 5%)
```
so adding mon setting to start on `compact` also adding
other setting present in cluster-test.yaml.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit e8e8a4673a)
2023-07-26 15:48:23 +00:00
subhamkrai 73fed34bfb test: collect kube-system logs for debugging
added kube-system namespace also to collect
logs from to debug the smoke suite issue

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 0ed91458dc)
2023-07-26 15:02:45 +00:00
Alexander Trost 7d5cfea91d Merge pull request #12594 from rook/mergify/bp/release-1.12/pr-12592 2023-07-26 16:15:29 +02:00
subhamkrai ec76ca6b87 build: cosi driver is missing from olm list
adding cosi driver list in olm list as it is
being missed in csv crd list generated by
other project.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 884a5c1c18)
2023-07-26 11:02:10 +00:00
Blaine Gardner a0413e3233 Merge pull request #12584 from rook/mergify/bp/release-1.12/pr-12579
ci: add detached mode in tmate (backport #12579)
2023-07-25 15:43:16 -06:00
Lucas Henry 719a8cdb50 object: do not add objectstore endpoint to zone when sync is disabled
Gateways that do not run the sync threads should not be accessible from one of
the Zone endpoint. If this is the case, the synchronization might stop working.

When the CephObjectStore has the option
`spec.gateway.disableMultisiteSyncTraffic` set to `true`, we must ensure that
the objectstore endpoint is not present in the Zone endpoint.

Signed-off-by: Lucas Henry <polyedre@disroot.org>
(cherry picked from commit 564afef4c7)
2023-07-25 21:32:28 +00:00
sp98 5d51214ad5 osd: configure backend store
Configure osd backend store from the cephCluster spec

Signed-off-by: sp98 <sapillai@redhat.com>
(cherry picked from commit c13d34f8d3)
2023-07-25 21:21:20 +00:00
sp98 4c95a180ec core: force delete rook-ceph-exporter pod
Force delete rook-ceph-exporter pod that is stuck in terminating
state due to unavailability of node.

Signed-off-by: sp98 <sapillai@redhat.com>
(cherry picked from commit dd90ef5db2)
2023-07-25 21:18:33 +00:00
Jiffin Tony Thottan 049f03e684 object: update ceph cosi driver image to v0.1.1
Update the ceph cosi driver image to v0.1.1, so that it can
work on both amd and arm platforms.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
(cherry picked from commit 1bf33f125e)
2023-07-25 20:55:39 +00:00
dependabot[bot] e8df41fe3e build(deps): bump wagoid/commitlint-github-action from 5.4.1 to 5.4.3
Bumps [wagoid/commitlint-github-action](https://github.com/wagoid/commitlint-github-action) from 5.4.1 to 5.4.3.
- [Changelog](https://github.com/wagoid/commitlint-github-action/blob/master/CHANGELOG.md)
- [Commits](https://github.com/wagoid/commitlint-github-action/compare/v5.4.1...v5.4.3)

---
updated-dependencies:
- dependency-name: wagoid/commitlint-github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit d5f5f0b64e)
2023-07-25 20:51:32 +00:00
subhamkrai 1d34907cf5 ci: add detached mode in tmate
with detached mode, we don't need to wait for the
tests to complete. Now, we can get inside tmate before
the tests start and we can monitor the tests.

By default, this mode will wait at the end of the job for
a user to connect and then to terminate the tmate session.
If no user has connected within 10 minutes after the post-job step started,
it will terminate the tmate session and quit gracefully.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit f171e1c037)
2023-07-25 20:47:47 +00:00
Blaine Gardner e417b4b1a1 Merge pull request #12582 from rook/mergify/bp/release-1.12/pr-12574
doc: update the external doc format (backport #12574)
2023-07-25 14:46:02 -06:00
parth-gr 581e089215 docs: update the external doc format
Cephobjectstore is not formated correctly
https://rook.io/docs/rook/v1.12/CRDs/Cluster/external-cluster/#connect-to-an-external-object-store

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 8a445ef0cb)
2023-07-25 16:19:30 +00:00
parth-gr c50dfb1053 external: create ceph cluster namespace
We need to create the namespace with the import script,
As per the documentation

The import script creates the secrets and
cm which is later used by the operator for cluster creation.

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit f9f880e528)
2023-07-18 22:46:10 +00:00
Travis Nielsen a4dc1b7265 Merge pull request #12551 from travisn/release-1.12.0
build: Update the release version to v1.12.0
v1.12.0
2023-07-18 16:10:49 -06:00
Travis Nielsen 40f70dd8b5 Merge pull request #12550 from rook/mergify/bp/release-1.12/pr-12548
cosi: The COSI driver should be disabled by default (backport #12548)
2023-07-18 16:08:49 -06:00
travisn e511e7ce83 build: update the release version to v1.12.0
For the minor release update the docs and example manifests
to v1.12.0.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-07-18 15:35:55 -06:00
travisn f1afd25624 cosi: handle deletion of the cosi driver
The controller was attempting to delete the cosi driver
again and again, always failing the reconcile when the
driver did not exist. Since the desired state is for the
driver not to exist when disabled, return a successful
reconcile.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 4c98669148)
2023-07-18 21:31:19 +00:00
travisn 1119da1409 cosi: document enabling the cosi driver
Add steps for enabling the cosi driver that is disabled
by default. Also add an introduction to the COSI driver
and a section for prerequisites.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 4145ecec37)
2023-07-18 21:31:19 +00:00
travisn 6e39f35741 cosi: change the default deployment strategy to never
While experimental, the cosi driver should not be enabled by
default.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 990cb40043)
2023-07-18 21:31:19 +00:00
Travis Nielsen d5b6405bdb Merge pull request #12546 from rook/mergify/bp/release-1.12/pr-12544
cosi: Correct capitalization for auto policy (backport #12544)
2023-07-18 14:40:05 -06:00
Travis Nielsen 102f99407d Merge pull request #12542 from rook/mergify/bp/release-1.12/pr-12460
object: align spelling of user admin capabilities with ceph (backport #12460)
2023-07-18 14:39:27 -06:00
travisn 5dc023b512 cosi: correct capitalization for auto policy
The CephCOSIDriver deploymentStrategy requires Auto, Never,
or Always. Change the example to Auto.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 182211d26c)
2023-07-18 20:06:11 +00:00
Peter Goron 21007c1cbe object: align spelling of user admin capabilities with ceph
users & buckets admin capabilities aren't spelled the same
way between rook crd (singular) and ceph (plural). It's a bit
misleading when comparing ceph admin cap and rook users.

Signed-off-by: Peter Goron <peter.goron@gmail.com>
(cherry picked from commit 40eed236cf)
2023-07-18 19:23:56 +00:00
Travis Nielsen 1d5a3a27d9 Merge pull request #12539 from rook/mergify/bp/release-1.12/pr-12502
external: support custom ceph keyring file (backport #12502)
2023-07-18 13:21:02 -06:00
Travis Nielsen 96fa6daf4a Merge pull request #12540 from rook/mergify/bp/release-1.12/pr-12415
object: adding ceph cosi driver (backport #12415)
2023-07-18 13:20:43 -06:00
Jiffin Tony Thottan ce716d538c object: intial cosi driver controller design
Adding CephCOSIDriver CRD and controller. The controller will bring up
the ceph cosi driver when first object store is created in the rook
operator namespace. Then admin can defined COSI CRDs like BucketClass
and BucketAccessClass for different object stores deployed via Rook.
Using the BucketClass and BucketAccessClass, user can define
BucketAccess for backend bucket in the RGW. The CephCOSIDriver CRD
defines configuration options for ceph cosi driver. In the first version
its usability is minimal. Even if it is not defined Rook will bring up
the ceph cosi driver with default values.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
(cherry picked from commit b48dc8a335)
2023-07-18 18:12:53 +00:00
Angelos Kolaitis 5d76723686 external: support custom ceph keyring file
When the ceph.conf is not in a well-known location, it is typical
for a custom ceph.keyring to be required as well. Currently, the
create-external-cluster-resources.py only tries to load the keyring
from well-known paths, and fails.

This commit adds a new optional argument `--keyring` to help in this
situation. When specified, create-external-cluster-resources.py will
attempt to use this as the keyring to authenticate with Ceph.

Signed-off-by: Angelos Kolaitis <neoaggelos@gmail.com>
(cherry picked from commit c021256e96)
2023-07-18 17:20:12 +00:00