otherwise it will fail with the following message:
```
The CephCluster "rook-ceph" is invalid:
* metadata.finalizers: Invalid value: "": name part must be non-empty
* metadata.finalizers: Invalid value: "": name part must consist of alphanumeric characters, '-',
'_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name',
or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]')
* metadata.finalizers: Forbidden: no new finalizers can be added if the object is being deleted,
found new finalizers []string{""}
```
Signed-off-by: Andrey Arapov <andrey.arapov@nixaid.com>
Long ago the gateway type for s3 was removed from the object
store CRD, and k8s 1.25 is now complaining about the obsolete
setting still included in the test.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
K8s 1.25 is not capable of creating PSPs, so we need to pick
up v1.9.10 as the base for the upgrade test before upgrading
to master.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
The rbd mirror daemon logs to two files, one for the
lodal mirror daemon and one log from the other cluster
where the mirroring is taking place. The log rotation
was only rotating one of the logs. Now we make the
log rotation more general to catch all of the rbd mirror
logs from different clusters.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
v1beta1 cron jobs have not been created by rook since k8s 1.21
and now are fully removed in 1.25. As long as we still support
older than 1.21 we still need to attempt to delete the v1beta1
cron jobs in case they had been created before an upgrade.
If the deletion fails, now we just log a debug statement since
it is a normal condition, and continue with the v1 cron job
creation.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Due to an oversight, PSP resources were left in generation of
common.yaml from #10797. Resolve that by setting
pspEnable=false when generating common.yaml.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
With the pending release of 1.10, the upgrade tests
in master should be testing the upgrade from 1.9
to the master branch.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
these indenation where added by vscode extentions.
for yaml I have extention ` YAML` by Red Hat
for bash I have `shell-format` and `shellCheck`.
Signed-off-by: subhamkrai <srai@redhat.com>
Nested list items need to be intended 3 spaces in order for markdown to
consistently handle nested lists.
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
Most of the users starts with single site, provide the steps to convert
existing cephobjectstore into multisite configurations.
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Setting the min version to 3.7 will make upgrade
difficult. If someone is using any different/custom
version, this means they won't be able to upgrade to
rook v1.10 unless they also update their csi image
at the same time. If we set the min version to 3.6,
it will give some time buffer to allow them to
change the csi driver later.
ref: https://github.com/rook/rook/pull/10759#discussion_r953014295
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Mon failover reliability is improved in two scenarios with these changes.
First, if the failover is aborted because of failing to start the new mon
and wait for it to join quorum, the new mon will be fully removed and
the failover rolled back. Previously, the operator would leave the new
mon pod running even if it never joined quorum. Now the timeout for the failover
is increased to wait longer for the new mon, but if it times out, there
are no leftovers from the cancelled failover.
Second, if the operator is failed in the middle of a failover
before the old mon is removed, the operator needs to remove an extra
mon. The operator was only selecting a random mon for removal instead
of honoring the stretch cluster topology or looking for mons
on the same node that could be removed to restore the correct
desired number of mons.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
With the beta release of v1.10 the release version in the examples
and docs is updated.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit bbbd709af9)
It's been a while we have the krew plugin capability for
troubleshooting that makes it easier but not added to rook
docs.
So adding it to rook docs and bug template
Closes: https://github.com/rook/rook/issues/10765
Signed-off-by: parth-gr <paarora@redhat.com>
One can now use the operator configmap for CSI_CLUSTER_NAME variable
for setting ClusterName on the RBD images and CephFS subvolume.
This will be useful in cases like for example, when two container orchestrator
clusters (Kubernetes/OCP) are using a single ceph cluster.
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
One can now tweak the operator configmap for CSI_ENABLE_METADATA boolean to
enable/disable setting of PV/PVC/PVCNamespace &
snapshot-name/snapshot-namespace/snapshotcontent-name on the RBD images
and CephFS subvolume.
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
As cephcsi v3.7.0 is released updating
CephCSI to v3.7.0 in Rook and defaulting
the minimum version to v3.7.0
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
The documentation previously did not cover how to use the CephClient
CRD in a realistic use case. This commit improves the documentation
on the general usage and also specificallyw with libcephsqlite.
Closes: https://github.com/rook/rook/issues/10689
Signed-off-by: vados <vados@vadosware.io>
Travis Nielsen
Andrey Arapov
Alexander Trost
subhamkrai
Blaine Gardner
Joshua Hoblitt
parth-gr
Satoru Takeuchi
Jiffin Tony Thottan
Madhu Rajanna
Prasanna Kumar Kalever
vados