Commit Graph
12443 Commits
Author SHA1 Message Date
parth-gr 350129fb42 pool: fix pool status check in rn controller
if the pool is just created and getting the status updated
rn controller can still go and proceed to check the pool status
which result in panic
and later it stop re-trying because of panic get swallowed
https://github.com/rook/rook/commit/cf13deee6f0aaa1ff854d57493bf91df70f8f436

Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit ec242d5ee7)
2025-11-12 06:22:26 +00:00
mergify[bot] a2b9854a1c Merge pull request #16686 from rook/mergify/bp/release-1.17/pr-16672
object: fix user quotas being overwritten when obc bucketOwner is set (backport #16672)
2025-11-07 19:22:24 +00:00
Joshua Hoblitt af624fce38 object: fix user quotas being overwritten when obc bucketOwner is set
Resolves https://github.com/rook/rook/issues/16417

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 61cbe4fc23)
2025-11-07 18:47:08 +00:00
Travis Nielsen 3601bb97cf Merge pull request #16634 from rook/mergify/bp/release-1.17/pr-16619
mon: wait for the canary pods to be terminated (backport #16619)
2025-10-23 16:04:45 -06:00
mergify[bot] 828e8ebfa0 Merge pull request #16633 from rook/mergify/bp/release-1.17/pr-16629
mon: Trap the sigterm to respond quickly to the mon canary pod deletion (backport #16629)
2025-10-23 17:19:19 +00:00
Santosh Pillai 82ca7ab146 mon: wait for the canary pods to be terminated
Wait for the mon-canary pods to be terminated before starting the actual
mons. When topology spread constraints are added to evenly spread the
mons, then pod-anti affinity does not allow mons to be created on the
same node where other mons are running, this also includes the
mon-canary pods. We delete the mon-canary pods and then start the actual
mon pods. Sometimes the termination of the canary pods might take more
time, so schedular won't schedular mon pods on that node.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
(cherry picked from commit 3137a857df)
2025-10-23 16:46:17 +00:00
Travis Nielsen ddaf3a2c80 mon: trap the sigterm in the mon canary
The mon canary should quickly shut down after the pod is
deleted, since it has no purpose to continue running.
Since the sleep does not catch the SIGTERM as pid 1,
use a bash trap to exit quickly.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 48b70500fa)
2025-10-23 16:45:22 +00:00
Travis Nielsen 4a1cf3dea1 Merge pull request #16534 from rook/mergify/bp/release-1.17/pr-16532
namespace: blocklist ip:nonce in cleanup job (backport #16532)
2025-09-25 10:39:55 -05:00
Madhu Rajanna 23e7390f8e namespace: blocklist ip:nonce in cleanup job
blocklisting IP can cause problems when the cleanup
job pod runs on the same host or gets the same ip
as that of the rbd client ip that is present in
the rbd status/watchers. instead of blocklisting
the whole ip of the node or the client blocklist
only the unique ip:nonce to allow the node to not
have any effect because of the cleanup job.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 5ae49cf7a0)
Signed-off-by: subhamkrai <srai@redhat.com>
2025-09-25 14:57:57 +05:30
mergify[bot] 757bb543e4 Merge pull request #16502 from rook/mergify/bp/release-1.17/pr-16496
core: fix ObjectZoneSpec.ZoneGroup and ObjectZoneGroupSpec.Realm field descriptions (backport #16496)
2025-09-17 12:20:38 +00:00
Joshua Hoblitt bd40cee69e core: fix ObjectZoneSpec.ZoneGroup field description
Resolves this incorrect field description:

     ~ $ k explain cephobjectzone.spec.zoneGroup
    GROUP:      ceph.rook.io
    KIND:       CephObjectZone
    VERSION:    v1

    FIELD: zoneGroup <string>

    DESCRIPTION:
        The display name for the ceph users

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 8b58d68592)
2025-09-17 11:47:20 +00:00
Joshua Hoblitt 5be2085768 core: fix ObjectZoneGroupSpec.Realm field description
Resolves this incorrect field description:

     ~ $ k explain cephobjectzonegroup.spec.realm
    GROUP:      ceph.rook.io
    KIND:       CephObjectZoneGroup
    VERSION:    v1

    FIELD: realm <string>

    DESCRIPTION:
        The display name for the ceph users

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 1a1478a342)
2025-09-17 11:47:19 +00:00
subham rai 0a64886719 Merge pull request #16458 from rook/mergify/bp/release-1.17/pr-16449
ci: fix the ci canary vault tests (backport #16449)
2025-09-10 21:11:06 +05:30
parth-gr ed60ee8242 ci: fix the ci canary valut test
use the official way for helm installation
and not use the cdn installation

Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit b4fa906202)
2025-09-10 13:32:06 +00:00
Travis Nielsen 8c7a83a2cf Merge pull request #16359 from obnoxxx/release-1.17-prep-1.17.8
Release 1.17 prepare v1.17.8
v1.17.8
2025-08-20 11:45:13 -06:00
Michael Adam 2e9954afa9 build: update release version to v1.17.8
For the patch release update the docs and examples to v1.17.8

Signed-off-by: Michael Adam <obnox@samba.org>
2025-08-20 19:11:08 +02:00
mergify[bot] 50d89115e8 Merge pull request #16357 from rook/mergify/bp/release-1.17/pr-16343
helm: Enable host network for OpenShift if needed (backport #16343)
2025-08-20 16:45:32 +00:00
Travis Nielsen 227d6ee06b helm: enable host network for openshift if needed
The securityContextConstraints require setting whether
host networking and host port access is needed by the
ceph cluster service accounts. The helm chart now allows
enabling this mode with the settings:
rook-ceph chart: useOperatorHostNetwork: true
rook-ceph-cluster chart: cephClusterSpec.network.provider: host

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 82262a8472)
2025-08-20 16:12:33 +00:00
mergify[bot] e84f22af66 Merge pull request #16333 from rook/mergify/bp/release-1.17/pr-16329
pool: fix cephblockpool remove when related pool is already removed (backport #16329)
2025-08-15 20:18:32 +00:00
Denis Egorenko 72fdce486d pool: fix cephblockpool remove when related pool is already removed from cluster
When removeing CephBlockPool check first that related ceph pool is exist in cluster,
since it may be manually removed by mistake.

Related-Issue: #16328
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
(cherry picked from commit c9e0f89a8b)
2025-08-15 19:46:18 +00:00
mergify[bot] 85d4dd7d60 Merge pull request #16314 from rook/mergify/bp/release-1.17/pr-16293
operator: mount udev to cleanup job and disable udev sync (backport #16293)
2025-08-14 20:00:19 +00:00
Denis Egorenko 4b71477621 operator: mount udev to cleanup job and disable udev sync
Mount /run/udev inside cluster cleanup jobs and disable udev sync
with DM_DISABLE_UDEV.

Related-Issue: rook#16292
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
(cherry picked from commit 09622a8b8d)
2025-08-14 13:32:20 -06:00
Travis Nielsen 9460407df4 Merge pull request #16316 from rook/mergify/bp/release-1.17/pr-16312
docs: minor syntax fixes for CephCluster CRD documentation (backport #16312)
2025-08-14 09:07:20 -06:00
Jack Henschel 2f7cdb2e71 docs: minor syntax fixes for CephCluster CRD documentation
Signed-off-by: Jack Henschel <jhensche@redhat.com>
(cherry picked from commit d8651f33ea)
2025-08-14 14:24:44 +00:00
Travis Nielsen f37ebcd0cd Merge pull request #16262 from rook/mergify/bp/release-1.17/pr-16244
csi: add CrossNamespaceVolumeDataSource feature gate (backport #16244)
2025-08-07 12:25:01 -06:00
Travis Nielsen 02315a8783 Merge pull request #16264 from rook/mergify/bp/release-1.17/pr-16260
core: cleanup csi-related folders from /var/lib/rook during uninstall (backport #16260)
2025-08-07 12:24:32 -06:00
mergify[bot] 62eb4e6c2a Merge pull request #16266 from rook/mergify/bp/release-1.17/pr-16069
object: mark realm as default to avoid zone creation (backport #16069)
2025-08-07 17:07:14 +00:00
Oded Viner 572f4ead49 object: mark realm as default to avoid zone creation
add defaultRealm field to cephobjectstore to allow rook to mark the
created realm as default. this prevents ceph from auto-creating a
"default" zonegroup and zone when the default is not explicitly set.
affects only non-multisite setups.

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit 182cd211ca)
2025-08-07 16:34:10 +00:00
Oded Viner 2bd3ec1afb core: cleanup csi-related folders from /var/lib/rook during uninstall
delete csi-related directories from /var/lib/rook that
match the suffix `.csi.ceph.com`.
these folders were used in earlier versions when rook managed
cephcsi directly. in later versions, logs and data are redirected
to /var/lib/cephcsi, but legacy paths may still exist and require
cleanup during uninstall.
this change improves cleanup completeness for odf 4.18 and earlier.

example of directories removed:
- /var/lib/rook/openshift-storage.cephfs.csi.ceph.com
- /var/lib/rook/openshift-storage.rbd.csi.ceph.com

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit 87165cc6d1)
2025-08-07 16:24:10 +00:00
CL0Pinette 0a5b692342 csi: add CrossNamespaceVolumeDataSource feature gate
This enables configuring the CrossNamespaceVolumeDataSource feature gate

Signed-off-by: CL0Pinette <me@cl0pinette.fr>
(cherry picked from commit b63c222d17)
2025-08-07 15:01:25 +00:00
mergify[bot] 43e80d741a Merge pull request #16240 from rook/mergify/bp/release-1.17/pr-16104
core: set erasure-code-profile plugin based on pool algorithm (backport #16104)
2025-08-04 23:19:10 +00:00
Benoît Knecht 7de58d6648 core: only support isa and jerasure algorithms on ec pools
The `CephBlockPool` CR allowed any algorithm to be specified in
`spec.erasureCoded.algorithm`, but in practice only `isa` or `jerasure`
would work.

Make that restriction explicit by restricting this field to `isa` or
`jerasure` in the CRD.

Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
(cherry picked from commit 0b423a30f9)
2025-08-04 22:47:50 +00:00
Benoît Knecht 18e119dc38 core: set erasure-code-profile plugin based on pool algorithm
When a `CephBlockPool` defines `spec.erasureCoded.algorithm`, use it as
the erasure-code-profile plugin.

Until now, that parameter would have been ignored completely, and every
erasure-coded pool would use the same plugin as the `default`
erasure-code-profile (i.e. `jerasure`).

Note that using any algorithm other than `jerasure` or `isa` is likely
to fail given the current implementation, as different algorithm require
different sets of parameters, and those cannot be supplied by the
user.

Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
(cherry picked from commit d7f08693ed)
2025-08-04 22:47:49 +00:00
mergify[bot] d5dee7d378 Merge pull request #16234 from rook/mergify/bp/release-1.17/pr-16052
object: simplify CephObjectStoreUser deletion logic (backport #16052)
2025-08-04 18:46:49 +00:00
Joshua Hoblitt d698edfb6f object: simplify CephObjectStoreUser deletion logic
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 1163133aec)
2025-08-04 18:15:21 +00:00
mergify[bot] 1508d6e716 Merge pull request #16221 from rook/mergify/bp/release-1.17/pr-16220
object: fix bucket policy in sync detection (backport #16220)
2025-08-01 19:58:19 +00:00
Joshua Hoblitt 15e9669c18 object: fix bucket policy in sync detection
A typo was causing the operator to attempt to sync bucket policy when
the state was already in sync. This resulted in the operator carrying
out unnecessary work and logging activity with no user visible change
resulting.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit fbc60608ed)
2025-08-01 19:27:08 +00:00
mergify[bot] 6c8694134a Merge pull request #16213 from rook/mergify/bp/release-1.17/pr-16201
core: improve cleanup of /var/lib/rook during cluster teardown (backport #16201)
2025-08-01 13:41:10 +00:00
Travis Nielsen ee2fc3ff20 Merge pull request #16212 from obnoxxx/release-1.17-prepare-v1.17.7
build: update release version to v1.17.7
v1.17.7
2025-07-31 12:19:14 -06:00
Oded Viner 8abce40d7d core: improve cleanup of /var/lib/rook during cluster teardown
extend StartHostPathCleanup to remove additional directories
under /var/lib/rook

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit 5992415b36)
2025-07-31 17:36:11 +00:00
Michael Adam 3a4de162c4 build: update release version to v1.17.7
For the patch release update the docs and examples to v1.17.7

Signed-off-by: Michael Adam <obnox@samba.org>
2025-07-31 19:24:24 +02:00
mergify[bot] d1bccca9b0 Merge pull request #16207 from rook/mergify/bp/release-1.17/pr-16109
osd: Exclude labels with a value of null from the topology string (backport #16109)
2025-07-30 23:13:52 +00:00
chentao.2022 4f2c92a6c8 osd: exclude labels with a value of null from the topology string
Avoid the OSD startup failing to parse crush_location when
the topology label is empty.

Signed-off-by: chentao.2022 <chentao.2022@bytedance.com>
(cherry picked from commit 62631d2614)
2025-07-30 22:41:33 +00:00
Travis Nielsen b1c6a59f3b Merge pull request #16204 from rook/mergify/bp/release-1.17/pr-16203
rgw: Increase timeout for admin user creation (backport #16203)
2025-07-30 16:29:31 -06:00
mergify[bot] 1e33241145 Merge pull request #16193 from rook/mergify/bp/release-1.17/pr-16186
core: Update ceph version to v19.2.3 (backport #16186)
2025-07-30 22:19:48 +00:00
Travis Nielsen 5b2fd88a4d tests: skip bucket lifecycle policy removal test
In ceph v19.2.3 bucket lifecycle policy removal appears to
be broken, so skip this test for now.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit db2e547779)
2025-07-30 15:48:22 -06:00
Travis Nielsen a08cd25a9b rgw: increase timeout for admin user creation
Creating the rgw admin user is taking on the order of two
minutes instead of the expected seconds, thus the command
was timing out and cause the object store user creation
to fail. The increased timeout allows the admin user creation
to complete, and other users to be created as well.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 79a7a3c01f)
2025-07-30 21:39:16 +00:00
Blaine Gardner 372c474e4a Merge pull request #16191 from rook/mergify/bp/release-1.17/pr-16150
core: log panics in controller reconcile functions (backport #16150)
2025-07-30 14:23:16 -06:00
Travis Nielsen 2d970de83e core: update ceph version to v19.2.3
With the new squid patch release, update the base
image, the docs, and the examples to all use the latest
stable Ceph release v19.2.3.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 66a006b99c)

# Conflicts:
#	tests/manifests/test-cluster-on-pvc-encrypted.yaml
2025-07-29 19:28:03 +00:00
Oded Viner ee0bae1a6c core: log panics in controller reconcile functions
add RecoverAndLogException() helper to log panics with stack trace.
added defer call in all rook controller Reconcile() methods for
better error visibility in operator logs

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit cf13deee6f)
2025-07-29 16:00:49 +00:00