Commit Graph
11306 Commits
Author SHA1 Message Date
Travis Nielsen 39cc31dbf1 Merge pull request #14499 from travisn/daily-upgrade-tests
tests: Check for correct base rook version during upgrade
2024-07-25 15:29:26 -06:00
Travis Nielsen 4cf349836f tests: check for correct base rook version during upgrade
The daily upgrade tests were checking for a specific
version of the rook image instead of the local_build tag
that is set as the rook base image since 14486.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-07-25 12:44:30 -06:00
Travis Nielsen 54a2944252 Merge pull request #14382 from parth-gr/external-seamless-upgrade-doc
doc: add upgrade steps for external cluster
2024-07-25 09:50:42 -06:00
Travis Nielsen 3c522dbd35 Merge pull request #14480 from rook/dependabot/go_modules/k8s-dependencies-6ec60a0016
build(deps): bump the k8s-dependencies group with 6 updates
2024-07-24 15:40:45 -06:00
dependabot[bot] 7ecf365c4b build(deps): bump the k8s-dependencies group with 6 updates
Bumps the k8s-dependencies group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.30.2` | `0.30.3` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.30.2` | `0.30.3` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.30.2` | `0.30.3` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.30.2` | `0.30.3` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.30.2` | `0.30.3` |
| [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) | `0.30.2` | `0.30.3` |

Updates `k8s.io/api` from 0.30.2 to 0.30.3
- [Commits](https://github.com/kubernetes/api/compare/v0.30.2...v0.30.3)

Updates `k8s.io/apiextensions-apiserver` from 0.30.2 to 0.30.3
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.30.2...v0.30.3)

Updates `k8s.io/apimachinery` from 0.30.2 to 0.30.3
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.30.2...v0.30.3)

Updates `k8s.io/cli-runtime` from 0.30.2 to 0.30.3
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.30.2...v0.30.3)

Updates `k8s.io/client-go` from 0.30.2 to 0.30.3
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.30.2...v0.30.3)

Updates `k8s.io/cloud-provider` from 0.30.2 to 0.30.3
- [Commits](https://github.com/kubernetes/cloud-provider/compare/v0.30.2...v0.30.3)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cloud-provider
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-24 14:25:07 -06:00
Travis Nielsen 6c36bc47b2 Merge pull request #14487 from travisn/upgrade-from-1.14
tests: Upgrade from rook 1.14 to master
2024-07-24 13:37:23 -06:00
Travis Nielsen 2fb1e7af2c Merge pull request #14491 from travisn/ceph-18.2.4
manifest: Update the ceph recommended version to v18.2.4
2024-07-24 13:31:17 -06:00
Travis Nielsen f74815283c Merge pull request #14485 from travisn/retry-helm-upgrade
tests: Retry helm upgrade during upgrade tests
2024-07-24 13:30:44 -06:00
Travis Nielsen 9e6d721919 Merge pull request #14484 from travisn/dashboard-cert-init
mgr: Properly detect if dashboard cert already exists to avoid unnecessary dashboard module restarts
2024-07-24 13:30:22 -06:00
Travis Nielsen 6ce616bf96 mgr: properly detect if dashboard cert already exists
If the dashboard cert already exists when ssl is enabled,
we need to not restart the dashboard module. The module
should only be restarted when there is a change to the
dashboard configuration. When ssl is enabled, the dashboard
is essentially being restarted every time there is a reconcile
which is causing issues with the mgr getting blocklisted
unnecessarily by ceph during failover.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-07-24 12:22:38 -06:00
Travis Nielsen 4e2447277f multus: install ip tool for multus
The ceph base image removed the ip tool, so we add
it into the rook image.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-07-24 11:19:37 -06:00
Travis Nielsen e26920a483 manifest: update the ceph recommended version to v18.2.4
Since Reef v18.2.4 is released, set it to the default
ceph version that is deployed with Rook.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-07-24 11:06:09 -06:00
Travis Nielsen 44acaa6aba Merge pull request #14482 from cobaltcore-dev/mgr-monitoring-label
mgr: lookup cluster crd on active mgr watch
2024-07-24 10:56:23 -06:00
parth-gr 8e72748be2 doc: add upgrade steps for external cluster
curently if user want to utilise the new flags with upgrade
user dont have the ability for it
Add the steps so user can make use of it

closes: https://github.com/rook/rook/issues/14368

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-07-24 21:25:50 +05:30
Travis Nielsen 043b446675 tests: retry helm upgrade during upgrade tests
The helm upgrade tests have been failing frequently, but not
always, on the oldest version of K8s that is tested in the CI
for the past few months. Add a retry to attempt to get
the CI passing more consistently.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-07-24 08:14:21 -06:00
Travis Nielsen 099c603a43 tests: upgrade from rook 1.14 to master
The upgrade tests in master have been upgrading from 1.13 to
master. In anticipation of the v1.15 release, we change
the upgrade tests to start from v1.14 to test if there
are any regressions in the supported upgrades.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-07-24 08:12:31 -06:00
Artem Torubarov 3f2d0eb1f8 mgr: lookup cluster crd on active mgr watch
Signed-off-by: Artem Torubarov <artem.torubarov@clyso.com>
2024-07-24 12:09:19 +02:00
subham rai cf2462fca3 Merge pull request #14486 from travisn/daily-upgrade-on-master
tests: Daily ceph upgrade tests on rook master
2024-07-24 10:03:36 +05:30
Travis Nielsen 1d8d55e1ad tests: daily ceph upgrade tests on rook master
The daily ceph upgrade tests were running on Rook v1.13.
This was causing the squid upgrade tests to fail since
1.13 does not support Squid. The purpose of the upgrade
tests is to test the ceph upgrades, therefore the daily
tests will just test them based on rook master.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-07-23 16:19:19 -06:00
Blaine Gardner cec77d7faa Merge pull request #14464 from parth-gr/external-upgrade
external: fix the output of user config
2024-07-23 10:05:21 -06:00
parth-gr cb30f66862 external: fix the output of user config
currently the output in the cm was not human readable
and can not easily used to create a config.ini file

Also for now removed the support of printing arg in upstream

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-07-22 22:23:57 +05:30
Travis Nielsen 5328c06d4e Merge pull request #14478 from yingshanghuangqiao/master
core: Fix some misspelled comments
2024-07-22 10:45:11 -06:00
Travis Nielsen 2903995448 Merge pull request #14481 from rook/dependabot/go_modules/github-dependencies-f4e564e1f1
build(deps): bump github.com/aws/aws-sdk-go from 1.54.19 to 1.54.20 in the github-dependencies group
2024-07-22 10:37:40 -06:00
Blaine Gardner 12e8727b20 Merge pull request #14473 from obnoxxx/token-permissions
ci: fix excessive token permissions
2024-07-22 08:36:10 -06:00
yingshanghuangqiao 3d672a726a core: fix some comments
Signed-off-by: yingshanghuangqiao <yingshanghuangqiao@foxmail.com>
2024-07-22 22:09:52 +08:00
dependabot[bot] cb0bc4f3cd build(deps): bump github.com/aws/aws-sdk-go
Bumps the github-dependencies group with 1 update: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go).


Updates `github.com/aws/aws-sdk-go` from 1.54.19 to 1.54.20
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.54.19...v1.54.20)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-22 12:10:54 +00:00
Michael AdamandBlaine Gardner 9b2b9b7be2 ci: fix excessive token permissions
Fixes: #14466

The OpenSSF scorecard report

https://scorecard.dev/viewer/?uri=github.com/rook/rook

warns about excessive token-permissions in the rook project's github CI
workflows.

This bulk change aims at improving this by

1. adding top-level read permissions where missing for integration tests.
2. adding write permissions as needed for the auto-assign workflow.
3. removing the warned-about and unused create-tag workflow

Signed-off-by: Michael Adam <obnox@samba.org>
Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com>
2024-07-22 12:34:01 +02:00
Satoru Takeuchi c8f9e6549d Merge pull request #14457 from travisn/deviceclass-update
osd: Update the device class if desired state changes
2024-07-19 10:06:58 +09:00
Travis Nielsen 88e952a3ac osd: update the device class if desired state changes
Normally the device class of an OSD is determined at provisioning
and is not updated thereafter. In some scenarios the admin may
want to force update the device class to a new value. The device
classes can be updated by first setting allowDeviceClassUpdate
in the storage spec of the cephcluster, then updating the
device class specified on the deviceSets or other OSDs.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-07-17 13:54:21 -06:00
Travis Nielsen 3ccdb53cb6 Merge pull request #14258 from subhamkrai/add-cephfs-fencing
mds: block of active mds ip only
2024-07-17 11:48:01 -06:00
Blaine Gardner b287aa9254 Merge pull request #14460 from BlaineEXE/design-vhost-updates
doc: update vhost-style S3 bucket design
2024-07-17 11:17:39 -06:00
subham rai b4f99fb5cc Merge pull request #14356 from subhamkrai/csi-operator-design
docs: design for csi operator integration with rook
2024-07-17 14:21:06 +05:30
subhamkrai 9f1b64be54 mds: block of active mds ip only
currently, it was blocking both the mds ip
instead its should block ip of of mds which is in
the same node which is down.

Signed-off-by: subhamkrai <srai@redhat.com>
2024-07-17 13:30:35 +05:30
subham rai a9e192b363 Merge pull request #14468 from Madhu-1/fix-log-rotation
csi: fix template render in logRotation
2024-07-17 12:56:54 +05:30
subhamkrai 73ea725c99 docs: design for csi operator integration with rook
this commits adds desgin doc for integrating the new csi operator
with rook.

Signed-off-by: subhamkrai <srai@redhat.com>
2024-07-17 12:41:54 +05:30
Madhu Rajanna cb87c3a845 csi: fix template render in logRotation
the templateParam need to be updated
with the right values before we are
rendering the template.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-07-17 08:15:30 +02:00
subhamkrai efe6ef4e45 csi: revert remove cephFs networkFence code temporarily
This reverts commit bd4250f56e.

Signed-off-by: subhamkrai <srai@redhat.com>
2024-07-17 11:36:15 +05:30
Blaine Gardner 00f20b1212 doc: update vhost-style S3 bucket design
Update the vhost-style S3 bucket access design doc to reflect recent
user feedback and configuration issues. The primary goal is to add a
field to disambiguate for users and Rook which endpoint should be used
for CephObjectStoreUsers, OBCs, and COSI buckets.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-07-16 16:50:50 -06:00
Travis Nielsen 9967b161f9 Merge pull request #14420 from YiteGu/make-kube-api-limit-configurable
csi: make kube apiserver qps configurable
2024-07-16 07:40:56 -06:00
yite.gu 80541a23c9 csi: make kube apiserver qps configurable
This commit adds the flexibility to configure kube apiserver qps
as per the user requirement and also keeps the existing values as
the default one.

Signed-off-by: yite.gu <yitegu0@gmail.com>
2024-07-16 18:39:16 +08:00
Travis Nielsen 525648e42c Merge pull request #14459 from rook/dependabot/go_modules/github-dependencies-fb6482a7be
build(deps): bump github.com/aws/aws-sdk-go from 1.54.15 to 1.54.19 in the github-dependencies group
2024-07-15 16:45:46 -06:00
Travis Nielsen e499fcad37 Merge pull request #14454 from travisn/squid-support
core: Add support for Ceph Squid
2024-07-15 12:44:04 -06:00
Travis Nielsen 22d4139b74 core: add support for ceph squid
With the release of the first squid RC, we add squid
to the supported versions and add tests to run
Rook against the squid release.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-07-15 10:04:32 -06:00
dependabot[bot] dee06bb136 build(deps): bump github.com/aws/aws-sdk-go
Bumps the github-dependencies group with 1 update: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go).


Updates `github.com/aws/aws-sdk-go` from 1.54.15 to 1.54.19
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.54.15...v1.54.19)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-15 12:16:03 +00:00
Travis Nielsen 689b39de4f Merge pull request #14057 from travisn/deviceclass-log
pool: Return error if device class update fails
2024-07-12 08:50:35 -06:00
Travis Nielsen da73421d7e Merge pull request #14396 from parth-gr/csi-logrotate-file
csi: add log rotation for csi cephfs nfs pod containers
2024-07-12 08:41:45 -06:00
parth-gr 4ca8b12e12 csi: add log rotation for csi cephfs nfs pod containers
Use the same logrotate flow of rbd, as merged in #14305

1) Make the csi cephfs and nfs container logs persisted in a file

2) Use the cephcluster api specs to configure the log rotate

3) Add log rotation to rotate the log file and
Add a sidecar log collector container

And some fixes on the implementation:

1) Add a operator namespace in the log file path

2) Only add volume to the container if logrotate is enabled

Closes: https://github.com/rook/rook/issues/12809, https://github.com/rook/rook/issues/14429

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-07-12 12:50:35 +05:30
subham rai 76d2886f17 Merge pull request #14432 from rook/dependabot/go_modules/github-dependencies-fc54c511fc
build(deps): bump the github-dependencies group across 1 directory with 4 updates
2024-07-12 10:03:44 +05:30
Blaine Gardner 67772a296b Merge pull request #14451 from BlaineEXE/multus-reset-test-line
multus: reset validation tool debounce time to 30
2024-07-11 14:53:12 -06:00
Blaine Gardner 65dc27845f Merge pull request #14451 from BlaineEXE/multus-reset-test-line
multus: reset validation tool debounce time to 30
2024-07-11 12:06:22 -06:00