Travis Nielsen
3fb5d4e833
Merge pull request #14271 from occ/docs-nixos-containerd
...
docs: Add a note for NixOS and containerd
2024-05-28 13:15:21 -06:00
Travis Nielsen
a63c896fa0
Merge pull request #14257 from bdowling/pr-reduce-purge-retry-timeout
...
osd: reduce safe-to-destroy retry timeout to 15s
2024-05-28 10:21:13 -06:00
Onur C. Cakmak
d1e139cdb3
docs: add a note for NixOS and containerd
...
Add a note to remove LimitNOFILE setting in containerd service configuration.
This setting causes multiple issues such as slow `ceph status` commands (and failing healthchecks),
various timeouts, and mons failing/timing out.
Upstream containerd already removed the setting. NixOS hasn't incorporated the change.
This note can be removed once https://github.com/NixOS/nixpkgs/pull/313507 makes it to a stable release.
Signed-off-by: Onur Cakmak <occ@occ.me >
2024-05-27 22:42:49 -04:00
Brian Dowling
ef0ed93134
osd: reduce safe-to-destroy retry timeout to 15s
...
This reduces the safe-to-remove retry interval from 1m to 15s.
Closes #14247
Signed-off-by: Brian Dowling <bjd-dev@simplicity.net >
2024-05-27 13:54:21 -04:00
subham rai
53be5ce1e9
Merge pull request #14266 from subhamkrai/fix-codespell
...
ci: fix codespell ci by skipping some words
2024-05-27 12:11:44 +05:30
subhamkrai
85c25bbc6e
ci: fix codespell ci by skipping some words
...
fixing 'secert' to `secret` and adding workds like
`NotIn, addin` to skip work list.
Signed-off-by: subhamkrai <srai@redhat.com >
2024-05-27 10:26:34 +05:30
Blaine Gardner
a138a38cdb
Merge pull request #14248 from BlaineEXE/fix-mon-ipv6-networking
...
mon: fix bind addr when IPv6 and msgr2 are enabled
2024-05-23 07:31:12 -06:00
Travis Nielsen
8dc88c39b1
Merge pull request #14250 from Nordix/fix-network-config-link
...
docs: fix broken link to network config
2024-05-22 07:55:28 -06:00
NymanRobin
30e6a7349b
docs: fix broken link to network config
...
Signed-off-by: NymanRobin <robin.nyman@est.tech >
2024-05-22 15:13:02 +03:00
Blaine Gardner
573a47e736
mon: fix bind addr when IPv6 and msgr2 are enabled
...
When IPv6-only network mode is enabled and when mons are configured to
listen only on msgrV2 port, Rook has to add the port to the mon
--public-bind-addr in order to force mons to stop listening on the
msgrV1 port. This can cause problems for IPv6 clusters where adding
':<port>' to the end of an IP addr looks like a valid IPv6 address.
In IPv6 mode, Rook needs to set this to '[<ip>]:<port>' with the
brackets to be a non-ambiguous IPv6 address.
In IPv4 mode, Rook needs to keep its existing behavior. IPv4 mode should
also continue to be the defualt assumption if the network config isn't
specified.
If 'dualStack: true' is specified, Rook is informed that the environment
is dual stack, but Rook doesn't know which IP family to expect from the
pod IP. In this scenario, it is safest for Rook not to apply the port,
since assuming either IPv4 or IPv6 format could be incorrect. In this
scenario, mons may still listen on msgrV1 ports, but this is preferable
to an environment where mons perpetually crash.
Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com >
2024-05-21 14:42:06 -06:00
subham rai
161306a484
Merge pull request #14186 from parth-gr/heartbeat-node
...
core: do not watch resourceversion and heartbeat node updates
2024-05-21 16:58:15 +05:30
parth-gr
c235a99cf9
core: do not watch resourceversion and heartbeat node updates
...
currently node predicate watches for resourceVersion and heartbeat
changes, which are not critical things. So with the PR we will add
a early-exit condition for the predicate as an optimization and to
ignore considering for a reconcile of cephcluster if updates are
not crucial
closes: https://github.com/rook/rook/issues/14070
Signed-off-by: parth-gr <partharora1010@gmail.com >
2024-05-20 22:25:39 +05:30
Travis Nielsen
3d62020709
Merge pull request #14173 from obnoxxx/sc-radosnamespace
...
docs: document how to have StorageClass consume Rados Namespace
2024-05-20 07:13:15 -06:00
Travis Nielsen
2555e51cba
Merge pull request #14234 from sp98/remove-owner-ref-in-cleanupjob
...
core: remove owner refs in resource cleanup jobs
2024-05-18 10:02:00 -06:00
8e7ac95f97
docs: document how to have StorageClass consume Rados Namespace
...
closes: https://github.com/rook/rook/issues/13214
Co-authored-by: Travis Nielsen <tnielsen@redhat.com >
Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com >
Signed-off-by: Michael Adam <obnox@samba.org >
2024-05-18 12:21:56 +02:00
Travis Nielsen
eecaa256df
Merge pull request #14236 from sp98/fix-svg-cleanup-job
...
core: fix missing env in svg cleanup job
2024-05-17 08:43:17 -06:00
sp98
33ce8f0c8e
core: fix missing env in svg cleanup job
...
SVG cleanup job uses the cephSubvolumeGroup env name
from spec.Name. But sometimes it can be empty. In that
case rook should use the CR name.
Signed-off-by: sp98 <sapillai@redhat.com >
2024-05-17 18:55:01 +05:30
sp98
c98fc86918
core: remove owner refs in resource cleanup jobs
...
Removed owner reference from Radosnamespace and
subVolumeGroup cleanup resources.
Signed-off-by: sp98 <sapillai@redhat.com >
2024-05-17 18:39:34 +05:30
Travis Nielsen
9f3d76c9ec
Merge pull request #14190 from yati1998/cross-storage
...
doc: Update documentation for volume clone
2024-05-16 08:59:45 -06:00
Travis Nielsen
bde9b40e2d
Merge pull request #14221 from subhamkrai/remove-extra-comma
...
ci: remove extra comma from platforms
2024-05-16 08:29:10 -06:00
subhamkrai
ea159ad9b7
ci: remove extra comma from platforms
...
The last pr missed removing the extra comma after the platform
so, instead of ` linux/amd64,linux/arm64,` it should be
` linux/amd64,linux/arm64`.
Signed-off-by: subhamkrai <srai@redhat.com >
2024-05-16 14:47:51 +05:30
yati1998
945da179e2
docs: update documentation for volume clone
...
after cross-storageclass clone/restore, now we can
clone across different storageclass.
this commit updates the documentation indicating
the same.
Signed-off-by: yati1998 <ypadia@redhat.com >
2024-05-16 13:17:32 +05:30
Satoru Takeuchi
07768b137e
Merge pull request #14210 from cybozu-go/remove-pacific-specific-code
...
core: remove pacific specific code
2024-05-16 08:43:29 +09:00
Travis Nielsen
fd7137bb4b
Merge pull request #14214 from subhamkrai/fix-ubuntu-22.04-build-image
...
ci: push image ci failing in ubuntu 22.04
2024-05-15 10:47:06 -06:00
subhamkrai
f89540c4ef
ci: push image ci failing in ubuntu 22.04
...
since we moved to ubuntu 22.04, ci push image build is failing
due wrong parameter `--platforms linux/amd64 linux/arm64,` it should
be instead `--platforms linux/amd64, linux/arm64`.
Signed-off-by: subhamkrai <srai@redhat.com >
2024-05-15 22:09:16 +05:30
Satoru Takeuchi
f776c0b35e
core: remove pacific specific code
...
Since pacific is no longer supported, we can remove pacific specific
code.
Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com >
2024-05-15 02:26:33 +00:00
Travis Nielsen
5a205832b8
Merge pull request #14204 from Nordix/fix-pylint-errors
...
ci: fix pylint errors
2024-05-14 14:23:44 -06:00
Travis Nielsen
0dc98fcab6
Merge pull request #14198 from Nordix/update-setup-go-version
...
ci: bump github actions dependency setup-go
2024-05-14 13:37:48 -06:00
NymanRobin
dcec080468
ci: fix pylint errors
...
Afte pylint was updated to version 3.2.0
a set of new errors appeared. This makes
ci passing by either fixing the problem
or ignoring it in the check
Signed-off-by: NymanRobin <robin.nyman@est.tech >
2024-05-14 22:28:24 +03:00
NymanRobin
8af9917b9e
ci: bump github actions dependency setup-go
...
The version v2 was deprecated and was causing warnings.
Signed-off-by: NymanRobin <robin.nyman@est.tech >
2024-05-14 12:46:33 +03:00
Travis Nielsen
fd795cec96
Merge pull request #14191 from rook/dependabot/github_actions/golangci/golangci-lint-action-6
...
build(deps): bump golangci/golangci-lint-action from 5 to 6
2024-05-13 16:51:58 -06:00
Travis Nielsen
3083a0b8b4
Merge pull request #14192 from rook/dependabot/go_modules/github-dependencies-58b26b4692
...
build(deps): bump github.com/aws/aws-sdk-go from 1.52.2 to 1.53.0 in the github-dependencies group
2024-05-13 16:51:29 -06:00
dependabot[bot]
08a4de106a
build(deps): bump github.com/aws/aws-sdk-go
...
Bumps the github-dependencies group with 1 update: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go ).
Updates `github.com/aws/aws-sdk-go` from 1.52.2 to 1.53.0
- [Release notes](https://github.com/aws/aws-sdk-go/releases )
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.52.2...v1.53.0 )
---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-13 12:48:50 +00:00
dependabot[bot]
b55b65a3f2
build(deps): bump golangci/golangci-lint-action from 5 to 6
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 5 to 6.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](https://github.com/golangci/golangci-lint-action/compare/v5...v6 )
---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-13 12:19:27 +00:00
Satoru Takeuchi
39f88521f0
Merge pull request #14187 from travisn/legacy-osd-status
...
osd: Add cephcluster status for deprecated osds to replace
2024-05-13 09:34:50 +09:00
Travis Nielsen
3628e83892
osd: add cephcluster status for legacy osds to replace
...
LVM-based OSDs on PVCs are legacy and are not well tested.
Therefore, we add status to the cephcluster CR that at least
gives a clue that the OSDs should be replaced.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com >
2024-05-10 16:00:41 -06:00
Blaine Gardner
5e3d62308c
Merge pull request #14178 from BlaineEXE/fix-markdownlint-missing-ci
...
ci: add missing markdownlint CI step
2024-05-08 11:18:59 -06:00
Blaine Gardner
115e0aa430
ci: add missing markdownlint CI step
...
The CI step that runs markdown lint accidentally got removed as part of
PR updates. Add the CI step back in.
Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com >
2024-05-08 10:55:33 -06:00
Blaine Gardner
0a08a73381
Merge pull request #14175 from BlaineEXE/update-govulncheck-version
...
ci: update go version for govulncheck
2024-05-08 10:24:00 -06:00
Blaine Gardner
f21f3f549c
ci: update go version for govulncheck
...
Update the version of Go used for govulncheck to get the latest CVE fix
present in Go v1.22.3.
Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com >
2024-05-08 08:01:57 -06:00
Blaine Gardner
517b1bf128
Merge pull request #14166 from subhamkrai/update-ubuntu-image
...
ci: update ubuntu image to 22.04
2024-05-07 09:05:32 -06:00
subham rai
cdc1bd24d8
Merge pull request #14167 from obnoxxx/doc-fix-bprnsc
...
docs: improve wording in BlockPoolRados Namespace CRD doc.
2024-05-07 16:36:41 +05:30
Michael Adam
10df932d62
docs: improve wording in BlockPoolRados Namespace CRD doc
...
Signed-off-by: Michael Adam <obnox@samba.org >
2024-05-07 12:43:57 +02:00
subhamkrai
11ce20feaf
ci: update ubuntu image to 22.04
...
updating ubuntu image to 22.04 from 20.04 which is used in ci test
Signed-off-by: subhamkrai <srai@redhat.com >
2024-05-07 12:46:12 +05:30
Travis Nielsen
c908f01e97
Merge pull request #14162 from rook/dependabot/go_modules/github-dependencies-03f982969c
...
build(deps): bump the github-dependencies group across 1 directory with 7 updates
2024-05-06 14:22:43 -06:00
dependabot[bot]
e9602861e9
build(deps): bump the github-dependencies group across 1 directory with 7 updates
...
Bumps the github-dependencies group with 7 updates in the / directory:
| Package | From | To |
| --- | --- | --- |
| [github.com/IBM/keyprotect-go-client](https://github.com/IBM/keyprotect-go-client ) | `0.12.2` | `0.13.0` |
| [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go ) | `1.51.11` | `1.52.2` |
| [github.com/ceph/go-ceph](https://github.com/ceph/go-ceph ) | `0.26.0` | `0.27.0` |
| [github.com/hashicorp/vault/api](https://github.com/hashicorp/vault ) | `1.12.2` | `1.13.0` |
| [github.com/k8snetworkplumbingwg/network-attachment-definition-client](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client ) | `1.6.0` | `1.7.0` |
| [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator ) | `0.72.0` | `0.73.2` |
| [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator ) | `0.72.0` | `0.73.2` |
Updates `github.com/IBM/keyprotect-go-client` from 0.12.2 to 0.13.0
- [Release notes](https://github.com/IBM/keyprotect-go-client/releases )
- [Changelog](https://github.com/IBM/keyprotect-go-client/blob/master/CHANGELOG.md )
- [Commits](https://github.com/IBM/keyprotect-go-client/compare/v0.12.2...v0.13.0 )
Updates `github.com/aws/aws-sdk-go` from 1.51.11 to 1.52.2
- [Release notes](https://github.com/aws/aws-sdk-go/releases )
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.51.11...v1.52.2 )
Updates `github.com/ceph/go-ceph` from 0.26.0 to 0.27.0
- [Release notes](https://github.com/ceph/go-ceph/releases )
- [Changelog](https://github.com/ceph/go-ceph/blob/master/docs/release-process.md )
- [Commits](https://github.com/ceph/go-ceph/compare/v0.26.0...v0.27.0 )
Updates `github.com/hashicorp/vault/api` from 1.12.2 to 1.13.0
- [Release notes](https://github.com/hashicorp/vault/releases )
- [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md )
- [Commits](https://github.com/hashicorp/vault/compare/v1.12.2...v1.13.0 )
Updates `github.com/k8snetworkplumbingwg/network-attachment-definition-client` from 1.6.0 to 1.7.0
- [Release notes](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/releases )
- [Commits](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/compare/v1.6.0...v1.7.0 )
Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.72.0 to 0.73.2
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases )
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.72.0...v0.73.2 )
Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.72.0 to 0.73.2
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases )
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.72.0...v0.73.2 )
---
updated-dependencies:
- dependency-name: github.com/IBM/keyprotect-go-client
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-dependencies
- dependency-name: github.com/ceph/go-ceph
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-dependencies
- dependency-name: github.com/hashicorp/vault/api
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-dependencies
- dependency-name: github.com/k8snetworkplumbingwg/network-attachment-definition-client
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-06 13:50:39 -06:00
Travis Nielsen
905c824ca2
Merge pull request #14160 from rkachach/fix_issue_13601
...
mgr: fix UpdateActiveMgrLabel to retry label update on failure
2024-05-06 12:59:20 -06:00
Redouane Kachach
ee7c71c89e
mgr: fix UpdateActiveMgrLabel to retry label update on failure
...
fix UpdateActiveMgrLabel to retry label update on failure. Previously,
the function always returned the current manager, even if update
failed, leading to inconsistent labels. This fix ensures retries on
failures.
Fixes: https://github.com/rook/rook/issues/13601
Signed-off-by: Redouane Kachach <rkachach@ibm.com >
2024-05-06 19:30:44 +02:00
Blaine Gardner
1af97d09a8
Merge pull request #14154 from BlaineEXE/csi-config-map-fix-empty-namespace
...
csi: fix missing namespace bug in csi cluster config map
2024-05-03 12:09:52 -06:00
Travis Nielsen
3364bd65bb
Merge pull request #14134 from subhamkrai/add-validation-scds
...
osd: limit storageClassDeviceSets to 63 chars
2024-05-03 07:29:28 -06:00