Commit Graph
6391 Commits
Author SHA1 Message Date
Sébastien Han 447f9c97ff Merge pull request #7299 from jshen28/remove-generatekeyring-for-osd
ceph: remove unnecessary generate key for osd
2021-02-25 14:51:35 +01:00
Sébastien Han 0c4d6a7fa4 Merge pull request #7217 from aruniiird/external-add-standby-mgrs
ceph: Enable external resource script to collect active and standby mgrs
2021-02-25 10:28:32 +01:00
shenjiatong fb33d87d33 ceph: remove generateKeyring for osd
After adopting `ceph-volume`, secret key for
user osd.x will be generated by `ceph-volume` and
thus method `generateKeyring` is not necessary
anymore.

Executing ceph command takes
extra half of second to complete, executing it
in serial is rather expensive, remove it for better
performance.

Signed-off-by: shenjiatong <yshxxsjt715@gmail.com>
2021-02-25 08:21:08 +08:00
Arun Kumar Mohan bc4dd24306 ceph: making changes to fix CI test failures
Changed the random port creation's max value from 255 to 254, as the IP
with value 255 fails.
Re-raise/propagate the 'ExecutionFailureException' exception so that we
don't end-up in ZERO exit value.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2021-02-24 23:54:42 +05:30
Arun Kumar Mohan 72b88b4267 ceph: adding the test-data file into the image fs
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2021-02-24 23:54:42 +05:30
Arun Kumar Mohan 5ce07b9559 ceph: fixed tests for standby mgr changes
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2021-02-24 23:54:42 +05:30
Arun Kumar Mohan f68529f31f ceph: enable external resource script to collect active and standby mgrs
Now 'create-external-cluster-resources.py' script will add standby mgrs
along with the active mgr while providing the output.
'MonitoringEndpoint' data-key will contain a comma separated list of
active followed by standby mgrs' IP addresses.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2021-02-24 23:54:42 +05:30
Travis Nielsen ca667abfc2 Merge pull request #7295 from travisn/network-troubleshoot
docs: Additional network troubleshooting details for mons
2021-02-24 10:52:46 -07:00
Travis Nielsen 64a3558d08 docs: more network troubleshooting details for mons
Forming mon quorum is one of the most common issues to
troubleshoot when starting a new cluster, whether it is the
network configuration or the previous install was not
cleaned properly.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-02-24 10:37:22 -07:00
Travis Nielsen 10547a4e2f Merge pull request #7298 from leseb/vault-certs
ceph: do not use curl ca-cert for signed certificates
2021-02-24 07:23:37 -07:00
Sébastien Han 4b8ec15b69 ceph: do not use curl ca-cert for signed certificates
cURL's ca-cert and Golang TLS config for ca-certs have a different
meaning, it seems that the Golang implementation will always lookup the
local certs first and then proceeds with the specificed cert, if the
system's certs works it will never go to the specificied certificate.
cURL however, does the opposite by strictly checking the specified cert.
If the certificate is signed we don't need to force a specific
certificate, thus by using capath instead we let cURL determine what's
best to validate against.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-02-24 11:49:56 +01:00
Sébastien Han e6b44cc386 Merge pull request #7286 from travisn/codegen-update
ceph: Codegen update for pool quotas
2021-02-23 17:44:02 +01:00
Sébastien Han dad4e4effa Merge pull request #7292 from leseb/bz-1931839
ceph: show error even in silent curl
2021-02-23 17:40:10 +01:00
Sébastien Han 069ff22d53 ceph: show error even in silent curl
The --silent option will remove the progress bar of the curl but also
silence any errors of stderr, so adding --show-error will display the
error even if --silent is used.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-02-23 17:15:31 +01:00
Sébastien Han 91343f4fdd Merge pull request #7283 from leseb/rm-index-cephfs-mirror
ceph: misc improvement for the ceph-fs-mirror implementation
2021-02-23 17:06:29 +01:00
Sébastien Han 6bc028be2a ceph: pass correct fs-mirror type for upgrade check
We were passing rbd-mirorr where it's fs-mirror...

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-02-23 10:49:58 +01:00
Sébastien Han 8e8afe7a75 ceph: do not check ok-to-stop fs-mirror
The fs-mirror has no "ok-to-stop" command so let's skip it.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-02-23 10:49:13 +01:00
Sébastien Han beb543b7bc ceph: fix fs-mirror collector logrotate
The sed from the log-collector pod was running incorrectly and the
rotation was not happening.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-02-23 10:45:53 +01:00
Sébastien Han 69b04057f1 ceph: do not use index for ceph-fs-mirror
When deploying the ceph-fs-mirror daemon we don't need to name the
deployment like "rook-ceph-fs-mirror-a", we can simply go with
"rook-ceph-fs-mirror". Today, in Pacific, the daemon only supports a
single replica. In the future, the Ceph Quincy release should support
mulitiple concurrent daemons, at this point Rook will introduce a
"count" field in the CephFilesystemMirror CRD specification. Internally,
this field will map with the "replica" value of the Deployment.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-02-23 10:45:45 +01:00
Alexander Trost 7cdbe6e869 Merge pull request #7027 from huats/Fix_rook-nfs_number 2021-02-23 10:09:53 +01:00
Christophe Sauthier 53ccb1e1e4 nfs: fix the number of containers displayed in documentation
Signed-off-by: Christophe Sauthier <christophe.sauthier@gmail.com>
2021-02-22 17:51:29 -05:00
Travis Nielsen 9d15c104cc ceph: codegen update for pool quotas
The pool quotas were added in #7264, however the codegen CI
action did not catch that an update was needed until it
was backported.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-02-22 11:14:11 -07:00
Sébastien Han 9470a64ba7 Merge pull request #7284 from leseb/pool-replica-failure
ceph: fail if subfailure domains are identical
2021-02-22 18:43:19 +01:00
Sébastien Han 0300111f73 ceph: fail if subfailure domains are identical
Both cannot be identical otherwise this will create placement issues.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-02-22 17:24:24 +01:00
Sébastien Han 288b0f6439 ceph: silence harmless error
Let's skip the reconcile and back-off if the operator is not ready.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-02-22 14:39:32 +01:00
Sébastien Han adcb92f635 Merge pull request #7280 from cybozu-go/ceph-fix-sigsegv-in-obc-creation
ceph: fix SIGSEGV when failing to get object store user
2021-02-22 12:59:01 +01:00
Satoru Takeuchi c628a996c8 ceph: fix SIGSEGV when failing to get object store user
We shouldn't use `user.userID` if `GetUser()` failed.

Closes: https://github.com/rook/rook/issues/7278

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2021-02-22 11:24:59 +00:00
Travis Nielsen 7404de7b38 Merge pull request #7264 from fritchie/pool-quotas
ceph: add ability to set pool quotas
2021-02-19 12:53:41 -07:00
Frank Ritchie a0488dac73 ceph: add ability to set pool quotas
This will allow setting ceph pool quotas in bytes and/or objects.

Ceph documentation: https://docs.ceph.com/en/latest/rados/operations/pools/#set-pool-quotas

Signed-off-by: Frank Ritchie <12985912+fritchie@users.noreply.github.com>
2021-02-19 13:49:25 -05:00
Sébastien Han 00e85bc53c Merge pull request #7271 from hookak/patch-2
docs: Delete 'rootPath' in cephfs storageclass yaml
2021-02-19 11:46:31 +01:00
Sébastien Han 0631408c2a Merge pull request #7270 from shellwedance/ceph_correct_fs_yaml
ceph: correct fs yaml fields
2021-02-19 10:54:32 +01:00
jinhong.kim f519323524 docs: delete 'rootPath' in cephfs storageclass yaml
The pre-provisioned volume or static-PV support in cephfs-csi has changed.
Delete 'rootPath' field which is no longer used

Signed-off-by: Jinhong Kim <hookak25@gmail.com>
2021-02-19 07:13:34 +00:00
Taeuk Kim c0c4d41b47 ceph: correct fs yaml fields
Some MDS fields such as placement, resource belong to mirroring currently.
It corrects the fields location.

Signed-off-by: Taeuk Kim <taeuk_kim@tmax.co.kr>
2021-02-19 01:28:03 +00:00
Travis Nielsen 42c06e48c4 Merge pull request #7256 from travisn/osd-topology-affinity
ceph: Enforce portable OSDs in same topology as osd prepare job
2021-02-18 17:06:49 -07:00
Travis Nielsen 291bf9e061 ceph: enforce portable osds in same topology as osd prepare job
The osd prepare job detects the failure domain for the OSD by querying
the node topology labels. This topology is then assigned to the OSD
daemon in the CRUSH map. Previously, the affinity was required to be
set in the cluster CR, but it was very difficult to get right. Now the
operator will enforce the correct topology label on the OSD daemon
nodeAffinity by setting the label of the lowest topology in the hierarcy.

For example, if there are region, zone, and rack labels, the rack label
would be used to set the node affinity for the OSD daemon. If an
OSD prepare job is run in rack1, the corresponding OSD daemon will
have node affinity to rack1 to ensure the same topology. Previously,
the OSD could have ended up in rack2 unless the storageClassDeviceSet
placement was very carefully crafted.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-02-18 12:49:37 -07:00
Blaine Gardner 5b9603a763 Merge pull request #6975 from BlaineEXE/design-doc-update-osds-in-parallel
design: add design to update ceph osds in parallel
2021-02-18 12:32:11 -07:00
Blaine Gardner 2c624df7ff docs: add design to update ceph osds in parallel
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-02-18 09:58:08 -07:00
Sébastien Han f8ce9df5e3 Merge pull request #7001 from crombus/master
ceph: Add ceph archive cmd in osd removal
2021-02-18 17:09:52 +01:00
crombus 76ed166e86 ceph: add ceph archive cmd in osd removal
Add ceph archive cmd in osd removal for
Silencing the warning when osd is removed.

Signed-off-by: crombus <pkundra@redhat.com>
2021-02-18 21:08:16 +05:30
Sébastien Han 42c6825d7f Merge pull request #7257 from travisn/relative-links-include
docs: Include doc script for referencing github branches
2021-02-18 14:11:52 +01:00
Travis Nielsen 99ffc4f5bf docs: include doc script for referencing github branches
The links from the documentation to github need to use the
branch name in order to point to the correct path. The docs
should reference a common script that will parse the branch
name instead of copying the script contents to all the docs.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-02-17 19:59:30 -07:00
Sébastien Han 86de4f6fb3 Merge pull request #7238 from varshar16/rados-namespace-optional
ceph: rados pool namespace is optional for nfs deployments
2021-02-17 11:40:06 +01:00
Sébastien Han 5f170bcfd2 Merge pull request #7248 from cybozu-go/ceph-fix-typos-in-ob-doc
ceph: fix typos in ob doc
2021-02-17 11:12:20 +01:00
Sébastien Han 4d4a5d2017 Merge pull request #7239 from leseb/bz-1894412
ceph: revert fail if mgr prometheus is not default
2021-02-17 10:29:50 +01:00
Travis Nielsen 99450276f6 Merge pull request #7247 from subhamkrai/osd-placement
ceph: update placement in osd with osdProps.placement
2021-02-16 21:44:00 -07:00
Travis Nielsen e130261156 Merge pull request #7249 from subhamkrai/helm-csi
ceph: helm update variable enableCephFSSnapshotter
2021-02-16 21:37:19 -07:00
subhamkrai 93309bc492 ceph: helm update variable enableCephFSSnapshotter
this commit removes the casing error in helm.
`enableCephFSSnapshotter` in `values.yaml` does not
match the casing `enableCephfsSnapshotter` in `deployment.yaml`.

Signed-off-by: subhamkrai <srai@redhat.com>
2021-02-17 08:30:27 +05:30
Satoru Takeuchi 70a5d15560 ceph: fix typos in ob doc
`phase` field name is not capitalized and its values are capitalized.
Here is an example.

```
apiVersion: objectbucket.io/v1alpha1
kind: ObjectBucketClaim
...
status:
  phase: Pending
```

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2021-02-17 02:45:16 +00:00
subhamkrai b20a7f13ee ceph: update placement in osd with osdProps.placement
this commit update `osdProps.placement` instead
of `osdProps.getPreparePlacement()` in the osd.go
this was the copy paste issues coming from other pr.

Signed-off-by: subhamkrai <srai@redhat.com>
2021-02-17 07:35:18 +05:30
Blaine Gardner 57f1ff7136 Merge pull request #7234 from travisn/cleanup-tolerations
ceph: Add tolerations for all daemons to the cleanup job
2021-02-16 17:49:26 -07:00