feedc0de/my-rook-config
1
0 Fork 0
forked from rook/rook
Code Pull Requests Activity
13,922 Commits 38 Branches 289 Tags
457d0657ef687e4e8938056417f4ce8312eefda5
Commit Graph
13922 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Joshua Hoblitt 457d0657ef Merge pull request #17837 from jhoblitt/docs-fix-typos 
docs: fix typos and grammar in documentation and design docs
 2026-06-29 12:04:43 -07:00
Joshua Hoblitt 993be34a24 Merge pull request #17834 from jhoblitt/docs/fix-stale-doc-comment-names 
docs: fix function comments to match their declaration names
 2026-06-29 12:04:25 -07:00
Blaine Gardner 485529056d Merge pull request #17764 from subhamkrai/mute-ceph-errors 
core: add api changes to mute ceph warnings
 2026-06-29 09:50:13 -06:00
subham rai 97f033ae4c Merge pull request #17845 from rook/dependabot/go_modules/github-dependencies-c2d6a278da 
build(deps): bump github.com/aws/smithy-go from 1.27.2 to 1.27.3 in the github-dependencies group
 2026-06-29 21:00:09 +05:30
subham rai 54188cea75 Merge pull request #17846 from rook/dependabot/github_actions/actions/checkout-7.0.0 
build(deps): bump actions/checkout from 6.0.3 to 7.0.0
 2026-06-29 20:59:37 +05:30
subham rai 7e25667488 Merge pull request #17844 from rook/dependabot/github_actions/actions/setup-go-6.5.0 
build(deps): bump actions/setup-go from 6.4.0 to 6.5.0
 2026-06-29 20:59:09 +05:30
subham rai 93be2032a8 Merge pull request #17843 from rook/dependabot/github_actions/aws-actions/configure-aws-credentials-6.2.1 
build(deps): bump aws-actions/configure-aws-credentials from 6.2.0 to 6.2.1
 2026-06-29 20:58:53 +05:30
subham rai 2bdd63bef1 Merge pull request #17842 from rook/dependabot/github_actions/actions/setup-python-6.3.0 
build(deps): bump actions/setup-python from 6.2.0 to 6.3.0
 2026-06-29 20:58:24 +05:30
subham rai 8f15aeb06e Merge pull request #17841 from rook/dependabot/github_actions/azure/setup-helm-5.0.1 
build(deps): bump azure/setup-helm from 5.0.0 to 5.0.1
 2026-06-29 20:58:00 +05:30
Travis Nielsen af7cd44554 Merge pull request #17825 from taraasrita10/remove-v-prefix-helm 
build: remove v prefix from helm chart version tag
 2026-06-29 07:39:17 -06:00
dependabot[bot] e5a1b6f2af build(deps): bump actions/checkout from 6.0.3 to 7.0.0 
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.3 to 7.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v6.0.3...9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-06-29 12:43:12 +00:00
dependabot[bot] c64e860cda build(deps): bump github.com/aws/smithy-go 
Bumps the github-dependencies group with 1 update: [github.com/aws/smithy-go](https://github.com/aws/smithy-go).


Updates `github.com/aws/smithy-go` from 1.27.2 to 1.27.3
- [Release notes](https://github.com/aws/smithy-go/releases)
- [Changelog](https://github.com/aws/smithy-go/blob/main/CHANGELOG.md)
- [Commits](https://github.com/aws/smithy-go/compare/v1.27.2...v1.27.3)

---
updated-dependencies:
- dependency-name: github.com/aws/smithy-go
  dependency-version: 1.27.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-06-29 12:43:05 +00:00
dependabot[bot] 1154e920a3 build(deps): bump actions/setup-go from 6.4.0 to 6.5.0 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 6.4.0 to 6.5.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/4a3601121dd01d1626a1e23e37211e3254c1c06c...924ae3a1cded613372ab5595356fb5720e22ba16)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-version: 6.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-06-29 12:42:49 +00:00
dependabot[bot] 1eb1bd1f7b build(deps): bump aws-actions/configure-aws-credentials 
Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 6.2.0 to 6.2.1.
- [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases)
- [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md)
- [Commits](https://github.com/aws-actions/configure-aws-credentials/compare/e7f100cf4c008499ea8adda475de1042d6975c7b...254c19bd240aabef8777f48595e9d2d7b972184b)

---
updated-dependencies:
- dependency-name: aws-actions/configure-aws-credentials
  dependency-version: 6.2.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-06-29 12:42:41 +00:00
dependabot[bot] 27b3e28a52 build(deps): bump actions/setup-python from 6.2.0 to 6.3.0 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6.2.0 to 6.3.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/a309ff8b426b58ec0e2a45f0f869d46889d02405...ece7cb06caefa5fff74198d8649806c4678c61a1)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 6.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-06-29 12:42:36 +00:00
dependabot[bot] 5ca11334ab build(deps): bump azure/setup-helm from 5.0.0 to 5.0.1 
Bumps [azure/setup-helm](https://github.com/azure/setup-helm) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/azure/setup-helm/releases)
- [Changelog](https://github.com/Azure/setup-helm/blob/main/CHANGELOG.md)
- [Commits](https://github.com/azure/setup-helm/compare/dda3372f752e03dde6b3237bc9431cdc2f7a02a2...9bc31f4ebc9c6b171d7bfbaa5d006ae7abdb4310)

---
updated-dependencies:
- dependency-name: azure/setup-helm
  dependency-version: 5.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-06-29 12:42:31 +00:00
Prabhala Tara Aasrita f699960a31 build: remove v prefix from helm chart version tag 
Removed the leading v from the Helm OCI chart version tag so that helm pull can auto-resolve the latest version without specifying the tag explicitly.

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
 2026-06-29 11:25:14 +05:30
Joshua Hoblitt d395d1916b docs: fix typos and grammar in documentation and design docs 
Correct duplicate words, incorrect articles, subject/verb agreement, and
other small grammar mistakes across the user-facing Documentation/ pages
and the design/ records. No content or behavior changes.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2026-06-26 13:40:03 -07:00
Joshua Hoblitt 49612461a4 docs: fix function comments to match their declaration names 
Several godoc comments led with a stale or incorrect identifier, left
over from renames, exported/unexported changes, copy-paste between
sibling declarations, or plain typos. As a result the documented name no
longer matched the function, method, type, or var it describes. Correct
each leading word to the name of the declaration it documents.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2026-06-26 12:52:39 -07:00
Joshua Hoblitt f44af173c4 Merge pull request #17734 from jhoblitt/ci-rgw-endpoint-timeout 
ci: make canary rgw endpoint validation retry until clean
 2026-06-26 12:31:01 -07:00
Joshua Hoblitt 8d5d29c4da Merge pull request #17830 from jhoblitt/ci-build-rook-retry-capture-stderr 
ci: capture build_rook stderr so the network-retry can see it
 2026-06-26 12:27:17 -07:00
Travis Nielsen a6bc8dd853 Merge pull request #17833 from pengqima/master 
docs: fix function comment to match actual function name
 2026-06-26 11:30:50 -06:00
pengqima 240c431f42 docs: fix function comment to match actual function name 
Signed-off-by: pengqima <pengqima@outlook.com>
 2026-06-26 23:43:22 +08:00
Parth Arora 8ff563664d Merge pull request #17826 from parth-gr/external-mounts 
external: volumeattachment should be deleted during unmount
 2026-06-26 20:38:13 +05:30
parth-gr 88e31185dc external: volumeattachment should be deleted during unmount 
before the csi op, the unblish grpc call was not present,
and it has no op
But with csi op, the unpublish grpc is called before the
volumeattachment get remove, and the unpublish call need a
unpublish secret, currently it is getting the secret from the
client profile, but the client profile secret is hardcoded to default
So to override this secret we are adding the secret name in the
storageclass parameter

Signed-off-by: parth-gr <partharora1010@gmail.com>
 2026-06-26 17:55:22 +05:30
Joshua Hoblitt 04734d7150 ci: capture build_rook stderr so the network-retry can see it 
build_rook() captures the make output into $o and inspects it for
transient network errors (connection reset, INTERNAL_ERROR, 503, 500)
to decide whether to retry the build. The capture was stdout-only,
but go and make write those errors to stderr, so $o never matched any
retry case. A transient module-proxy failure (e.g. proxy.golang.org
returning INTERNAL_ERROR while downloading modules) therefore fell
through to the "valid failure" branch and failed the job in the build
step, before the integration test even ran.

Redirect stderr into the captured output (2>&1) so the existing retry
logic actually triggers on network failures.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2026-06-25 12:36:33 -07:00
Travis Nielsen 01d49c2763 Merge pull request #17821 from daixihegu/master 
core: use slices.Contains to simplify code
 2026-06-25 10:40:35 -06:00
Joshua Hoblitt c1594a82ea Merge pull request #17801 from jhoblitt/ci-loop-to-iscsi 
ci: replace loop devices with iscsi in canary osd tests
 2026-06-24 22:25:16 -07:00
daixihegu 063dcad054 core: use slices.Contains to simplify code 
Signed-off-by: daixihegu <daixihegu@163.com>
 2026-06-25 10:17:53 +08:00
Travis Nielsen d9de5b1d6f Merge pull request #17758 from kavirakesh14/fix-17285-config-override-newline 
ceph: ensure config overrides end with a trailing newline
 2026-06-24 10:48:48 -06:00
Joshua Hoblitt d0885370fa Merge pull request #17732 from jhoblitt/ci-smoke-suite-flakes 
ci: harden CephSmokeSuite against CSI cold-start and teardown flakes
 2026-06-24 08:57:25 -07:00
Joshua Hoblitt 343462981a Merge pull request #17798 from jhoblitt/ci-multisite-sync-converge 
ci: converge wedged multisite secondary before asserting sync
 2026-06-24 08:56:49 -07:00
Joshua Hoblitt 342463b488 Merge pull request #17814 from jhoblitt/test-prune-dead-test-scripts 
test: prune unused functions and orphaned scripts from tests/scripts
 2026-06-24 08:55:57 -07:00
Joshua Hoblitt 4b7d769102 ci: replace loop devices with iscsi in canary osd tests 
The raw-disk-with-object, osd-with-metadata-device, and pvc canary jobs
used loopback devices to supply an extra block device beyond the single
spare disk a GitHub runner provides. Loop devices behave differently
from real block devices -- Rook gates them behind
ROOK_CEPH_ALLOW_LOOP_DEVICES and special-cases them in the OSD daemon --
so exercising core scenarios on them is less realistic than using real
SCSI disks.

Provision the extra device(s) over iSCSI (LIO) instead, reusing the
existing create_extra_disk helper: it now creates N LUNs, the new
find_extra_block_devs and find_second_block_dev helpers enumerate them,
and deploy_cluster gains a two_raw_disks mode. The three jobs now run
entirely on real disks, and the canary CI no longer creates loop devices
or relies on the loop-device test helpers.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2026-06-24 08:54:54 -07:00
subhamkrai 9a6c5842bc core: implement ceph health warning mute 
this commit implement api to configure
ceph health warning mute/unmute.

Signed-off-by: subhamkrai <srai@redhat.com>
 2026-06-24 21:10:54 +05:30
subham rai 72110d767c Merge pull request #17676 from rook/dependabot/go_modules/k8s-dependencies-6f6fdbcc47 
build(deps): bump the k8s-dependencies group across 1 directory with 7 updates
 2026-06-24 16:50:03 +05:30
dependabot[bot] 4f5541f8c6 build(deps): bump the k8s-dependencies group across 1 directory with 7 updates 
Bumps the k8s-dependencies group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.35.4` | `0.36.2` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.35.4` | `0.36.2` |
| [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) | `0.35.4` | `0.36.2` |
| [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.23.3` | `0.24.1` |
| [sigs.k8s.io/mcs-api](https://github.com/kubernetes-sigs/mcs-api) | `0.4.1` | `0.5.0` |

Updates `k8s.io/apiextensions-apiserver` from 0.35.4 to 0.36.2
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.35.4...v0.36.2)

Updates `k8s.io/apimachinery` from 0.35.4 to 0.36.2
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.35.4...v0.36.2)

Updates `k8s.io/cli-runtime` from 0.35.4 to 0.36.2
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.35.4...v0.36.2)

Updates `k8s.io/client-go` from 0.35.4 to 0.36.2
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.35.4...v0.36.2)

Updates `k8s.io/cloud-provider` from 0.35.4 to 0.36.2
- [Commits](https://github.com/kubernetes/cloud-provider/compare/v0.35.4...v0.36.2)

Updates `sigs.k8s.io/controller-runtime` from 0.23.3 to 0.24.1
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.23.3...v0.24.1)

Updates `sigs.k8s.io/mcs-api` from 0.4.1 to 0.5.0
- [Release notes](https://github.com/kubernetes-sigs/mcs-api/releases)
- [Changelog](https://github.com/kubernetes-sigs/mcs-api/blob/master/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/mcs-api/compare/v0.4.1...v0.5.0)

---
updated-dependencies:
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-version: 0.36.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-version: 0.36.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-version: 0.36.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-version: 0.36.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cloud-provider
  dependency-version: 0.36.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-version: 0.24.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/mcs-api
  dependency-version: 0.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: subhamkrai <srai@redhat.com>
 2026-06-24 16:10:50 +05:30
kavirakesh14 619b800b67 operator: fail reconcile if rook-config-override lacks trailing newline 
Signed-off-by: kavirakesh14 <kavirakesh007@gmail.com>
 2026-06-24 09:56:41 +00:00
Travis Nielsen a7f0a13e69 Merge pull request #17812 from travisn/skip-startup-node-watch 
core: Skip node watcher during initial cache sync
 2026-06-23 17:33:59 -06:00
Joshua Hoblitt 335e840079 test: remove orphaned legacy multi-node and kubeadm scripts 
These shell scripts under tests/scripts are referenced nowhere in the
repository -- no workflow, Makefile, Go test, documentation, or
.mergify.yml invokes them:

- tests/scripts/multi-node/ (build-rook.sh, rpm-system-prerequisites.sh,
  config.rb): the abandoned Vagrant multi-node VM harness, pinned to the
  long-EOL centos/7 box.
- tests/scripts/kubeadm-install.sh: an old kubeadm/apt installer for a
  pinned Kubernetes version, no longer wired into any test path.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2026-06-23 15:37:11 -07:00
Joshua Hoblitt 6f1e7a7dd5 test: remove unused functions from tests/scripts helpers 
Three shell functions defined under tests/scripts are never invoked --
not internally, not from another script, and not dispatched by name from
any CI workflow:

- deploy_csi_hostnetwork_disabled_cluster (github-action-helper.sh)
- wait_for_ceph_csi_configmap_to_be_updated (github-action-helper.sh)
- test_demo_pool (validate_cluster.sh): the daemon validation loop never
  passes a "pool" daemon, so this branch is unreachable.

Removing them orphans no other helpers; each only called functions that
remain in use elsewhere.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2026-06-23 15:36:51 -07:00
Joshua Hoblitt 799a101446 Merge pull request #17808 from jhoblitt/test-remove-mgr-suite 
test: remove CephMgrSuite integration test and CI workflow
 2026-06-23 14:29:31 -07:00
Joshua Hoblitt 1c8ec71edb test: remove CephMgrSuite integration test and CI workflow 
CephMgrSuite (ceph_mgr_test.go) exercised the Rook orchestrator mgr
module through `ceph orch` commands. Remove the suite together with its
GitHub Actions workflow (integration-test-mgr-suite.yaml), whose sole
purpose was to run this suite, gated behind the run-mgr-suite label and
a nightly cron.

No other code references the deleted suite. Its helpers (logBytesInfo,
the defaultTries constant, and the host/service/serviceStatus types)
were all local to the file, so nothing is left orphaned.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2026-06-23 13:14:17 -07:00
Travis Nielsen 7803fac10d core: skip node watcher during initial cache sync 
When the operator starts, there is no need to handle the
node watcher immediately while the controller runtime
cache is being initialized. The cluster will anyway be
fully reconciled and create new OSDs if needed. The node
watcher is only intended for triggering a reconcile when
a node is added or updated at a later time after a sync
would anyway be triggered.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2026-06-23 13:39:49 -06:00
Joshua Hoblitt 7593f2db18 Merge pull request #17749 from jhoblitt/ci-canary-unique-artifact-names 
ci: include kubernetes version in canary artifact names
 2026-06-23 11:22:13 -07:00
Joshua Hoblitt dec475914e Merge pull request #17744 from jhoblitt/keystone-webhook-eventually 
test: add Eventually polling helper for test setup waits
 2026-06-23 10:39:46 -07:00
Joshua Hoblitt 924b421e4b Merge pull request #17752 from jhoblitt/ci-add-actionlint 
ci: lint GitHub Actions workflows with actionlint
 2026-06-23 10:20:31 -07:00
Joshua Hoblitt 0ec0816035 Merge pull request #17751 from jhoblitt/ci-canary-require-ceph-images 
ci: require explicit ceph_images input for canary workflow
 2026-06-23 09:31:55 -07:00
Travis Nielsen 33cbe3ddda Merge pull request #17794 from rook/dependabot/go_modules/github-dependencies-77d13303f7 
build(deps): bump the github-dependencies group with 4 updates and require Go 1.26
 2026-06-23 10:31:08 -06:00
Parth Arora 451c3f3d1b Merge pull request #17805 from parth-gr/drbd-mons 
core: reduce the floating mon reschdule time
 2026-06-23 20:55:48 +05:30