Commit Graph
13854 Commits
Author SHA1 Message Date
Joshua Hoblitt 459c4bebe9 external: add timeout to rgw admin ops api request
The rgw endpoint validation issued an HTTP request to the admin ops
api without a timeout. If the RGW is accepting connections but slow to
respond, for example right after the object store was created, the
script hangs indefinitely instead of reporting a validation error that
the caller could retry on.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2026-06-22 16:41:32 -07:00
Satoru Takeuchi a8398f9996 Merge pull request #17724 from jhoblitt/osd-activate-skip-rbd-scan
osd: do not scan rbd devices in raw activate fallback
2026-06-23 07:44:02 +09:00
Joshua Hoblitt aab850f2f5 Merge pull request #17750 from jhoblitt/ci-canary-drop-redundant-shell
ci: drop redundant per-step shell overrides in canary tests
2026-06-22 13:18:17 -07:00
Joshua Hoblitt 35a85b8c5e Merge pull request #17748 from jhoblitt/ci-drop-ignored-github-token
ci: drop ignored github-token inputs from composite action calls
2026-06-22 13:17:02 -07:00
Joshua Hoblitt 6a67e4fbaf ci: drop ignored github-token inputs from composite action calls
Several callers pass a github-token input to composite actions that do not declare it, so it is silently ignored and emits a runner warning at run time. The integration-test-setup-cluster-resources action (called from the nightly jobs and the keystone-auth suite) and the encryption-pvc-kms-ibm-kp action (called from the canary suite) declare only their real inputs. Remove the dead github-token from every such call. If a token is ever needed it should be declared and consumed by the action itself.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2026-06-22 12:41:36 -07:00
Joshua Hoblitt 990947a597 ci: drop redundant per-step shell overrides in canary tests
The workflow already sets defaults.run.shell, yet several steps in the rgw-multisite-testing and two-object-one-zone jobs re-declare the identical shell. Remove the per-step overrides; the workflow default already applies to every run step.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2026-06-22 12:12:27 -07:00
Joshua Hoblitt e6cd104ebe Merge pull request #17795 from obnoxxx/build-add-target-lint.workflows
build: add a  target lint.workflows
2026-06-22 11:00:48 -07:00
Michael Adam 6dd6a23286 build: add a lint.workflows target
This adds a Makefile target lint.workflows that checks
the github workflow yaml files with the
actionlint tool.

Signed-off-by: Michael Adam <obnox@samba.org>
2026-06-22 19:19:57 +02:00
Joshua Hoblitt da07f0c476 osd: do not scan rbd devices in raw activate fallback
When the OSD activate init container cannot match its configured
device, it falls back to a bare 'ceph-volume raw list', which
enumerates every block device on the node and opens each one to read
bluestore labels. Opening a krbd device whose backing cluster is
unhealthy can block in uninterruptible sleep; when that device's I/O
depends on the OSD being activated, activation deadlocks.

Build the fallback scan list explicitly with lsblk and exclude the
network-backed device types that can hang when their backing storage
is unavailable (rbd, nbd, drbd) along with zram (volatile RAM). Rook
never provisions OSDs on any of these, so the fallback can never
legitimately need to find an OSD on them. loop devices are kept,
since OSDs on loop devices are supported for CI and local testing.
Fail fast if the filtered list is empty rather than degenerating back
to a full scan.

Note this hardens only the rename-fallback path. The deadlock observed
in CI (kernel hung tasks under 'ceph-volume raw activate' opening a
stalled /dev/rbd0; actions runs 27325963851, 27333888237, and
27378983111, which reproduced it on this PR's own head) ultimately
originates inside ceph-volume: 'raw activate' runs an unconditional
LUKS2/TPM2 discovery sweep over all block devices even when given an
explicit --device. That requires a ceph-volume fix; this change makes
the Rook-controlled scan safe regardless of ceph version.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2026-06-22 10:00:58 -07:00
Travis Nielsen 63eed4ed47 Merge pull request #17279 from sophotechlabs/test/osd-config-store
test: add unit tests for OSD store config parsing
2026-06-19 08:12:00 -06:00
Travis Nielsen 2c6c7ac5a8 Merge pull request #17782 from obnoxxx/ci-mergify-k8s-v1.35.5
CI: require k8s v1.35.5 tests to pass in mergify for  release-1.20 and release-1.19
2026-06-19 07:58:58 -06:00
Travis Nielsen f77e54dce5 Merge pull request #17492 from cobaltcore-dev/osd-replacement-design-doc
Osd replacement design doc
2026-06-18 12:20:27 -06:00
Michael Adam 9a518a134f ci: require k8s v1.35.5 tests to pass in mergify for 1.20
Integration tests in the CI were recently updated to test on
the latest patch release for kkubernettes  1.35, i. e. v1.35.5.

This change updates the mergify config for the 1.20 release branch
to require these checs on k8s v1.35.5 to succeed.

Signed-off-by: Michael Adam <obnox@samba.org>
2026-06-18 19:29:34 +02:00
Travis Nielsen 5e5af3c75b Merge pull request #17779 from obnoxxx/ci-canary-test-k8s-1.35.5
CI: test latest k8s 1.35 patch release in the canary integration test
2026-06-18 09:06:32 -06:00
Travis Nielsen 5c9bed96f6 Merge pull request #17777 from s3onghyun/docs-fix-dupword
docs: fix duplicated word in external-cluster consumer import
2026-06-18 09:06:04 -06:00
Michael Adam b6ce3e2633 ci: test latest k8s 1.35 patch release in the canary integration test
It is intended that the CI test the latest patch release of each
kubernetes version that is tested.

The canary integration test tested v1.35.0 however, while
the latest v1.35 patch releaase is v1.35.5.

This change updates the integration-test CI workflow
to test k8s v1.35.5 instead of v1.35.0 to match the intention.

Signed-off-by: Michael Adam <obnox@samba.org>
2026-06-18 16:28:14 +02:00
Artem Torubarov 48dc9be5a7 docs: osd replacement design doc
Signed-off-by: Artem Torubarov <artem.torubarov@sap.com>
2026-06-18 12:17:35 +02:00
s3onghyun 28fbc23aee docs: fix duplicated word in external-cluster consumer import
Signed-off-by: s3onghyun <s3onghyun.hong@gmail.com>
2026-06-18 17:52:47 +09:00
Travis Nielsen dc50bce4e6 Merge pull request #17559 from OdedViner/network_policy_upstream
security: add example NetworkPolicy CRs for Ceph operand pods
2026-06-17 12:54:24 -06:00
Travis Nielsen 2c0ed0d9db Merge pull request #17774 from subhamkrai/update-ceph-to-20.2.2
build: update ceph version to latest v20.2.2
2026-06-17 11:00:56 -06:00
subhamkrai ad26ebdab0 build: update ceph version to latest v20.2.2
updating the ceph version from v20.2.1 to v20.2.2

Signed-off-by: subhamkrai <srai@redhat.com>
2026-06-17 22:00:11 +05:30
Santosh Pillai 6feb856a9f Merge pull request #17670 from jhoblitt/maint-remove-dead-lockingbool
operator: remove dead code from the operator tree
2026-06-17 15:05:49 +05:30
Travis Nielsen ecadb76e6f Merge pull request #17710 from jhoblitt/object-realm-key-urlsafe
object: generate URL-safe realm access keys
2026-06-16 15:16:22 -06:00
Travis Nielsen 393cb7a25a Merge pull request #17711 from jhoblitt/ci-rgw-multisite-deterministic
ci: make rgw-multisite-testing wait for multisite readiness
2026-06-16 15:15:33 -06:00
Travis Nielsen 72dde3db1d Merge pull request #17712 from jhoblitt/ci-multus-setup-flakes
ci: fix multus integration test setup flakes
2026-06-16 15:14:45 -06:00
Travis Nielsen 923302d7e7 Merge pull request #17714 from jhoblitt/ci-upgrade-suite-flakes
ci: reduce CephUpgradeSuite flakes
2026-06-16 15:14:03 -06:00
Travis Nielsen 6dbdd1d517 Merge pull request #17722 from jhoblitt/ci-validate-cluster-toolbox
ci: fix toolbox exec race in validate_cluster.sh
2026-06-16 15:12:17 -06:00
Travis Nielsen 030626726d Merge pull request #17760 from sp98/udev-as-prerequiste
doc: update prerequisite to use udev
2026-06-16 10:25:37 -06:00
Travis Nielsen 16ac936fc6 Merge pull request #17743 from jhoblitt/ci-remove-enablecsioperator
ci: remove unused EnableCsiOperator test setting
2026-06-16 10:21:45 -06:00
Oded Viner 9dc70051a8 security: add example NetworkPolicy CRs for Ceph operand pods
Add a single example YAML with NetworkPolicy definitions
for all Ceph operand pods (mon, osd, mgr, mds, exporter,
osd-prepare, crashcollector, tools).
Users can apply these policies to restrict egress/ingress
traffic for Rook-Ceph daemon pods.

Signed-off-by: Oded Viner <oviner@redhat.com>
2026-06-16 17:44:34 +03:00
Travis Nielsen bb4fb438c4 Merge pull request #17742 from obnoxxx/ci-k8s-versions-prep-v1.36
CI: test k8s v1.34 instead of v1.33 for  rook releases
2026-06-16 07:42:41 -06:00
subham rai 5be5cd8f6a Merge pull request #17759 from rook/dependabot/go_modules/github-dependencies-8270579e47
build(deps): bump the github-dependencies group with 7 updates
2026-06-16 15:28:28 +05:30
Michael Adam fbbbf6f8ee ci: testk8s v1.34 instead of v1.33 for releases
Rook supports six versions of kubernetes but we only want to spend CI
resources for testing four of them.

In order to align with this commitment, this change lets rook run
integration test suites on kubernetes v1.34 instead of v1.33 for release
testing.

As a result, the latest patch releases of kubernetes v1.31, v1.32,
v1.34, and v1.35 are tested for rook releases.

In addition, k8s version specification is made more systematic to
use the pattern  v1.3X.Y instead of 1.3X.Y.

Signed-off-by: Michael Adam <obnox@samba.org>
2026-06-15 21:37:29 +02:00
Santosh 28c84a2209 doc: update prerequisite to use udev
Updated the prerequisite guide to ensure udev is installed on the rook
ceph cluster.

Signed-off-by: Santosh <sapillai@redhat.com>
2026-06-15 19:40:15 +05:30
dependabot[bot] b85e01a4e5 build(deps): bump the github-dependencies group with 7 updates
Bumps the github-dependencies group with 7 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/IBM/keyprotect-go-client](https://github.com/IBM/keyprotect-go-client) | `0.16.0` | `0.17.2` |
| [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) | `1.41.12` | `1.42.0` |
| [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.32.23` | `1.32.25` |
| [github.com/aws/aws-sdk-go-v2/credentials](https://github.com/aws/aws-sdk-go-v2) | `1.19.22` | `1.19.24` |
| [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) | `1.103.2` | `1.103.3` |
| [github.com/aws/aws-sdk-go-v2/service/sns](https://github.com/aws/aws-sdk-go-v2) | `1.40.0` | `1.40.1` |
| [github.com/aws/smithy-go](https://github.com/aws/smithy-go) | `1.27.1` | `1.27.2` |


Updates `github.com/IBM/keyprotect-go-client` from 0.16.0 to 0.17.2
- [Release notes](https://github.com/IBM/keyprotect-go-client/releases)
- [Changelog](https://github.com/IBM/keyprotect-go-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/IBM/keyprotect-go-client/compare/v0.16.0...v0.17.2)

Updates `github.com/aws/aws-sdk-go-v2` from 1.41.12 to 1.42.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/v1.41.12...v1.42.0)

Updates `github.com/aws/aws-sdk-go-v2/config` from 1.32.23 to 1.32.25
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/config/v1.32.23...config/v1.32.25)

Updates `github.com/aws/aws-sdk-go-v2/credentials` from 1.19.22 to 1.19.24
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/credentials/v1.19.22...credentials/v1.19.24)

Updates `github.com/aws/aws-sdk-go-v2/service/s3` from 1.103.2 to 1.103.3
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/service/s3/v1.103.2...service/s3/v1.103.3)

Updates `github.com/aws/aws-sdk-go-v2/service/sns` from 1.40.0 to 1.40.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/v1.40.0...v1.40.1)

Updates `github.com/aws/smithy-go` from 1.27.1 to 1.27.2
- [Release notes](https://github.com/aws/smithy-go/releases)
- [Changelog](https://github.com/aws/smithy-go/blob/main/CHANGELOG.md)
- [Commits](https://github.com/aws/smithy-go/compare/v1.27.1...v1.27.2)

---
updated-dependencies:
- dependency-name: github.com/IBM/keyprotect-go-client
  dependency-version: 0.17.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-version: 1.42.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-version: 1.32.25
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/credentials
  dependency-version: 1.19.24
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/s3
  dependency-version: 1.103.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/sns
  dependency-version: 1.40.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/smithy-go
  dependency-version: 1.27.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-15 12:49:39 +00:00
Parth Arora 31236a51e5 Merge pull request #17628 from parth-gr/drbd-upstream
core: add a install guide for tnf
2026-06-15 15:42:09 +05:30
Joshua Hoblitt 95132446f7 Merge pull request #17708 from jhoblitt/single-rgw-instance-only
test: run object suite store with a single rgw instance
2026-06-12 12:05:41 -07:00
Joshua Hoblitt faa2fb684b ci: remove unused EnableCsiOperator test setting
The CSI operator is installed unconditionally by the integration test
installer, so the EnableCsiOperator setting no longer selects between
CSI management modes and is consumed nowhere in the test framework.
Remove the setting and the three suites' usages of it.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2026-06-12 11:32:05 -07:00
Joshua Hoblitt 4597f437ce Merge pull request #17730 from jhoblitt/maint-remove-dead-test-framework-files
tests: remove unused test framework helpers
2026-06-12 09:11:01 -07:00
Joshua Hoblitt b1bbfb4bba Merge pull request #17726 from jhoblitt/maint-remove-dead-k8sutil-sweep
k8sutil: remove unused helper functions
2026-06-12 09:10:32 -07:00
Blaine Gardner 3d9e868741 Merge pull request #17727 from jhoblitt/maint-remove-dead-cephclient-funcs
core: remove dead code from pkg/daemon and pkg/util
2026-06-12 10:04:24 -06:00
Travis Nielsen a67a76755c Merge pull request #17736 from obnoxxx/readme-add-license-badge
add a license badge to the README
2026-06-12 08:50:03 -06:00
Michael AdamandCopilot Autofix powered by AI 8db775bb67 docs: add a license badge
This adds a license badge to the list of badges at the top of the README.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Michael Adam <obnox@samba.org>
2026-06-12 16:44:57 +02:00
parth-gr 8171c3ed3b core: add a install guide for tnf
add a install guide for tnf
1) Add a drbd install script
2) add a drbd instal doc

assisted-by: anthropic-ai/claude-code

Signed-off-by: parth-gr <partharora1010@gmail.com>
2026-06-12 17:22:43 +05:30
subham rai 702855df6b Merge pull request #17718 from subhamkrai/bump-golang-x-crypto
build: bump golang.org/x/crypto to v0.52.0
2026-06-12 12:51:44 +05:30
Travis Nielsen 9df1190a79 Merge pull request #17699 from jhoblitt/mergify-require-objectsuite-tls
ci: require TestCephObjectSuiteTLS checks for release-1.20 automerge
2026-06-11 17:09:09 -06:00
Joshua Hoblitt b30ba09bda operator: remove unused AddCephVersionLabelToDaemonSet
AddCephVersionLabelToDaemonSet had no callers anywhere in the repo
(verified with deadcode and repo-wide grep); rook applies ceph version
labels to Deployments, Jobs, and object metas, but never to DaemonSets.
The shared addCephVersionLabel helper remains in use by the live
siblings.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2026-06-11 15:44:18 -07:00
Joshua Hoblitt 23f4f50bdb csi: remove unused NFSDriverName variable
NFSDriverName was assigned once in the CSI controller reconcile but never
read anywhere in the repo (verified with repo-wide grep and an
exported-symbol audit). Remove the variable, its assignment, and the
nfsDriverSuffix const that only existed to feed it.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2026-06-11 15:44:18 -07:00
Joshua Hoblitt c4f8831a4d tests: remove unused k8s helper functions
The package-level VersionAtLeast function had no callers anywhere in the
repo (the K8sHelper.VersionAtLeast method remains in use), and
IsKubectlErrorNotFound's only caller was provisioners.go, which is
deleted in this PR. Verified with deadcode and repo-wide grep.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2026-06-11 15:42:39 -07:00
Joshua Hoblitt ef9761d4df core: remove unused OSDPerfStats type
The OSDPerfStats struct had no references anywhere in the repo (verified
with repo-wide grep and an exported-symbol audit); the code that consumed
this unmarshal target was removed long ago.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2026-06-11 15:40:49 -07:00