Commit Graph
4068 Commits
Author SHA1 Message Date
Travis Nielsen 577ebc6ee7 Merge pull request #4390 from Madhu-1/cephfs-kernel-flag
CSI: Add ENV variable to use ceph kernel client
2019-12-16 14:28:37 -07:00
Travis Nielsen 804e41132d ceph: force enable the cephfs kernel driver by default
There are two issues at odds with the cephfs driver. The
first is that older kernels less than 4.17 do not support
quotas so PVC sizes will not be enforced with the kernel
driver in that case. If the FUSE client is used instead, there
are issues during upgrade because the client mount will be
disrupted and the client pods will have to restart.

To prevent client pods from breaking during upgrade, we enable
the kernel driver by default. If the quotas are critical,
the admin will need to take steps during upgrade to prevent
breaking the applications.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2019-12-16 13:04:16 -07:00
Madhu Rajanna 85d622dc2f CSI: Add ENV variable to use ceph kernel client
In ceph-csi v1.2.2 we have add a flag `forcecephkernelclient`
to force use Ceph Kernel clients on kernel < 4.17 which
support quotas for Cephfs

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2019-12-16 12:36:31 -07:00
Blaine Gardner 02afa746bf Merge pull request #4491 from travisn/upgrade-testing
Clarifications to v1.2 upgrade guide
2019-12-16 11:37:37 -07:00
Travis Nielsen 32a69b8afc ceph: clarifications to v1.2 upgrade guide
Removed some obsolete instructions from the 1.1 upgrade
and made a few minor fixes to make the upgrade to 1.2 smoother.
With the addition of the CephClient CRD, the CRD needs to be
created before the upgrade or else the operator log will be
filled with errors until it is created. The CSI driver also
had an error when registering after the upgrade due to an RBAC
change.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2019-12-16 11:31:52 -07:00
Sébastien Han 9b6ad00f4d Merge pull request #4308 from leseb/storage-class-io-tuning
ceph: add CR flag to tune slow device class for OSD on PVC in the Cloud
2019-12-16 17:45:01 +01:00
Sébastien Han 0a1d700927 ceph: osd tune startup flags when running on GP2
gp2 devices present themselves as SSDs,
but have much more variable performance.
Ceph attempts to adjust some settings based on the drive type,
HDD/SSD
In this case client I/O can be impacted too much by assuming gp2 devices are like other SSDs
(an example is https://bugzilla.redhat.com/show_bug.cgi?id=1765923#c6)

In order to prevent this, rook can set the following for OSDs
if the new CR setting `tuneSlowDeviceClass` is set to `true`:

```
osd_recovery_sleep = 0.1
osd_snap_trim_sleep = 2
osd_delete_sleep = 2
```

Closes: https://github.com/rook/rook/issues/4298 and https://bugzilla.redhat.com/show_bug.cgi?id=1771047
Signed-off-by: Sébastien Han <seb@redhat.com>
2019-12-16 16:37:02 +01:00
Dmitry Yusupov 1fd1938234 Merge pull request #4505 from dyusupov/master
EdgeFS documentation corrections and 1.2 release notes
2019-12-13 17:22:48 -08:00
Travis Nielsen e46b71f25e Merge pull request #4504 from travisn/no-block-owner-ref
Set discover ownerrefs without blocking parent deletion
2019-12-13 17:24:06 -07:00
Dmitry Yusupov f87fff972f Merge pull request #4501 from sabbot/restapi-local-repo
edgefs: Fix restapi image selection
2019-12-13 15:39:37 -08:00
Dmitry Yusupov ad93098a33 EdgeFS documentation corrections and 1.2 release notes
Signed-off-by: Dmitry Yusupov <dmitry@nexenta.com>
2019-12-13 15:35:30 -08:00
Travis Nielsen 5d24710fd2 ceph: set discover ownerrefs without blocking parent deletion
An owner reference cannot be set with BlockOwnerDeletion: true
if the operator does not have privs to add a finalizer to the parent.
The discover resources don't need to block deletion based on the
parent so we remove that property from the owner reference.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2019-12-13 15:22:21 -07:00
Anton Skriptsov 1d7c26f23b edgefs: Fix restapi image selection
Signed-off-by: Anton Skriptsov <sabbotagge@gmail.com>
2019-12-13 14:12:13 -08:00
Travis Nielsen 7605ccdfd9 Merge pull request #4478 from travisn/no-more-remove-osds
Document OSD removal and stop removing OSDs automatically
2019-12-13 12:19:23 -07:00
Travis Nielsen ef4d5aea88 ceph: document manual deletion of osds
Removal of OSDs is a sensitive area. If you get it wrong you could have data
loss. Now a help topic is provided for manual steps to remove OSDs when
absolutely necessary.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2019-12-13 09:09:07 -07:00
Travis Nielsen fbf3837f13 ceph: stop removing osds for any cephcluster CR update
Removing an OSD unintentionally can result in data loss,
which is to be prevented at all costs. Rook's functionality
to remove OSDs automatically when a node was removed from the
cluster CR has led on several occasions to users having OSDs
unintentionally removed from their cluster.

If the admin decides they really need to remove OSDs they should
do it as a one-time action that they intentionally run
rather than the operator attempting to manage the deletion
with desired state. The risk of misinterpreting the desired
state, even with a typo, is too great.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2019-12-13 08:26:23 -07:00
Sébastien Han 2652ae74d0 Merge pull request #4347 from swati-kale/operandForm
ceph: Metadata for creation of operand form for CephObjectStore
2019-12-13 10:23:00 +01:00
Travis Nielsen c9edcd34f0 Merge pull request #4475 from SUSE/upgrade-docs
Ceph: update upgrade docs for v1.1 -> v1.2
2019-12-12 16:41:12 -07:00
Blaine Gardner c4061f8068 Merge pull request #4469 from rohan47/add_version_check
Ceph: Added version check for ceph osd safe-to-destroy command
2019-12-12 15:14:29 -07:00
Blaine Gardner 5d0312c07d Ceph: tidy up pending release notes for v1.2
Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2019-12-12 13:58:25 -07:00
Blaine Gardner 2a250314be Ceph: update upgrade docs for v1.1 -> v1.2
Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2019-12-12 13:58:25 -07:00
Travis Nielsen 67c0b02848 Merge pull request #3078 from travisn/no-extra-release-tags
No longer generate "release" docker tag during release build promotion
2019-12-12 12:55:04 -07:00
Swati Kale 946c6e2a64 olm: Metadata for creation of operand form for CephObjectStore
Signed-off-by: Swati Kale <swkale@redhat.com>
2019-12-12 14:06:11 -05:00
Sébastien Han f01ce9804c Merge pull request #4483 from leseb/owner-ref-discover
rook: add missing owner references to the discover daemon
2019-12-12 19:46:03 +01:00
Blaine Gardner c2143045bb Merge pull request #4337 from SUSE/integration-upgrade-stabilize
ceph: integration: upgrade: long wait for mgr module - disable dashboard
2019-12-12 11:45:42 -07:00
rohan47 6dfc2c139f Ceph: Added version check for ceph osd safe-to-destroy command
It's not 100% safe since before Nautilus osd safe-to-destroy command
didn't have any json output. So added a version check.

Signed-off-by: rohan47 <rohgupta@redhat.com>
2019-12-13 00:07:39 +05:30
Travis Nielsen 1d30cce864 Merge pull request #4423 from leseb/ceph-crash-key
ceph: add crash key
2019-12-12 11:29:10 -07:00
Sébastien Han a888ed5d7c Merge pull request #4485 from anmolsachan/osd_alerts
ceph: Added OSD utilization alerts
2019-12-12 18:24:27 +01:00
Anmol Sachan 99e961f72a ceph: Added OSD utilization alerts
Signed-off-by: Anmol Sachan <anmol13694@gmail.com>
2019-12-12 22:40:26 +05:30
Sébastien Han 991c8d6e4d Merge pull request #4484 from mkogan1/rgw-healthcheck
ceph: rgw change the liveness probe url
2019-12-12 18:06:43 +01:00
Sébastien Han ed44626f6f Merge pull request #4452 from anmolsachan/utilization_alert
ceph: Improve storage utilization alert description and message.
2019-12-12 17:46:08 +01:00
Sébastien Han 2396e64525 rook: add owner reference to discover cm
Add owner reference to the discover config map so that when the
discover pod goes away we also remove its configmap.

Signed-off-by: Sébastien Han <seb@redhat.com>
2019-12-12 15:10:06 +01:00
Mark Kogan 3c807688fe ceph: rgw change the liveness probe url
to the RGWs swift objectstorage healthcheck api url [1]
which resolves an OCS false-positive CLBO of the RGW pod.

[1] https://docs.openstack.org/swift/latest/middleware.html#healthcheck

Signed-off-by: Mark Kogan <mkogan@redhat.com>
2019-12-12 12:47:11 +02:00
Sébastien Han 90b4e74457 rook: add owner reference to the discover daemon
Attach owner reference to the discover daemon set so that when the
opetator goes away, the discover pod gets removed too.

Signed-off-by: Sébastien Han <seb@redhat.com>
2019-12-12 11:07:18 +01:00
Anmol Sachan 353621452b ceph: Improve storage utilization alert description and message.
Signed-off-by: Anmol Sachan <anmol13694@gmail.com>
2019-12-12 14:51:27 +05:30
Sébastien Han 440a68f57e ceph: add crash key
As of 14.2.5, the crash collector pod will use the client.crash user
instead of the client.admin keyring to post crash dumps.

Closes: https://github.com/rook/rook/issues/4388
Signed-off-by: Sébastien Han <seb@redhat.com>
2019-12-12 09:05:38 +01:00
Sébastien Han 695412acd8 Merge pull request #4477 from shellwedance/ceph_document_typo
docs: fix typo on ceph cluster crd description
2019-12-12 08:59:32 +01:00
taeuk_kim 3aedc8c80d docs: fix typo on ceph cluster crd description
Signed-off-by: taeuk_kim <taeuk_kim@tmax.co.kr>
2019-12-12 15:38:58 +09:00
Blaine Gardner adfc1ef9a9 Merge pull request #4457 from ashangit/gateways_podantiaffinity
ceph: enforce pod anti affinity on gateways if hostNetwork is true
2019-12-11 12:02:42 -07:00
Blaine Gardner 9f7f7d63e9 ceph: integration: upgrade: disable dashboard
Disable the dashboard in the upgrade test because upgrading Ceph from
Mimic to Nautilu with Rook v1.0 can stall for a LONG time when updating
the mgr module. We are pretty sure there is very little risk that the
upgrade test will expose problems with the dashboard module that aren't
caught by other integration tests.

Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2019-12-11 11:27:37 -07:00
Blaine Gardner dceeff22e1 ceph: integration: kill process grp on file-test
The file-test pod still hangs sometimes when exiting. Instead of
trapping SIGTERM as before, use tini's `-g` option to kill the process
group. According to further reading on bash signal handling [1], Ctrl-C
sends a kill signal to the entire process group in order to kill `sleep`
commands.

[1] Link also noted in code comments:
http://mywiki.wooledge.org/SignalTrap#When_is_the_signal_handled.3F

Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2019-12-11 11:27:37 -07:00
Blaine Gardner 3cc5bf5191 integration: k8s helper, raise RetryLoop by 50%
To stabilize tests, raise the `RetryLoop` variable 50%.

Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2019-12-11 11:27:36 -07:00
Blaine Gardner 20e5639461 ceph: integration:upgrade: long wait for mgr module
Reset the integration test k8s helper's `RetryLoop` to its original
value, and instead only wait an extra long time to allow the mgr module
updates to take a long time after Ceph is updated from Mimic to Nautilus
as part of Ceph's upgrade integration test.

Updating mgr modules can hang for quite a while, which causes the tests
to time out waiting for the OSDs to be updated. Allow this to take a
long time so the tests aren't as flaky.

Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2019-12-11 11:27:36 -07:00
Sébastien Han 1e0ec0467f Merge pull request #4472 from leseb/rgw-fronted-flag
ceph: fix rgw liveness probe error
2019-12-11 16:45:57 +01:00
Sébastien Han 8a5aec0df0 Merge pull request #4465 from leseb/various-fixes
ceph: various controller and crash fixes
2019-12-11 15:26:43 +01:00
Sébastien Han 9cb752a874 ceph: rgw fix --id and remove --name
Both --id and --name do the same thing, so let's use one only: --id
which is shared accross all the daemons already.

Signed-off-by: Sébastien Han <seb@redhat.com>
2019-12-11 15:24:42 +01:00
Sébastien Han dde9e189b4 ceph: rgw fix fronted flag
rgw needs the fronted on its cli line to select the fronted as well the
port. This option is not supported in the mon config store.

Closes: https://github.com/rook/rook/issues/4471
Signed-off-by: Sébastien Han <seb@redhat.com>
2019-12-11 15:24:26 +01:00
n.fraison b9c2d616ab ceph: enforce pod anti affinity on gateways if hostNetwork is true
As performed with mon, gateways from same ceph object store
must not run on the same host if hostNetwork is set to true

Signed-off-by: n.fraison <n.fraison@criteo.com>
2019-12-11 14:53:07 +01:00
Sébastien Han f56d618568 ceph: add missing ownerref to csi secrets
CSI secrets were missing OwnerReference so when csi went away secrets
were remaining. Now this is fixed.

Signed-off-by: Sébastien Han <seb@redhat.com>
2019-12-11 10:35:53 +01:00
Sébastien Han 6051a3ca26 ceph: controller accept multiple changes at once
If editing the cluster CR we must update the spec to reflect its new
content. Now the spec is updated so we can update with an unsupported
image as well as setting allowUnsupported: true.
It was not possible before we had to restart the operator, now we can do
it as an update.

Signed-off-by: Sébastien Han <seb@redhat.com>
2019-12-11 10:35:53 +01:00