Commit Graph
12023 Commits
Author SHA1 Message Date
dependabot[bot] 5dcc6af9e8 build(deps): bump the k8s-dependencies group with 7 updates
Bumps the k8s-dependencies group with 7 updates:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.32.1` | `0.32.2` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.32.1` | `0.32.2` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.32.1` | `0.32.2` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.32.1` | `0.32.2` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.32.1` | `0.32.2` |
| [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) | `0.32.1` | `0.32.2` |
| [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.20.1` | `0.20.2` |

Updates `k8s.io/api` from 0.32.1 to 0.32.2
- [Commits](https://github.com/kubernetes/api/compare/v0.32.1...v0.32.2)

Updates `k8s.io/apiextensions-apiserver` from 0.32.1 to 0.32.2
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.32.1...v0.32.2)

Updates `k8s.io/apimachinery` from 0.32.1 to 0.32.2
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.32.1...v0.32.2)

Updates `k8s.io/cli-runtime` from 0.32.1 to 0.32.2
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.32.1...v0.32.2)

Updates `k8s.io/client-go` from 0.32.1 to 0.32.2
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.32.1...v0.32.2)

Updates `k8s.io/cloud-provider` from 0.32.1 to 0.32.2
- [Commits](https://github.com/kubernetes/cloud-provider/compare/v0.32.1...v0.32.2)

Updates `sigs.k8s.io/controller-runtime` from 0.20.1 to 0.20.2
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.20.1...v0.20.2)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cloud-provider
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-03-05 16:09:21 -07:00
Blaine Gardner 3d6af8facf Merge pull request #15477 from obnoxxx/docs-lengthy-commits
docs: slight rewording in development guide
2025-02-28 11:51:24 -07:00
Michael Adam 1d3f8c58fb docs: slight rewording in development guide
The development  guide mentioned that commit messages
should be lengthy which has a negative connotation
of meaning long-winded.

This change rewords the corresponding part to sound   more positive.

Signed-off-by: Michael Adam <obnox@samba.org>
2025-02-28 13:44:04 +01:00
Travis Nielsen e5f1d9f589 Merge pull request #15295 from subhamkrai/fix-rgw-multisite-ci-test
ci: Increase rgw multisite test timeout for s3 client call
2025-02-27 11:28:10 -07:00
subhamkrai 0dda801488 ci: test rgw multisite test
Signed-off-by: subhamkrai <srai@redhat.com>
2025-02-27 23:19:13 +05:30
Travis Nielsen f892baa22c Merge pull request #15470 from travisn/stretch-pool-creation
mgr: Wait for builtin mgr pool to exist before enabling stretch
2025-02-27 10:01:32 -07:00
Blaine Gardner 851852b015 Merge pull request #15423 from obnoxxx/make-markdownlint
CI: extract    'markdownlint' and 'golangci-lint' make targets from the ci workflows
2025-02-27 09:59:21 -07:00
Michael Adam 3e230661ae docs: document how to run linters locally
This change expands the section about regression testing in the
developer guide by adding information about how  to run  linters
locally.

Signed-off-by: Michael Adam <obnox@samba.org>
2025-02-27 16:35:20 +01:00
Michael Adam 8a4aa1fd00 build: add a make target 'golangci-lint'
This adds a command 'make golangci-lint'

This is done so developers can conveiently run golangci-lint
locally like it runs in the CI.

golangci-lint is also run as part of the more general 'make lint'.

Signed-off-by: Michael Adam <obnox@samba.org>
2025-02-27 16:29:54 +01:00
Michael Adam d1ef4f9e69 build: add a make target 'markdownlint'
This checks the documentation sources for syntactic correctness

The functionality is essentially extracted from the docs-check workflow
to provide developers with a tool to locally run the corresponding check
before pushing

Signed-off-by: Michael Adam <obnox@samba.org>
2025-02-27 16:29:54 +01:00
Travis Nielsen 8429affc79 mgr: wait for builtin mgr pool to exist before enabling stretch
There is a race condition in ceph v19 at startup of a
stretch cluster where if the .mgr pool is created by
the mgr pod after stretch mode is entered, the
devicehealth mgr module will crash and cause a
ceph HEALTH_ERR. The error then causes rook reconcile
of all CRs to be skipped because Rook is assuming
admin intervention is needed to continue. The fix
is to wait until the .mgr pool is created by the mgr
pod before entering stretch mode.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2025-02-27 08:10:52 -07:00
Travis Nielsen 3bd5881fe5 core: suppress mgr module health errors during reconcile
Some ceph health errors should not block the reconcile
of the cluster. Mgr modules do not have cause to block
the reconcile, as the cluster can usually work even
if a module is failing.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2025-02-27 08:10:52 -07:00
Travis Nielsen b1df450cbd Merge pull request #15471 from subhamkrai/update-ubuntu-version
ci: update ubuntu version to 22.04 or latest
2025-02-27 07:48:16 -07:00
subhamkrai 1f4d2bb29b ci: update ubuntu version to 22.04 or latest
ubuntu 20.04 is going to unsupported by April 1 and there
are planned brownouts planned from March 4th. so let's
upgrade to version 22.04.

Signed-off-by: subhamkrai <srai@redhat.com>
2025-02-27 09:48:34 +05:30
Blaine Gardner 64bb8141b2 Merge pull request #15451 from rook/dependabot/go_modules/github-dependencies-8e097e19d0
build(deps): bump the github-dependencies group across 1 directory with 6 updates
2025-02-26 11:27:23 -07:00
dependabot[bot] 328383fa27 build(deps): bump the github-dependencies group across 1 directory with 6 updates
Bumps the github-dependencies group with 6 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [github.com/ceph/go-ceph](https://github.com/ceph/go-ceph) | `0.31.0` | `0.32.0` |
| [github.com/google/go-cmp](https://github.com/google/go-cmp) | `0.6.0` | `0.7.0` |
| [github.com/hashicorp/vault/api](https://github.com/hashicorp/vault) | `1.15.0` | `1.16.0` |
| [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator) | `0.80.0` | `0.80.1` |
| [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator) | `0.80.0` | `0.80.1` |
| [github.com/spf13/cobra](https://github.com/spf13/cobra) | `1.8.1` | `1.9.1` |

Updates `github.com/ceph/go-ceph` from 0.31.0 to 0.32.0
- [Release notes](https://github.com/ceph/go-ceph/releases)
- [Changelog](https://github.com/ceph/go-ceph/blob/master/docs/release-process.md)
- [Commits](https://github.com/ceph/go-ceph/compare/v0.31.0...v0.32.0)

Updates `github.com/google/go-cmp` from 0.6.0 to 0.7.0
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](https://github.com/google/go-cmp/compare/v0.6.0...v0.7.0)

Updates `github.com/hashicorp/vault/api` from 1.15.0 to 1.16.0
- [Release notes](https://github.com/hashicorp/vault/releases)
- [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG-v1.10-v1.15.md)
- [Commits](https://github.com/hashicorp/vault/compare/v1.15.0...v1.16.0)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.80.0 to 0.80.1
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.80.0...v0.80.1)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.80.0 to 0.80.1
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.80.0...v0.80.1)

Updates `github.com/spf13/cobra` from 1.8.1 to 1.9.1
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](https://github.com/spf13/cobra/compare/v1.8.1...v1.9.1)

---
updated-dependencies:
- dependency-name: github.com/ceph/go-ceph
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/google/go-cmp
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/hashicorp/vault/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
...

Note:
Requires some cascaded updates to ./api go modules as well.

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-26 10:57:00 -07:00
Blaine Gardner 8010042a61 Merge pull request #15424 from parth-gr/mds-liveness-fix
mds: fix mds liveness probe
2025-02-26 09:08:19 -07:00
Travis Nielsen 799d45c8da Merge pull request #15456 from rook/dependabot/go_modules/github.com/go-jose/go-jose/v4-4.0.5
build(deps): bump github.com/go-jose/go-jose/v4 from 4.0.4 to 4.0.5
2025-02-25 17:26:15 -07:00
Travis Nielsen 612979b6f0 Merge pull request #15293 from travisn/node-ceph-conf-override
osd: Enable node specific ceph conf overrides
2025-02-25 14:13:54 -07:00
dependabot[bot] 40a2c03e38 build(deps): bump github.com/go-jose/go-jose/v4 from 4.0.4 to 4.0.5
Bumps [github.com/go-jose/go-jose/v4](https://github.com/go-jose/go-jose) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/go-jose/go-jose/releases)
- [Changelog](https://github.com/go-jose/go-jose/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-jose/go-jose/compare/v4.0.4...v4.0.5)

---
updated-dependencies:
- dependency-name: github.com/go-jose/go-jose/v4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-25 14:09:26 -07:00
Travis Nielsen 9b6e2b5e60 Merge pull request #15455 from patrostkowski/docs/rook-maintenance-14995
docs: add comprehensive Rook Ceph cluster maintenance guide
2025-02-25 14:02:56 -07:00
Patryk Rostkowski 20f2af02ee docs: add comprehensive Rook Ceph cluster maintenance guide
- Introduced a detailed markdown document outlining
  procedures for safe cluster shutdown and restart
  as per https://github.com/rook/rook/issues/14995
- Document includes steps to scale down applications,
  set Ceph flags, and orderly shutdown of Ceph
  components (operator, RGW, CSI, OSD, MON, MGR).
- Provides command examples for both scaling
  down and scaling up deployments.
- Adds additional Q&A and best practices to help
  cluster administrators manage maintenance with
  minimal downtime.

Signed-off-by: Patryk Rostkowski <patrostkowski@gmail.com>
2025-02-25 21:52:25 +01:00
Travis Nielsen c6f709ce21 Merge pull request #15442 from travisn/operator-env-vars
core: Query env vars instead of polling the operator settings configmap
2025-02-25 11:06:36 -07:00
parth-gr 0999cf9b56 mds: fix mds liveness probe
mds liveness probe call ceph cmd with mons and keyring,
but ceph actually looks for the ceph keyring at default folder
first and then use the cmd line keyring path,
So to avoid that use ceph_args env variable to expose the keyring
folder path,
Workaround for https://tracker.ceph.com/issues/70167

closes: https://github.com/rook/rook/issues/15373

Signed-off-by: parth-gr <partharora1010@gmail.com>
2025-02-25 18:05:07 +05:30
Travis NielsenandDmitry Mishin d109dc9029 core: implement operator settings as env vars
The operator settings loaded from the configmap have proven
inefficient for load time and frequently checking the configmap.
To avoid this ineffenciency, the configmap is only loaded once
each time it is created or updated. The values in the configmap
are applied as environment variables, which then are very efficient
to query throughout the various controllers, without needing
to be concerned about loading the configmap again.

Co-authored-by: Dmitry Mishin <dmitry.mishin@gmail.com>
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2025-02-24 12:12:45 -07:00
Travis Nielsen 4eed2a644f Merge pull request #15433 from SkalaNetworks/master
fix(csi-addons): bind cephfs and rbd provisionners on non-colliding p…
2025-02-24 12:06:57 -07:00
Blaine Gardner 84fc8afade Merge pull request #15443 from FabianPonce/patch-2
helm: quote object store ingress hostname
2025-02-24 11:32:47 -07:00
subham rai 258de8c8cd Merge pull request #15447 from rook/dependabot/github_actions/actions/upload-artifact-4.6.1
build(deps): bump actions/upload-artifact from 4.6.0 to 4.6.1
2025-02-24 21:49:13 +05:30
subham rai c6b46e10b0 Merge pull request #15448 from rook/dependabot/github_actions/azure/setup-helm-4.3.0
build(deps): bump azure/setup-helm from 4.2.0 to 4.3.0
2025-02-24 21:42:35 +05:30
subham rai 52ff9484e7 Merge pull request #15449 from rook/dependabot/github_actions/github/codeql-action-3.28.10
build(deps): bump github/codeql-action from 3.28.9 to 3.28.10
2025-02-24 21:41:53 +05:30
subham rai 567fa44e45 Merge pull request #15450 from rook/dependabot/github_actions/ossf/scorecard-action-2.4.1
build(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1
2025-02-24 21:41:24 +05:30
dependabot[bot] d6028eefea build(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](https://github.com/ossf/scorecard-action/compare/62b2cac7ed8198b15735ed49ab1e5cf35480ba46...f49aabe0b5af0936a0987cfb85d86b75731b0186)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-24 13:33:20 +00:00
dependabot[bot] 24d93a6744 build(deps): bump github/codeql-action from 3.28.9 to 3.28.10
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.9 to 3.28.10.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/9e8d0789d4a0fa9ceb6b1738f7e269594bdd67f0...b56ba49b26e50535fa1e7f7db0f4f7b4bf65d80d)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-24 13:33:16 +00:00
dependabot[bot] d2c041901d build(deps): bump azure/setup-helm from 4.2.0 to 4.3.0
Bumps [azure/setup-helm](https://github.com/azure/setup-helm) from 4.2.0 to 4.3.0.
- [Release notes](https://github.com/azure/setup-helm/releases)
- [Changelog](https://github.com/Azure/setup-helm/blob/main/CHANGELOG.md)
- [Commits](https://github.com/azure/setup-helm/compare/fe7b79cd5ee1e45176fcad797de68ecaf3ca4814...b9e51907a09c216f16ebe8536097933489208112)

---
updated-dependencies:
- dependency-name: azure/setup-helm
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-24 13:33:12 +00:00
dependabot[bot] 99f8a77960 build(deps): bump actions/upload-artifact from 4.6.0 to 4.6.1
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08...4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-24 13:33:08 +00:00
Skala Networks d3c3d25c60 csi: bind cephfs and rbd provisionners on non-colliding ports for hostNetwork setups
Signed-off-by: Skala Networks <contact@skala.network>
2025-02-23 06:31:43 -05:00
Travis Nielsen 81d9159c2d Merge pull request #15441 from VirajJadhav/patch-1
doc: Authenticated Container Registry | Typo for imagePullSecrets
2025-02-22 12:27:13 -07:00
Viraj Jadhav 659d574633 doc: typo for imagePullSecrets
Signed-off-by: Viraj Jadhav <vjadhav7@slb.com>
2025-02-22 18:25:51 +05:30
Fabian Ponce 7467f19c23 helm: quote object store ingress hostname
Kubernetes permits wildcards as leading members of this field, but if it is not quoted, then there will be a YAML parsing error.

Signed-off-by: Fabian Ponce <me@fabianponce.com>
2025-02-21 22:26:58 -05:00
Travis Nielsen 2181170811 Merge pull request #15370 from travisn/osd-upgrade-checks
osd: Enable osd ok-to-stop checks on single node where there are at least three OSDs
2025-02-20 12:52:03 -07:00
Travis Nielsen 24b14601f8 Merge pull request #15410 from rook/dependabot/github_actions/golangci/golangci-lint-action-6.5.0
build(deps): bump golangci/golangci-lint-action from 6.3.1 to 6.5.0
2025-02-20 12:33:28 -07:00
Travis Nielsen 8f79b58edc Merge pull request #15392 from subhamkrai/update-ceph-v19.2.1
manifest: Update default ceph version to v19.2.1
2025-02-20 11:41:06 -07:00
subhamkrai 0e395f0a67 manifest: update default ceph version to v19.2.1
with ceph release v19.2.1 updating it to be dafult version
in rook.

Signed-off-by: subhamkrai <srai@redhat.com>
2025-02-20 23:24:54 +05:30
Travis Nielsen 272deabdd8 Merge pull request #15431 from subhamkrai/fix-keystone-ci
ci: wait for pod before exec into pod
2025-02-20 10:28:56 -07:00
subhamkrai 45e76204bf ci: wait for pod before exec into pod
keystone integration test has recentally starting to fail
as pod with lable osc-admin-admin was not in running status
and we're trying to exec into the pod.

Signed-off-by: subhamkrai <srai@redhat.com>
2025-02-20 12:25:07 +05:30
Blaine Gardner 26d5441844 Merge pull request #15429 from BlaineEXE/pend-release-note
doc: add obc allow list to pending release notes
2025-02-19 12:54:32 -07:00
Blaine Gardner 88bf8dd475 doc: add obc allow list to pending release notes
Add a note about the upcoming potentially-breaking change to OBCs to the
v1.17 release notes. This covers usage of
`ROOK_OBC_ALLOW_ADDITIONAL_CONFIG_FIELDS` for OBC fields that some
admins might not want exposed to users.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2025-02-19 12:10:06 -07:00
Blaine Gardner 73c931fc0a Merge pull request #15376 from BlaineEXE/obc-allow-list-obc-fields
object: disallow unsafe OBC fields by default
2025-02-19 12:00:54 -07:00
subham rai 63335dbf69 Merge pull request #15409 from rook/dependabot/github_actions/aws-actions/configure-aws-credentials-4.1.0
build(deps): bump aws-actions/configure-aws-credentials from 4.0.3 to 4.1.0
2025-02-19 13:34:09 +05:30
Travis Nielsen 42454bd80e Merge pull request #15421 from nixpanic/roadmap/ceph-csi-v3.14
docs: update link to Ceph-CSI v3.14 milestone
2025-02-18 10:14:46 -07:00