feedc0de/my-rook-config
1
0 Fork 0
forked from rook/rook
Code Pull Requests Activity
12,023 Commits 38 Branches 289 Tags
5dcc6af9e898bc4eecba10dbefe7270e202f2f81
Commit Graph
4564 Commits
Author SHA1 Message Date
dependabot[bot] 5dcc6af9e8 build(deps): bump the k8s-dependencies group with 7 updates 
Bumps the k8s-dependencies group with 7 updates:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.32.1` | `0.32.2` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.32.1` | `0.32.2` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.32.1` | `0.32.2` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.32.1` | `0.32.2` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.32.1` | `0.32.2` |
| [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) | `0.32.1` | `0.32.2` |
| [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.20.1` | `0.20.2` |

Updates `k8s.io/api` from 0.32.1 to 0.32.2
- [Commits](https://github.com/kubernetes/api/compare/v0.32.1...v0.32.2)

Updates `k8s.io/apiextensions-apiserver` from 0.32.1 to 0.32.2
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.32.1...v0.32.2)

Updates `k8s.io/apimachinery` from 0.32.1 to 0.32.2
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.32.1...v0.32.2)

Updates `k8s.io/cli-runtime` from 0.32.1 to 0.32.2
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.32.1...v0.32.2)

Updates `k8s.io/client-go` from 0.32.1 to 0.32.2
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.32.1...v0.32.2)

Updates `k8s.io/cloud-provider` from 0.32.1 to 0.32.2
- [Commits](https://github.com/kubernetes/cloud-provider/compare/v0.32.1...v0.32.2)

Updates `sigs.k8s.io/controller-runtime` from 0.20.1 to 0.20.2
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.20.1...v0.20.2)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cloud-provider
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-03-05 16:09:21 -07:00
Travis Nielsen 8429affc79 mgr: wait for builtin mgr pool to exist before enabling stretch 
There is a race condition in ceph v19 at startup of a
stretch cluster where if the .mgr pool is created by
the mgr pod after stretch mode is entered, the
devicehealth mgr module will crash and cause a
ceph HEALTH_ERR. The error then causes rook reconcile
of all CRs to be skipped because Rook is assuming
admin intervention is needed to continue. The fix
is to wait until the .mgr pool is created by the mgr
pod before entering stretch mode.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2025-02-27 08:10:52 -07:00
Travis Nielsen 3bd5881fe5 core: suppress mgr module health errors during reconcile 
Some ceph health errors should not block the reconcile
of the cluster. Mgr modules do not have cause to block
the reconcile, as the cluster can usually work even
if a module is failing.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2025-02-27 08:10:52 -07:00
Blaine Gardner 64bb8141b2 Merge pull request #15451 from rook/dependabot/go_modules/github-dependencies-8e097e19d0 
build(deps): bump the github-dependencies group across 1 directory with 6 updates
 2025-02-26 11:27:23 -07:00
dependabot[bot] 328383fa27 build(deps): bump the github-dependencies group across 1 directory with 6 updates 
Bumps the github-dependencies group with 6 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [github.com/ceph/go-ceph](https://github.com/ceph/go-ceph) | `0.31.0` | `0.32.0` |
| [github.com/google/go-cmp](https://github.com/google/go-cmp) | `0.6.0` | `0.7.0` |
| [github.com/hashicorp/vault/api](https://github.com/hashicorp/vault) | `1.15.0` | `1.16.0` |
| [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator) | `0.80.0` | `0.80.1` |
| [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator) | `0.80.0` | `0.80.1` |
| [github.com/spf13/cobra](https://github.com/spf13/cobra) | `1.8.1` | `1.9.1` |

Updates `github.com/ceph/go-ceph` from 0.31.0 to 0.32.0
- [Release notes](https://github.com/ceph/go-ceph/releases)
- [Changelog](https://github.com/ceph/go-ceph/blob/master/docs/release-process.md)
- [Commits](https://github.com/ceph/go-ceph/compare/v0.31.0...v0.32.0)

Updates `github.com/google/go-cmp` from 0.6.0 to 0.7.0
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](https://github.com/google/go-cmp/compare/v0.6.0...v0.7.0)

Updates `github.com/hashicorp/vault/api` from 1.15.0 to 1.16.0
- [Release notes](https://github.com/hashicorp/vault/releases)
- [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG-v1.10-v1.15.md)
- [Commits](https://github.com/hashicorp/vault/compare/v1.15.0...v1.16.0)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.80.0 to 0.80.1
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.80.0...v0.80.1)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.80.0 to 0.80.1
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.80.0...v0.80.1)

Updates `github.com/spf13/cobra` from 1.8.1 to 1.9.1
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](https://github.com/spf13/cobra/compare/v1.8.1...v1.9.1)

---
updated-dependencies:
- dependency-name: github.com/ceph/go-ceph
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/google/go-cmp
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/hashicorp/vault/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
...

Note:
Requires some cascaded updates to ./api go modules as well.

Signed-off-by: dependabot[bot] <support@github.com>
 2025-02-26 10:57:00 -07:00
Blaine Gardner 8010042a61 Merge pull request #15424 from parth-gr/mds-liveness-fix 
mds: fix mds liveness probe
 2025-02-26 09:08:19 -07:00
Travis Nielsen 799d45c8da Merge pull request #15456 from rook/dependabot/go_modules/github.com/go-jose/go-jose/v4-4.0.5 
build(deps): bump github.com/go-jose/go-jose/v4 from 4.0.4 to 4.0.5
 2025-02-25 17:26:15 -07:00
Travis Nielsen 612979b6f0 Merge pull request #15293 from travisn/node-ceph-conf-override 
osd: Enable node specific ceph conf overrides
 2025-02-25 14:13:54 -07:00
dependabot[bot] 40a2c03e38 build(deps): bump github.com/go-jose/go-jose/v4 from 4.0.4 to 4.0.5 
Bumps [github.com/go-jose/go-jose/v4](https://github.com/go-jose/go-jose) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/go-jose/go-jose/releases)
- [Changelog](https://github.com/go-jose/go-jose/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-jose/go-jose/compare/v4.0.4...v4.0.5)

---
updated-dependencies:
- dependency-name: github.com/go-jose/go-jose/v4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-02-25 14:09:26 -07:00
parth-gr 0999cf9b56 mds: fix mds liveness probe 
mds liveness probe call ceph cmd with mons and keyring,
but ceph actually looks for the ceph keyring at default folder
first and then use the cmd line keyring path,
So to avoid that use ceph_args env variable to expose the keyring
folder path,
Workaround for https://tracker.ceph.com/issues/70167

closes: https://github.com/rook/rook/issues/15373

Signed-off-by: parth-gr <partharora1010@gmail.com>
 2025-02-25 18:05:07 +05:30
Travis NielsenandDmitry Mishin d109dc9029 core: implement operator settings as env vars 
The operator settings loaded from the configmap have proven
inefficient for load time and frequently checking the configmap.
To avoid this ineffenciency, the configmap is only loaded once
each time it is created or updated. The values in the configmap
are applied as environment variables, which then are very efficient
to query throughout the various controllers, without needing
to be concerned about loading the configmap again.

Co-authored-by: Dmitry Mishin <dmitry.mishin@gmail.com>
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2025-02-24 12:12:45 -07:00
Travis Nielsen 4eed2a644f Merge pull request #15433 from SkalaNetworks/master 
fix(csi-addons): bind cephfs and rbd provisionners on non-colliding p…
 2025-02-24 12:06:57 -07:00
Skala Networks d3c3d25c60 csi: bind cephfs and rbd provisionners on non-colliding ports for hostNetwork setups 
Signed-off-by: Skala Networks <contact@skala.network>
 2025-02-23 06:31:43 -05:00
Travis Nielsen 2181170811 Merge pull request #15370 from travisn/osd-upgrade-checks 
osd: Enable osd ok-to-stop checks on single node where there are at least three OSDs
 2025-02-20 12:52:03 -07:00
Blaine Gardner 73c931fc0a Merge pull request #15376 from BlaineEXE/obc-allow-list-obc-fields 
object: disallow unsafe OBC fields by default
 2025-02-19 12:00:54 -07:00
Blaine Gardner 13cf8f0996 Merge pull request #15393 from BlaineEXE/fix-broken-nfs 
nfs: workaround broken nfs-ganesha config parser
 2025-02-13 09:51:36 -07:00
Blaine Gardner 55d1a86755 nfs: workaround broken nfs-ganesha config parser 
NFS-Ganesha introduced a breaking change in its config parser that no
longer accepts single quotes around values. This seems to be working for
most Ceph release images, but this was seen in at least one dev build of
Ceph.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
 2025-02-13 09:25:07 -07:00
Blaine Gardner 022d68e98b Merge pull request #15371 from jhoblitt/plumbing/user-controller-no-state 
object: rm ReconcileObjectStoreUser.userConfig field
 2025-02-13 08:53:31 -07:00
Satoru Takeuchi 9ddab0165b Merge pull request #15377 from sfackler/lvs-deadlock 
osd: avoid lvm device scan deadlock in activate
 2025-02-13 18:47:40 +09:00
Blaine Gardner 0e33536539 object: disallow unsafe OBC fields by default 
Implement an allow list mechanism that disables potentially unsafe OBC
fields by default. OBC fields beyond `maxObjects` and `maxSize` don't
neatly fit into the OBC framework as it was originally envisioned and
implemented.

Some of the newly added configs could allow users to cause confusion for
themselves. Others might allow users to hijack others buckets. Some
might allow bricking the entire S3 store.

Out of an abundance of safety, allow-list the known-safe options by
default, and require administrators to enable potentially troublesome
options via the new operator-level config
`ROOK_OBC_ALLOW_ADDITIONAL_CONFIG_FIELDS`.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
 2025-02-12 14:18:01 -07:00
subhamkrai e546bdb370 build: update prometheus to latest version v0.80.0 
Signed-off-by: subhamkrai <srai@redhat.com>
 2025-02-11 11:38:55 +05:30
Steven Fackler bbe600aa20 osd: avoid lvm device scan deadlock in activate 
If a locally mounted volume is blocked on reads because this OSD is
down, lvs will deadlock trying to read from it. To avoid this, tell LVM
to filter out RBD volumes from its scanning process.

Signed-off-by: Steven Fackler <sfackler@gmail.com>
 2025-02-08 13:39:16 -05:00
Joshua Hoblitt 37b7930e13 object: rm ReconcileObjectStoreUser.userConfig field 
This field held state for a single reconciliation request, which
should not have been retrained / reused across multiple, possibly concurrent,
reconciliations.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2025-02-07 14:37:14 -07:00
Blaine Gardner 1cf0a83ead Merge pull request #15311 from jhoblitt/feature/obc-bucket-owner 
object: add obc bucketOwner
 2025-02-07 13:48:35 -07:00
Travis Nielsen e068e156ce osd: enable osd ok-to-stop checks on single node for three osds 
If there are at least three OSDs on a single node, we should
treat it as a potential production cluster and perform
the ok-to-stop checks during reconcile. Otherwise,
it may cause instability during upgrades on
single-node clusters.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2025-02-05 12:08:48 -07:00
subhamkrai d7be3318b6 build: updates spf13 pflag from 1.0.5 to 1.0.6 
Signed-off-by: subhamkrai <srai@redhat.com>
 2025-02-04 08:54:19 +05:30
Joshua Hoblitt 0eef85357a object: obc should not modify existing users 
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2025-02-03 15:19:48 -07:00
Joshua Hoblitt 48a9b90642 object: add obc bucketOwner 
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2025-01-31 08:48:41 -07:00
Blaine Gardner bcb1db361a Merge pull request #15255 from cobaltcore-dev/hostname-topology-label 
Hostname topology label
 2025-01-28 09:00:50 -07:00
Travis Nielsen 16daa7dc44 Merge pull request #15184 from OdedViner/err_msg_ok_to_stop 
operator: improve operator error logging for ok-to-stop failures
 2025-01-24 08:13:20 -07:00
Artem Torubarov 25ee6b4f59 operator: custom hostname topology label 
Signed-off-by: Artem Torubarov <artem.torubarov@clyso.com>
 2025-01-24 15:59:07 +01:00
Travis Nielsen e17ef88ae8 Merge pull request #15309 from cobaltcore-dev/mon-db-conf-trace-log 
operator: log mon db config values with trace lvl
 2025-01-24 07:55:27 -07:00
Artem Torubarov 58febcbeab operator: log mon db config values with trace lvl 
log applied mon store config values with trace lvl for debug purpose

Signed-off-by: Artem Torubarov <artem.torubarov@clyso.com>
 2025-01-24 15:18:19 +01:00
Santosh Pillai e23e921f28 Merge pull request #15306 from sfackler/wait-for-secret 
rgw: fix error handling for secret lookup
 2025-01-24 12:06:39 +05:30
Joshua Hoblitt a55fdb3fbe object: add obc bucketLifecycle 
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2025-01-21 16:01:37 -07:00
Joshua Hoblitt f52f48c477 ci: codespell: s/re-using/reusing/ 
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2025-01-21 15:11:33 -07:00
Steven Fackler 6935dfdc47 rgw: fix error handling for secret lookup 
Get will return a non-nil pointer even in the error case.

Signed-off-by: Steven Fackler <sfackler@gmail.com>
 2025-01-21 09:42:46 -05:00
subhamkrai e1ce1e4416 build: update k8s and cntrl runtime pkg 
this commits updates the k8s pkg to v0.32.1 and
controller runtime to v0.20.0

Signed-off-by: subhamkrai <srai@redhat.com>
 2025-01-21 14:34:12 +05:30
Eng Zer Jun e68a7ea561 build: replace golang.org/x/exp/slices with stdlib slices 
The experimental functions in `golang.org/x/exp/slices` are now
available in the standard library in Go 1.21.

Reference: https://go.dev/doc/go1.21#slices
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2025-01-21 15:02:35 +08:00
Oded Viner 3d7f5cff65 operator: improve operator error logging for ok-to-stop failures 
this PR improves the error logging when ok-to-stop requests fail
in the Rook operator. Instead of only showing a generic exit status

Signed-off-by: Oded Viner <oviner@redhat.com>
 2025-01-19 14:46:57 +02:00
Travis Nielsen b0aefed8e5 osd: enable node specific ceph conf overrides 
Some ceph.conf settings need to be unique per node
depending on the hardware. The ceph.conf overrides
can now be customized per-node by creating a node-specific
configmap that will be loaded for all OSDs and OSD prepare
jobs on that node, instead of the default ceph.conf
that is loaded from the rook-config-override configmap.

The node-specific configmaps must have the label
node.config.rook.io/osd, and be named as:
rook-config-override-<hostname>

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2025-01-17 15:57:48 -07:00
Travis Nielsen f5833cf58f Merge pull request #15270 from cobaltcore-dev/remove-mon-db-conf-log 
operator: omit values from mon db config logs
 2025-01-16 11:29:37 -07:00
Travis Nielsen 53c419afdd Merge pull request #15258 from OdedViner/pruner_tollerations 
core: add tolerations to crashcollector pruner cronJob pod
 2025-01-16 10:00:34 -07:00
ArtemandTravis Nielsen db88970641 operator: omit mon db config value log 
Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Artem Torubarov <artem.torubarov@clyso.com>
 2025-01-16 16:42:34 +01:00
Oded Viner 8817a1a703 core: add tolerations to crashcollector pruner cronJob pod 
This PR addresses an issue where the CrashCollector Pruner
CronJob pods were stuck in a Pending state due to missing
tolerations in their PodTemplateSpec.
These tolerations were not being propagated from the
cephClusterSpec.placement.all field.
Added tolerations to the PodTemplateSpec of the
CrashCollector Pruner CronJob.

Signed-off-by: Oded Viner <oviner@redhat.com>
 2025-01-16 16:17:20 +02:00
Niels de Vos 955fa9cae4 csi: update Kubernetes CSI sidecar images to current versions 
The Kubernetes CSI sidecars have had several releases that were not
included in deployments by Rook yet, update them to the versions that
are available today:

- csi-node-driver-registrar:v2.13.0
- csi-provisioner:v5.1.0
- csi-attacher:v4.8.0
- csi-resizer:v1.13.1

Signed-off-by: Niels de Vos <ndevos@ibm.com>
 2025-01-15 13:11:26 +01:00
Artem Torubarov a44ae0fdc6 operator: omit values from mon db config logs 
Signed-off-by: Artem Torubarov <artem.torubarov@clyso.com>
 2025-01-14 18:14:04 +01:00
Travis Nielsen f9ebaf3418 csi: set driver name to same as the operator namespace 
The operator namespace is where the csi driver resources
are being created. The prefix is expected to match the
namespace where the driver is being created.
It was an incorrect change from 15245 where it
had been assumed that the cluster prefix name was
required instead.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2025-01-13 16:34:43 -07:00
subham rai 77b6565c4f Merge pull request #15245 from travisn/csi-operator-cleanup 
csi: Set correct driver name with csi operator
 2025-01-09 12:26:24 +05:30
Travis Nielsen ac1767fa0f csi: set correct driver name with csi operator 
When the cluster is in a different namespace from the rook
operator, the csi provider name was setting the incorrect
namespace prefix. Now the prefix will be the same as the
ceph cluster namespace.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2025-01-08 16:04:27 -07:00