Commit Graph
11826 Commits
Author SHA1 Message Date
Madhu Rajanna 610126c560 doc: update groupsnapshot to betav1
updating the groupsnapshot to betav1 api.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-01-02 16:06:16 +01:00
Travis Nielsen 6f1f34a073 Merge pull request #15215 from travisn/test-wait-for-image-pull
tests: Canary tests to wait for first mon to start
2024-12-20 14:32:34 -07:00
Travis Nielsen 56c6659655 tests: canary tests to wait for first mon to start
Many of the canary tests have been failing much more
frequently in the past week or two. The test is typically
timing out pulling the image from quay.ceph.io since
it does not have as high bandwidth for the images.
A check is added to the test to wait specifically for the
first mon so it waits sufficiently for the image pull
before checking for other ceph daemons.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-12-20 13:53:21 -07:00
Blaine Gardner 52eab6cce4 Merge pull request #15199 from ideepika/wip-rgw-sidecar
object: add opsLogSidecar to gateway subsection from zone
2024-12-20 12:24:34 -07:00
Travis Nielsen ea57e18f8b Merge pull request #15209 from degorenko/fix-mgr-label
mgr: fix label selector when updating mgr active label
2024-12-20 10:27:34 -07:00
Denis Egorenko 009a0d9f6f mgr: fix label selector when updating mgr active label
Fix label selector for watch-active mgr container: during update active mgr label,
add missed app=rook-ceph-mgr label, to avoid setting label for mon pod.

Resolves: #15208
Signed-off-by: Denis Egorenko degorenko@mirantis.com
2024-12-20 20:50:05 +04:00
Deepika Upadhyay e821edc24b object: move opsLogSidecar to gateway subsection from zone subsection
Update YAML configuration to correctly place the opsLogSidecar field
under gateway.opsLogSidecar instead of zone.opsLogSidecar, as it is a
configuration option specific to the RGW gateway.

Signed-off-by: Deepika Upadhyay <deepika.upadhyay@clyso.com>
2024-12-19 20:35:06 +05:30
Blaine Gardner 2e8673699d Merge pull request #15196 from buroa/master
csi: csi-snapshotter flag typo; upgrade csi-snapshotter
2024-12-18 08:38:25 -07:00
Steven Kreitzer 463d9fb420 csi: csi-snapshotter flag typo; upgrade csi-snapshotter
Signed-off-by: Steven Kreitzer <skre@skre.me>
2024-12-18 09:09:29 -06:00
subham rai 1b50ddeb08 Merge pull request #15191 from travisn/csi-min-obsolete
docs: Remove obsolete min csi version
2024-12-18 12:11:09 +05:30
Blaine Gardner ebd3c512b9 Merge pull request #15189 from BlaineEXE/test-fix-object-spec-test-added-flags
test: ignore rgw cli flag order in unit test
2024-12-17 12:41:16 -07:00
Travis Nielsen 26ff895f0a docs: remove obsolete min csi version
The csi version is no longer checked by Rook. If the user
changes the default csi version, it's their responsibility
to ensure it is updated according to the upgrade guide,
we just don't officially have a min version anymore.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-12-17 12:39:32 -07:00
Blaine Gardner 37c3cc9fba test: ignore rgw cli flag order in unit test
In the unit test that ensures `rgwCommandFlags` works properly, ignore
the ordering of the flags. Golang maps are used underneath, which
results in random flag ordering. This is fine as long as the
`rgwCommandFlags` are still guaranteed to be appended to the args Rook
normally applies.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-12-17 12:21:50 -07:00
Travis Nielsen a0b6ecf2c6 Merge pull request #15176 from BlaineEXE/doc-add-object-advanced-volmount-example
doc: add object advanced config and vol mount example
2024-12-17 11:28:45 -07:00
Blaine Gardner dde609a9d4 Merge pull request #15185 from BlaineEXE/test-fix-flaky-unit
test: fix flaky object config unit test
2024-12-17 10:35:19 -07:00
Travis Nielsen 1a44ab3fa3 Merge pull request #14646 from ideepika/wip-rgw-sidecar
add rgw ops sidecar for op logs
2024-12-17 10:35:08 -07:00
Blaine Gardner 92c95fcc16 test: fix flaky object config unit test
Use testify/assert.Equal() to compare maps. Comparing string
representations of maps is supposed to be stable but is flaking in GH
actions CI.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-12-17 10:12:04 -07:00
Deepika Upadhyay c5d27467d6 object: add rgw ops sidecar for op logs
the rgw operations for s3 can now be accessible using sidecar
rgw-ops-log availabe in json form that can be further filtered logging
for observability, this will set the rgw_enable_ops_log setting

Signed-off-by: Deepika Upadhyay <deepika.upadhyay@clyso.com>
2024-12-17 22:36:03 +05:30
Travis Nielsen c116748182 Merge pull request #15178 from TomHellier/master
ceph: Update s5cmd to resolve vulnerabilities
2024-12-17 08:19:16 -07:00
Travis Nielsen 5baed04b6f Merge pull request #15153 from cobaltcore-dev/rgw-data-pool-bulk
rgw: bulk data pool by default
2024-12-17 07:16:00 -07:00
TomHellier a87843de62 build: update s5cmd to resolve vulnerabilities
The docker.io/rook/ceph image contains vulnerabilities in the s5cmd binary.
A new version of s5cmd was released on 16th December which resolves these issues.

Signed-off-by: TomHellier <me@tomhellier.com>
2024-12-17 12:12:52 +00:00
Artem Torubarov e3c3aafe09 rgw: bulk data pool by default
update CephObjecStore examples to set bulk=true for data pools by default

Signed-off-by: Artem Torubarov <artem.torubarov@clyso.com>
2024-12-17 09:47:59 +01:00
subham rai c1823ac80e Merge pull request #15167 from rook/dependabot/github_actions/wagoid/commitlint-github-action-6.2.0
build(deps): bump wagoid/commitlint-github-action from 6.1.2 to 6.2.0
2024-12-17 11:45:50 +05:30
subham rai 69c20650b7 Merge pull request #15166 from rook/dependabot/github_actions/github/codeql-action-3.27.9
build(deps): bump github/codeql-action from 3.27.6 to 3.27.9
2024-12-17 11:45:32 +05:30
subham rai bf7f329439 Merge pull request #15165 from rook/dependabot/github_actions/actions/setup-go-5.2.0
build(deps): bump actions/setup-go from 5.1.0 to 5.2.0
2024-12-17 11:45:01 +05:30
subham rai fabfe496f6 Merge pull request #15164 from rook/dependabot/github_actions/helm/kind-action-1.11.0
build(deps): bump helm/kind-action from 1.10.0 to 1.11.0
2024-12-17 11:25:21 +05:30
Blaine Gardner c845d36b20 doc: add object advanced config and vol mount example
Add a sample to the CephObjectStore Advanced configuration section which
shows how the new `rgwConfig` option can be used with the
`additionalVolumeMounts` setting.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-12-16 16:08:22 -07:00
Blaine Gardner 7322b05dd3 Merge pull request #15160 from BlaineEXE/object-finish-rgw-config-passthru
object: allow overriding rgw configs and flags
2024-12-16 15:29:40 -07:00
Blaine Gardner aaa16488de object: allow overriding rgw configs and flags
Implement #15119

Allow users to override RGW configurations by specifying Ceph config
options in the CephObjectStore. For configurations that require RGW to
be restarted when the config is applied, allow configs to be specified
as CLI arguments to the RGW as well.

This is an advanced option and is documented as such. Users should be
careful to understand the values they are setting, as there is no
validation to prevent the object store from breaking when these configs
are used.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-12-16 14:57:15 -07:00
Blaine Gardner 3294d96f34 Merge pull request #15119 from BlaineEXE/object-add-rgw-config-options
doc: design ceph config passthru for object store
2024-12-16 13:01:27 -07:00
dependabot[bot] 1bdd74906f build(deps): bump actions/setup-go from 5.1.0 to 5.2.0
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed...3041bf56c941b39c61721a86cd11f3bb1338122a)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-16 19:54:56 +00:00
dependabot[bot] a7ab497552 build(deps): bump helm/kind-action from 1.10.0 to 1.11.0
Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.10.0 to 1.11.0.
- [Release notes](https://github.com/helm/kind-action/releases)
- [Commits](https://github.com/helm/kind-action/compare/0025e74a8c7512023d06dc019c617aa3cf561fde...ae94020eaf628e9b9b9f341a10cc0cdcf5c018fb)

---
updated-dependencies:
- dependency-name: helm/kind-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-16 19:54:52 +00:00
Blaine Gardner c0799e0d39 Merge pull request #15115 from obnoxxx/update-api-deps
build: Update api gomod dependencies
2024-12-16 12:53:41 -07:00
Travis Nielsen 2fdf173ddf test: add new default fields to csi unit test
With the updated dependencies, the csi unit tests
require new default fields in the comparison of the
json test blob.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-12-16 19:52:15 +01:00
Michael Adam c8a1bb21f6 build: update api go module dependencies
Signed-off-by: Michael Adam <obnox@samba.org>
2024-12-16 19:52:15 +01:00
Travis Nielsen a6595e9754 Merge pull request #14456 from yaguangtang/exporter-secret-not-create-issue
external: fix exporter secret isn't created with external cluster
2024-12-16 10:58:23 -07:00
Travis Nielsen 3170ac6a0c Merge pull request #15158 from Lykos153/docs/rgw-swift-url-prefix
docs: Fix misleading example for urlPrefix
2024-12-16 09:30:35 -07:00
Blaine Gardner 72c7f2fbb1 Merge pull request #15132 from obnoxxx/update-golangci-lint
ci: update golangci-lint to the latest version (v1.62)
2024-12-16 09:09:12 -07:00
Michael Adam 26b4fb06d5 core: add function roundupSizeMiB
This change  refactors inline roundup code to a function
roundup_size_MiB that takes a size(in bytes) as argument and returns
the smallest number of Mibibytes larger than or equal to the given size.

Signed-off-by: Michael Adam <obnox@samba.org>
2024-12-16 15:30:47 +01:00
dependabot[bot] 0b228df125 build(deps): bump wagoid/commitlint-github-action from 6.1.2 to 6.2.0
Bumps [wagoid/commitlint-github-action](https://github.com/wagoid/commitlint-github-action) from 6.1.2 to 6.2.0.
- [Changelog](https://github.com/wagoid/commitlint-github-action/blob/master/CHANGELOG.md)
- [Commits](https://github.com/wagoid/commitlint-github-action/compare/3d28780bbf0365e29b144e272b2121204d5be5f3...0184f5a228ee06430bb9e67d65f73a1a6767496a)

---
updated-dependencies:
- dependency-name: wagoid/commitlint-github-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-16 12:05:08 +00:00
dependabot[bot] 4a59be5a11 build(deps): bump github/codeql-action from 3.27.6 to 3.27.9
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.27.6 to 3.27.9.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/aa578102511db1f4524ed59b8cc2bae4f6e88195...df409f7d9260372bd5f19e5b04e83cb3c43714ae)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-16 12:05:06 +00:00
df511fb58f ci: update golangci-lint to the latest version (v1.62)
The ci was using a pretty old version og golangci-lint.
This updates to the latest version.

Additionally, it  silences some
gosec integer conversion overflow false positves
and fixes some real errors of this category
 and string format errors found by golangci-lint, while at it.

Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com>
Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Michael Adam <obnox@samba.org>
2024-12-14 14:47:30 +01:00
Yaguang Tang 1563d32fbb external: fix exporter secret isn't created with external cluster
Fix the issue when using with external ceph cluster, ceph exporter
secret isn't created which cause ceph-exporter fail to run. By
default this option is false means ceph-exporter will run for
external cluster.

monitoring
  metricsDisabled: false

This patch also adds metricsDisabled option to helm values.yaml.

fixes #14275

Signed-off-by: Yaguang Tang <heut20008@gmail.com>
2024-12-13 17:01:08 -07:00
Blaine Gardner 80903df984 Merge pull request #15138 from jhoblitt/feature/obc-bucket-policy-alt1
object: add bucketPolicy to obc
2024-12-12 14:36:16 -07:00
Joshua Hoblitt 8fd34e88bb test: add obc bucketPolicy integration test
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-12-12 13:36:26 -07:00
Joshua Hoblitt 97b904c717 object: add obc bucketPolicy
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-12-12 13:36:26 -07:00
Silvio Ankermann fcce3ca520 docs: fix misleading example for urlPrefix
The default value for protocols.swift.urlPrefix is "swift", which makes
the Swift API available at http://host:port/swift/v1. However, in the
documentation our example says "/swift", which resulted in the
unexpected endpoint http://host:port//swift/v1.

Apparently, Ceph distinguishes between both values even though their
docs[1] seem to suggest that using leading slashes is fine.

This commit fixes the examples in the documentation to use the default
value "swift".

[1]
https://docs.ceph.com/en/reef/radosgw/config-ref/#confval-rgw_swift_url_prefix

Fixes #15065

Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
2024-12-12 21:08:20 +01:00
Blaine Gardner d3b9b74165 doc: design ceph config passthru for object store
Add a design for CephObjectStore to allow users to pass through Ceph
configs (e.g., `rgw_enable_apis`, `debug_rgw`) to the object store. This
design will help users set configs that they want for their environments
that aren't covered under Rook's umbrella of managed configs. This will
benefit users by allowing them to make use of rare RGW features that
Rook devs don't have ability to prioritize, as well as newly-released
RGW features that Rook devs haven't had time to plan API interfaces for.
This frees up Rook developers to focus effort on implementing APIs that
have integration benefits with Kubernetes or other resources and less
effort on simple configs.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-12-12 11:44:23 -07:00
Travis Nielsen a92236879f Merge pull request #15155 from travisn/k8s-1.32
build: Add support for K8s 1.32
2024-12-12 11:24:18 -07:00
Joshua Hoblitt 57b7eeec80 object: add httpClient param to object.NewS3Agent()
To allow the caller to pass in their own transport when testing.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-12-12 10:20:41 -07:00