Commit Graph
7679 Commits
Author SHA1 Message Date
Sébastien Han 67fa72aaeb Merge pull request #8943 from leseb/fix-8942
ci: fix osd disk permission on provisioning
2021-10-11 17:19:20 +02:00
Sébastien Han abc5c635a6 ci: fix osd disk permission on provisioning
When the OSD is prepared, systemd-udev kicks in since the device has
been exclusively opened and thus reverts the permissions to root:disk.
We need a udev rule to force re-applying the correct ceph permission so
we can consume the disk.

Closes: https://github.com/rook/rook/issues/8942
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-10-11 16:50:28 +02:00
Sébastien Han 4f9c31fa8b ci: clarify the wait for csi to be ready
The wait is now more comprehensive.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-10-11 16:47:02 +02:00
Travis Nielsen c628edec85 Merge pull request #8939 from leseb/fix-8928
mon: run ceph commands to mon with timeout
2021-10-08 10:00:21 -06:00
Sébastien Han c45fee83c1 Merge pull request #8646 from parth-gr/mon-finalizer
ceph: add finalizers to rook-ceph-mon secrets and configmap
2021-10-08 15:10:31 +02:00
Sébastien Han 8da68bfb78 mon: run ceph commands to mon with timeout
If the mons are not in quorum yet the commands interacting with mon
config store will stale for a very long time.

Closes: https://github.com/rook/rook/issues/8928
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-10-08 11:57:16 +02:00
Sébastien Han 0e40d6d9a8 Merge pull request #8889 from parth-gr/logrotate-object
ceph: fixing ClientID of log-collector for RGW instance
2021-10-08 11:41:21 +02:00
Travis Nielsen 2ddf9c9498 Merge pull request #8877 from parth-gr/scc
ceph: modify rook scc in  operator-openshift cr
2021-10-07 13:51:09 -06:00
parth-gr 7c99858a77 ceph: add finalizers to rook-ceph-mon secrets and configmap
Adding finalizers to rook-ceph-mon secrets
and rook-ceph-mon-endpoints configmap
We don't want to delete this resources during disaster
because these details are needed during disaster recovery

Closes: https://github.com/rook/rook/issues/8369
Signed-off-by: parth-gr <paarora@redhat.com>
2021-10-07 19:44:17 +00:00
Travis Nielsen 084dc41045 Merge pull request #8884 from BlaineEXE/remove-unused-helm-content
helm: remove chart content not in common.yaml
2021-10-07 13:43:17 -06:00
Travis Nielsen b77e4fcc03 Merge pull request #8933 from leseb/do-not-hide-error
osd: do not hide errors
2021-10-07 13:29:05 -06:00
Sébastien Han 4471f3a92e osd: do not hide errors
The previous exit 32 check for loop device is 5 years old. Also, if the
device cannot be read it will be skipped anyway so let's report the
error and not hide it.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-10-07 17:39:58 +02:00
parth-gr fc7905a7bd ceph: fixing ClientID of log-collector for RGW instance
The Client_ID generated by operator was
different from the log rotate file created
The Clinet_ID= rgwceph.client.rook.ceph.rgw.my.store.a
and log file name= ceph-client.rgw.my.store.a.log
So changed the CLient_ID to ceph-client.rgw.my.store.a for
correct working and this follow the patterns how other modules
Client_ID is generated

Closes: https://github.com/rook/rook/issues/8692
Signed-off-by: parth-gr <paarora@redhat.com>
2021-10-07 19:30:21 +05:30
parth-gr 59467e56ba ceph: modify rook scc in operator-openshift cr
Added allowHostNetwork and allowHostPorts fields
in operator-openshift cr as they are necessary
for validation

Closes: https://github.com/rook/rook/issues/8876
Signed-off-by: parth-gr <paarora@redhat.com>
2021-10-07 18:44:34 +05:30
Travis Nielsen 8e1a6ef07a Merge pull request #8845 from travisn/volume-replication-optional
csi: No longer install the VolumeReplication CRDs from Rook
2021-10-06 11:42:04 -06:00
Travis Nielsen c420f2309c csi: no longer install the volumereplication crds from rook
The volume replication CRDs are an external component, not owned by Rook.
Therefore, they should be installed as any other independent component
in case the admin will install other consumers of the volumereplication CRDs
in the future in addition to Rook and the CSI driver.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-10-06 16:27:44 +00:00
Sébastien Han c252e42a02 Merge pull request #8923 from Rakshith-R/add-rbdpool-init
ceph: initialize rbd block pool after creation
2021-10-06 17:29:57 +02:00
Rakshith R ab87e1d238 ceph: initialize rbd block pool after creation
This is done in order to prevent deadlock when parallel
PVC create requests are issued on a new uninitialized
rbd block pool due to https://tracker.ceph.com/issues/52537.

Fixes: #8696

Signed-off-by: Rakshith R <rar@redhat.com>
2021-10-06 19:54:51 +05:30
Travis Nielsen 87eee8afbc Merge pull request #8924 from leseb/rm-unused-client
core: remove unused clientset
2021-10-06 07:40:52 -06:00
Sébastien Han 0e0ccf8640 Merge pull request #8808 from BlaineEXE/add-trace-log-option
core: create TRACE_INSECURE log level
2021-10-06 11:35:32 +02:00
Sébastien Han 723f144452 core: remove unused clientset
Removing ancient clientset which was not used anywhere any more.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-10-06 11:34:06 +02:00
Blaine Gardner 507dfe11f6 helm: remove chart content not in common.yaml
Assume common.yaml is the right source of truth, and remove major
content from helm charts that does not exist in common.yaml.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-10-06 09:18:02 +00:00
Travis Nielsen 00cef458af Merge pull request #8917 from subhamkrai/close-stdout
core:  close stdoutPipe for the discovery daemon
2021-10-05 12:36:42 -06:00
subhamkrai 6387c7d063 core: close stdoutPipe for the discovery daemon
Closing stdoutPipe for the discovery daemon that
could possibly leaks memory due to unclosed resources.

Closes: https://github.com/rook/rook/issues/8914
Signed-off-by: subhamkrai <srai@redhat.com>
2021-10-05 18:10:59 +00:00
Travis Nielsen 086649c7f8 Merge pull request #8742 from subhamkrai/cant-mount-volume-nodelost
docs: add doc to recover from pod from lost node
2021-10-05 12:09:50 -06:00
subhamkrai 7587704743 docs: add doc to recover from pod from lost node
This commit adds the doc which has the manual
steps to recover from the specific scenario
like
`on the node lost, the new pod can't mount the
same volume`.

Closes: https://github.com/rook/rook/issues/1507
Signed-off-by: subhamkrai <srai@redhat.com>
2021-10-05 21:13:13 +05:30
Travis Nielsen 078f648644 Merge pull request #8909 from aruniiird/revert-one-alert-interval-change
ceph: reverting the time delay of 'CephMonHighNumberOfLeaderChanges'
2021-10-04 08:58:54 -06:00
Arun Kumar Mohan 4d845425e6 ceph: reverting the time delay of 'CephMonHighNumberOfLeaderChanges'
As 'CephMonHighNumberOfLeaderChanges' means there is a
multiple monitor election and indicate some communication
issue between the monitors. Increasing interval timing for
this alert is not considered as safe. So reverting this
change back to 5m

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2021-10-04 10:37:34 +05:30
Blaine Gardner 7586cea049 core: create TRACE_INSECURE log level
Create a new log level for Rook that is hidden from users. This is the
most verbose log level, and it is the level developers would like to use
to get debug logs that are important for debugging but that could leak
senstivie information like credentials in production use.

If a user sets their debug level to "TRACE", they will merely get
"DEBUG" level logs. Only if they set "TRACE_INSECURE" will they get
trace logs, and those are likely to include insecure information. Rook
tries very hard not to leak sensitive information in logs even with
verbose "DEBUG" logs.

Resolves #8778

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-10-01 12:09:19 -06:00
Blaine Gardner 08cb6785a4 Merge pull request #8804 from jmolmo/fix_timeout
ceph: retry <ceph orch> commands when they fail
2021-10-01 10:55:32 -06:00
Sébastien Han 5f0cfb6829 Merge pull request #8896 from aruniiird/alert-interval-changes
ceph: increasing the auto-resolvable alerts' delay to 15m
2021-10-01 14:57:49 +02:00
Arun Kumar Mohan a7f16c912a ceph: increasing the auto-resolvable alerts' delay to 15m
The following alerts,

CephMonHighNumberOfLeaderChanges
CephOSDDiskNotResponding
CephClusterWarningState

, which are resolved automatically, in most cases,
are causing unnecessary admin events. So we are increasing the
alert delay time to '15m'.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2021-10-01 11:44:43 +00:00
Sébastien Han 3c93eb3ab8 Merge pull request #8901 from aruniiird/add-namespace-to-ceph-queries
ceph: adding 'namespace' field to the needed ceph queries
2021-10-01 13:42:29 +02:00
Arun Kumar Mohan 8950e78a4f ceph: adding 'namespace' field to the needed ceph queries
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2021-10-01 16:05:54 +05:30
Sébastien Han 8468b6f777 Merge pull request #8897 from travisn/test-local-build
build: Run canary tests against the local-build tag
2021-10-01 09:44:20 +02:00
Blaine Gardner c084ee715f Merge pull request #8898 from BlaineEXE/fix-double-makelib-helm-mk-include
build: fix double include of build/makelib/helm.mk
2021-09-30 16:21:42 -06:00
Travis Nielsen af29d1d801 build: run canary tests against the local-build tag
The canary tests were still picking up the tag from operator.yaml
and toolbox.yaml instead of the new test local-build tag.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 6f48dce3f5)
2021-09-30 15:33:48 -06:00
Travis Nielsen aa085c93b9 Merge pull request #8895 from leseb/mgr-weekly
ci: run the orch ceph manager test daily
2021-09-30 15:31:24 -06:00
Blaine Gardner 74d3492ee5 build: fix double include of build/makelib/helm.mk
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-30 15:29:54 -06:00
Blaine Gardner 7aa4bbfff7 Merge pull request #8878 from BlaineEXE/initial-generate-rbac-from-helm
build: start tracking rbac generated from helm chart
2021-09-30 13:49:21 -06:00
Blaine Gardner e2ba16f710 build: start tracking rbac generated from helm chart
This is a starting step to be able to generate common.yaml from Helm
charts. For right now, we merely want to be able to determine when the
rendered output of the Helm chart changes.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-30 12:20:24 -06:00
Sébastien Han 04e1589a33 ci: run the orch ceph manager test daily
Let's run the test every day at midnight since the code is moving
fast and tends to fail. This gives us some time to fix the issues.
It can be triggered on PR too if the "run-mgr-suite" label is set.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-30 18:54:09 +02:00
Blaine Gardner da52226280 Merge pull request #8885 from BlaineEXE/use-intermediate-tmp-for-offline-image-install-list
build: use intermediate tmp for offline image gen
2021-09-30 08:18:58 -06:00
Sébastien Han 1f49b6f766 Merge pull request #8882 from aruniiird/change-CephMgrIsAbsent-alert
ceph: change CephAbsentMgr to use 'up' query
2021-09-30 09:05:49 +02:00
Satoru Takeuchi a0d0d7ef86 Merge pull request #8881 from BlaineEXE/period-log
rgw: add period does not exist debug message
2021-09-30 16:02:41 +09:00
Blaine Gardner 24bf99f31c build: use intermediate tmp for offline image gen
Reading from a file, processing the file in a pipe, and outputting the
piped content to the same file can have undefined results, often leading
to an empty file. Use an intermediate temp file for generating the
offline image list.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-29 17:31:02 -06:00
Blaine Gardner c6edc1b7d0 Merge pull request #8781 from BlaineEXE/limit-wildcard-in-rbac-verb-resource
rgw: reduce RBAC for lib-bucket-provisioner
2021-09-29 14:40:54 -06:00
aruniiird 854eb0113f ceph: change CephAbsentMgr to use 'up' query
Instead of using 'absent' query, we are trying to use 'up' which should
provide us with the needed 'namespace' field in the resultant metrics

Signed-off-by: aruniiird <amohan@redhat.com>
2021-09-30 01:12:46 +05:30
Blaine Gardner e10fb751e5 rgw: add period does not exist debug message
Log as a debug message when the RGW period will be updated because it
does not exist.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-29 13:14:52 -06:00
Blaine Gardner 2826bc99df Merge pull request #8828 from BlaineEXE/rgw-period-command-should-be-run-on-every-reconcile
rgw: update period if period does not exist
2021-09-29 13:08:27 -06:00