Commit Graph
10516 Commits
Author SHA1 Message Date
Travis Nielsen 6b1f912958 Merge pull request #13236 from rkachach/fix_issue_monitoring_namespace
manifest: adding the namespace tag to the monitoring manifests
2023-11-20 11:43:05 -07:00
Redouane Kachach 147f6e2e78 manifest: adding the namespace tag to the monitoring manifests
including the namespace tag in the monitoring manifests to streamline
the automated process of modifying them through scripting

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-20 17:19:37 +01:00
Travis Nielsen 8f611cfdfc Merge pull request #13228 from Madhu-1/fix-csi-conf-link
doc: correct csi ceph.conf path
2023-11-17 09:48:58 -07:00
Travis Nielsen 250db2b888 Merge pull request #13218 from subhamkrai/min-k8s-1.23
ci: upgrade min k8s support to 1.23.17
2023-11-17 07:24:42 -07:00
Madhu Rajanna d1613af35d doc: correct csi ceph.conf path
correct the csi ceph.conf path
in the documentation.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-11-17 13:38:21 +01:00
subhamkrai 39e41ed8d7 ci: upgrade min k8s support to 1.23.17
Upgrade minimum kubernetes support to 1.23.17 from 1.22.17.
Also, upgrade kubernetes version latest minor release.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-11-17 13:06:46 +05:30
Alexander Trost 931174d36a Merge pull request #13202 from koor-tech/design_osd_scrubbing_schedule 2023-11-17 00:53:27 +01:00
Travis Nielsen 297e8400e5 Merge pull request #12850 from parth-gr/node-telemetry
core: report node metrics using ceph telemetry
2023-11-16 14:55:44 -07:00
Alexander Trost d7311c8e87 docs: add design doc for setting ceph config via cluster crd
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2023-11-16 16:47:00 +01:00
parth-gr f007f2aca1 core: report node metrics using ceph telemetry
Add this reporting with the cephcluster reconcile,
Similar way we reported other telemetry's

Closes: https://github.com/rook/rook/issues/12344

Signed-off-by: parth-gr <paarora@redhat.com>
2023-11-16 19:13:22 +05:30
Travis Nielsen f86fca5e7a Merge pull request #13216 from travisn/upgrade-from-1.12
tests: Upgrade from 1.12 to master
2023-11-15 17:40:58 -07:00
travisn 6c16c0eb83 tests: upgrade from 1.12 to master
The upgrade test should always upgrade from the previous
minor release to the latest master. With 1.13 releasing
soon, now we uprade from 1.12 to master, to confirm
if there are any upgrade issues to 1.13.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-11-15 16:11:14 -07:00
Travis Nielsen 7b57e0640f Merge pull request #13207 from travisn/remove-pacific
core: Remove support for ceph pacific
2023-11-15 10:24:43 -07:00
travisn 03d077aa6b core: remove support for ceph pacific
Pacific is end of life and no longer necessary to
support in Rook with v1.13.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-11-14 17:07:03 -07:00
Blaine Gardner d01029a4b0 Merge pull request #13206 from BlaineEXE/multus-fix-network-canary-all-placement
multus: fix placement error for net addr detect job
2023-11-14 17:58:19 -06:00
Blaine Gardner 0a538bfc37 multus: fix placement error for net addr detect job
Fix an issue in the network address detection job where placement was
only retreived from osd and not merged with all.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-11-14 12:36:58 -07:00
Travis Nielsen 1f157df699 Merge pull request #12817 from parth-gr/objectstore-improvements
object: improve the error handling for multisite objs
2023-11-14 12:33:38 -07:00
parth-gr 46c241433d object: improve the error handling for multisite objs
here is the https://go.dev/play/p/SS9Q-dAiIx3 example which says the
error handling was wrongly implemented

Signed-off-by: parth-gr <paarora@redhat.com>
2023-11-14 15:12:15 +05:30
Blaine Gardner 5230fcd60d Merge pull request #12845 from synarete/nfs-liveness-probe
nfs: add livness-probe to nfs-ganesha container
2023-11-13 13:44:57 -06:00
Travis Nielsen 6f1a3eee01 Merge pull request #13182 from obnoxxx/fix-getopts-in-create-dev-cluster
unify treatment of invocation errors in the create-dev-cluster script
2023-11-13 11:29:40 -07:00
Michael Adam 82c329c6af tests: create-dev-cluster: unify handling of invocation errors
This change to the create-dev-cluster script is intended to make the
handling of invalid invocations more uniform
examples are unknown options and options requiring an argument specified
without one.

The unification is achieved by encapsulating the corresponding code in a
function.

Signed-off-by: Michael Adam <obnox@samba.org>
2023-11-13 19:19:52 +01:00
Travis Nielsen 3288e60cf5 Merge pull request #13069 from subhamkrai/update-device-class
pool: allow updating deviceClass on existing pool
2023-11-13 10:57:57 -07:00
subhamkrai 133154d192 pool: allow updating deviceClass on existing pool
This commits add check to update the deviceClass on
existing pool.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-11-13 20:40:21 +05:30
Travis Nielsen 784325a5d9 Merge pull request #13194 from rook/dependabot/github_actions/dcarbone/install-jq-action-2.1.0
build(deps): bump dcarbone/install-jq-action from 2.0.2 to 2.1.0
2023-11-13 07:43:27 -07:00
Travis Nielsen da53fb8ad2 Merge pull request #13193 from rook/dependabot/go_modules/github-dependencies-0aba6ab15d
build(deps): bump the github-dependencies group with 4 updates
2023-11-13 07:42:29 -07:00
Shachar Sharon e05184d0a7 nfs: allow livness-probe for nfs-ganesha container
Use K8s LivenessProbe mechanism to check OK-status of nfs-ganesha
container. A user may define his own lineness-probe, or a default one
which expects NFS TCP-port 2049 to be active; that is, willing to accept
new connections: for Ceph>=18.2.1 issue 'rpcinfo' call on local pod;
otherwise use standard K8s TCP-socket liveness probe mechanism.
Define permissive values to liveness-probe to ensure that the NFS
service is defined in failed-state only when it has non-recoverable
error.

The current default definition of LivenessProbe is expected to guard the
nfs pod from at least the following two cases:

  - Deadlocks: where an nfs-ganesha server is running, but unable serve
    new connections due to internal bad-state.

  - Resource exhaustion on the host node (e.g. OOM) which prevents the
    server from accepting new connections and reply to NULL RPC request.

In both cases we expect K8s to reschedule the nfs pod, most likely on
different host node.

Refs rook issue #12719

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
2023-11-13 16:21:24 +02:00
Shachar Sharon 7c3e91390e nfs: add optional LivenessProbe to GaneshaServerSpec
Allow end-user to have full control on NFS-Ganesha liveness probe:

  - Disabled
  - Enabled, using user-provided definition
  - Enabled, using Rook's default liveness probe for Ganesha.

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
2023-11-13 16:21:24 +02:00
dependabot[bot] 27ab069863 build(deps): bump dcarbone/install-jq-action from 2.0.2 to 2.1.0
Bumps [dcarbone/install-jq-action](https://github.com/dcarbone/install-jq-action) from 2.0.2 to 2.1.0.
- [Release notes](https://github.com/dcarbone/install-jq-action/releases)
- [Commits](https://github.com/dcarbone/install-jq-action/compare/v2.0.2...v2.1.0)

---
updated-dependencies:
- dependency-name: dcarbone/install-jq-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-11-13 12:32:26 +00:00
dependabot[bot] 3b2a14b1cb build(deps): bump the github-dependencies group with 4 updates
Bumps the github-dependencies group with 4 updates: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go), [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator), [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator) and [github.com/spf13/cobra](https://github.com/spf13/cobra).


Updates `github.com/aws/aws-sdk-go` from 1.46.6 to 1.47.9
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.46.6...v1.47.9)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.68.0 to 0.69.1
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.68.0...v0.69.1)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.68.0 to 0.69.1
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.68.0...v0.69.1)

Updates `github.com/spf13/cobra` from 1.7.0 to 1.8.0
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](https://github.com/spf13/cobra/compare/v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-11-13 12:10:24 +00:00
Blaine Gardner 65d5920584 Merge pull request #13170 from parth-gr/objectsuite-ci
ci: fix objectsuite flakiness
2023-11-09 15:55:51 -06:00
Blaine Gardner a7fce61f68 Merge pull request #13129 from BlaineEXE/multus-use-rook-image-for-ip-detect
multus: use rook image for ip range detection
2023-11-09 11:29:24 -06:00
Travis Nielsen 383dfda153 Merge pull request #13187 from subhamkrai/fix-govul
ci: add go 1.21.4 in govulncheck ci run
2023-11-09 09:28:41 -06:00
subhamkrai a878e52ba7 ci: add go 1.21.4 in govulncheck ci run
In, go 1.20 govulncheck ci is failing due to
some vulnerabilities which affects windows
machine and rook is not used in windows machine.
The solution is to update go version to 1.21.4

Signed-off-by: subhamkrai <srai@redhat.com>
2023-11-09 19:25:30 +05:30
Travis Nielsen 635570a168 Merge pull request #13179 from rkachach/fix_issue_13159
mgr: set interval of serviceMonitor to the value from MonitoringSpec
2023-11-09 07:17:41 -06:00
Redouane Kachach 06bc976959 mgr: set interval of serviceMonitor to the value from MonitoringSpec
This change updates the serviceMonitor interval field with the
value from the MonitoringSpec.

closes: https://github.com/rook/rook/issues/13159

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-09 06:35:20 +01:00
Satoru Takeuchi 77db655558 Merge pull request #13169 from cybozu-go/osd-revert-encrypted-osd-on-part
Revert "osd: support encrypted OSD on partiton"
2023-11-09 06:54:15 +09:00
Blaine Gardner 592b74b1d2 Merge pull request #13157 from rook/dependabot/github_actions/helm/chart-testing-action-2.6.1
build(deps): bump helm/chart-testing-action from 2.6.0 to 2.6.1
2023-11-08 11:13:55 -06:00
Blaine Gardner db1ca8c93e multus: use rook image for ip range detection
Use the Rook image (defined by the operator pod) to detect the Multus
network address ranges. It is reasonable for users to want to have a
minimal Ceph image that does not have the `ip` utility installed, which
is used for detecting the address ranges of multus interfaces. Instead,
use the Rook image, which Rook can ensure has the `ip` tool if Ceph ever
removes it from their image.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-11-08 10:11:04 -07:00
Blaine Gardner 63aaa19a96 Merge pull request #13161 from rook/dependabot/go_modules/golang.org/x/sync-0.5.0
build(deps): bump golang.org/x/sync from 0.4.0 to 0.5.0
2023-11-08 10:46:21 -06:00
Blaine Gardner 553dc38c8c Merge pull request #13173 from rkachach/fix_issue_dev_script_multiple_profiles
test: adding support for multi-rook clusters creation
2023-11-08 10:26:28 -06:00
Redouane Kachach b9501bdddb test: adding support for multi-rook clusters creation
This change introduce a new argument -p to specify the minikube
profile for the new cluster. This way we can have multiple rook
clusters running on the same machine.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-08 13:29:46 +01:00
parth-gr 40295a989c ci: fix objectsuite flakiness
objectstore deletion was failing with not found error,
Could Not get resource in k8s -- Failed to run:
kubectl [get -n object-ns CephObjectStore
other-tls-test-store -o json]
So added a check if it not found then donot check its
further condition

Signed-off-by: parth-gr <paarora@redhat.com>
2023-11-08 15:33:03 +05:30
Travis Nielsen 2cdeeac26f Merge pull request #13166 from Madhu-1/remove-grpc
csi: remove deprecated grpc metrics code
2023-11-07 19:27:55 -06:00
dependabot[bot] 4c87e34470 build(deps): bump golang.org/x/sync from 0.4.0 to 0.5.0
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.4.0 to 0.5.0.
- [Commits](https://github.com/golang/sync/compare/v0.4.0...v0.5.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-11-07 16:20:48 +00:00
dependabot[bot] df5527ce25 build(deps): bump helm/chart-testing-action from 2.6.0 to 2.6.1
Bumps [helm/chart-testing-action](https://github.com/helm/chart-testing-action) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/helm/chart-testing-action/releases)
- [Commits](https://github.com/helm/chart-testing-action/compare/v2.6.0...v2.6.1)

---
updated-dependencies:
- dependency-name: helm/chart-testing-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-11-07 15:49:02 +00:00
Satoru Takeuchi 8e80b21035 Revert "osd: support encrypted OSD on partiton"
This reverts commit 093125904b.

Once we introduced encrypted OSD on partition in #12924.
However, even though `encryptedDevice` field is `true`,
an non-encrypted OSD is created. To prevent the creation
of misconfigured OSD, it's better to revert #12924 for now.

Initially, I intended to correct this problem. However, I found
it will take long time because we need to change the KMS-related
code, init containers of both OSD pod and OSD prepare pod.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2023-11-07 12:37:31 +00:00
Sébastien Han 572f3890bf Merge pull request #13158 from rkachach/fix_issue_dev_script_feature_2
test: using minikube profiles for rook cluster creation
2023-11-07 13:36:35 +01:00
Redouane Kachach 1d0fb2f5a1 test: adding a new variable for minikube command and its args
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-07 12:54:36 +01:00
Sébastien Han 3704ad9bec Merge pull request #13143 from travisn/pr-description
build: Clarify PR template instructions
2023-11-07 12:14:27 +01:00
Madhu Rajanna 5658e026cb csi: remove deprecated grpc metrics code
GRPC metrics got deprecated in cephcsi
3.7.0 and the deprecated flags will get
removed in the next release. This PR
removes the deprecated metrics code which
allow us to run with older cephcsi as well.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-11-07 11:24:17 +01:00