Commit Graph
8274 Commits
Author SHA1 Message Date
Blaine Gardner 9a5d43761d test: collect fuller logs for CI tests
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-02-22 13:14:39 -07:00
Travis Nielsen dc7a837262 Merge pull request #9777 from travisn/local-test-warning
docs: Warn in quickstart guide about using a vm
2022-02-21 14:43:14 -07:00
Travis Nielsen eb4ac1d6c9 docs: warn in quickstart about using a vm
If Rook is run on a developer machine, devices may accidentally
be consumed by rook and cause data loss.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-02-21 13:58:12 -07:00
Blaine Gardner d73093883b Merge pull request #9765 from BlaineEXE/update-cleanup-doc
docs: clarify teardown disk zap section
2022-02-21 08:15:10 -07:00
Satoru Takeuchi 4ba43b077c Merge pull request #9770 from bootjp/fix_typo
Fix typo
2022-02-21 08:06:54 +09:00
bootjp / Yoshiaki Ueda 294b6854f6 test: fix typo
GitHub is officially known as GitHub. https://github.com/logos

Signed-off-by: bootjp / Yoshiaki Ueda <contact@bootjp.me>
2022-02-19 20:32:23 +09:00
bootjp / Yoshiaki Ueda 1d86648a7f docs: fix typo
GitHub is officially known as GitHub.
https://github.com/logos

Signed-off-by: bootjp / Yoshiaki Ueda <contact@bootjp.me>
2022-02-19 20:32:01 +09:00
Travis Nielsen d339d39ef7 Merge pull request #9766 from BlaineEXE/daily-nightly-job-fix-log-collection
test: fix upgrade test namespace in daily-nightly CI
2022-02-17 15:38:23 -07:00
Blaine Gardner 362eaac98d test: fix upgrade test namespace in daily-nightly CI
PR #9546 missed updating the daily-nightly CI jobs, and logs are no
longer properly collected from the upgrade jobs there.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-02-17 15:05:33 -07:00
Blaine Gardner 325eda655c docs: clarify teardown disk zap section
Users have reported some problems understanding the teardown
"Zapping Devices" section. Break the section in to per-disk and
all-disks-on-host parts, and clarify that they are not one-size-fits-all
scripts.

Resolves #9542
Resolves #9764

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-02-17 13:00:07 -07:00
Sébastien Han 3b0547a88c Merge pull request #9760 from leseb/fix-external-cluster-csi-validation
core: various external mode enhancements
2022-02-17 16:44:17 +01:00
Satoru Takeuchi f6abe14d03 Merge pull request #9746 from travisn/osd-return-error
osd: Return error if fail to list osds in prepare job
2022-02-18 00:13:08 +09:00
Sébastien Han 0143a8f8ee core: remove unnecessary secret validation
We don't need to validate the name of Ceph-CSI secret, simply because
the names can be different. The default example have default names but
since the secret can be created by the administrator we should not
assume anything. This check will fail if the secret names are different
for whatever reason. This is especially true for external mode. In
converged mode Rook creates the secrets on its own if needed to ease the
integration with the default StorageClass examples.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-02-17 15:33:54 +01:00
Sébastien Han 47b8bb989e core: move clusterInfo discovery in converged cluster
The external code has its own mechanism to look up the clusterInfo so
let's move this to the non-external condition to clarify the code.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-02-17 15:32:37 +01:00
Sébastien Han fdcad15b87 core: check for canceled context in external mode
This is fixing a potential race where the context is canceled and the
external cluster is trying to fetch the cluster info. If the context is
canceled then the loop will be stuck forever. Now we check for the
canceled context and return appropriately.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-02-17 15:30:25 +01:00
Travis Nielsen eb24b17844 Merge pull request #9758 from Madhu-1/remove-rbd-default
ceph: remove rbd_default_features setting
2022-02-17 07:29:58 -07:00
Madhu Rajanna f482b1ceba core: remove rbd_default_features setting
Instead of setting the default values in the Rook
we should use the defaults provided by the ceph
it self. This configuration is causing problem
for the rbd image creation, this is not allowing
the rbd images to have default image features
which comes with librbd.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-02-17 16:08:55 +05:30
Sébastien Han ad42c7ecc3 Merge pull request #9511 from leseb/fix-9488
docs: add multus known limitations
2022-02-17 10:25:54 +01:00
Sébastien Han a25dd4ec4c docs: add multus known limitations
Add doc to explain why some daemons are not listening to the NAD.

Closes: https://github.com/rook/rook/issues/9488
Signed-off-by: Sébastien Han <seb@redhat.com>
2022-02-17 10:00:32 +01:00
Sébastien Han a6fc3ae467 Merge pull request #9609 from parth-gr/external-cluster-client-upgrade
csi: modify upgrade flag in external cluster
2022-02-16 11:10:02 +01:00
Sébastien Han d86351aa1c Merge pull request #9728 from thotz/vault-kms-backendpath-tranist-engine-fix
object: fix backend path for transit engine for rgw kms
2022-02-16 10:21:08 +01:00
parth-gr 3e64525b62 csi: make use of common user creation method
refactor the code so we can use common csi user
creation method

Signed-off-by: parth-gr <paarora@redhat.com>
2022-02-16 10:29:34 +05:30
parth-gr 9b20b475cf csi: modify upgrade flag in external cluster
The upgrade function doesn't seem to be that smart
for now so it can update the new auth caps listed
with the existing one, it only compares the value of
the current cap with the MIN_USER_CAP_PERMISSIONS,

Modified the upgrade flag functionality so we can use
this while upgrading the cluster clients

Closes: https://github.com/rook/rook/issues/9589

Signed-off-by: parth-gr <paarora@redhat.com>
2022-02-16 10:29:34 +05:30
Travis Nielsen d4b8fa19b2 osd: return error if fail to list osds in prepare job
The OSD prepare job was succeeding even if the OSDs failed to be listed
by ceph-volume. These errors should be returned and fail the job, resulting
in a retry to retrieve the OSDs. Otherwise, the failure is masked and
the admin needs to dig through logs to find why the OSDs were not configured
on that node.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-02-15 15:49:50 -07:00
Travis Nielsen 1d5b43593e Merge pull request #9718 from travisn/node-placement-logging
osd: Write log message when node is being skipped
2022-02-15 08:14:56 -07:00
Travis Nielsen 23e934c899 Merge pull request #9690 from thotz/bucketnotificatione2e
test: update bucket notification integration test with http server
2022-02-15 07:43:25 -07:00
Jiffin Tony Thottan 0b4cdb992b object: fix backend path for transit engine for rgw kms
The backend path was added with additional `transit` to it.
Also added PR test case to check transit engine

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2022-02-15 18:49:31 +05:30
Jiffin Tony Thottan 438cf6abf1 test: update bucket notification integration test with http server
Add test cases to check notification is received by http server. For
this a sample http server https://github.com/thotz/pythonwebserver is
used.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2022-02-15 12:59:58 +05:30
Travis Nielsen 476e94632b Merge pull request #9713 from Rakshith-R/cleanup-csi
csi: cleanup csi driver resources when zero cephclusters exist
2022-02-14 13:31:20 -07:00
Travis Nielsen 4570204a1d osd: write log message when node is being skipped
When a node is being skipped for creation of OSDs, log a message
that indicates whether it was from the node being unschedulable,
the node is not ready, or the node does not meet the placement
criteria specified in the cluster CR.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-02-14 12:06:49 -07:00
Travis Nielsen 3fc49f2b9a Merge pull request #9735 from subhamkrai/add-comment
csi: add comment after namespace
2022-02-14 07:33:05 -07:00
Travis Nielsen f08172ed92 Merge pull request #9734 from leseb/fix-rgw-vault
rgw: fix variable assignment
2022-02-14 07:18:20 -07:00
subhamkrai 5b49d36167 csi: add comment after namespace
adding comment after namespace to identify if
it cluster namespace or operator namespace.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-02-14 18:39:33 +05:30
Sébastien Han 7f32461b8f rgw: fix variable assignment
We need to explicitly assign the ceph version within each scope since
one function returns a pointer and one is not.
Previously, the `desiredCephVersion` was recreated in the scope of the
`else` and thus a new variable `desiredCephVersion` was initialized (see
the `:=`).
Now, each scope creates and assign to clusterInfo a `desiredCephVersion`
value.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-02-14 12:42:30 +01:00
Sébastien Han c3e02e7295 Merge pull request #9724 from leseb/fix-external-object
object: do not check for upgrade on external mode
2022-02-11 09:32:55 +01:00
Travis Nielsen 2d3839bf41 Merge pull request #9715 from leseb/ix-9714
core: do not dereference a non-pointer
2022-02-10 09:56:08 -07:00
Sébastien Han 856b14e60a object: do not check for upgrade on external mode
The object child controller should not compare versions if the object
store is external. The current version comparison is using the
cmdreporter to check the ceph version of the image in the CephCluster spec.
In external mode, this image is not set so the cmdreporter fails.
Also, this check is only valid for converged mode, so external mode
should be skipped.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-02-10 17:41:01 +01:00
Sébastien Han 32998cbda4 core: do not dereference a non-pointer
In this case `oldMappingToGo` and `newMappingToGo` were not pointers so
there is nothing to dereference.
This happens when the monitors endpoints configmap is updated, but only
on the pool and file controllers. They are watching for changes on that
configmap so that they can reconcile and upate the bootstrap peers token
when replication is enabled.

Closes: https://github.com/rook/rook/issues/9714
Signed-off-by: Sébastien Han <seb@redhat.com>
2022-02-10 17:11:38 +01:00
Travis Nielsen 8e8c95d342 Merge pull request #9702 from sathieu/registrar_v2.5.0
csi: bump registar image to v2.5.0
2022-02-10 08:59:30 -07:00
Sébastien Han 213be4023e Merge pull request #9720 from leseb/vualt-k8s-auth-ns
osd: add namespace in vault client
2022-02-10 16:47:07 +01:00
Sébastien Han 23832c8cc7 osd: add namespace in vault client
If the KMS connection details for Vault have a VAULT_NAMESPACE we must
use it when building the vault client to auto-detect the KV internal
version.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-02-10 12:13:41 +01:00
Travis Nielsen 014eef7bb9 Merge pull request #9624 from yati1998/addons-doc
doc: Adds doc for implementation of csi-addons
2022-02-09 09:21:48 -07:00
yati1998 045cc87e03 docs: adds doc for implementation of csi-addons
This commit adds the documentation for implementation
of csi-addons.

Signed-off-by: yati1998 <ypadia@redhat.com>
2022-02-09 15:10:57 +05:30
Rakshith R 1e9920fb85 csi: cleanup csi driver resources when zero cephclusters exist
This commit modifies ceph-csi controller to be able to cleanup
ceph-csi deployment,daemonset,services & csidriver objects
when no cephcluster exists.

It makes the following changes:
- redundant check for tp.DriverNamePrefix is removed.
- retry to start drivers within reconcile loop is removed,
  controller will retry in case of error now.
- stopDrivers() will now return error in case of failure.
- predicate delete func will now respond to cephcluster deletion.
- CSI resources will be cleaned up when cephcluster does not exist.

Fixes: #9697

Signed-off-by: Rakshith R <rar@redhat.com>
2022-02-09 12:07:34 +05:30
Travis Nielsen 4c63785867 Merge pull request #9696 from travisn/update-pool-properties
object: Update object pool properties during reconcile
2022-02-07 07:34:08 -07:00
Sébastien Han 40dc6cf947 Merge pull request #9703 from parth-gr/get-and-create
csi: make create and get process separate for csi users
2022-02-07 11:30:42 +01:00
Travis Nielsen 221b3dfb72 object: update pool properties during reconcile
The reconcile was skipping updating most pool properties for
object stores. The implementation of pools between the file,
object, and pool controllers had some duplicate code, so
this change also factors out the common code for better
reuse in a single place. Anytime a pool is created or updated,
it will now consistently update all the pool properties
that are expected to be modifiable.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-02-04 13:41:12 -07:00
Blaine Gardner ba7318c388 Merge pull request #9643 from BlaineEXE/multus-csi-design
docs: add CSI section to Multus design doc
2022-02-04 11:19:23 -07:00
Satoru Takeuchi 5e038806a8 Merge pull request #9682 from cybozu-go/core-eliminate-nautilus-code
core: eliminate unnecessary code
2022-02-04 23:39:45 +09:00
parth-gr 4f43f2d93e csi: make create and get process separate for csi users
Currently if we run external-script and user already exit,
it fails to create/run same user again if the caps are upgraded,
so we need to check first if user is already present.
And for upgrading user we can do upgrade after this
PR: https://github.com/rook/rook/pull/9609 will get merged.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2048458

Signed-off-by: parth-gr <paarora@redhat.com>
2022-02-04 20:08:31 +05:30