Commit Graph
7961 Commits
Author SHA1 Message Date
Sébastien Han 4df2549863 Merge pull request #6198 from leseb/init-dashboard
ceph: only enable init container if dash is enabled
2020-09-01 13:20:40 +02:00
Sébastien Han 152ebf618d ceph: only enable init container if dash is enabled
If the dashboard module is not enabled we don't need to run the
"dashboard-server-addr" init container.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-09-01 11:42:40 +02:00
Sébastien Han 7dea2b10ff ceph: disable ceph mgr test temporarily
The CI keeps failing intermittently due to
https://github.com/rook/rook/issues/5877 and the fix has not merged yet
so disabling until fixed.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-09-01 11:24:09 +02:00
Sébastien Han f133fecf3c Merge pull request #6142 from leseb/svc-mon
ceph: do not use label selector on external svc
2020-09-01 11:19:35 +02:00
Servesha Dudhgaonkar 0c323439a6 ceph: purge a down osd with a job
If an OSD is down and needs to be removed from the cluster,
a job can be run that will remove the OSD deployment
and purge the OSD from ceph. If the OSD is still up,
the purge will be rejected.

To purge multiple OSDs at the same time, the OSD IDs can be
specified as a comma-separated list.

Signed-off-by: Servesha Dudhgaonkar <sdudhgao@redhat.com>
2020-09-01 09:36:20 +02:00
Sébastien Han a3328564bd Merge pull request #6187 from greenstatic/docs-formatting-fix
docs: fix markdown code block formatting issue
2020-09-01 09:33:43 +02:00
Sébastien Han 96b4a56a57 ceph: silence aws s3 sdk logs on healthcheck
We don't need to activate the debug logs on the objectstore
healthchecks.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-09-01 09:32:15 +02:00
Sébastien Han af72502fe4 ceph: do not use label selector on external svc
When the cluster is external there are no running pods so setting a
Selector on the Service Spec does not make sense, even worse, it makes
Kubernetes reconciling and overriding the configured endpoint.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-09-01 09:32:15 +02:00
Sébastien Han bd90f9afe9 ceph: add more error handling and debug logging
The predicate was lacking from very useful errors as well as logging
messages.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-09-01 09:32:15 +02:00
Sébastien Han e7043edbd8 ceph: reconcile if cm is config override
Earlier, we were returning only when the object was not the config
override configmap, we want the opposite.
Also, this was blocking all subsequent conditions and add the correct
check to avoid cm to reconcile.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-09-01 09:32:15 +02:00
Sébastien Han b68f9a7a41 ceph: fix the service monitor port name
When the cluster is external the service monitor port name should match
with the name of the external metrics one.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-09-01 09:32:15 +02:00
Sébastien Han 6b11a86bf0 Merge pull request #6193 from satoru-takeuchi/ci-force-reset-test-cluster
ci: reset test cluster without prompting
2020-09-01 09:12:05 +02:00
Sébastien Han 65fa318e0c Merge pull request #6190 from leseb/fix-ci-disk
ci: change disk used by the CI
2020-09-01 09:00:06 +02:00
Satoru Takeuchi 4b764c20b1 ci: reset test cluster without prompting
It's messy to answer `y` everytime in `tests/script/kubeadm.sh clean.`
Since the cluster only exists for testing, it's safe to reset without prompting.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2020-09-01 14:02:28 +09:00
Satoru Takeuchi 6ae37de6fb ceph: update the note of OSD on LV-backed PVC
The problem of OSD on LV-backed PVC can be mitigated with disabling
`lvmetad`.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2020-09-01 04:18:14 +00:00
Obleskar 55da5e9560 edgefs: docs: note nfs service name restrictions
Add a note that NFS service names created by efscli need to comply with
k8 DNS naming restrictions. Failure to do so will result in an invalid NFS
object manifest name.

Signed-off-by: Obleskar <benjamindeuson@gmail.com>
2020-08-31 19:41:51 -07:00
Sébastien Han 9a06d059f0 ci: change local disk path
With the recent aws instance type the disk naming changed too, so
replace xvdc with nvme0n1.

Closes: https://github.com/rook/rook/issues/6189
Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-31 22:04:46 +02:00
Sébastien Han 04467dd915 ci: print dev info
Try to understand the issue:

invalid scratch device name: /dev/xvdc

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-31 22:04:33 +02:00
Sébastien Han a10b5e2534 Merge pull request #6145 from raghavendra-talur/rtalur-add-uninstall-mode
ceph: add uninstall mode
2020-08-31 22:00:30 +02:00
Raghavendra TalurandNitin Goyal f8a721dbb0 ceph: doc additions for the uninstall mode
Add documentation for the setting AllowUninstallWithVolumes to the
following files:
Documentation/ceph-cluster-crd.md
cluster/examples/kubernetes/ceph/cluster.yaml

Co-authored-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
2020-08-31 14:07:32 -04:00
Raghavendra TalurandNitin Goyal 42a30ff5f8 ceph: skip check for existing PVs in forced uninstall
If AllowUninstallWithVolumes is set in the cleanup policy then we don't
check and wait for the deletion of existing volumes from the
cephCluster.

Co-authored-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
2020-08-31 14:07:32 -04:00
Raghavendra TalurandNitin Goyal a6f59f3b64 ceph: add uninstall mode
This adds an uninstall mode to the ceph cluster. If
allowUninstallWithVolumes in the CleanupPolicySpec is set to true then
the cluster deletion does not wait for the PVs to be deleted.

Co-authored-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
2020-08-31 14:06:44 -04:00
Gregor Krmelj 256b284b35 docs: fix markdown code block formatting issue
this fixes the issue of the code block not being rendered
correctly from markdown into html.

Signed-off-by: Gregor Krmelj <gregor@krmelj.xyz>
2020-08-31 16:40:48 +02:00
Travis Nielsen 2d6750d79c Merge pull request #5956 from travisn/k8s-1.19-tests
ci: Run integration tests on k8s 1.19
2020-08-28 12:04:09 -06:00
Travis Nielsen 34d40fee6e ceph: upgrade test uses rbac v1 instead of v1beta1
The upgrade tests can safely use the rbac.authorization.k8s.io/v1 instead of
rbac.authorization.k8s.io/v1beta1. In K8s 1.19, the upgrade test was failing
because v1beta1 has been deprecated.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-08-28 10:26:36 -06:00
Travis Nielsen 68b3789bba ci: run integration tests on k8s 1.19
With the pending release of k8s 1.19 we need to start running
the integration tests on 1.19. In master we remove support for
1.14 to keep the last five releases running in master.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-08-28 08:35:45 -06:00
Travis Nielsen bebaed09b5 Merge pull request #6176 from leseb/workflow-unittests
ci: run unit test in a github workflow
2020-08-27 16:28:02 -06:00
Sébastien Han 575b00f4c3 ci: only run unit tests on official build
Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-27 22:33:54 +02:00
Sébastien Han 296997e723 Merge pull request #6175 from leseb/do-not-exec-lvm
ceph: do not exec on rootfs just lookup
2020-08-27 16:26:02 +02:00
Sébastien Han 48dad45f98 ci: run unit tests in gh actions
We now run Rook's unit test in gh workflows

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-27 16:19:10 +02:00
Sébastien Han c5a1bbda75 Merge pull request #6166 from leseb/modcheck-workflow
ci: add modcheck github workflow
2020-08-27 15:43:04 +02:00
Sébastien Han f2313d6db0 ceph: do not exec on rootfs just lookup
Trying to execute a binary from the host within the container can result
in mismatched libraries. The host version is compiled with paths of
libraries on the host where the libs inside the container can differ.
Because the path is known and we only need to make sure whether the bin
exists or not then simply doing a lookup when we fallback on /rootfs is
sufficient.

Closes: https://github.com/rook/rook/issues/6078
Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-27 15:16:46 +02:00
Sébastien Han 58c8de95be ci: add modcheck github workflow
Add a new github workflow to verify with mod check.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-27 12:15:41 +02:00
Travis Nielsen 85d72f70b0 Merge pull request #6170 from leseb/obc-log
ceph: run obc requests with debug
2020-08-26 20:45:13 -06:00
Sébastien Han 3a92f98233 ceph: use special dns suffix for object ep
By addding ".svc.cluster.local" to the endpoint of the object store, the
OBC requests won't go through a proxy if any is configured.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-26 17:10:31 -06:00
Sébastien Han 5bcade6d55 Merge pull request #6164 from cybozu-go/ceph-improve-common-issues-document
ceph: improve common issues document
2020-08-26 15:56:14 +02:00
Sébastien Han bcd76bf46d ceph: run obc requests with debug
Use debug log to all the s3 calls so it's either to debug. Also, it's
not so verbose.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-26 15:27:49 +02:00
Travis Nielsen 24b0bdd119 Merge pull request #6156 from cloudical-io/first_part_6111
ceph: operator should only "watch" OSD placement nodes
2020-08-26 07:20:30 -06:00
Satoru Takeuchi 65528d67ed ceph: improve common issues document
node-hangs-after-reboot problem can't be fixed with ceph-csi:2.0.1
if Rook is v1.2.x. It's because this version doesn't have a bind
mount that is needed to fix this problem.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2020-08-25 22:09:33 +00:00
Travis Nielsen e40b462216 Merge pull request #6084 from cloudical-io/additional_user_labels_ceph
ceph: allow user to add labels to pods
2020-08-25 15:58:40 -06:00
Travis Nielsen b7034c16a0 Merge pull request #6160 from travisn/doc-ceph-upgrades-link
docs: Fix link to ceph upgrade guide
2020-08-25 13:52:04 -06:00
Travis Nielsen d786b7f547 docs: fix link to ceph upgrade guide
There was a broken link in the cluster CR documentation that was pointing
to /Documentation instead of the .md in the same dir.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-08-25 13:43:03 -06:00
Alexander Trost a87c00ddee ceph: allow user to add labels to pods
This allows users to specify additional labels to be added to the components
created by the Rook Ceph operator.
Additionally the rbd mirrors are now getting their annotations and
labels set.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2020-08-25 19:38:51 +02:00
Travis Nielsen 06db5785b3 Merge pull request #6136 from subhamkrai/security-text
ceph: vulnerability in package golang.org/x/text
2020-08-25 11:29:35 -06:00
Sébastien Han fed4775a9b Merge pull request #6158 from leseb/workflow-make-codegen
ci: run make codegen validation in workflow
2020-08-25 19:27:29 +02:00
Sébastien Han 0c1250ac81 ceph: resync codegen
Resync API.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-25 19:21:50 +02:00
Sébastien Han af5a7f4df8 ci: run make codegen validation in workflow
Fail if a PR is submitted and has not run "make codegen"

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-25 19:19:15 +02:00
Alexander Trost 94d5196439 ceph: operator should only "watch" OSD placement nodes
This change is the first part to improve the watch OSD nodes logic in
the Rook Ceph operator.
This commit changes the "is node valid check" to use the OSD placement
instead of the all placement. The OSD placement is "merged" with the
all placement already.

Second step will be to skip the first "iteration" of the "nodes added"
events and then start the actual watch logic.

Partially resolves #6111.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2020-08-25 18:16:20 +02:00
Sébastien Han 69f6e87fd1 Merge pull request #6152 from leseb/fix-multus-csi
ceph: correctly return if multus was applied
2020-08-25 11:56:25 +02:00
Sébastien Han 8668e1f69c ceph: correctly return if multus was applied
We must only return if multus got configured successfully.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-25 09:54:18 +02:00