There is a missing YAML document / object separator in the apply file.
This PR adds it so it can be applied without errors.
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
This fixes the helm commands to be compatible with Helm v3.x and adds an
example / notes for Helm v2.x users.
Resolves#5491
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
Some more optional items in json output.
RBD Provisioner, CSI CephFS node and provisioner are now optional and
will only be populated if they are available.
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
callCephVolume() was using our exec interface with CombinedOutput which
means return both stdout and stderr. This is fine when preparing OSDs
since we read back the stdout and also want any errors if any (stderr).
However when listing OSD we only want the output since ceph-volume tends
to mix stdout and stderr in the output and does not always silence the
warning types/harmless errors. If the listing has a problem we report it
by printing the ceph-volume log file.
Signed-off-by: Sébastien Han <seb@redhat.com>
There is a critical flaw in OSD on LV-backed PVC. So it's necessary
to let users to know what they should do.
Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
If a node is gone, we try to remove crash collector deployments so they
don't stay stale or pending. We must ensure the node is gone and not
just return an error even if we successfully deployment the orphan
deployment.
Signed-off-by: Sébastien Han <seb@redhat.com>
Older versions of lvm do not implement "--help" but "help" only where
new versions support both so let's use "help" so the check works for all
the versions.
Closes: https://github.com/rook/rook/issues/6057
Signed-off-by: Sébastien Han <seb@redhat.com>
`anon-user-access` clusterrolebinding is created when installing rook operator.
However each test suite does not delete the clusterrolebinding,
and cause errors.
This PR skip creating the clusterrolebinding in each suite if it already exists.
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
Now the metadata pvc will also be encrypted if the storageClassDeviceSet
has the "encrypted" flag turned on.
Signed-off-by: Sébastien Han <seb@redhat.com>
The helper to convert annotations to a string map is not needed in the
production code, so it is moved to the unit tests.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Applying annotations was crashing when there were no annotations in the
original map. Now the map is initialized when no annotations are set
in the original map.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
currently, the object store schema requires the
port to be non-zero. This does not allow http
access to the object store to be disabled.
so setting the port minimum to 0 to from 1 in the cr.
Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
The CSV generation needs to be patched with the correct service account names
for the correct RBAC to be generated.
Signed-off-by: Sébastien Han <seb@redhat.com>
When a mon is failed over, the new mon is started before the old mon
is removed from quorum and purged from the cluster. If the mon has
anti-affinity, in small clusters or specific toplogies where sufficient
nodes are not available, the new mon may be prevented from starting simply
because the dead mon pod still exists. To ensure a clean failover, the
dead mon pod must first be stopped before the new mon is started.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Alexander Trost
Travis Nielsen
Sébastien Han
Arun Kumar Mohan
Satoru Takeuchi
Humble Chirammal
Madhu Rajanna
Takashi IIGUNI
subhamkrai