feedc0de/my-rook-config
1
0 Fork 0
forked from rook/rook
Code Pull Requests Activity
13,650 Commits 38 Branches 289 Tags
9eec9c730ea6aa4d4d4ed5590957cfed13402e55
Commit Graph
13650 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Joshua Hoblitt 9eec9c730e core: rm unused consts 
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2026-05-14 09:34:52 -07:00
Travis Nielsen a7d4c0ce88 Merge pull request #17448 from taraasrita10/adding-watcher-drbd-cm 
mon: add watcher for DRBD ConfigMap in TNF deployments
 2026-05-14 09:51:47 -06:00
Prabhala Tara Aasrita af03615e97 mon: add watcher for DRBD ConfigMap in TNF deployments 
Added a watcher in the cluster controller to detect changes to the DRBD ConfigMap used by floating monitors in TNF deployments. When the ConfigMap is updated, the watcher triggers a CephCluster reconciliation to ensure configuration changes are applied.

Fixes #17338

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
 2026-05-14 18:15:32 +05:30
Blaine Gardner 5920f47d58 Merge pull request #17468 from OdedViner/aws_sdk_2_notification 
object: migrate notification package to aws sdk v2
 2026-05-13 11:35:46 -06:00
Oded Viner f5df592106 object: migrate notification package to aws sdk v2 
migrate the notification provisioner and s3ext packages from
aws sdk v1 to v2. the custom DeleteBucketNotification call is
rewritten to manually build and sign the HTTP request using the
v2 v4 signer, since this ceph-specific API has no sdk equivalent.

also fix t.Skipped() -> t.Skip() in notification integration test.

Signed-off-by: Oded Viner <oviner@redhat.com>
 2026-05-13 19:06:52 +03:00
Travis Nielsen d9381469e0 Merge pull request #17286 from lumir-sliva/cleanup-csi-operator-resources 
doc: add CSI operator resource cleanup steps to teardown guide
 2026-05-12 12:45:10 -10:00
Travis Nielsen 2898acddfc Merge pull request #17494 from immanuwell/docs-fix-duplicated-words 
docs: fix duplicated words in docs and comments
 2026-05-12 12:41:18 -10:00
Travis Nielsen 4cf71d9a27 Merge pull request #17472 from texasich/codex-rook-17405 
mgr: retry self-signed cert creation on wrapped context deadline errors
 2026-05-12 12:37:11 -10:00
Lumir Sliva 943ea89cd5 doc: add CSI operator resource cleanup steps to teardown guide 
Add a section to the teardown documentation with cleanup commands
for CSI operator resources: OperatorConfig, Driver, ClientProfile,
ClientProfileMapping, and CephConnection custom resources, plus the
csi-operator.yaml deployment manifest.

Signed-off-by: Lumir Sliva <61183145+lumir-sliva@users.noreply.github.com>
 2026-05-13 00:23:26 +02:00
Parth Arora d9d6461bf2 Merge pull request #17502 from sp98/fix-CleanupUnusedCrushRules 
core: skip crush rule cleanup if no pools exist yet
 2026-05-12 19:53:46 +05:30
subham rai 5cc791ccf6 Merge pull request #17510 from rook/dependabot/go_modules/github-dependencies-78e89dec3a 
build(deps): bump the github-dependencies group with 3 updates
 2026-05-12 15:24:15 +05:30
subham rai 1effc90014 Merge pull request #17509 from rook/dependabot/github_actions/github/codeql-action-4.35.4 
build(deps): bump github/codeql-action from 4.35.3 to 4.35.4
 2026-05-12 15:23:57 +05:30
subham rai eadd24c60e Merge pull request #17508 from rook/dependabot/github_actions/aws-actions/configure-aws-credentials-6.1.1 
build(deps): bump aws-actions/configure-aws-credentials from 6.1.0 to 6.1.1
 2026-05-12 15:23:39 +05:30
subham rai 692b69bc11 Merge pull request #17507 from rook/dependabot/github_actions/sigstore/cosign-installer-4.1.2 
build(deps): bump sigstore/cosign-installer from 4.1.1 to 4.1.2
 2026-05-12 15:23:20 +05:30
Santosh 1c1d6cf261 core: skip crush rule cleanup if no pools exist yet 
During the initial cluster setup, CleanUnusedCrushRules() runs after MGR
startup but before any pools are created (if user does not create the
.mgr pool along with the cephCluster manifest). It deletes the default
replicated_pool since no pool references it.

This leaves the cluster in a state if Zero crush rules. When the MGR
tries to start the device_health_metris during this window, thne it
fails to find the crush rule and crashes.

Skip the cleanup when no pools exists yet, since there is nothing
meaninful to cleanup.

Signed-off-by: Santosh <sapillai@redhat.com>
 2026-05-12 11:45:04 +05:30
Travis Nielsen a6b7da2c5a Merge pull request #17474 from travisn/stable-concurrency 
core: Declare concurrent cluster reconciles stable
 2026-05-11 12:49:21 -10:00
Travis Nielsen 0dc9191237 Merge pull request #17503 from OdedViner/test_nvme_ocp 
nvmeof: add sys_admin to scc allowedcapabilities for gateway pods
 2026-05-11 12:03:33 -10:00
dependabot[bot] e7ae1cead9 build(deps): bump the github-dependencies group with 3 updates 
Bumps the github-dependencies group with 3 updates: [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2), [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator) and [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator).


Updates `github.com/aws/aws-sdk-go-v2/service/s3` from 1.100.1 to 1.101.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/service/s3/v1.100.1...service/s3/v1.101.0)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.90.1 to 0.91.0
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.90.1...v0.91.0)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.90.1 to 0.91.0
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.90.1...v0.91.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/s3
  dependency-version: 1.101.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring
  dependency-version: 0.91.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client
  dependency-version: 0.91.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-05-11 19:53:10 +00:00
dependabot[bot] 2b2f6f5832 build(deps): bump github/codeql-action from 4.35.3 to 4.35.4 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.3 to 4.35.4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/e46ed2cbd01164d986452f91f178727624ae40d7...68bde559dea0fdcac2102bfdf6230c5f70eb485e)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.35.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-05-11 19:52:33 +00:00
dependabot[bot] f5531ea12e build(deps): bump aws-actions/configure-aws-credentials 
Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 6.1.0 to 6.1.1.
- [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases)
- [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md)
- [Commits](https://github.com/aws-actions/configure-aws-credentials/compare/ec61189d14ec14c8efccab744f656cffd0e33f37...d979d5b3a71173a29b74b5b88418bfda9437d885)

---
updated-dependencies:
- dependency-name: aws-actions/configure-aws-credentials
  dependency-version: 6.1.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-05-11 19:52:19 +00:00
dependabot[bot] 77d9d958bc build(deps): bump sigstore/cosign-installer from 4.1.1 to 4.1.2 
Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/sigstore/cosign-installer/releases)
- [Commits](https://github.com/sigstore/cosign-installer/compare/v4.1.1...v4.1.2)

---
updated-dependencies:
- dependency-name: sigstore/cosign-installer
  dependency-version: 4.1.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-05-11 19:52:14 +00:00
Oded Viner f8c1c99cb4 nvmeof: add sys_admin to scc allowedcapabilities for gateway pods 
the nvmeof gateway requires privileged containers with
sys_admin capability. the rook-ceph scc only allowed mknod,
causing pod creation to fail on openshift with:
"unable to validate against any security context constraint"

add sys_admin to allowedcapabilities in the helm chart sccs
and the go scc helper. this does not affect other daemons
(osd, rgw, mgr, mon) since they do not request sys_admin.

the operator-openshift.yaml example already includes
sys_admin, so this aligns the helm charts to match.

Signed-off-by: Oded Viner <oviner@redhat.com>
 2026-05-11 13:47:12 +03:00
subham rai 0b359e9461 Merge pull request #17498 from OdedViner/bump-x-net-govulncheck 
build: bump golang.org/x/net to fix govulncheck ci failure
 2026-05-11 14:54:24 +05:30
Oded Viner 20fa0128f5 build: bump golang.org/x/net to fix govulncheck ci failure 
bump golang.org/x/net from v0.52.0 to latest patched version
to resolve known http2 vulnerability flagged by govulncheck.

the vulnerable call path is:
  object.debugHTTPClient.Do
  -> httputil.DumpRequestOut
  -> http2.Transport.RoundTrip

this is a pre-existing issue blocking ci on all pull requests.

Signed-off-by: Oded Viner <oviner@redhat.com>
 2026-05-10 17:35:52 +03:00
immanuwell c3a9f5fdd9 docs: fix duplicated words in docs and comments 
Clean up duplicated words and a typo in object storage docs, comments, and user-facing messages.

Signed-off-by: immanuwell <pchpr.00@list.ru>
 2026-05-09 12:50:31 +04:00
Blaine Gardner eb9f5fe00a Merge pull request #17465 from taraasrita10/setenv-mon-as-root 
helm: add ROOK_CEPH_MON_RUN_AS_ROOT to chart values
 2026-05-07 09:45:53 -06:00
Prabhala Tara Aasrita e6ad74087e helm: add ROOK_CEPH_MON_RUN_AS_ROOT to chart values 
Added monRunAsRoot chart value to support the ROOK_CEPH_MON_RUN_AS_ROOT environment variable in the operator ConfigMap.

Fixes #17452

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
 2026-05-07 11:54:08 +05:30
Santosh Pillai 0100ecaa9b Merge pull request #17484 from taraasrita10/fixing-mon-failover 
mon: check node existence on every health check iteration
 2026-05-07 11:33:12 +05:30
Blaine Gardner 7da85259f4 Merge pull request #17104 from subhamkrai/add-tls-cipher-rgw-option 
rgw: add option for tls and cipher in objectstore
 2026-05-06 11:13:30 -06:00
subham rai 9a44df84b3 Merge pull request #17478 from rook/dependabot/github_actions/DavidAnson/markdownlint-cli2-action-23.1.0 
build(deps): bump DavidAnson/markdownlint-cli2-action from 23.0.0 to 23.2.0
 2026-05-06 21:10:07 +05:30
subhamkrai 01ef98c1e3 rgw: add option for tls and cipher in objectstore 
this commit add option in the ceph objecstore CR
to configure TLS profile and TLS ciphersuite for
rgw beast.

Signed-off-by: subhamkrai <srai@redhat.com>
 2026-05-06 21:02:30 +05:30
Prabhala Tara Aasrita aeae61e5be mon: check node existence on every health check iteration 
Previously, shouldFailoverMonImmediately() was called only when a mon first went out of quorum. If the node gets deleted after the timeout starts, it does not get detected until the timeout expires. Moved the call outside the timeout initialization block so it runs on every health check iteration and detects node deletion immediately.

Fixes #15953

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
 2026-05-06 20:04:05 +05:30
subham rai d7751125ce Merge pull request #17479 from rook/dependabot/github_actions/github/codeql-action-4.35.3 
build(deps): bump github/codeql-action from 4.35.2 to 4.35.3
 2026-05-06 17:33:02 +05:30
subham rai cf084a97bb Merge pull request #17481 from rook/dependabot/go_modules/gopkg.in/ini.v1-1.67.2 
build(deps): bump gopkg.in/ini.v1 from 1.67.1 to 1.67.2
 2026-05-06 17:31:49 +05:30
dependabot[bot] 8f40dcf576 build(deps): bump DavidAnson/markdownlint-cli2-action 
Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action) from 23.0.0 to 23.2.0.
- [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases)
- [Commits](https://github.com/davidanson/markdownlint-cli2-action/compare/ce4853d43830c74c1753b39f3cf40f71c2031eb9...ded1f9488f68a970bc66ea5619e13e9b52e601cd)

---
updated-dependencies:
- dependency-name: DavidAnson/markdownlint-cli2-action
  dependency-version: 23.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-05-06 11:11:45 +00:00
dependabot[bot] 4dac6b908e build(deps): bump github/codeql-action from 4.35.2 to 4.35.3 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.2 to 4.35.3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/95e58e9a2cdfd71adc6e0353d5c52f41a045d225...e46ed2cbd01164d986452f91f178727624ae40d7)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.35.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-05-06 11:11:43 +00:00
dependabot[bot] f5b43e5f06 build(deps): bump gopkg.in/ini.v1 from 1.67.1 to 1.67.2 
Bumps gopkg.in/ini.v1 from 1.67.1 to 1.67.2.

---
updated-dependencies:
- dependency-name: gopkg.in/ini.v1
  dependency-version: 1.67.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-05-06 11:11:40 +00:00
subham rai a92ee17959 Merge pull request #17482 from rook/dependabot/go_modules/github-dependencies-0ce660e14a 
build(deps): bump the github-dependencies group with 5 updates
 2026-05-06 16:40:18 +05:30
subham rai 93a5d83c0d Merge pull request #17483 from Madhu-1/fix-csi-issue 
csi: wait for the PV deletion
 2026-05-06 13:50:48 +05:30
Madhu Rajanna 799bd66243 csi: wait for the PV deletion 
Wait for the PV deletion before deleting
the ceph resources like pools.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2026-05-06 12:37:48 +05:30
Blaine Gardner bf9ab2d606 Merge pull request #17485 from obnoxxx/build-make-lint.quick 
build: introduce a make target lint.quick
 2026-05-05 13:13:53 -06:00
Michael Adam dd99db9ca9 build: introduce a make target lint.quick 
`make lint` runs all available linters and tskes quite some time
(around 25 to 35 seconds) to complete, eventually failing on lint.python,
at least locally on some machines.

This change splits a target `lint.quick` out of `lint`.
`make lint.quick` runs all linters except for `lint.python`
and consistently takes some 20 seconds
of runtime to complete successfully.

Signed-off-by: Michael Adam <obnox@samba.org>
 2026-05-05 18:53:26 +02:00
dependabot[bot] 997843ee9d build(deps): bump the github-dependencies group with 5 updates 
Bumps the github-dependencies group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) | `1.41.6` | `1.41.7` |
| [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.32.16` | `1.32.17` |
| [github.com/aws/aws-sdk-go-v2/credentials](https://github.com/aws/aws-sdk-go-v2) | `1.19.15` | `1.19.16` |
| [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) | `1.100.0` | `1.100.1` |
| [github.com/aws/aws-sdk-go-v2/service/sns](https://github.com/aws/aws-sdk-go-v2) | `1.39.16` | `1.39.17` |


Updates `github.com/aws/aws-sdk-go-v2` from 1.41.6 to 1.41.7
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/v1.41.6...v1.41.7)

Updates `github.com/aws/aws-sdk-go-v2/config` from 1.32.16 to 1.32.17
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/config/v1.32.16...config/v1.32.17)

Updates `github.com/aws/aws-sdk-go-v2/credentials` from 1.19.15 to 1.19.16
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/credentials/v1.19.15...credentials/v1.19.16)

Updates `github.com/aws/aws-sdk-go-v2/service/s3` from 1.100.0 to 1.100.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/service/s3/v1.100.0...service/s3/v1.100.1)

Updates `github.com/aws/aws-sdk-go-v2/service/sns` from 1.39.16 to 1.39.17
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/service/sns/v1.39.16...service/sns/v1.39.17)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-version: 1.41.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-version: 1.32.17
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/credentials
  dependency-version: 1.19.16
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/s3
  dependency-version: 1.100.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/sns
  dependency-version: 1.39.17
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-05-04 16:10:11 +00:00
Travis Nielsen 45ec32e513 core: declare stable concurrent cluster reconciles 
The ROOK_RECONCILE_CONCURRENT_CLUSTERS feature was implemented
in v1.19. This feature has been stable, with no related issues
reported. The feature is tested in the CI with no known
stability issues. Let's declare this feature as stable.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2026-05-01 14:18:35 -06:00
texasich beb6c0f373 mgr: retry self-signed cert creation on wrapped deadline errors 
Signed-off-by: texasich <texasich@users.noreply.github.com>
 2026-05-01 11:31:01 -05:00
Travis Nielsen a4316348cc Merge pull request #17464 from jhoblitt/feature/cmd-reporter-default-resource-limits 
core: add default ResourceRequirements for cmd-reporter
 2026-04-30 11:34:14 -06:00
Travis Nielsen 747f521cab Merge pull request #17458 from obnoxxx/build-vet-lint-vet 
Build: align the vet target with the new naming taxonomy
 2026-04-30 11:32:27 -06:00
Joshua Hoblitt 64cf1df920 core: add default ResourceRequirements for cmd-reporter 
The cmd-reporter ResourceRequirements are used by the
`rook-ceph-detect-version` pod.  Setting a default ResourceRequirement
is useful in and of itself while always allowing the `values.yaml` serve
double duty as a configuration example.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2026-04-30 08:52:54 -07:00
Michael Adam 5ca0959a75 build: align the vet target with the new naming taxonomy 
Recently, in PR #17445, a new naming taxonomy was introduced for the naming
of make targets, specifically linting targets.

This change aligns the `vet` target with that taxonomy by renaming it to
`lint.vet`.

Signed-off-by: Michael Adam <obnox@samba.org>
 2026-04-30 13:51:01 +02:00
Santosh Pillai f9c9a9b1b6 Merge pull request #17453 from sp98/fix-osd-encrypted-label-values 
osd: detect encryption label from dmcrypt path
 2026-04-30 13:37:51 +05:30