Commit Graph
12516 Commits
Author SHA1 Message Date
Mason a030d2ceb3 helm: update rook-ceph SecurityContextConstraints to match operator-openshift.yaml example
The rook-ceph SecurityContextConstraints in the rook-ceph helm chart does not include all the users necessary for a successful deployment. Specifically, rook-ceph-default, rook-ceph-mgr, rook-ceph-osd, and rook-ceph-rgw are listed in the operator-openshift.yaml example file (https://github.com/rook/rook/blob/master/deploy/examples/operator-openshift.yaml) but are not included in the helm chart. This commit adds these users.

Signed-off-by: Mason Buchanan <masonwb@gmail.com>
2025-07-21 01:17:14 -04:00
Blaine Gardner e4da184ce3 Merge pull request #16132 from parth-gr/fix-rgwstatus-err
rgw: fail reconcile on status update error
2025-07-16 14:51:36 -06:00
Blaine Gardner 0488f6dec8 Merge pull request #16060 from parth-gr/cephclient-cephx
core: automate cephclient cephx key rotation
2025-07-16 13:35:28 -06:00
Blaine Gardner 22ef8043f9 Merge pull request #16133 from cobaltcore-dev/multus-rgw-zone-json-fix
multus: support copy file to cmd-proxy container for rgw zone set
2025-07-16 10:28:50 -06:00
Travis Nielsen 87219acc6a Merge pull request #16144 from OdedViner/metadata_server_probe
core: fix nil pointer panic when startupProbe is set in cephfilesystem
2025-07-16 10:04:13 -06:00
Oded Viner 51e9ddc3f5 core: fix nil pointer panic when startupProbe is set in cephfilesystem
fixes a nil pointer dereference in GetProbeWithDefaults when
startupProbe is set in cephfilesystem and currentProbe is nil.
adds panic recovery in cephfilesystem reconcile loop to improve
error visibility and avoid silent reconcile restarts.

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-07-16 18:23:06 +03:00
parth-gr 6ffbec7308 core: automate cephclient cephx key rotation
Ceph has a new ceph auth rotate command currently
present in ceph:main

Add a cephclient api support to rotate the
cephx keys genrated by cephclient

Signed-off-by: parth-gr <partharora1010@gmail.com>
2025-07-16 14:43:18 +05:30
parth-gr b8517eb54f rgw: fail reconcile on status update error
if the status update is failed, return an error
and do a new reconcile for the rgw controller

Signed-off-by: parth-gr <partharora1010@gmail.com>
2025-07-16 14:37:03 +05:30
Artem Torubarov c88e6ea952 multus: support copy file to cmd-proxy container for rgw zone set commands
Signed-off-by: Artem Torubarov <artem.torubarov@sap.com>
2025-07-16 10:45:42 +02:00
subham rai 98287f5a74 Merge pull request #16140 from travisn/hash-modules
core: Update go modules to latest except for go 1.24
2025-07-16 09:05:56 +05:30
Travis Nielsen 24b0b866ab core: update go modules to latest except for go 1.24
Update all the go modules to the latest, except for the modules
that require go 1.24. Those modules will be updated in a
follow-up change.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2025-07-15 14:13:12 -06:00
Travis Nielsen 6520d006cc Merge pull request #16128 from rook/dependabot/go_modules/golang.org/x/sync-0.16.0
build(deps): bump golang.org/x/sync from 0.15.0 to 0.16.0
2025-07-15 14:09:18 -06:00
Travis Nielsen 805341661a Merge pull request #16135 from synthe102/master
helm(rook-ceph-cluster): add HTTPRoute for dashboard and objectstore
2025-07-15 13:30:05 -06:00
synthe102 25a7a910b5 helm(rook-ceph-cluster): add HTTPRoute for dashboard and objectstore
Signed-off-by: synthe102 <leonard@suslian.engineer>
2025-07-15 19:00:00 +00:00
Santosh Pillai 615ac4af6d Merge pull request #16087 from elias-dbx/pdb_missing_node
osd: treat non existing OSD nodes as drained
2025-07-15 21:47:50 +05:30
Travis Nielsen df598916d0 Merge pull request #16129 from subhamkrai/test-helm-ci-error
test: add pathType with ingress dashboard host
2025-07-15 09:39:10 -06:00
Travis Nielsen 95ea3dfdff Merge pull request #16126 from OdedViner/rbd-remove-redundant-stats-log
pool: remove redundant stats pools info log
2025-07-15 08:09:44 -06:00
Travis Nielsen b2d8fc296b Merge pull request #16079 from raaizik/ra-14355
docs: have a StorageClass consume SubVolumeGroup
2025-07-15 08:08:34 -06:00
raaizikandTravis Nielsen e46de55a90 docs: have a StorageClass consume SubVolumeGroup
Adds guide for how to create a storage class that consumes a SubVolumeGroup

Signed-off-by: raaizik <132667934+raaizik@users.noreply.github.com>
Co-Authored-By: Travis Nielsen <tnielsen@redhat.com>
2025-07-15 13:28:28 +03:00
subhamkrai 8bd4b38399 test: add pathType with ingress dashboard host
Recentally, helm related ci started failing due to
```
testutil: failed to install chart. result=. walk.go:75: found symbolic link in path: /home/runner/work/rook/rook/deploy/charts/rook-ceph-cluster/charts/library resolves to /home/runner/work/rook/rook/deploy/charts/library. Contents of linked file included and used
I0714 09:44:18.963620   18291 warnings.go:110] "Warning: path /ceph-dashboard(/|$)(.*) cannot be used with pathType Prefix"
Error: INSTALLATION FAILED: 1 error occurred:
	* admission webhook "validate.nginx.ingress.kubernetes.io" denied the request: ingress contains invalid paths: path /ceph-dashboard(/|$)(.*) cannot be used with pathType Prefix, err=failed to run helm command on args [install --create-namespace rook-ceph-cluster /home/runner/work/rook/rook/deploy/charts/rook-ceph-cluster --namespace helm-ns -f values-test.yaml] : . walk.go:75: found symbolic link in path: /home/runner/work/rook/rook/deploy/charts/rook-ceph-cluster/charts/library resolves to /home/runner/work/rook/rook/deploy/charts/library. Contents of linked file included and used
I0714 09:44:18.963620   18291 warnings.go:110] "Warning: path /ceph-dashboard(/|$)(.*) cannot be used with pathType Prefix"
Error: INSTALLATION FAILED: 1 error occurred:
```
as default `pathType` is `Prefix`, we need to change it to
`pathType:ImplementationSpecific`.

Signed-off-by: subhamkrai <srai@redhat.com>
2025-07-15 12:50:20 +05:30
dependabot[bot] 8515ca0dc9 build(deps): bump golang.org/x/sync from 0.15.0 to 0.16.0
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.15.0 to 0.16.0.
- [Commits](https://github.com/golang/sync/compare/v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-version: 0.16.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-14 14:51:55 +00:00
Oded Viner e089092092 pool: remove redundant stats pools info log
remove unnecessary info-level log for enableStatsForPools;
detailed debug log already exists

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-07-14 12:31:31 +03:00
Blaine Gardner a156f27f34 Merge pull request #16115 from sp98/clusterCephxStatus-uninitialized
core: init cephxStatus on cephCluster
2025-07-11 13:52:31 -06:00
Travis Nielsen 7be445d799 Merge pull request #16119 from puskunalis/ci-refactor-cluster-teardown-logic
ci: refactor cluster teardown logic
2025-07-11 08:55:26 -06:00
Vilius Puškunalis 1a4d8e2859 ci: refactor cluster teardown logic
Refactors cluster teardown logic in remaining jobs to use the new delete_cluster function.

Signed-off-by: Vilius Puškunalis <47086537+puskunalis@users.noreply.github.com>
2025-07-10 20:23:52 +03:00
Travis Nielsen 56febf607b Merge pull request #16041 from obnoxxx/build-helm-index-merge-again
build: merge helm indexes instead of recreating for every release
2025-07-10 10:54:38 -06:00
Travis Nielsen 7de769c060 Merge pull request #16056 from travisn/mon-failover-host-net
mon: Failover with host network must use different node
2025-07-10 10:49:53 -06:00
Travis Nielsen 009e8eb254 Merge pull request #15666 from puskunalis/cleanup-fix-disk-shredding
osd: fix cleanup job disk shredding
2025-07-10 10:28:46 -06:00
Travis Nielsen aa61ddb57e mon: failover with host network must use different node
When a mon is failed over, the old mon is left in mon quorum
until the new quorum is confirmed in quorum. When host networking
is enabled, this may result in two mons being in quorum with the
same ip, if the new mon is scheduled on the same node as the
down mon. This results in daemon crashes in the cluster since
they are confused by multiple of the same ip in the mon map.

The solution is to avoid scaling down the bad mon when host networking
is enabled. This will ensure the new mon is not scheduled on the
same node as the previous mon. With host networking, either another
node is necessary or the original mon must come back online to
restore quorum.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2025-07-10 10:13:17 -06:00
Santosh Pillai a07f2478f3 core: init cephxStatus on cephCluster
Set cephXStatus on the CephCluster status to Uninitialized when the
cluster is first created.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2025-07-10 20:43:58 +05:30
subham rai 30a01c920e Merge pull request #16098 from rook/dependabot/github_actions/snyk/actions-28606799782bc8e809f4076e9f8293bc4212d05e
build(deps): bump snyk/actions from cdb760004ba9ea4d525f2e043745dfe85bb9077e to 28606799782bc8e809f4076e9f8293bc4212d05e
2025-07-08 20:52:29 +05:30
subham rai 2095518cf5 Merge pull request #16097 from rook/dependabot/github_actions/github/codeql-action-3.29.2
build(deps): bump github/codeql-action from 3.29.1 to 3.29.2
2025-07-08 20:52:24 +05:30
Travis Nielsen 865aaf13c7 Merge pull request #16105 from subhamkrai/discover-env-udev
operator: add missing udev env to discover pod
2025-07-08 08:27:01 -06:00
subhamkrai 2742a707cc operator: add missing udev env to discover pod
currently, we're setting the env `DISCOVER_DAEMON_UDEV_BLACKLIST`
in operator.yaml but we're not reading from the operator env and
setting the value to discover pod env.

Signed-off-by: subhamkrai <srai@redhat.com>
2025-07-08 17:13:01 +05:30
Travis Nielsen a00c6fba64 Merge pull request #15846 from patrostkowski/fix/mon-run-as-root-15564
mon: allow running mon pods as root
2025-07-07 16:08:48 -06:00
Travis Nielsen efd02dfc7a Merge pull request #16091 from sp98/rgw-keyrotation-failure
object: fail if keys didn't rotate.
2025-07-07 12:22:58 -06:00
Blaine Gardner c02632154c Merge pull request #16093 from OdedViner/fix_debug_ci_lable
ci: fix typo in debug-ci input for tmate action
2025-07-07 09:47:43 -06:00
dependabot[bot] 71e0ccaeb5 build(deps): bump snyk/actions
Bumps [snyk/actions](https://github.com/snyk/actions) from cdb760004ba9ea4d525f2e043745dfe85bb9077e to 28606799782bc8e809f4076e9f8293bc4212d05e.
- [Release notes](https://github.com/snyk/actions/releases)
- [Commits](https://github.com/snyk/actions/compare/cdb760004ba9ea4d525f2e043745dfe85bb9077e...28606799782bc8e809f4076e9f8293bc4212d05e)

---
updated-dependencies:
- dependency-name: snyk/actions
  dependency-version: 28606799782bc8e809f4076e9f8293bc4212d05e
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-07 14:58:58 +00:00
dependabot[bot] d1d35ee17e build(deps): bump github/codeql-action from 3.29.1 to 3.29.2
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.1 to 3.29.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/39edc492dbe16b1465b0cafca41432d857bdb31a...181d5eefc20863364f96762470ba6f862bdef56b)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-07 14:43:44 +00:00
Oded Viner e58d0bd1c2 ci: fix typo in debug-ci input for tmate action
fixes a typo in the 'required' field of the debug-ci input in the
tmate_debug action. this prevented the input from being recognized
correctly by github actions.

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-07-07 17:07:15 +03:00
Santosh Pillai 9b742c781a object: fail if keys didn't rotate
Fail the reconcile if rgw key rotation fails. Currnetly we are just
logging it.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2025-07-04 12:21:45 +05:30
Elias Carter 5f2d6c01d7 osd: treat non existing OSD nodes as drained
If the node for an OSD does not exist within kubernetes, the PDB
reconciliation logic will fail to make progress. This can be problematic
as new OSDs added to the cluster may not be protected by OSD PDBs after
they are added since the PDB reconcilation logic is failing.

The solution is to treat non existing OSD nodes as drained which is
logically consistent with treating unschedulable OSD nodes as drained as
you cannot schedule a pod onto a node which does not exist.

Fixes: #16086

Signed-off-by: Elias Carter <elias@dropbox.com>
2025-07-02 18:41:24 +00:00
Blaine Gardner 5fec88e8c8 Merge pull request #16031 from OdedViner/doc_minikube
doc: switch linux minikube driver from kvm2 to qemu2
2025-07-02 09:44:08 -06:00
Blaine Gardner b58ea6d98b Merge pull request #16080 from obnoxxx/dev-cluster-linux-qemu2
test: use qemu2 minikube driver  for Linux in the  create-dev-cluster script
2025-07-02 09:14:52 -06:00
Blaine Gardner 76c62ab2ed Merge pull request #16078 from raaizik/ra-16072
core: CephObjectRealm controller generated generated AccessKey invalid chars
2025-07-02 09:04:41 -06:00
Oded Viner 5183ecdff4 doc: switch linux minikube driver from kvm2 to qemu2
update the developer guide to use the qemu2 driver instead of kvm2
for minikube on linux.

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-07-02 14:48:04 +03:00
Michael Adam 849e9a48cb test: use the qemu2 minikube driver on Linyx for create-dev-cluster
The create-dev-cluster script used the kvm2 minikube driver on Linux.

On newer Linux flavors like Fedora 41+, the kvm2 driver can have problems
and the qemu2 driver is recommended.

This changes the script to use the qemu2 driver for  Linux

Signed-off-by: Michael Adam <obnox@samba.org>
2025-07-01 19:35:29 +02:00
raaizik 1b3f36ff5c core: fix CephObjectRealm controller generated generated AccessKey invalid chars
Suggested fix for issue https://github.com/rook/rook/issues/16072
Adds key type differentiation to exclude invalid characters from AccessKey

Signed-off-by: raaizik <132667934+raaizik@users.noreply.github.com>
2025-07-01 18:32:48 +03:00
subham rai c90ce00902 Merge pull request #16076 from rook/dependabot/github_actions/github/codeql-action-3.29.1
build(deps): bump github/codeql-action from 3.29.0 to 3.29.1
2025-07-01 11:11:45 +05:30
dependabot[bot] e0ba3767a4 build(deps): bump github/codeql-action from 3.29.0 to 3.29.1
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.0 to 3.29.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/ce28f5bb42b7a9f2c824e633a3f6ee835bab6858...39edc492dbe16b1465b0cafca41432d857bdb31a)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-30 15:35:01 +00:00