Commit Graph
13584 Commits
Author SHA1 Message Date
subhamkrai a9d29bdec6 csi: move csi management to admin
Going forward, admin will manage the csi operator
CR's and rook will only manage Ceph Connection cr
and client Profile cr.

The old csi driver is completely removed from Rook
and can no longer be used starting in Rook v1.20.

The upgrade guide will contain the needed transition steps
for managing the csi operator settings.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 4eefad42e8)
2026-05-12 12:49:21 -10:00
subhamkrai 9f978ec685 ci: fix some minor canary test issues
The canary test was waiting for replicapool
instead of replicapool2, and a more reliable
wait for the toolbox pod start is added.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit b50f1a3d60)
2026-05-12 12:49:21 -10:00
Travis Nielsen 97926f1dc9 Merge pull request #17470 from rook/mergify/bp/release-1.20/pr-17464
core: add default ResourceRequirements for cmd-reporter (backport #17464)
2026-05-12 12:47:37 -10:00
mergify[bot] e51203798d Merge pull request #17513 from rook/mergify/bp/release-1.20/pr-17474
core: Declare concurrent cluster reconciles stable (backport #17474)
2026-05-12 10:38:37 +00:00
subham rai 9b5b80b172 Merge pull request #17511 from rook/mergify/bp/release-1.20/pr-17503
nvmeof: add sys_admin to scc allowedcapabilities for gateway pods (backport #17503)
2026-05-12 15:39:54 +05:30
mergify[bot] ad5a48b123 Merge pull request #17457 from rook/mergify/bp/release-1.20/pr-17455
ci: Upgrade tests from v1.19 to master (backport #17455)
2026-05-11 23:30:30 +00:00
Travis Nielsen aff4a6b9f8 ci: upgrade tests from v1.19 to master
The upgrade integration tests for the v1.20 release need to
validate the upgrade starting from v1.19 to the latest.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 1f205c4be4)
2026-05-11 13:02:16 -10:00
Travis Nielsen 4182fe67a1 core: declare stable concurrent cluster reconciles
The ROOK_RECONCILE_CONCURRENT_CLUSTERS feature was implemented
in v1.19. This feature has been stable, with no related issues
reported. The feature is tested in the CI with no known
stability issues. Let's declare this feature as stable.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 45ec32e513)
2026-05-11 22:50:18 +00:00
Travis Nielsen ce8ef223c9 Merge pull request #17501 from rook/mergify/bp/release-1.20/pr-17498
build: bump golang.org/x/net to fix govulncheck ci failure (backport #17498)
2026-05-11 12:04:19 -10:00
Oded Viner 67520301ac nvmeof: add sys_admin to scc allowedcapabilities for gateway pods
the nvmeof gateway requires privileged containers with
sys_admin capability. the rook-ceph scc only allowed mknod,
causing pod creation to fail on openshift with:
"unable to validate against any security context constraint"

add sys_admin to allowedcapabilities in the helm chart sccs
and the go scc helper. this does not affect other daemons
(osd, rgw, mgr, mon) since they do not request sys_admin.

the operator-openshift.yaml example already includes
sys_admin, so this aligns the helm charts to match.

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit f8c1c99cb4)
2026-05-11 22:04:16 +00:00
Oded Viner 7b4313ffbb build: bump golang.org/x/net to fix govulncheck ci failure
bump golang.org/x/net from v0.52.0 to latest patched version
to resolve known http2 vulnerability flagged by govulncheck.

the vulnerable call path is:
  object.debugHTTPClient.Do
  -> httputil.DumpRequestOut
  -> http2.Transport.RoundTrip

this is a pre-existing issue blocking ci on all pull requests.

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit 20fa0128f5)
2026-05-11 09:25:07 +00:00
mergify[bot] a62de9e649 Merge pull request #17493 from rook/mergify/bp/release-1.20/pr-17465
helm: add ROOK_CEPH_MON_RUN_AS_ROOT to chart values (backport #17465)
2026-05-08 16:24:46 +00:00
Prabhala Tara Aasrita 46d62209db helm: add ROOK_CEPH_MON_RUN_AS_ROOT to chart values
Added monRunAsRoot chart value to support the ROOK_CEPH_MON_RUN_AS_ROOT environment variable in the operator ConfigMap.

Fixes #17452

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
(cherry picked from commit e6ad74087e)
2026-05-07 15:46:35 +00:00
subham rai 627f0fe32b Merge pull request #17490 from rook/mergify/bp/release-1.20/pr-17484
mon: check node existence on every health check iteration (backport #17484)
2026-05-07 13:53:30 +05:30
Prabhala Tara Aasrita 771e377cc7 mon: check node existence on every health check iteration
Previously, shouldFailoverMonImmediately() was called only when a mon first went out of quorum. If the node gets deleted after the timeout starts, it does not get detected until the timeout expires. Moved the call outside the timeout initialization block so it runs on every health check iteration and detects node deletion immediately.

Fixes #15953

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
(cherry picked from commit aeae61e5be)
2026-05-07 06:03:40 +00:00
mergify[bot] 45185d172b Merge pull request #17488 from rook/mergify/bp/release-1.20/pr-17104
rgw: add option for tls and cipher in objectstore (backport #17104)
2026-05-06 17:44:43 +00:00
subhamkrai 3445e2be3a rgw: add option for tls and cipher in objectstore
this commit add option in the ceph objecstore CR
to configure TLS profile and TLS ciphersuite for
rgw beast.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 01ef98c1e3)
2026-05-06 17:13:59 +00:00
subham rai ef126a3918 Merge pull request #17486 from rook/mergify/bp/release-1.20/pr-17483
csi: wait for the PV deletion (backport #17483)
2026-05-06 14:37:52 +05:30
Madhu Rajanna eb38b091ed csi: wait for the PV deletion
Wait for the PV deletion before deleting
the ceph resources like pools.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 799bd66243)
2026-05-06 08:21:10 +00:00
Joshua Hoblitt ffbb449b82 core: add default ResourceRequirements for cmd-reporter
The cmd-reporter ResourceRequirements are used by the
`rook-ceph-detect-version` pod.  Setting a default ResourceRequirement
is useful in and of itself while always allowing the `values.yaml` serve
double duty as a configuration example.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 64cf1df920)
2026-04-30 17:34:49 +00:00
Travis Nielsen b9726d4834 Merge pull request #17456 from rook/mergify/bp/release-1.20/pr-17444
object: migrate bucket provisioner to aws sdk v2 (backport #17444)
2026-04-29 14:42:29 -06:00
mergify[bot] 7c25791a13 Merge pull request #17461 from rook/mergify/bp/release-1.20/pr-17451
exporter: set correct DNSPolicy for rook-ceph-exporter (backport #17451)
2026-04-29 18:38:39 +00:00
Rohan Gupta 5ce77b0d94 exporter: set correct DNSPolicy for rook-ceph-exporter
rook-ceph-exporter should use DNSPolicy ClusterFirstWithHostNet when
hostNetwork is enabled

Signed-off-by: Rohan Gupta <rohgupta@redhat.com>
(cherry picked from commit 17873d3af2)
2026-04-29 18:11:46 +00:00
Oded Viner d11ef74a9b object: migrate bucket provisioner to aws sdk v2
migrate bucket provisioner from aws sdk v1 to v2.

replace awserr.Error type assertions with smithy.APIError
using errors.As for v2-style error handling.

switch setBucketPolicy and setBucketLifecycle to use
the v2 s3 client (ClientV2) directly with context.

replace v1 s3 types (BucketLifecycleConfiguration,
GetBucketLifecycleConfigurationOutput) with v2 equivalents
from s3types and s3v2 packages.

add cmpopts.IgnoreUnexported to cmp.Diff calls to handle
unexported noSmithyDocumentSerde fields in v2 sdk types.

add nil guard on lifecycle output before accessing rules
to prevent nil dereference when get returns an error.

depends on #17414

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit 5ba3e1a2c0)
2026-04-29 16:24:17 +00:00
Joshua Hoblitt 02a403b663 Merge pull request #17446 from rook/mergify/bp/release-1.20/pr-17414
object: migrate bucket policy methods to aws sdk v2 (backport #17414)
2026-04-29 09:21:30 -07:00
mergify[bot] bc82c95440 Merge pull request #17450 from rook/mergify/bp/release-1.20/pr-17442
core: Update all docs and examples default to v20.2.1 (backport #17442)
2026-04-28 22:54:36 +00:00
Travis Nielsen 82e9c4de51 core: update all docs and examples to v20.2.1
With the default version now being v20.2.1, also update
all of the examples, documentation, and default CI to run
with that version

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 62a9debceb)
2026-04-28 22:24:53 +00:00
Oded Viner fe9d515ced object: migrate bucket policy methods to aws sdk v2
migrate PutBucketPolicy and GetBucketPolicy to use aws sdk v2
client.

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit 88e0047d9b)
2026-04-28 11:45:57 +00:00
Travis Nielsen 03b9b8b1b0 Merge pull request #17427 from rook/mergify/bp/release-1.20/pr-17282
pool: clean up unused crush rules (backport #17282)
2026-04-27 13:32:01 -06:00
Travis Nielsen e23819428e Merge pull request #17435 from rook/mergify/bp/release-1.20/pr-17342
object: migrate s3agent object methods to aws sdk v2 (backport #17342)
2026-04-27 10:27:59 -06:00
mergify[bot] 00ecf80de1 Merge pull request #17437 from rook/mergify/bp/release-1.20/pr-17432
security: grant scc to rook-ceph-nvmeof service account (backport #17432)
2026-04-27 16:23:11 +00:00
Oded Viner 1332e79115 security: grant scc to rook-ceph-nvmeof service account
the rook-ceph-nvmeof service account is not listed in the
securitycontextconstraints users, causing cephnvmeofgateway
pods to fail on openshift. add the service account to the
scc in the helm charts, go scc builder, and test namespace
substitution.

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit 7f3e2ace27)
2026-04-27 15:50:44 +00:00
Oded Viner 9341b3dcfa object: migrate s3agent object methods to aws sdk v2
migrate PutObjectInBucket, GetObjectInBucket, and
DeleteObjectInBucket to use aws sdk v2 client.
replace v1 awserr error handling in DeleteObjectInBucket
with v2 typed errors (errors.As).
remove unused v1 awserr import.

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit 2cb714dabd)
2026-04-27 15:48:57 +00:00
Asish Kumar 0b3605dd84 pool: clean up unused crush rules
Clean up stale CRUSH rules after the Ceph mgr starts so rules left behind by pool failure-domain or device-class changes do not accumulate indefinitely.

The cleanup is guarded by a package-level RWMutex. Pool create and update paths hold the read lock while creating and assigning CRUSH rules, while cluster-wide cleanup holds the write lock before listing pools and deleting unused rules. This keeps pool reconciles parallel with each other while preventing cleanup from deleting a rule that another reconcile has just created but not yet attached to a pool.

Keep direct pool-delete cleanup for the pool's current CRUSH rule, make the cluster-wide cleanup best-effort across all unused rules, and add an operator-level ROOK_DELETE_UNUSED_CRUSH_RULES setting for clusters that need to leave unused custom rules in place.

Document the operator and Helm settings, regenerate the Helm chart docs, and add a pending release note for the default cleanup behavior.

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
(cherry picked from commit 24a35e4e74)
2026-04-24 22:32:15 +00:00
mergify[bot] cf34dce04f Merge pull request #17425 from rook/mergify/bp/release-1.20/pr-17420
core:remove newlines from liveness probe scripts (backport #17420)
2026-04-24 14:13:07 +00:00
Santosh cbe544ec21 core: remove newlines from liveness probe scripts
Strip unnecessary leading and trailing newlines from osdLivenessProbeScript and livenessProbeScript raw string literals in spec.go

Signed-off-by: Santosh <sapillai@redhat.com>
(cherry picked from commit 925acb3e92)
2026-04-24 13:44:46 +00:00
subham rai e28407401d Merge pull request #17419 from rook/mergify/bp/release-1.20/pr-17411
osd: fix KMS log error format specifier (backport #17411)
2026-04-24 18:12:52 +05:30
Prabhala Tara Aasrita f1be5f1a1c osd: fix KMS log error format specifier
During OSD provisioning, the KMS error log incorrectly uses logger.Error() instead of logger.Errorf(), causing the format specifier %q to appear in the logs. Changed logger.Error to logger.Errorf to fix the same.

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
(cherry picked from commit 85ee8631cf)
2026-04-24 08:39:55 +00:00
Travis Nielsen 9e4d249fcf Merge pull request #17418 from rook/mergify/bp/release-1.20/pr-17417
docs: update upgrade docs for v1.20 (backport #17417)
2026-04-23 17:04:45 -06:00
Travis Nielsen 9d0586d277 Merge pull request #17408 from rook/mergify/bp/release-1.20/pr-17382
mon: fix floating mon validation in TNF deployments (backport #17382)
2026-04-23 16:01:34 -06:00
Travis Nielsen d007d46c7c Merge pull request #17416 from rook/mergify/bp/release-1.20/pr-17288
mon: relax balanced CRUSH weight check for stretch mode (backport #17288)
2026-04-23 16:01:10 -06:00
Blaine Gardner d1e7dac4a7 docs: update upgrade docs for v1.20
Update upgrade docs to reflect v1.20 changes.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit cb60ec5ae2)
2026-04-23 15:59:38 -06:00
Lumir Sliva 396ef531e1 mon: relax balanced CRUSH weight check for stretch mode
Ceph relaxed the stretch mode CRUSH weight check in ceph/ceph#66580 to
allow weights within 10 percent of each other. This change is available
in Ceph Umbrella and was backported to tentacle v20.2.2 via ceph/ceph
number 67790. The squid backport is still pending.

Signed-off-by: Lumir Sliva <61183145+lumir-sliva@users.noreply.github.com>
(cherry picked from commit 27f95f2feb)
2026-04-23 18:05:50 +00:00
mergify[bot] 75b9e9a19a Merge pull request #17404 from rook/mergify/bp/release-1.20/pr-17403
ci: remove K8s 1.30 and use latest patch versions (backport #17403)
2026-04-22 17:11:16 +00:00
Prabhala Tara Aasrita 7db4af9796 ci: remove K8s 1.30 and use latest patch versions
Remove Kubernetes 1.30 from k8s workflows and update supported
versions to their latest patches (1.31.14, 1.32.13, 1.33.11, 1.35.4)

Closes #17399

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
(cherry picked from commit b7ea6f488f)
2026-04-22 10:40:38 -06:00
Prabhala Tara Aasrita 5af4ecc44f mon: fix floating mon validation in TNF deployments
The floating mon in a TNF cluster is designed to share a node with a pinned mon. Fixed the pre-cluster start evaluation logic to allow the same when allowMultiplePerNode is set to false.

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
(cherry picked from commit 8e205b194c)
2026-04-22 15:37:03 +00:00
mergify[bot] ef3871fb76 Merge pull request #17397 from rook/mergify/bp/release-1.20/pr-17228
osd: fix CRUSH device class not applied during OSD re-discovery (backport #17228)
2026-04-21 13:08:27 +00:00
David Orman 31722a2041 osd: fix CRUSH device class not applied during OSD re-discovery
When an OSD is purged and reprovisioned, it comes back without the
correct CRUSH device class. NVMe devices configured with
deviceClass: nvme in the CR end up as ssd.

Root cause: the operator sets ROOK_OSD_CRUSH_DEVICE_CLASS on prepare
jobs but not on OSD deployments. During re-discovery
(GetCephVolumeRawOSDs), the daemon reads this env var, finds it
absent, and falls back to auto-detected deviceType which returns ssd
for NVMe.

Fix: add crushDeviceClassEnvVar(osd.DeviceClass) to the OSD
deployment spec in spec.go, alongside the existing
dataDeviceClassEnvVar. Existing deployments pick up the new env var
on operator reconciliation without manual intervention.

Fixes #17227
Signed-off-by: David Orman <ormandj@corenode.com>
(cherry picked from commit 1357d71177)
2026-04-21 12:21:15 +00:00
subham rai 8656c96d08 Merge pull request #17393 from rook/mergify/bp/release-1.20/pr-17373
mds: fix incorrect behaviour for CephFS when no active standby (backport #17373)
2026-04-21 09:25:08 +05:30
subham rai 6c95740730 Merge pull request #17391 from rook/mergify/bp/release-1.20/pr-17376
doc: fix out of date references to default PgHealthyRegex (backport #17376)
2026-04-21 09:24:01 +05:30