Commit Graph
12769 Commits
Author SHA1 Message Date
Travis Nielsen aae0ddfb8b Merge pull request #16564 from rook/mergify/bp/release-1.18/pr-16563
build: Add csi operator image to images.txt (backport #16563)
2025-10-02 09:30:03 -06:00
Travis Nielsen e8c501ba8e build: add csi operator image to images.txt
With the addition of the csi operator, the csi operator
image is added to the list of images that are required
for deploying rook.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 535f9f0868)
2025-10-02 14:55:49 +00:00
Travis Nielsen b1d5319ba1 Merge pull request #16562 from rook/mergify/bp/release-1.18/pr-16560
csi: update csi-operator to v0.4.1 (backport #16560)
2025-10-02 08:54:19 -06:00
Madhu Rajanna b3bd0bfc3b csi: update operator to 0.4.1
Updating the operator dependency to
0.4.1

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 5ea7410d58)
2025-10-02 14:03:59 +00:00
Travis Nielsen fa0ca0a4a6 Merge pull request #16547 from rook/mergify/bp/release-1.18/pr-16520
rbdmirror: fix mirroring monitoring settings for rn (backport #16520)
2025-09-26 16:11:37 -05:00
Travis Nielsen e11cf61692 Merge pull request #16546 from rook/mergify/bp/release-1.18/pr-16542
core: add PHASE column to cephor (backport #16542)
2025-09-26 16:11:25 -05:00
Travis Nielsen c176a81cd3 Merge pull request #16545 from rook/mergify/bp/release-1.18/pr-16543
core: add PHASE column to cephnfs (backport #16543)
2025-09-26 16:11:14 -05:00
Travis Nielsen f3cb1ba070 Merge pull request #16544 from rook/mergify/bp/release-1.18/pr-16541
core: add PHASE column to cephbn (backport #16541)
2025-09-26 16:11:04 -05:00
Travis Nielsen 2957c3cdbb Merge pull request #16539 from rook/mergify/bp/release-1.18/pr-16512
helm: Allow specifying the image tag and repository separately (backport #16512)
2025-09-26 16:10:49 -05:00
parth-gr 225121879f rbdmirror: fix mirroring monitoring settings for rn
currently if we disable the monitoring for rn,
it doesnt reset the status

Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit 49c26dbfb0)
2025-09-26 19:49:06 +00:00
Joshua Hoblitt 35be9ce5dd core: add PHASE column to cephor
The current behavior does not print the PHASE column, as most other
CRDs do. E.g.:

```
 ~ $ k get cephor lfa
NAME   AGE
lfa    45d
```

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 6d9c884259)
2025-09-26 18:21:50 +00:00
Joshua Hoblitt 6640476ee0 core: add PHASE column to cephnfs
The current behavior does not print the PHASE column, as most other
CRDs do. E.g.:

```
 ~ $ k get cephnfs nfs1
NAME   AGE
nfs1   45d
```

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 5ee982f1e1)
2025-09-26 18:21:48 +00:00
Joshua Hoblitt 913d02a02b core: add PHASE column to cephbn
The current behavior does not print the PHASE column, as most other
CRDs do. E.g.:

```
~ $ k get cephbn chorus
NAME     AGE
chorus   10d
```

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 8866d47d92)
2025-09-26 18:21:02 +00:00
Travis Nielsen c55f164248 helm: allow specifying the image tag and repository separately
The image repo and tag conveniently can be specified separately
so the release tag can be picked from the official chart, and
the repo can be customized in the values.yaml

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 51cb22c791)
2025-09-25 16:37:43 +00:00
subham rai 283cf54234 Merge pull request #16533 from rook/mergify/bp/release-1.18/pr-16532
namespace: blocklist ip:nonce in cleanup job (backport #16532)
2025-09-25 11:37:45 +05:30
Madhu Rajanna 4f1953cbb3 namespace: blocklist ip:nonce in cleanup job
blocklisting IP can cause problems when the cleanup
job pod runs on the same host or gets the same ip
as that of the rbd client ip that is present in
the rbd status/watchers. instead of blocklisting
the whole ip of the node or the client blocklist
only the unique ip:nonce to allow the node to not
have any effect because of the cleanup job.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 5ae49cf7a0)
2025-09-24 16:58:39 +00:00
subham rai 0cc54183c5 Merge pull request #16529 from rook/mergify/bp/release-1.18/pr-16488
osd: clean encrypted disks from other clusters (backport #16488)
2025-09-24 14:39:37 +05:30
Santosh Pillai 2478073d2d osd: clean encrypted disks from other clusters
Clean encrypted disks from other clusters by checking the cephFSID in
the luks header.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
(cherry picked from commit ec271bdde3)
2025-09-23 20:03:59 +00:00
subham rai a2054ef9c9 Merge pull request #16525 from rook/mergify/bp/release-1.18/pr-16499
object: add status.{phase,observedGeneration} to cephbn (backport #16499)
2025-09-23 12:55:34 +05:30
subham rai 682d9c8cb4 Merge pull request #16527 from rook/mergify/bp/release-1.18/pr-16516
csi: Remove liveness probe setting from the csi-op (backport #16516)
2025-09-23 12:26:50 +05:30
Madhu Rajanna ae0dc30ccc csi: use recreate deployment strategy
This is a fix/workaround to set the Recreate
deployment strategy as default in Rook as
its long proven working without any problem.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 333082c397)
2025-09-23 05:19:16 +00:00
Madhu Rajanna 083cb37e34 csi: remove liveness from the driver spec
CephCSI will remove the livess sidecar
container functionality as it was created
very long back and it should be replaced with
kubernetes GRPC livessness problem.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 46c7d2cc26)
2025-09-23 05:19:15 +00:00
Joshua Hoblitt 628fc97e88 object: add status.{phase,observedGeneration} to cephbn
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 864c349c1f)
2025-09-22 22:27:16 +00:00
subham rai 971527d85b Merge pull request #16519 from rook/mergify/bp/release-1.18/pr-16514
csi: add labels to the csi-operator driver pod (backport #16514)
2025-09-22 21:07:45 +05:30
subhamkrai 1477f60e10 csi: add labels to the csi-operator driver pod
currently, labels are not passed to csi-operator but
for csi-driver lables works as expected. This commit
add changes to add labels on csi-operator driver pod as well.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 0c296545a5)
2025-09-22 14:40:42 +00:00
Travis Nielsen 0ecc756bd9 Merge pull request #16510 from rook/mergify/bp/release-1.18/pr-16494
helm: refactoring to modernize templates (backport #16494)
2025-09-19 13:42:59 -06:00
Travis Nielsen ff780f697c Merge pull request #16509 from rook/mergify/bp/release-1.18/pr-16506
osd: updated blocking pdbs if drained node is back (backport #16506)
2025-09-18 14:02:14 -06:00
Erik Sundell bb96b545ff helm: fix refactoring typo
Fixes a typo forgetting to replace `if` with `with`.

Signed-off-by: Erik Sundell <erik@sundellopensource.se>
(cherry picked from commit 8efac50952)
2025-09-18 20:00:20 +00:00
Erik Sundell 4e90d6fa68 helm: refactoring to modernize templates
This touches a lot where a typo could cause issues for someone, so I have self-
reviewed it many times line-by-line already.

There are a few types of changes:
- All resources get tied to their own YAML document separator (`---`)
  before their definition, reducing the risk of not separating resources
  correctly when rendering multiple into a file. I think the changes
  will fix edge case bugs for people with mutiple items listed in
  `cephFileSystems` and similar configuration.
- `toYaml ...` is made into `... | toYaml` consistently.
- `default A B` is made into `B | default A` consistently.
- Consistent whitespace chomping, so instead of `{{ end }}` you would
  find `{{- end }}` typically. The system is that you should chomp left
  almost all the time, and almost all the time _not_ chomp right. You
  would chomp right in the beginning of a file or helper function in
  order to clear some initial whitespace, otherwise not.
- Multiline helm template comments `{{- /* ... */ }}` get their content
  indented 2 spaces.
- List items are consistently rendered with two spaces of indentation.
- `kind` is put before `apiVersion` consistently, to follow a practice
  observed partially in the repo.
- Calls to the helm `template` function have been replaced with
  `include` to be consistent and to stick with modern practices.
- Use of `indent` have been replaced with `nindent #` and a left
  whitespace chomp for a consistent easy to follow practice that gets
  good result.
- Several `if` statements like `if X -> render X` have been replaced
  with `with X -> render .` to avoid repetition. The `with` statement
  won't render if the provided context, making it function also like an
  `if` statement.
- Fixed a bug with `if .Values.revisionHistoryLimit`, which should
  really be `if not (typeIs "<nil>" .Values.revisionHistoryLimit)` to
  handle situations when its set to `0`.

Signed-off-by: Erik Sundell <erik@sundellopensource.se>
(cherry picked from commit 039f158950)
2025-09-18 20:00:20 +00:00
Santosh Pillai 3e0514b947 osd: updated blocking pdbs if drained node is back
If the drained node is added back and one or more others nodes are down
update the blocking pdbs, that is, add blocking pdb to node that was
just added back.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
(cherry picked from commit f2bf0eb200)
2025-09-18 17:10:32 +00:00
Travis Nielsen 76bce3a292 Merge pull request #16495 from rook/mergify/bp/release-1.18/pr-16493
core: use latest operator context in the preClusterStartValidation function (backport #16493)
2025-09-17 10:00:33 -06:00
subham rai 6b5312f4ec Merge pull request #16503 from rook/mergify/bp/release-1.18/pr-16496
core: fix ObjectZoneSpec.ZoneGroup and ObjectZoneGroupSpec.Realm field descriptions (backport #16496)
2025-09-17 18:19:07 +05:30
Joshua Hoblitt 58becd0385 core: fix ObjectZoneSpec.ZoneGroup field description
Resolves this incorrect field description:

     ~ $ k explain cephobjectzone.spec.zoneGroup
    GROUP:      ceph.rook.io
    KIND:       CephObjectZone
    VERSION:    v1

    FIELD: zoneGroup <string>

    DESCRIPTION:
        The display name for the ceph users

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 8b58d68592)
2025-09-17 11:47:28 +00:00
Joshua Hoblitt 0f8b0992f5 core: fix ObjectZoneGroupSpec.Realm field description
Resolves this incorrect field description:

     ~ $ k explain cephobjectzonegroup.spec.realm
    GROUP:      ceph.rook.io
    KIND:       CephObjectZoneGroup
    VERSION:    v1

    FIELD: realm <string>

    DESCRIPTION:
        The display name for the ceph users

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 1a1478a342)
2025-09-17 11:47:28 +00:00
subham rai c83cf896fe Merge pull request #16500 from rook/mergify/bp/release-1.18/pr-16497
docs: add cephobjectrealm.spec.defaultrealm field to examples (backport #16497)
2025-09-17 17:16:56 +05:30
subham rai e73a0039ce Merge pull request #16498 from rook/mergify/bp/release-1.18/pr-16418
ci: update latest k8s version to v1.34 (backport #16418)
2025-09-17 17:04:10 +05:30
Joshua Hoblitt 47d8824525 docs: add cephobjectrealm.spec.defaultrealm field to examples
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 39691e3e06)
2025-09-16 22:25:21 +00:00
Michael Adam 61674b8977 ci: move minikube to a better location
In the deb package's location of /usr/bin/minilube, a wrong version seems to be
reported but from /usr/local/bin it reports correctly.

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 605e820fc8)
2025-09-16 17:12:37 +00:00
Michael Adam 4941d02bdc ci: update latest k8s version to 1.34
this change updates the k8s version to 1.34 and also updates
the  cri-ctl version for minikube.

Signed-off-by: Michael Adam <obnox@samba.org>
Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 40427d5c0d)
2025-09-16 17:12:37 +00:00
Santosh Pillai 96d03cb1e4 core: use updated context in prevalidaiton checks
If the CephCluster spec is updated before the prevalidation check, then
Cluster.context still refers to the cancelled context of the operator.
This PR just updates the cluster context to use the latest operator
context.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
(cherry picked from commit 1ff7604f82)
2025-09-16 15:53:11 +00:00
Travis Nielsen ccbac6de98 Merge pull request #16490 from rook/mergify/bp/release-1.18/pr-16468
external: fix ipv6 monitoring endpoint reconcile (backport #16468)
2025-09-15 13:47:43 -06:00
Travis Nielsen 460f73ba7e Merge pull request #16491 from rook/mergify/bp/release-1.18/pr-16478
pool: Allow enableCrushUpdates to be nil (backport #16478)
2025-09-15 13:45:53 -06:00
Travis Nielsen 44e8bf2778 pool: allow enablecrushupdates to be nil
Enabling crush updates is false by default, and can be enabled
if set to true. The setting needs to be nullable in case
we need to differentiate between the value being set
to false or just not set, to know if the default should be
different. This is necessary for rook consumers who are
refererencing the pool struct and want to change the default,
rather than using rook's default value of false.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit df49ca1247)
2025-09-15 18:34:59 +00:00
parth-gr 0249d2b6a5 external: fix ipv6 monitoring endpoint reconcile
currently the extraction ipv6 was not correct
used the net package to extract the host ip from
the ipadress

Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit e1873cb2e7)
2025-09-15 16:46:41 +00:00
subham rai 98ba1335cb Merge pull request #16487 from rook/mergify/bp/release-1.18/pr-16484
mon: fix mon health nil pointer exception with mons on PVC (backport #16484)
2025-09-15 21:15:44 +05:30
Santosh Pillai 508658f797 mon: fix mon health nil pointer exception
shouldFailoverMonImmediately has a nil pointer exception with mons on
PVC. Rook-ceph-mon-endpoint does not store node information of the mons
on PVC. So `mapping.Hostname` throws nill pointer

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
(cherry picked from commit d399615bdc)
2025-09-15 14:00:10 +00:00
Travis Nielsen 79d961d45e Merge pull request #16477 from rook/mergify/bp/release-1.18/pr-16112
osd: exclude down OSDs from main PDB when cluster is clean (backport #16112)
2025-09-11 14:58:55 -06:00
Travis Nielsen c6dbff9596 Merge pull request #16465 from rook/mergify/bp/release-1.18/pr-16457
helm: refactoring of rook-ceph's configmap to be easier to read and maintain (backport #16457)
2025-09-11 14:58:27 -06:00
Elias Carter 4c31c51ddb osd: exclude down OSDs from main PDB when cluster is clean
Currently, when there are down OSDs but all PGs are clean we add the
number of downed OSDs ot the main PDB maxUnavailable. For example if
OSDs 1,3,5 are down and all PGs are clean we create the following PDB:
```yaml
  maxUnavailable: 4
  selector:
    matchLabels:
      app: rook-ceph-osd
```

This is potentially dangerous as there can be race conditions which can
break the cluster, for example:
1. A new node is added to the cluster with 4 OSDs
2. Those OSDs are down as they have not started up and joined the cluster yet
3. All PGs are healthy as the new OSDs haven't started yet and they are new
4. The rook operator sets maxUnavailable to 5 on the OSD PDB
5. The new OSDs move from down to up as they start
6. Something in the cluster starts a disruption (eviction request)
7. Any 5 OSDs can be disrupted as maxUnavilable is still 5 and the downed OSDs are now up
8. If the 5 disrupted OSDs contain all the replicas of a PG it will cause the PG to go down

To better protect from this scenario, we can instead exclude the downed
OSDs from the main PDB instead of adding to maxUnavailable.
```yaml
  maxUnavailable: 1
  selector:
    matchExpressions:
    - key: app
      operator: In
      values: ["rook-ceph-osd"]
    - key: osd
      operator: NotIn
      values: ["1", "3", "5"]
```

This allows drains to still process when there are downed OSDs and PGs
are clean without allowing the non-downed OSDs to be disrupted.

Signed-off-by: Elias Carter <elias@dropbox.com>
(cherry picked from commit 60a15306e9)
2025-09-11 18:47:12 +00:00
Blaine Gardner 4d6a1d15a0 Merge pull request #16476 from rook/mergify/bp/release-1.18/pr-16456
nfs: rotate nfs cephx key (backport #16456)
2025-09-11 11:18:20 -06:00